Commit graph

6 commits

Author SHA1 Message Date
ragnarok-clanker
f8d3e8622d Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
2026-11-06 16:30:12 +00:00
ragnarok-clanker
5f3e627627 Decompile fn_11358 (UIDescriptRace::Paint)
Batch #7098 by Landruca: 1 byte-identical, 0 confirmed by peer review.

- fn_11358 UIDescriptRace::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-31 04:06:49 +00:00
ragnarok-clanker
a7052bcd4a Decompile 4 functions in Source/UI/Text/UITextViewer.cpp, Source/UI/Window/UIMessageBox.cpp, ...
Batch #7043 by Lumen: 0 byte-identical, 4 confirmed by peer review.

- fn_11194 UIItemTagCtrl::AddTagButton: logic confirmed by peer review
- fn_11195 UIItemTagOnMail::AddTagButton: logic confirmed by peer review
- fn_11196 UIItemTagOnMegaPhone::AddTagButton: logic confirmed by peer review
- fn_11323 UIDescriptRace::Slot15: logic confirmed by peer review

Peer-reviewed-by: eAthena, Romain, alisonrag, kyoshi, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 03:27:35 +00:00
ragnarok-clanker
05cb11f08a Decompile 4 functions in Source/UI/Buttons/UITextButton.cpp, Source/UI/Lists/UIComboBoxDefWnd.h, ...
Batch #6273 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_11406 UINewComboBoxCtrl::Slot26: logic confirmed by peer review
- fn_11416 UIDescriptRace::Slot25: logic confirmed by peer review
- fn_11410 UITabControl::Slot26: logic confirmed by peer review
- fn_11373 UINewComboBoxCtrl::Paint: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 21:31:37 +00:00
ragnarok-clanker
dc9d9c3265 Decompile 3 functions in Source/UI/Edit/ItemTagRetirement.cpp, Source/UI/Edit/ItemTagRetirement.h, ...
Batch #5491 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_11521 MailItemTagRemoval::Remove: logic confirmed by peer review
- fn_11522 MegaPhoneItemTagRemoval::Remove: logic confirmed by peer review
- fn_11548 UIDescriptRace::SendMsg: logic confirmed by peer review

Peer-reviewed-by: ntrl, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 12:23:11 +00:00
ragnarok-clanker
2d16bc8d36 Decompile fn_11041 (UIDescriptRace::UIDescriptRace)
Batch #5130 by meitogi: 0 byte-identical, 1 confirmed by peer review.

- fn_11041 UIDescriptRace::UIDescriptRace: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Buttons/UIDescriptRace.cpp
2026-10-30 08:50:16 +00:00