Commit graph

25 commits

Author SHA1 Message Date
ragnarok-clanker
44ae8b169a Decompile fn_23514 (CSession::RefreshHpSpWindows)
Batch #5059 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_23514 CSession::RefreshHpSpWindows: logic confirmed by peer review

Peer-reviewed-by: Lumen, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 07:29:47 +00:00
ragnarok-clanker
fc32ec1b03 Decompile 4 functions in Source/UI/Text/UIAchWnd.cpp, Source/UI/Text/UIAchWnd.h, ...
Batch #5016 by Yommy: 0 byte-identical, 4 confirmed by peer review.

- fn_09222 UIAchUpperWnd::Paint: logic confirmed by peer review
- fn_09223 UIAchViewWnd::Paint: logic confirmed by peer review
- fn_24174 CSession::GetItem6B68: logic confirmed by peer review
- fn_24175 CSession::GetItem61B8: logic confirmed by peer review

Peer-reviewed-by: youko, superintelligence, OrangeCat, eAthena, KWDev, zindokar, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 06:54:11 +00:00
ragnarok-clanker
7f5dae84bf Decompile 36 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #4723 by eAthena: 0 byte-identical, 36 confirmed by peer review.

- fn_23352 CSession::IsNumberWithCommas: logic confirmed by peer review
- fn_23361 CSession::FindUnknown0708: logic confirmed by peer review
- fn_23362 CSession::FindUnknown0700: logic confirmed by peer review
- fn_23363 CSession::GetEnemyHitWaveName: logic confirmed by peer review
- fn_23366 CSession::GetEquippedItem: logic confirmed by peer review
- fn_23367 CSession::FindItem2B50: logic confirmed by peer review
- fn_23369 CSession::FindItem17F0: logic confirmed by peer review
- fn_23370 CSession::GetExchangeItem: logic confirmed by peer review
- fn_23384 CSession::FindInventoryIndexByItemId: logic confirmed by peer review
- fn_23388 CSession::GetInventoryItemAt: logic confirmed by peer review
- fn_23389 CSession::FindInventoryItemByItemId: logic confirmed by peer review
- fn_23390 CSession::GetInventoryItemCount: logic confirmed by peer review
- fn_23606 CSession::RefreshWindow02C8: logic confirmed by peer review
- fn_23607 CSession::RefreshItem1740Window: logic confirmed by peer review
- fn_23608 CSession::RefreshItem1750Window: logic confirmed by peer review
- fn_23609 CSession::RefreshItem1768Window: logic confirmed by peer review
- fn_23610 CSession::UpdateUnknown1708: logic confirmed by peer review
- fn_23612 CSession::RefreshItem1738Window: logic confirmed by peer review
- fn_23613 CSession::EraseRecord0734: logic confirmed by peer review
- fn_23615 CSession::IgnoreText: logic confirmed by peer review
- fn_23616 CSession::SaveMiniPartyInfo: logic confirmed by peer review
- fn_23617 CSession::SetItem1768Quantity: logic confirmed by peer review
- fn_23618 CSession::SetUnknown5C1C: logic confirmed by peer review
- fn_23619 CSession::UpdateFriendName: logic confirmed by peer review
- fn_23622 CSession::SetNavigationPlayerMap: logic confirmed by peer review
- fn_23623 SetMemberFlags: logic confirmed by peer review
- fn_23626 CSession::SetFriendOffline: logic confirmed by peer review
- fn_23627 CSession::SetHomunSkillLevel: logic confirmed by peer review
- fn_23628 CSession::UpdateInventoryItem: logic confirmed by peer review
- fn_23629 CSession::SetMercSkillLevel: logic confirmed by peer review
- fn_23630 CSession::SetItem1768Unknown0014: logic confirmed by peer review
- fn_23631 CSession::AddRecord0734: logic confirmed by peer review
- fn_23632 CSession::SetUnknown5210: logic confirmed by peer review
- fn_23634 CSession::SetUnknown5214: logic confirmed by peer review
- fn_23635 CSession::SetPlayerPosition: logic confirmed by peer review
- fn_23636 CSession::SetRecord0734Value: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 06:05:12 +00:00
ragnarok-clanker
5844ecf0f0 Decompile 20 functions in Source/Client/Session.cpp, Source/Client/Session.h, ...
Batch #4477 by youko: 2 byte-identical, 18 confirmed by peer review.

- fn_24138 NightWatchBodyPath2: logic confirmed by peer review
- fn_24139 NightWatchRidingBodyPath2: logic confirmed by peer review
- fn_24140 HyperNoviceBodyPath2: logic confirmed by peer review
- fn_24141 HyperNoviceRidingBodyPath2: logic confirmed by peer review
- fn_24142 SpiritHandlerBodyPath2: logic confirmed by peer review
- fn_24143 SpiritHandlerRidingBodyPath2: logic confirmed by peer review
- fn_24144 DruidBodyPath3: logic confirmed by peer review
- fn_24145 DruidBodyPath4: logic confirmed by peer review
- fn_24146 KarnosBodyPath3: logic confirmed by peer review
- fn_24147 KarnosBodyPath4: logic confirmed by peer review
- fn_24148 AliteaBodyPath2: logic confirmed by peer review
- fn_24151 CSession::AddUnknown7F94: logic confirmed by peer review
- fn_24153 CSession::EndSkillOption: logic confirmed by peer review
- fn_24154 CSession::ClearNormalItemSlots: byte-identical
- fn_24155 CSession::ResetItems6B68: logic confirmed by peer review
- fn_24156 CSession::ResetItems61B8: logic confirmed by peer review
- fn_24157 CSession::IsPartyRecommendTarget: logic confirmed by peer review
- fn_24158 CSession::GetBodyStyle: logic confirmed by peer review
- fn_24160 SerializeItems: logic confirmed by peer review
- fn_24161 CSession::GetUnknown8148: byte-identical

Peer-reviewed-by: willerthal, Bruwuno, eAthena, KWDev, tayoba, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 03:27:42 +00:00
ragnarok-clanker
b804147d3c Decompile 9 functions in Source/UI/UIGradeEnchantWnd.cpp, Source/UI/UIGradeEnchantWnd.h, ...
Batch #3897 by kyoshi: 0 byte-identical, 9 confirmed by peer review.

- fn_09758 UIGradeEnchantWnd::Slot26: logic confirmed by peer review
- fn_09763 UIGradeEnchantWnd::Slot19: logic confirmed by peer review
- fn_09765 UIGradeEnchantWnd::Slot33: logic confirmed by peer review
- fn_09766 UIGradeEnchantWnd::SendMsg: logic confirmed by peer review
- fn_09750 UIGradeEnchantWnd::ResetItem: logic confirmed by peer review
- fn_09751 UIGradeEnchantWnd::SelectedMaterialZeny: logic confirmed by peer review
- fn_09749 UIGradeEnchantWnd::Slot10: logic confirmed by peer review
- fn_09752 UIGradeEnchantWnd::SuccessRate: logic confirmed by peer review
- fn_24189 CSession::HasItem61B8: logic confirmed by peer review

Peer-reviewed-by: Yommy, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:03:32 +00:00
ragnarok-clanker
4c9177c71f Decompile fn_23354 (CSession::RemovePartyMemberByName)
Batch #3682 by superintelligence: 0 byte-identical, 1 confirmed by peer review.

- fn_23354 CSession::RemovePartyMemberByName: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 23:05:38 +00:00
ragnarok-clanker
0c85bf7a1f Decompile 25 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #3339 by youko: 0 byte-identical, 25 confirmed by peer review.

- fn_23424 CSession::GetItem1784At: logic confirmed by peer review
- fn_23425 CSession::GetCommandId: logic confirmed by peer review
- fn_23442 CSession::GetItemSlot: logic confirmed by peer review
- fn_23443 CSession::GetItem21A0: logic confirmed by peer review
- fn_23445 CSession::GetItem1718QuantityByItemId: logic confirmed by peer review
- fn_23446 CSession::GetItem1718QuantityOf: logic confirmed by peer review
- fn_23447 CSession::GetItem1718Unknown006CByItemId: logic confirmed by peer review
- fn_23448 CSession::GetItem1718Unknown006COf: logic confirmed by peer review
- fn_23449 CSession::SumItem1720Unknown006CByItemId: logic confirmed by peer review
- fn_23450 CSession::SumItem1720Unknown006C: logic confirmed by peer review
- fn_23456 CSession::FindItem1720ByItemId: logic confirmed by peer review
- fn_23457 CSession::GetItem1720At: logic confirmed by peer review
- fn_23458 CSession::GetItem1720QuantityByItemId: logic confirmed by peer review
- fn_23459 CSession::GetItem1720Quantity: logic confirmed by peer review
- fn_23460 CSession::GetItem1720Total: logic confirmed by peer review
- fn_23462 CSession::GetMonsterRmaName: logic confirmed by peer review
- fn_23463 CSession::FindItem1730: logic confirmed by peer review
- fn_23464 CSession::GetItem1730At: logic confirmed by peer review
- fn_23465 CSession::GetItem1730Quantity: logic confirmed by peer review
- fn_23470 CSession::GetItem1718At: logic confirmed by peer review
- fn_23471 CSession::GetItem1718Quantity: logic confirmed by peer review
- fn_23472 CSession::GetHotkeyDescription: logic confirmed by peer review
- fn_23475 CSession::FindItem1738: logic confirmed by peer review
- fn_23476 CSession::GetItem1738At: logic confirmed by peer review
- fn_23477 CSession::GetItem1738Quantity: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:40:01 +00:00
ragnarok-clanker
8b8a6c8f53 Decompile 4 functions in Source/Client/Session.cpp, Source/Client/Session.h, ...
Batch #2976 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_24181 CSession::CheckInterval: logic confirmed by peer review
- fn_24182 CSession::IsPlayerPerformerJob: logic confirmed by peer review
- fn_24183 CSession::IsSpecialMonsterJob: logic confirmed by peer review
- fn_24187 CSession::IsWithinUnknown59C0: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:38:18 +00:00
ragnarok-clanker
74b563ec78 Decompile fn_23426 (CSession::GetItem1728Count)
Batch #3341 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_23426 CSession::GetItem1728Count: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 21:30:36 +00:00
ragnarok-clanker
c77bf2f4d8 Decompile fn_23359 (CSession::GetUnknown8134)
Batch #3307 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_23359 CSession::GetUnknown8134: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 21:20:13 +00:00
ragnarok-clanker
2ba833f291 Decompile 2 functions in Source/Client/Session.cpp, Source/Client/Session.h, ...
Batch #2985 by eAthena: 2 byte-identical, 0 confirmed by peer review.

- fn_24180 CSession::IsEffectRenderEnabled: byte-identical
- fn_24194 CSession::ResetUnknownState: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:09:59 +00:00
ragnarok-clanker
c38c98066c Decompile 7 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Client/Session.cpp, ...
Batch #2718 by youko: 0 byte-identical, 7 confirmed by peer review.

- fn_23853 CSession::IsBabyJob: logic confirmed by peer review
- fn_23873 CSession::IsMercenaryJob: logic confirmed by peer review
- fn_23874 CSession::IsNewMercenaryJob: logic confirmed by peer review
- fn_23889 CSession::GetSceneUnknown004C: logic confirmed by peer review
- fn_23891 CSession::IsSuperNovice2Job: logic confirmed by peer review
- fn_23894 CSession::IsExpandedJob: logic confirmed by peer review
- fn_24188 CSession::IsCostumeJob: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:27:53 +00:00
ragnarok-clanker
14c5a7b063 Decompile 4 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #2472 by meitogi: 0 byte-identical, 4 confirmed by peer review.

- fn_23422 CSession::FindRecord0734: logic confirmed by peer review
- fn_23423 CSession::GetBgmFileName: logic confirmed by peer review
- fn_23565 CSession::HasItem17D4: logic confirmed by peer review
- fn_23566 CSession::IsFriendName: logic confirmed by peer review

Peer-reviewed-by: alisonrag, bigodeira, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 17:17:44 +00:00
ragnarok-clanker
b4c06be357 Decompile 3 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #2503 by meitogi: 0 byte-identical, 3 confirmed by peer review.

- fn_23355 CSession::GatName2RswName: logic confirmed by peer review
- fn_23415 CSession::FindItem1760ByItemId: logic confirmed by peer review
- fn_23417 CSession::GetItem1760QuantityByItemId: logic confirmed by peer review

Peer-reviewed-by: alisonrag, bigodeira, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 17:17:20 +00:00
ragnarok-clanker
5a54d550c0 Decompile 2 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #2168 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23563 CSession::HasItem1718: logic confirmed by peer review
- fn_23564 CSession::HasExchangeItem: logic confirmed by peer review

Peer-reviewed-by: ntrl
Reviewed-by: ragnarok-clanker
2026-10-29 15:07:33 +00:00
ragnarok-clanker
574f7ad757 Decompile 18 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #2146 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_23402 CSession::FindItem1768: logic confirmed by peer review
- fn_23403 CSession::GetItem1768At: logic confirmed by peer review
- fn_23404 CSession::GetItem1768Quantity: logic confirmed by peer review
- fn_23405 CSession::FindItem1740: logic confirmed by peer review
- fn_23406 CSession::GetItem1740At: logic confirmed by peer review
- fn_23407 CSession::GetItem1740Quantity: logic confirmed by peer review
- fn_23408 CSession::FindItem1750: logic confirmed by peer review
- fn_23409 CSession::GetItem1750At: logic confirmed by peer review
- fn_23410 CSession::GetItem1750Quantity: logic confirmed by peer review
- fn_23411 CSession::FindItem1758: logic confirmed by peer review
- fn_23412 CSession::FindItem1758ByItemId: logic confirmed by peer review
- fn_23413 CSession::GetItem1758At: logic confirmed by peer review
- fn_23414 CSession::FindItem1760: logic confirmed by peer review
- fn_23416 CSession::GetItem1760At: logic confirmed by peer review
- fn_23418 CSession::GetItem1760Quantity: logic confirmed by peer review
- fn_23419 CSession::FindItem1770: logic confirmed by peer review
- fn_23420 CSession::GetItem1760Total: logic confirmed by peer review
- fn_23421 CSession::GetItem1748At: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:39:01 +00:00
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
3ec1742a36 Decompile fn_23562 (CSession::IsExchangeItemListFull)
Batch #1887 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23562 CSession::IsExchangeItemListFull: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 23:16:52 +00:00
ragnarok-clanker
b677bdbc59 Decompile 3 functions in Source/Client/Session.cpp, Source/Client/Session.h, ...
Batch #1704 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_24179 CSession::IsDoramJob: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review
- fn_19754 EquipmentResourceMgr::GetBodyRacePrefix: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:33:49 +00:00
ragnarok-clanker
ee280b667b Decompile fn_23401 (CSession::MercSkillLevel)
Batch #1324 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23401 CSession::MercSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:06:46 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 10:35:18 +00:00
ragnarok-clanker
92886d28ca Decompile 2 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1329 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23633 CSession::ClearItemSelection: logic confirmed by peer review
- fn_17254 UIWindowMgr::NotifyMode: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 10:30:24 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard)
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:19:34 +00:00
ragnarok-clanker
308cefc066 Decompile fn_23826 (CSession::SyncUnknown0E98)
Batch #1325 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23826 CSession::SyncUnknown0E98: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:10:19 +00:00
ragnarok-clanker
f575258340 Maintenance: Define every global once in its owner unit; session members replace member globals
Batch #906 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Client/Session.h, Source/Client/Registry.h, Source/Client/Application/LaunchInfo.h, Source/Client/Application/Launcher.h, Source/Client/Mode/ActiveGameMode.h, Source/Render/DeviceSelection.h.
Adds to the build: Source/Client/Session.cpp, Source/Client/Registry.cpp, Source/Client/Application/LaunchInfo.cpp, Source/Render/DeviceSelection.cpp
2026-10-26 18:34:25 +00:00