Commit graph

6 commits

Author SHA1 Message Date
ragnarok-clanker
3f8411389e Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13406 by ragnarok-clanker: no function's compiled code changes; checked with 124 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/SpriteParticle.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/Contents/Actors/Skill.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/Contents/Effects/HealEffect.h, Source/Contents/AchievementMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/Contents/Effects/LightSphereEffect.h, Source/Contents/Effects/BlastForge.h, Source/Security/NProtectGameGuardMgr.h, Source/Contents/Effects/MapChainEffect.h, Source/Utility/Math/Int64Math.h.
2026-11-06 16:08:47 +00:00
ragnarok-clanker
8d2e0819f8 Decompile fn_19179 (CSmokeEffect::Slot03)
Batch #13234 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_19179 CSmokeEffect::Slot03: logic confirmed by peer review

Peer-reviewed-by: Tanke, Toshiro, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 14:30:45 +00:00
ragnarok-clanker
b93dbdf725 Decompile 16 functions in Source/Contents/Effects/Bash.cpp, Source/Contents/Effects/ElectricEffect.cpp, ...
Batch #12326 by cremane: 16 byte-identical, 0 confirmed by peer review.

- fn_07035 CHitLineEffect::Close: byte-identical
- fn_07055 CMeteorEffect::Close: byte-identical
- fn_07072 CNyanggrassEffect::Close: byte-identical
- fn_07075 CNyanggrassEffect::Slot03: byte-identical
- fn_07098 CRectUpEffect::Close: byte-identical
- fn_19162 CSaintCastingEffect::Close: byte-identical
- fn_19169 CScatterEffect::Close: byte-identical
- fn_19176 CSmokeEffect::Close: byte-identical
- fn_19188 CSphereWindEffect::Close: byte-identical
- fn_19196 CSpriteEffect::Close: byte-identical
- fn_19229 CThrowItemEffect::Close: byte-identical
- fn_19241 CVolcanoEffect::Close: byte-identical
- fn_18869 CBash::Close: byte-identical
- fn_07477 CStarEmperorEffect::Close: byte-identical
- fn_07483 CStarEmperorEffect::Slot04: byte-identical
- fn_18971 CSteal::Close: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 13:26:33 +00:00
ragnarok-clanker
07f768fb76 Decompile 2 functions in Source/Contents/Effects/SmokeEffect.cpp, Source/Contents/Effects/SmokeEffect.h
Batch #3976 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_19177 CSmokeEffect::Slot01: logic confirmed by peer review
- fn_19179 CSmokeEffect::Slot03: logic confirmed by peer review

Peer-reviewed-by: willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:26:52 +00:00
ragnarok-clanker
496171e547 Decompile 2 functions in Source/Contents/Effects/SmokeEffect.cpp, Source/Contents/Effects/SmokeEffect.h
Batch #3997 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_19174 CSmokeEffect::CSmokeEffect: logic confirmed by peer review
- fn_19176 CSmokeEffect::Close: logic confirmed by peer review

Peer-reviewed-by: willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:26:20 +00:00
ragnarok-clanker
1a48ee0945 Decompile 2 functions in Source/Contents/Effects/SmokeEffect.cpp, Source/Contents/Effects/SmokeEffect.h
Batch #3993 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_19178 CSmokeEffect::Slot06: byte-identical
- fn_19180 CSmokeEffect::Slot04: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Effects/SmokeEffect.cpp
2026-10-30 00:26:00 +00:00