clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
6,625 commits 2 branches 0 tags 76 MiB
Commit graph

105 commits

Author SHA1 Message Date
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED 
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
 2026-11-08 16:44:36 +00:00
ragnarok-clanker
521b52384c Maintenance: Replace LookupMessage(<integer>) with the existing MSGSTRINGID constant of the same value (3596 sites, 162 files; each v 
Batch #14938 by ragnarok-clanker: no function's compiled code changes; checked with 162 compiled unit(s).
 2026-11-08 14:19:01 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr 
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
 2026-11-08 13:56:42 +00:00
ragnarok-clanker
858265cc69 Maintenance: Second pass: name remaining numeric switch case labels (identifier-only; no code change). ~3,500 more labels across 150 
Batch #14936 by ragnarok-clanker: no function's compiled code changes; checked with 158 compiled unit(s), including every includer of Source/Client/Mode/GameModeEnums.h, Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Contents/Actors/PetEnums.h, Source/Contents/Combat/CombatTypes.h, Source/Contents/Configuration/ServiceEnums.h, Source/Contents/Effects/EffectPrimId.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemId.h, Source/Contents/Items/ItemType.h, Source/Network/Packets/ModeResultEnums.h, Source/Network/Packets/NoticeEnums.h, Source/Network/Packets/PacketId.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
 2026-11-08 12:37:46 +00:00
ragnarok-clanker
71e78b2d37 Decompile 2 functions in Source/UI/Window/FrameFocus.cpp, Source/Client/Session.cpp, ... 
Batch #14901 by SapitoSucio: 2 byte-identical, 0 confirmed by peer review.

- fn_17195 UIWindowMgr::IsFriend: byte-identical
- fn_23566 CSession::IsFriendName: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-08 06:22:50 +00:00
ragnarok-clanker
d5d002d780 Decompile fn_23502 (CSession::InitResourceNameTables) 
Batch #14784 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_23502 CSession::InitResourceNameTables: logic confirmed by peer review

Peer-reviewed-by: Tanke, codeplay, NYD
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-08 00:28:58 +00:00
ragnarok-clanker
854a0e32fb Maintenance: Name numeric switch case labels with enum constants (identifier-only; no code change). 13,500+ case labels across 70 uni 
Batch #14886 by ragnarok-clanker: no function's compiled code changes; checked with 225 compiled unit(s), including every includer of Source/Contents/Combat/CombatTypes.h, Source/Contents/Effects/EffectMessageId.h, Source/Contents/Items/InventoryType.h, Source/Contents/Items/ItemId.h, Source/Contents/Jobs/JobId.h, Source/Contents/MessageTable.h, Source/Contents/Skills/SkillId.h, Source/Contents/Skills/SkillUnitId.h, Source/Network/Packets/ModeResultEnums.h, Source/Network/Packets/NoticeEnums.h, Source/Network/Packets/PacketId.h, Source/UI/GameSettings/TalkType.h, Source/UI/Window/WindowId.h.
 2026-11-07 23:58:37 +00:00
ragnarok-clanker
ffbeee0f2a Maintenance: Forced maintainer submission (resubmission of 14678 after td sync to 8deac7a3; replaces 14460 and 14473). Native-run fix 
Batch #14681 by ragnarok-clanker: forced by an admin (6 lower score(s), 70 changed function(s)); checked with 555 compiled unit(s), including every includer of Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObject.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/CartCannon.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Ground/GroundGeometry.h, Source/Network/Connection/Connection.h, Source/Resource/Audio/WaveResource.h, Source/Resource/Bitmap/BitmapResource.h, Source/Resource/EZeffectResource.h, Source/Resource/EmblemResource.h, Source/Resource/GifResource.h, Source/Resource/ImfResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelResource.h, Source/Resource/PaletteResource.h, Source/Resource/RmaResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/Sprites/SpriteResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/TerrainResource.h, Source/Resource/World/WorldResource.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UITextButton.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UINewSelectCharWnd.h.
 2026-11-07 14:05:21 +00:00
ragnarok-clanker
e6de27b3fc Decompile 3 functions in Source/Contents/ClientItemLists.cpp, Source/Client/Session.cpp 
Batch #13984 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_21641 ReceiveItemSlot: logic confirmed by peer review
- fn_21642 ReceiveItemSlotOptions: logic confirmed by peer review
- fn_23340 CSession::RemoveItem1768: logic confirmed by peer review

Peer-reviewed-by: KWDev, Tanke, codeplay, StrawberrysherbetIX, secret
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-07 13:40:43 +00:00
ragnarok-clanker
a101d971d4 Decompile fn_23502 (CSession::InitResourceNameTables) 
Batch #13547 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23502 CSession::InitResourceNameTables: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke, codeplay, raiken
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-07 12:35:06 +00:00
ragnarok-clanker
00c4c28627 Decompile fn_23626 (CSession::SetFriendOffline) 
Batch #14085 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_23626 CSession::SetFriendOffline: logic confirmed by peer review

Peer-reviewed-by: secret, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-07 08:14:14 +00:00
ragnarok-clanker
70c4570b63 Decompile fn_24178 (CSession::InitJobSpriteNames) 
Batch #14349 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_24178 CSession::InitJobSpriteNames: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-07 07:34:11 +00:00
ragnarok-clanker
2e12f4dd57 Decompile 3 functions in Source/Client/Session.cpp 
Batch #14068 by secret: 0 byte-identical, 3 confirmed by peer review.

- fn_23501 CSession::LoadMiniPartyInfo: logic confirmed by peer review
- fn_23509 CSession::LoadMapViewParameters: logic confirmed by peer review
- fn_23573 CSession::HasItem1740Number: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-07 06:24:10 +00:00
ragnarok-clanker
9bcb240a60 Decompile fn_23624 (CSession::SetUnknown16EC) 
Batch #13759 by SapitoSucio: 1 byte-identical, 0 confirmed by peer review.

- fn_23624 CSession::SetUnknown16EC: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-06 22:24:09 +00:00
ragnarok-clanker
4de5cee9c0 Decompile fn_23385 (CSession::FindInventoryIndicesByItemId) 
Batch #13656 by SapitoSucio: 1 byte-identical, 0 confirmed by peer review.

- fn_23385 CSession::FindInventoryIndicesByItemId: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-06 21:09:30 +00:00
ragnarok-clanker
0ad3d7fad3 Decompile fn_23565 (CSession::HasItem17D4) 
Batch #13636 by SapitoSucio: 1 byte-identical, 0 confirmed by peer review.

- fn_23565 CSession::HasItem17D4: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-06 21:03:34 +00:00
ragnarok-clanker
f77f87c348 Decompile fn_23569 (CSession::IsGuildMemberCharacter) 
Batch #13637 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23569 CSession::IsGuildMemberCharacter: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-06 20:55:25 +00:00
ragnarok-clanker
5ead212992 Decompile fn_23385 (CSession::FindInventoryIndicesByItemId) 
Batch #13586 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23385 CSession::FindInventoryIndicesByItemId: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-06 20:38:39 +00:00
ragnarok-clanker
14ff75ccc6 Decompile 17 functions in Source/Client/Session.cpp 
Batch #13536 by eAthena: 17 byte-identical, 0 confirmed by peer review.

- fn_23388 CSession::GetInventoryItemAt: byte-identical
- fn_23403 CSession::GetItem1768At: byte-identical
- fn_23406 CSession::GetItem1740At: byte-identical
- fn_23409 CSession::GetItem1750At: byte-identical
- fn_23413 CSession::GetItem1758At: byte-identical
- fn_23416 CSession::GetItem1760At: byte-identical
- fn_23421 CSession::GetItem1748At: byte-identical
- fn_23457 CSession::GetItem1720At: byte-identical
- fn_23464 CSession::GetItem1730At: byte-identical
- fn_23470 CSession::GetItem1718At: byte-identical
- fn_23476 CSession::GetItem1738At: byte-identical
- fn_23420 CSession::GetItem1760Total: byte-identical
- fn_23446 CSession::GetItem1718QuantityOf: byte-identical
- fn_23448 CSession::GetItem1718Unknown006COf: byte-identical
- fn_23450 CSession::SumItem1720Unknown006C: byte-identical
- fn_23633 CSession::ClearItemSelection: byte-identical
- fn_23366 CSession::GetEquippedItem: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-06 20:29:21 +00:00
ragnarok-clanker
bf22aa5b62 Maintenance: Forced (approved by the maintainer: small score loss accepted for correct behaviour). Resubmission of 13479. CSession+0x 
Batch #13484 by ragnarok-clanker: forced by an admin (1 lower score(s), 3 changed function(s)); checked with 266 compiled unit(s), including every includer of Source/Client/Session.h.
 2026-11-06 19:10:41 +00:00
ragnarok-clanker
f8d3e8622d Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids 
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
 2026-11-06 16:30:12 +00:00
ragnarok-clanker
a2dedd3dcd Maintenance: Link fixes (resubmission of 13274, forced). (1) Session.cpp declared the EncryptedName<14, 0xB5F3F779237315F3> construct 
Batch #13284 by ragnarok-clanker: forced by an admin (0 lower score(s), 1 changed function(s)); checked with 2 compiled unit(s).
 2026-11-06 12:38:45 +00:00
ragnarok-clanker
fec919b88e Maintenance: Link-completeness fixes so the whole client links into one executable (all units in data/compile.json plus exe-only thir 
Batch #13186 by ragnarok-clanker: forced by an admin (40 lower score(s), 206 changed function(s)); checked with 620 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h, Source/Client/Timer.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/ServiceOptions.h, Source/Contents/Skills/SkillTreeScript.h, Source/Render/DX9/D3DX9Runtime.h, Source/Resource/GifResource.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Cooldowns/CooldownOwner.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIReputeWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/EncryptedName.h.
 2026-11-06 10:56:48 +00:00
ragnarok-clanker
2982bf31ee Decompile fn_23501 (CSession::LoadMiniPartyInfo) 
Batch #12564 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_23501 CSession::LoadMiniPartyInfo: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-06 04:21:31 +00:00
ragnarok-clanker
f43dbe74e2 Decompile fn_24181 (CSession::CheckInterval) 
Batch #12954 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_24181 CSession::CheckInterval: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-06 03:33:59 +00:00
ragnarok-clanker
c3424d2e0b Decompile fn_23568 (CSession::IsGuildMemberAccount) 
Batch #12888 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_23568 CSession::IsGuildMemberAccount: logic confirmed by peer review

Peer-reviewed-by: Yommy, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-06 02:44:34 +00:00
ragnarok-clanker
b48fb882d9 Decompile 4 functions in Source/Client/Session.cpp 
Batch #12784 by cremane: 4 byte-identical, 0 confirmed by peer review.

- fn_23621 CSession::SetEquipItem2B50: byte-identical
- fn_23625 CSession::SetEquipItem17F0: byte-identical
- fn_23636 CSession::SetRecord0734Value: byte-identical
- fn_23355 CSession::GatName2RswName: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-06 00:49:25 +00:00
ragnarok-clanker
735bc6ee87 Decompile fn_23615 (CSession::IgnoreText) 
Batch #12566 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_23615 CSession::IgnoreText: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-05 21:54:56 +00:00
ragnarok-clanker
6aec4bb360 Decompile fn_24153 (CSession::EndSkillOption) 
Batch #12520 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_24153 CSession::EndSkillOption: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-05 16:58:11 +00:00
ragnarok-clanker
1321ea8890 Decompile fn_23483 (CSession::GetShopType) 
Batch #12496 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_23483 CSession::GetShopType: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-05 16:05:06 +00:00
ragnarok-clanker
8b1570ee8e Decompile 2 functions in Source/Client/Session.cpp 
Batch #12489 by Toshiro: 2 byte-identical, 0 confirmed by peer review.

- fn_23463 CSession::FindItem1730: byte-identical
- fn_23475 CSession::FindItem1738: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-05 15:55:05 +00:00
ragnarok-clanker
ad19fd2b45 Decompile 5 functions in Source/Client/Session.cpp 
Batch #12487 by Toshiro: 5 byte-identical, 0 confirmed by peer review.

- fn_23402 CSession::FindItem1768: byte-identical
- fn_23405 CSession::FindItem1740: byte-identical
- fn_23408 CSession::FindItem1750: byte-identical
- fn_23414 CSession::FindItem1760: byte-identical
- fn_23419 CSession::FindItem1770: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-05 15:52:32 +00:00
ragnarok-clanker
f00a4f0331 Decompile 2 functions in Source/Client/Session.cpp 
Batch #12482 by Toshiro: 2 byte-identical, 0 confirmed by peer review.

- fn_23383 CSession::GetItemNameColor: byte-identical
- fn_23460 CSession::GetItem1720Total: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-05 15:49:45 +00:00
ragnarok-clanker
ff0d4993ba Decompile 2 functions in Source/Client/Session.cpp 
Batch #11389 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_23415 CSession::FindItem1760ByItemId: byte-identical
- fn_23456 CSession::FindItem1720ByItemId: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-04 23:51:46 +00:00
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from 
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
 2026-11-04 21:29:46 +00:00
ragnarok-clanker
78b8eb03d2 Decompile fn_24189 (CSession::HasItem61B8) 
Batch #10749 by kyoshi: 1 byte-identical, 0 confirmed by peer review.

- fn_24189 CSession::HasItem61B8: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-11-04 17:10:17 +00:00
ragnarok-clanker
7773c2fd73 Maintenance: [forced, user-approved] Family V2: remove the invented view structs SessionItemLists and SessionMessengerContext. Both w 
Batch #10278 by ragnarok-clanker: forced by an admin (0 lower score(s), 68 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
 2026-11-03 15:58:10 +00:00
ragnarok-clanker
514c8dc0cd Maintenance: [forced, user-approved] Family S3: remove ShortcutCooldowns (17 reinterpret_cast<ShortcutCooldowns&>(g_session.m_request 
Batch #10274 by ragnarok-clanker: forced by an admin (3 lower score(s), 9 changed function(s)); checked with 348 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/UI/Shortcuts/ShortcutCooldowns.h.
 2026-11-03 15:12:40 +00:00
ragnarok-clanker
3be8819db2 Maintenance: [forced, user-approved] Family W4: remove invented EffectAttachments (reference bundle over EffectActorState effects/fir 
Batch #10257 by ragnarok-clanker: forced by an admin (7 lower score(s), 31 changed function(s)); checked with 95 compiled unit(s), including every includer of Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectAttachments.h.
Deletes: Source/Contents/Effects/EffectAttachments.h
 2026-11-03 13:09:24 +00:00
ragnarok-clanker
f975f8eca8 Maintenance: [forced, user-approved] Family G25: remove JobNameInitialization (inventory row 72). CSession::InitJobNameTable 0xDE67E0 
Batch #10248 by ragnarok-clanker: forced by an admin (0 lower score(s), 3 changed function(s)); checked with 241 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Jobs/JobNames.h.
 2026-11-03 12:15:09 +00:00
ragnarok-clanker
8a04248e21 Maintenance: [forced, user-approved] Family G22: remove StoreBackupData, ItemTagRetirement/ItemTagRemoval, SoundMgrContext, JobInheri 
Batch #10242 by ragnarok-clanker: forced by an admin (7 lower score(s), 33 changed function(s)); checked with 260 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Jobs/JobInheritance.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/Store/MCStoreInfoBackup.h, Source/UI/Edit/ItemTagRetirement.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Shortcuts/ShortcutPainting.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/Contents/Configuration/OptionWriter.h, Source/Contents/Store/StoreBackupData.h.
Deletes: Source/Contents/Configuration/OptionWriter.h, Source/Contents/Store/StoreBackupData.h
 2026-11-03 11:44:08 +00:00
ragnarok-clanker
70f3e36c88 Maintenance: [forced, user-approved] Family G19: remove WindowOrdering, WindowDropDown, WindowMouseHit and the dead WindowMouseCaptur 
Batch #10231 by ragnarok-clanker: forced by an admin (5 lower score(s), 39 changed function(s)); checked with 495 compiled unit(s), including every includer of Source/Client/Mode/ModeTooltip.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Lists/UIDropDownBox.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
Deletes: Source/UI/Window/WindowOrdering.h
 2026-11-03 10:07:55 +00:00
ragnarok-clanker
85f98ef6ab Maintenance: [forced, user-approved] Family G16: remove ClientMessenger (reference view over g_session.m_partyMembers +0x17DC / m_fri 
Batch #10222 by ragnarok-clanker: forced by an admin (7 lower score(s), 45 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Messenger/ClientMessenger.h.
 2026-11-03 01:04:03 +00:00
ragnarok-clanker
09f4285a2e Maintenance: [forced, user-approved] Family G8: type CSession +0x61A8/+0x61AC (replaces G7's *(int*)unknown_61A8_0000 cast). Original 
Batch #10203 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 214 compiled unit(s), including every includer of Source/Client/Session.h.
 2026-11-02 22:11:24 +00:00
ragnarok-clanker
20a69b11ce Decompile fn_23488 (CSession::sub_DE3D90) 
Batch #10078 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_23488 CSession::sub_DE3D90: logic confirmed by peer review

Peer-reviewed-by: meitogi, Montyla, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-02 15:24:05 +00:00
ragnarok-clanker
ce3385d512 Decompile fn_24178 (CSession::InitJobSpriteNames) 
Batch #10038 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.

- fn_24178 CSession::InitJobSpriteNames: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, meitogi, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-02 14:52:40 +00:00
ragnarok-clanker
b538c3a695 Maintenance: Consolidate the guild state into its real owner. The original has one GuildInfo object at 0x16D4400 (static ctor 0x4A887 
Batch #10011 by ragnarok-clanker: forced by an admin (8 lower score(s), 43 changed function(s)); checked with 137 compiled unit(s), including every includer of Source/Contents/Actors/RenderObject.h, Source/Contents/GuildInfo.h, Source/Contents/GuildMgr.h.
 2026-11-02 13:42:03 +00:00
ragnarok-clanker
c908705603 Decompile 2 functions in Source/Client/Session.cpp, Source/Client/Session.h 
Batch #9668 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23509 CSession::LoadMapViewParameters: logic confirmed by peer review
- fn_23506 SessionMessengerContext::sub_DF33B0: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-11-02 12:06:36 +00:00
ragnarok-clanker
c6250792e0 Decompile fn_22763 (CSession::CSession) 
Batch #9759 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_22763 CSession::CSession: logic confirmed by peer review

Peer-reviewed-by: KWDev, Romain, Montyla, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-01 21:20:12 +00:00
ragnarok-clanker
c7631ed38d Decompile fn_23478 (CSession::GetTalkType) 
Batch #9581 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23478 CSession::GetTalkType: logic confirmed by peer review

Peer-reviewed-by: secret, tayoba, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-01 16:57:04 +00:00