Commit graph

10 commits

Author SHA1 Message Date
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
7b0d89d9d6 Decompile 3 functions in Source/Contents/NavigationLink.cpp
Batch #14447 by SapitoSucio: 0 byte-identical, 3 confirmed by peer review.

- fn_19438 CNaviInfo::AddNpc: logic confirmed by peer review
- fn_19439 CNaviInfo::AddLink: logic confirmed by peer review
- fn_19440 CNaviInfo::AddMob: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 10:39:12 +00:00
ragnarok-clanker
ce93e29e1c Decompile fn_19483 (CNavi_Link::GetCell)
Batch #12916 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_19483 CNavi_Link::GetCell: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 03:04:46 +00:00
ragnarok-clanker
11253e0bce Decompile 4 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h
Batch #1950 by eAthena: 4 byte-identical, 0 confirmed by peer review.

- fn_19514 CNaviInfo::LinkCount: byte-identical
- fn_19515 CNaviInfo::MobCount: byte-identical
- fn_19516 CNaviInfo::NpcCount: byte-identical
- fn_19517 CNavi_Link::LinkedLinkCount: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 00:04:10 +00:00
ragnarok-clanker
eb96e386eb Decompile 15 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h
Batch #1782 by Yommy: 0 byte-identical, 15 confirmed by peer review.

- fn_19438 CNaviInfo::AddNpc: logic confirmed by peer review
- fn_19439 CNaviInfo::AddLink: logic confirmed by peer review
- fn_19440 CNaviInfo::AddMob: logic confirmed by peer review
- fn_19441 CNavi_Link::AddLinkedLink: logic confirmed by peer review
- fn_19442 CNavi_Link::AddLink: logic confirmed by peer review
- fn_19443 CNavi_Object::AddLink: logic confirmed by peer review
- fn_19445 CNavi_Link::LinksBegin: logic confirmed by peer review
- fn_19446 CNavi_Object::LinksBegin: logic confirmed by peer review
- fn_19447 CNavi_Link::FindLinkAt: logic confirmed by peer review
- fn_19448 CNavi_Object::FindLinkAt: logic confirmed by peer review
- fn_19449 CNavi_Link::FindLinkTo: logic confirmed by peer review
- fn_19450 CNavi_Object::FindLinkTo: logic confirmed by peer review
- fn_19454 CNavi_Link::EraseLink: logic confirmed by peer review
- fn_19455 CNavi_Object::EraseLink: logic confirmed by peer review
- fn_19491 CNavi_Link::GetLinkedCell: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:19:30 +00:00
ragnarok-clanker
40dade2c0b Decompile 4 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h
Batch #1783 by Yommy: 4 byte-identical, 0 confirmed by peer review.

- fn_19451 CNavi_Link::ClearLinkedLinks: byte-identical
- fn_19452 CNavi_Link::ClearLinks: byte-identical
- fn_19453 CNavi_Object::ClearLinks: byte-identical
- fn_19490 CNavi_Link::GetLinkedName: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 22:14:12 +00:00
ragnarok-clanker
5b8f2cfb1f Decompile 12 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ...
Batch #1554 by ragnarok-clanker: 0 byte-identical, 12 confirmed by peer review.

- fn_21278 CGameMode::WorldCell: logic confirmed by peer review (already on main)
- fn_19599 CNavigationManager::LoadStates: logic confirmed by peer review (annotation added to existing code)
- fn_19394 CNaviData::ResetLinkDepths: logic confirmed by peer review (annotation added to existing code)
- fn_19390 CNaviData::FindRoute: logic confirmed by peer review (annotation added to existing code)
- fn_19508 CNavi_Link::SetDepth: logic confirmed by peer review (annotation added to existing code)
- fn_19456 CNavi_Link::LinkedEnd: logic confirmed by peer review (annotation added to existing code)
- fn_19444 CNavi_Link::LinkedBegin: logic confirmed by peer review (annotation added to existing code)
- fn_19466 CNaviInfo::LinksBegin: logic confirmed by peer review (annotation added to existing code)
- fn_19467 CNaviInfo::LinksEnd: logic confirmed by peer review (annotation added to existing code)
- fn_19509 CNaviInfo::SetVisited: logic confirmed by peer review (annotation added to existing code)
- fn_19581 CNavigationManager::PlayerCell: logic confirmed by peer review (annotation added to existing code)
- fn_21282 CGameMode::PlayerCell: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
2026-10-28 18:50:46 +00:00
ragnarok-clanker
4cf3413524 Decompile 4 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ...
Batch #1556 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_19489 CNavi_Link::GetLinkedInfo: byte-identical
- fn_19481 CNaviInfo::IsVisited: byte-identical
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/NavigationDestinations.cpp, Source/Contents/NavigationGraph.cpp, Source/Contents/WorldNavigation.cpp
2026-10-28 18:48:31 +00:00
ragnarok-clanker
4c1960b206 Decompile 14 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h, ...
Batch #1540 by ragnarok-clanker: 0 byte-identical, 14 confirmed by peer review.

- fn_19436 CNavi_Link::`scalar deleting destructor': logic confirmed by peer review
- fn_19483 CNavi_Link::GetCell: logic confirmed by peer review
- fn_19497 CNavi_Link::GetInfo: logic confirmed by peer review
- fn_19387 CNaviData::SetDestination: logic confirmed by peer review
- fn_19638 CNavigationManager::UpdateGround: logic confirmed by peer review
- fn_19364 CNaviData::CNaviData: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review
- fn_19429 CNaviInfo::~CNaviInfo: logic confirmed by peer review
- fn_19551 CNavigationManager::CNavigationManager: logic confirmed by peer review
- fn_19574 CNavigationManager::ClearRouteNodes: logic confirmed by peer review
- fn_19575 CNavigationManager::ClearNodePaths: logic confirmed by peer review
- fn_19593 CNavigationManager::Reset: logic confirmed by peer review
- fn_45448 CNavigationManager::~CNavigationManager: logic confirmed by peer review
- fn_45452 CNavigationManager::GetLinkedPlayerInfo: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 17:40:11 +00:00
ragnarok-clanker
dfadb24ce5 Decompile 5 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h, ...
Batch #1541 by ragnarok-clanker: 5 byte-identical, 0 confirmed by peer review.

- fn_19473 CNavi_Link::GetTitle: byte-identical
- fn_19475 CNavi_Link::GetName: byte-identical
- fn_19487 CNavi_Link::GetIndex: byte-identical
- fn_19492 CNavi_Link::GetType: byte-identical
- fn_19494 CNavi_Link::GetId: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/NavigationLink.cpp
2026-10-28 17:38:51 +00:00