Commit graph

22 commits

Author SHA1 Message Date
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
521b52384c Maintenance: Replace LookupMessage(<integer>) with the existing MSGSTRINGID constant of the same value (3596 sites, 162 files; each v
Batch #14938 by ragnarok-clanker: no function's compiled code changes; checked with 162 compiled unit(s).
2026-11-08 14:19:01 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 13:56:42 +00:00
ragnarok-clanker
c341982e8c Decompile fn_05452 (CRenewQuestMgr::AddRecommendedQuest)
Batch #14102 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_05452 CRenewQuestMgr::AddRecommendedQuest: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-07 05:16:26 +00:00
ragnarok-clanker
f8d3e8622d Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
2026-11-06 16:30:12 +00:00
ragnarok-clanker
fec919b88e Maintenance: Link-completeness fixes so the whole client links into one executable (all units in data/compile.json plus exe-only thir
Batch #13186 by ragnarok-clanker: forced by an admin (40 lower score(s), 206 changed function(s)); checked with 620 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h, Source/Client/Timer.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/ServiceOptions.h, Source/Contents/Skills/SkillTreeScript.h, Source/Render/DX9/D3DX9Runtime.h, Source/Resource/GifResource.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Cooldowns/CooldownOwner.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIReputeWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/EncryptedName.h.
2026-11-06 10:56:48 +00:00
ragnarok-clanker
31b89604b0 Decompile 10 functions in Source/Client/Mode/GameModeNotices.cpp, Source/Client/Mode/GameModePackets.cpp, ...
Batch #13148 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_05385 CPetEvolutionMgr::L_InsertEvolutionRecipeLGU: byte-identical
- fn_05440 CRenewQuestMgr::GetMonsterConditionText: byte-identical
- fn_06538 NEO_PACKAGEITEM::CPaidPackageItemMgr::IsPaidItem: byte-identical
- fn_08147 CRuneSystemMgr::Reset: byte-identical
- fn_19316 Replay::AnimationScale: byte-identical
- fn_19317 Replay::DelayScale: byte-identical
- fn_19618 CNavigationManager::FitToSquare: byte-identical
- fn_21737 CGameMode::ReceiveMemorialDungeonNotify: byte-identical
- fn_22067 CGameMode::ReceiveLapineBoxResult: byte-identical
- fn_22123 CGameMode::ReceiveGradeEnchantInfo: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 07:31:21 +00:00
ragnarok-clanker
86a5142dbd Decompile 15 functions in Source/Client/Browser/BrowserCursor.cpp, Source/Client/Input/Language.cpp, ...
Batch #12875 by KWDev: 15 byte-identical, 0 confirmed by peer review.

- fn_03576 UINavigationV4Wnd::RefreshLayout: byte-identical
- fn_05441 CRenewQuestMgr::GetIconTooltip: byte-identical
- fn_10202 UIRuneSetReWard::Slot31: byte-identical
- fn_13844 UITagButton::Slot31: byte-identical
- fn_14354 CUIListBox<AdventureGuide::CUISubTab>::SelectItem: byte-identical
- fn_14355 CUIListBox<AdventureGuide::CUITab>::SelectItem: byte-identical
- fn_14417 CUIDropDownBox::HasChild: byte-identical
- fn_14420 CUIDropDownBox::Attach: byte-identical (already on main)
- fn_14685 CUITab::Select: byte-identical
- fn_16497 CQuestItemSelector::SetHighlighted: byte-identical
- fn_17063 ContainsValue: byte-identical
- fn_17764 CLanguageBase::Paste: byte-identical
- fn_18377 GetMessageString: byte-identical
- fn_19310 Replay::Cipher: byte-identical
- fn_45438 CWebBrowser::PollCursor: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 02:20:45 +00:00
ragnarok-clanker
3649066f7a Decompile 4 functions in Source/Contents/RenewQuestMgr.cpp
Batch #12814 by cremane: 3 byte-identical, 1 confirmed by peer review.

- fn_05439 CRenewQuestMgr::GetFilterName: byte-identical
- fn_05443 CRenewQuestMgr::GetOngoingQuest: logic confirmed by peer review
- fn_05445 CRenewQuestMgr::GetRecommendedQuest: byte-identical
- fn_05497 CRenewQuestMgr::L_SetRecommendedQuestActive: byte-identical

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 01:06:58 +00:00
ragnarok-clanker
8337288eff Decompile fn_05434 (CRenewQuestMgr::Create)
Batch #12742 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_05434 CRenewQuestMgr::Create: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 00:23:09 +00:00
ragnarok-clanker
2f9ab1c144 Decompile 5 functions in Source/Contents/RenewQuestMgr.cpp
Batch #11933 by Yommy: 0 byte-identical, 5 confirmed by peer review.

- fn_05439 CRenewQuestMgr::GetFilterName: logic confirmed by peer review
- fn_05442 RenewQuestOngoingInfo::GetHuntText: logic confirmed by peer review
- fn_05447 CRenewQuestMgr::WriteOngoingQuests: logic confirmed by peer review
- fn_05454 CRenewQuestMgr::IsInFilter: logic confirmed by peer review
- fn_05461 CRenewQuestMgr::SendQuestStatusRequest: logic confirmed by peer review

Peer-reviewed-by: KWDev, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 14:40:21 +00:00
ragnarok-clanker
46e68f709e Decompile 6 functions in Source/Contents/RenewQuestMgr.cpp
Batch #11935 by Yommy: 4 byte-identical, 2 confirmed by peer review.

- fn_05438 RenewQuestOngoingInfo::GetDateString: logic confirmed by peer review
- fn_05441 CRenewQuestMgr::GetIconTooltip: logic confirmed by peer review
- fn_05444 CRenewQuestMgr::FindOngoingQuest: byte-identical
- fn_05446 CRenewQuestMgr::FindRecommendedQuest: byte-identical
- fn_05463 CRenewQuestMgr::SetRecommendedQuestActive: byte-identical
- fn_05464 CRenewQuestMgr::SetOngoingSimpleView: byte-identical

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 05:38:29 +00:00
ragnarok-clanker
2d55a137fc Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is
Batch #10269 by ragnarok-clanker: forced by an admin (2 lower score(s), 6 changed function(s)); checked with 102 compiled unit(s), including every includer of Source/Script/LuaScript.h.
2026-11-03 14:40:29 +00:00
ragnarok-clanker
e70d0c293d Decompile fn_05449 (CRenewQuestMgr::LoadQuestInfo)
Batch #10089 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_05449 CRenewQuestMgr::LoadQuestInfo: logic confirmed by peer review

Peer-reviewed-by: cremane, doczeira, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-02 15:45:18 +00:00
ragnarok-clanker
fcad6e032a Decompile 2 functions in Source/Contents/ClientState.cpp, Source/Client/Session.h, ...
Batch #6512 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_24217 CSession::ReadReplayQuests: logic confirmed by peer review
- fn_05465 CRenewQuestMgr::ReadOngoingQuests: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:07:49 +00:00
ragnarok-clanker
0a1ebeff83 Decompile 2 functions in Source/Contents/RenewQuestMgr.cpp, Source/Contents/RenewQuestMgr.h
Batch #6395 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_05451 CRenewQuestMgr::AddOngoingQuest: logic confirmed by peer review
- fn_05465 CRenewQuestMgr::ReadOngoingQuests: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 22:43:38 +00:00
ragnarok-clanker
7ba03c521f Decompile 5 functions in Source/Contents/RenewQuestMgr.cpp, Source/Contents/RenewQuestMgr.h, ...
Batch #5370 by tayoba: 1 byte-identical, 4 confirmed by peer review.

- fn_05435 Nullsub212: byte-identical
- fn_05457 CRenewQuestMgr::sub_67B620: logic confirmed by peer review
- fn_05458 CRenewQuestMgr::sub_67B650: logic confirmed by peer review
- fn_05459 CRenewQuestMgr::sub_67B690: logic confirmed by peer review
- fn_05460 CRenewQuestMgr::sub_67B6B0: logic confirmed by peer review

Peer-reviewed-by: Yommy, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 11:31:42 +00:00
ragnarok-clanker
9aebcc2238 Decompile fn_05449 (CRenewQuestMgr::LoadQuestInfo)
Batch #5217 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_05449 CRenewQuestMgr::LoadQuestInfo: logic confirmed by peer review

Peer-reviewed-by: alisonrag, OvoKore, zindokar
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:49:08 +00:00
ragnarok-clanker
b80a39a02c Decompile 7 functions in Source/Utility/Text/FormatString.cpp, Source/Utility/Text/FormatString.h, ...
Batch #4204 by Yommy: 0 byte-identical, 7 confirmed by peer review.

- fn_17181 IntToString: logic confirmed by peer review
- fn_09909 UIRefining_BtnAgain::Paint: logic confirmed by peer review
- fn_09910 UIRefining_BtnRefining::Paint: logic confirmed by peer review
- fn_05440 CRenewQuestMgr::GetMonsterConditionText: logic confirmed by peer review
- fn_05442 RenewQuestOngoingInfo::GetHuntText: logic confirmed by peer review
- fn_05467 CRenewQuestMgr::SaveOngoingSimpleViewList: logic confirmed by peer review
- fn_05468 CRenewQuestMgr::SaveRecommendedActiveList: logic confirmed by peer review

Peer-reviewed-by: youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 02:11:51 +00:00
ragnarok-clanker
d9503eb561 Decompile 10 functions in Source/Contents/RenewQuestMgr.cpp, Source/Contents/RenewQuestMgr.h
Batch #3552 by Yommy: 0 byte-identical, 10 confirmed by peer review.

- fn_05417 RenewQuestOngoingInfo::RenewQuestOngoingInfo: logic confirmed by peer review
- fn_05420 RenewQuestInfo::RenewQuestInfo: logic confirmed by peer review
- fn_05421 RenewQuestRecommendedInfo::RenewQuestRecommendedInfo: logic confirmed by peer review
- fn_05443 CRenewQuestMgr::GetOngoingQuest: logic confirmed by peer review
- fn_05445 CRenewQuestMgr::GetRecommendedQuest: logic confirmed by peer review
- fn_05452 CRenewQuestMgr::AddRecommendedQuest: logic confirmed by peer review
- fn_05493 CRenewQuestMgr::L_AddOngoingDescription: logic confirmed by peer review
- fn_05494 CRenewQuestMgr::L_AddOngoingRewardInfo: logic confirmed by peer review
- fn_05495 CRenewQuestMgr::L_AddRecommendedQuestInfo: logic confirmed by peer review
- fn_05496 CRenewQuestMgr::L_InsertRecommendedQuestInfo: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:46:14 +00:00
ragnarok-clanker
d6a0e4d7ba Decompile 23 functions in Source/Contents/RenewQuestMgr.cpp, Source/Contents/RenewQuestMgr.h
Batch #3271 by eAthena: 0 byte-identical, 23 confirmed by peer review.

- fn_05414 CRenewQuestMgr::CRenewQuestMgr: logic confirmed by peer review
- fn_05432 CRenewQuestMgr::AddIconTooltip: logic confirmed by peer review
- fn_05434 CRenewQuestMgr::Create: logic confirmed by peer review
- fn_05436 CRenewQuestMgr::Destroy: logic confirmed by peer review
- fn_05437 CRenewQuestMgr::RemoveStatusRequest: logic confirmed by peer review
- fn_05438 RenewQuestOngoingInfo::GetDateString: logic confirmed by peer review
- fn_05439 CRenewQuestMgr::GetFilterName: logic confirmed by peer review
- fn_05441 CRenewQuestMgr::GetIconTooltip: logic confirmed by peer review
- fn_05444 CRenewQuestMgr::FindOngoingQuest: logic confirmed by peer review
- fn_05446 CRenewQuestMgr::FindRecommendedQuest: logic confirmed by peer review
- fn_05447 CRenewQuestMgr::WriteOngoingQuests: logic confirmed by peer review
- fn_05448 CRenewQuestMgr::GetOngoingQuestsSize: logic confirmed by peer review
- fn_05450 CRenewQuestMgr::AddNewQuest: logic confirmed by peer review
- fn_05453 CRenewQuestMgr::IsNewQuest: logic confirmed by peer review
- fn_05454 CRenewQuestMgr::IsInFilter: logic confirmed by peer review
- fn_05455 CRenewQuestMgr::L_AddQuestFilterInfo: logic confirmed by peer review
- fn_05456 CRenewQuestMgr::L_AddQuestIconTooltip: logic confirmed by peer review
- fn_05461 CRenewQuestMgr::SendQuestStatusRequest: logic confirmed by peer review
- fn_05462 CRenewQuestMgr::SetOngoingQuestState: logic confirmed by peer review
- fn_05463 CRenewQuestMgr::SetRecommendedQuestActive: logic confirmed by peer review
- fn_05464 CRenewQuestMgr::SetOngoingSimpleView: logic confirmed by peer review
- fn_05466 CRenewQuestMgr::SetParameter: logic confirmed by peer review
- fn_05497 CRenewQuestMgr::L_SetRecommendedQuestActive: logic confirmed by peer review

Peer-reviewed-by: bigodeira
Reviewed-by: ragnarok-clanker
2026-10-29 22:06:56 +00:00
ragnarok-clanker
93bcf35abf Decompile fn_05433 (CRenewQuestMgr::Clear)
Batch #3287 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_05433 CRenewQuestMgr::Clear: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/RenewQuestMgr.cpp
2026-10-29 21:14:55 +00:00