clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
rodecomp/Source/UI
History
ragnarok-clanker c8cd69a8bf Maintenance: direct admin merge of fn_17817 sub_AD1C90 (0xAD1C90), protector-damaged 
Merged directly by the admin, bypassing peer review, because part of the
original function was overwritten by the client's protector and can never
match. Task 16009 is marked done on purpose; do not resubmit it.

- Jump table 0xAD29E4: modes 0/1 go to 0xAD1E58, now "jmp 0x027AB0FE" into
  an empty protector stub. Bytes 0xAD1E58..0xAD237D are garbage.
- The rest of case 0/1 survives from 0xAD237E (g_serviceFlag07 = 29,
  strstr(g_launchServerName, "QmSakray"), key/address pair, StringFormat
  into g_serviceAddress, then the admin/monster-job tail); ported as is.
- Live WinDbg run (servertype=primary): 0xAD1C90 is never called; the
  protector loader in .data6 (sub_3DE8027) replaces it at runtime.
- Based on attempt 57915 (batch 10359), with g_session.unknown_58FA replaced
  by g_launchServerName (same address, 0x1737F32). Key/string decryption
  verified against the binary. td check --includers: no errors.
2026-11-03 21:39:07 +00:00
..
Acceptance Decompile 2 functions in Source/UI/Acceptance/UIChooseSellBuyWnd.cpp, Source/UI/Items/UIEquipWnd.h, ... 2026-11-03 20:59:18 +00:00
AdventureGuide Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Buttons Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
CashEmotion Decompile fn_12732 (UINewChatWnd::ApplyInputLayout) 2026-11-03 20:49:17 +00:00
CashShop Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Chat Maintenance: Fold two alias globals into their evidenced owner members. 0x14576A4 (gl_24635 g_inputSuggestionsEnabled) and 0x14576A6 2026-11-03 21:15:45 +00:00
Clan Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Cooldowns Maintenance: [forced, user-approved] R8: remove the last members of ShortcutPainting and QuickSlotPainting (RenderCommandPool& comman 2026-11-03 12:23:10 +00:00
Dialogs Decompile fn_12329 (UIChatRoomChangeWnd::SendMsg) 2026-11-03 20:27:57 +00:00
Edit Maintenance: Fold alias global gl_24862 g_vendingSaleAlarm (0x173824C) into its owner member CSession::m_muteSellSound (g_session 0x1 2026-11-03 21:27:50 +00:00
Emotion Maintenance: [forced, user-approved] Family G30: remove ModeBaseEvents, CharacterConfigSave, AccountConfigLoad. ModeBaseEvents::Send 2026-11-03 14:13:27 +00:00
Enchant Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
EntryQueue Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Exchange Maintenance: [forced, user-approved] Family F6 (closes family F): delete the four headers left empty or orphaned by F1-F5. WindowDial 2026-11-03 11:10:29 +00:00
GameSettings Decompile fn_17216 (ToggleGameSettingsTab4) 2026-11-03 21:33:15 +00:00
Gauges Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Guild Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Item Decompile fn_13324 (UIMerchantShopMakeWnd::Slot15) 2026-11-03 19:49:02 +00:00
Items Decompile fn_12346 (UIItemCollectionWnd::SendMsg) 2026-11-03 20:44:51 +00:00
Layout Maintenance: [forced, user-approved] Resubmit of #10124 (returned only for 143 changed peer-confirmed scores). Remove fabricated UIFr 2026-11-02 17:48:48 +00:00
Lists Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Menu Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is 2026-11-03 14:40:29 +00:00
Navigation Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Party Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
ProbabilityTable Maintenance: [forced, user-approved] Family F6 (closes family F): delete the four headers left empty or orphaned by F1-F5. WindowDial 2026-11-03 11:10:29 +00:00
Quest Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Rodex Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
RuneSystem Maintenance: [forced, user-approved] Family V2: remove the invented view structs SessionItemLists and SessionMessengerContext. Both w 2026-11-03 15:58:10 +00:00
SelectPackageItemBox Maintenance: [forced, user-approved] Family F6 (closes family F): delete the four headers left empty or orphaned by F1-F5. WindowDial 2026-11-03 11:10:29 +00:00
Shop Maintenance: Fold alias global gl_24862 g_vendingSaleAlarm (0x173824C) into its owner member CSession::m_muteSellSound (g_session 0x1 2026-11-03 21:27:50 +00:00
Shortcuts Maintenance: Fold two alias globals into their evidenced owner members. 0x14576A4 (gl_24635 g_inputSuggestionsEnabled) and 0x14576A6 2026-11-03 21:15:45 +00:00
Skill Decompile fn_13324 (UIMerchantShopMakeWnd::Slot15) 2026-11-03 19:49:02 +00:00
SkillDelayInfo Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is 2026-11-03 14:40:29 +00:00
Status Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
StylingShop Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
Text Decompile fn_21112 (CGameActor::SendMsg) 2026-11-03 21:30:03 +00:00
Window Maintenance: direct admin merge of fn_17817 sub_AD1C90 (0xAD1C90), protector-damaged 2026-11-03 21:39:07 +00:00
FrameSkin.cpp Decompile fn_14469 (CUIFrameWnd::~CUIFrameWnd) 2026-10-31 03:15:49 +00:00
FrameSkin.h Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
MiniPartyGrid.cpp Decompile 4 functions in Source/UI/MiniPartyGrid.cpp, Source/UI/MiniPartyGrid.h 2026-10-26 22:51:41 +00:00
MiniPartyGrid.h Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to UI headers 2026-10-27 13:55:58 +00:00
MiniPartyManager.cpp Maintenance: [forced, user-approved] Family V3: remove the invented view struct ClientItemLists (a copy of CSession's layout, declare 2026-11-03 16:16:06 +00:00
MiniPartyPlacement.cpp Decompile fn_07657 (CMiniPartyWndAreaMgr::FindFreeCell) 2026-10-29 18:09:28 +00:00
MiniPartyPlacement.h Decompile 2 functions in Source/UI/MiniPartyPlacement.cpp, Source/UI/MiniPartyPlacement.h 2026-10-27 21:09:35 +00:00
MiniPartyUsableArea.cpp Decompile fn_17166 (UIWindowMgr::GetMiniPartyUsableArea) 2026-10-28 19:11:08 +00:00
PriceCommission.cpp Decompile fn_00161 (PriceCommission) 2026-10-26 22:56:16 +00:00
PriceCommission.h Decompile fn_13263 (UIMerchantShopMakeWnd::CommitPrice) 2026-10-30 16:46:22 +00:00
TextTagExtraction.cpp Decompile 4 functions in Source/UI/Edit/UIEditLinks.cpp, Source/UI/Edit/UIEditCtrl.h, ... 2026-10-28 23:22:38 +00:00
TextTagRegistry.cpp Decompile 4 functions in Source/UI/Edit/UIEditLinks.cpp, Source/UI/Edit/UIEditCtrl.h, ... 2026-10-28 23:22:38 +00:00
TextTags.h Decompile 4 functions in Source/UI/Edit/UIEditLinks.cpp, Source/UI/Edit/UIEditCtrl.h, ... 2026-10-28 23:22:38 +00:00
UIBarGraph.cpp Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UIBarGraph.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIBartermarketWnd.cpp Maintenance: Fold alias global gl_25087 g_barterValueA (0x1733d34) into its evidenced owner member g_session.m_maxWeight. 0x1733D34 = 2026-11-03 21:34:01 +00:00
UIBartermarketWnd.h Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UIBasicCtrl.cpp Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIBasicCtrl.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIBroadcastBalloon.cpp Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UIBroadcastBalloon.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UICaptchaPreviewWnd.cpp Maintenance: [forced, user-approved] Remove fabricated UIEditContext scalar fields and InputFocus wrapper (family C1-C4). focus -> UI 2026-11-02 20:47:58 +00:00
UICaptchaPreviewWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UICaptchaRegisterWnd.cpp Maintenance: [forced, user-approved] Family V5: remove invented helper types that exist only to call real methods under old sub_ name 2026-11-03 16:16:57 +00:00
UICaptchaRegisterWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIChangeMaterialWnd.cpp Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIChangeMaterialWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UICheckAttendanceWnd.cpp Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is 2026-11-03 14:40:29 +00:00
UICheckAttendanceWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIGradeEnchantWnd.cpp Maintenance: [forced, user-approved] Family V2: remove the invented view structs SessionItemLists and SessionMessengerContext. Both w 2026-11-03 15:58:10 +00:00
UIGradeEnchantWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIHotkeyGuideWnd.cpp Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is 2026-11-03 14:40:29 +00:00
UIHotkeyGuideWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIIngredientInfoWnd.h Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UIItemReformWnd.cpp Maintenance: [forced, user-approved] Family F5: remove ModeTooltip (agent 3 hand-off row 129). ModeTooltip::Show 0xAD6510 (fn_17834) 2026-11-03 10:40:48 +00:00
UIItemReformWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UILapineBoxWnd.cpp Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is 2026-11-03 14:40:29 +00:00
UILapineScrollBar.cpp Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UILapineScrollBar.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UILapineUpgradeBoxWnd.cpp Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is 2026-11-03 14:40:29 +00:00
UILapineUpgradeBoxWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIMacroBlackListCheckWnd.cpp Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UIMacroBlackListCheckWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIMacroDetectorWnd.cpp Maintenance: [forced, user-approved] CLanguage step 6 (follow-up to #10184): edit-input methods move from the reference struct CLangu 2026-11-02 19:49:06 +00:00
UIMacroDetectorWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIMacroReport.cpp Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UIMacroReport.h Decompile 3 functions in Source/UI/Window/UIControl.cpp, Source/UI/Lists/UIThumb.h, ... 2026-11-01 15:10:39 +00:00
UIMacroUserInfoWnd.cpp Maintenance: [forced, user-approved] Family G24: remove EditTextState, EditViewport (inventory rows 83, 55) and the unused FrameFocus 2026-11-03 11:57:46 +00:00
UIMacroUserInfoWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIPreviewEquipWnd.cpp Maintenance: [forced, user-approved] Family W2: remove invented SpriteDrawingPolicy and AccessoryLayerDepth reference structs; their 2026-11-03 12:41:12 +00:00
UIPreviewEquipWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIRefiningWnd.cpp Maintenance: [forced, user-approved] Family F5: remove ModeTooltip (agent 3 hand-off row 129). ModeTooltip::Show 0xAD6510 (fn_17834) 2026-11-03 10:40:48 +00:00
UIRefiningWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIReputeWnd.cpp Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UIReputeWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIRoundBoxTooltipWnd.cpp Maintenance: [forced, user-approved] Family G19: remove WindowOrdering, WindowDropDown, WindowMouseHit and the dead WindowMouseCaptur 2026-11-03 10:07:55 +00:00
UIRoundBoxTooltipWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIScrollWnd.cpp Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIScrollWnd.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UISlotBitmap.cpp Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UISlotBitmap.h Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2 2026-11-03 00:23:34 +00:00
UIStaticBitmap.cpp Maintenance: [forced, user-approved] Family F5: remove ModeTooltip (agent 3 hand-off row 129). ModeTooltip::Show 0xAD6510 (fn_17834) 2026-11-03 10:40:48 +00:00
UIStaticBitmap.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIStaticItem.cpp Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
UIStaticItem.h Maintenance: [forced, user-approved] Window-class layout correction (supersedes batches 10282 and 10283). Removed placeholder members 2026-11-03 18:46:49 +00:00
WindowBackground.cpp Maintenance: [forced, user-approved] Family F1: UIWindowContext field reads replaced by the real objects. primitives->g_renderer->pri 2026-11-02 23:01:18 +00:00
WindowLowerBorder.cpp Decompile 41 functions in Source/Client/Input/InputCharset.cpp, Source/Client/Input/InputCharset.h, ... 2026-10-28 19:13:07 +00:00
WindowOverlay.cpp Maintenance: Stage 0 resubmit (identical to #10090; that and #10084 failed only on Source/Client/Session.cpp with an empty log, consi 2026-11-02 16:03:53 +00:00
WindowSprite.cpp Decompile fn_16923 (UIWindow::AddRotatedSpriteCellOverlay) 2026-10-31 01:46:51 +00:00
WindowTitlebar.cpp Maintenance: Stage 0 resubmit (identical to #10090; that and #10084 failed only on Source/Client/Session.cpp with an empty log, consi 2026-11-02 16:03:53 +00:00