Decompile 22 functions in Source/Client/Session.h, Source/Contents/Actors/GroundScope.cpp, ...

Batch #4990 by youko: 3 byte-identical, 19 confirmed by peer review.

- fn_24228 ReadMessengerMembers: logic confirmed by peer review
- fn_24229 ReadItemList: logic confirmed by peer review
- fn_24230 ReadItemArray: logic confirmed by peer review
- fn_24232 CSession::SetUnknown5BC0: logic confirmed by peer review
- fn_24236 MessengerMember::Deserialize: logic confirmed by peer review
- fn_24247 ClientItemLists::SetItems1750: logic confirmed by peer review
- fn_24249 AppendBytes: logic confirmed by peer review
- fn_24258 CMsgEffect::~CMsgEffect: logic confirmed by peer review
- fn_24259 CSkill::~CSkill: logic confirmed by peer review
- fn_24267 CGroundScope::SkillScopeType: logic confirmed by peer review
- fn_24268 CSkill::GetTrapModelName: logic confirmed by peer review
- fn_24269 CSkill::ReleaseModel: logic confirmed by peer review
- fn_24270 CMsgEffect::UsesMsgEffect: logic confirmed by peer review
- fn_24275 CGraffiSkill::ReleaseTexture: byte-identical
- fn_24277 CArrowEffect::Reset: logic confirmed by peer review
- fn_24278 CEffectMaker::Reset: byte-identical
- fn_24279 CGraffiSkill::BuildTexture: logic confirmed by peer review
- fn_24280 CArrowEffect::OnProcess: logic confirmed by peer review
- fn_24281 CDummyEffectLauncher::OnProcess: logic confirmed by peer review
- fn_24282 CEffectMaker::OnProcess: logic confirmed by peer review
- fn_24283 CGraffiSkill::OnProcess: byte-identical
- fn_24285 CMandraAttackEffect::OnProcess: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Actors/GraffiSkill.cpp, Source/Contents/Effects/ArrowEffect.cpp, Source/Contents/Effects/DummyEffectLauncher.cpp, Source/Contents/Effects/MandraAttackEffect.cpp, Source/Contents/Effects/MsgEffect.cpp

Source/Contents/Actors/Skill.cpp

@@ -1,6 +1,118 @@
 #include "Contents/Actors/Skill.h"
+
+#include "Client/Mode/CGameMode.h"
+#include "Client/Mode/ModeMgr.h"
+#include "Contents/Effects/Effect.h"
+#include "Contents/Effects/EffectLists.h"
+#include "Contents/Effects/RagEffect.h"
+#include "Contents/Models/ModelActor.h"
+#include "Contents/World/World.h"
+#include "Contents/World/WorldObjects.h"
 #include "Render/Renderer.h"
 #include "Render/SpriteGeometry.h"
+#include "UI/Window/UIWindowMgr.h"
+
+// OFFSET: 0x00E4AA30
+// FUNCTION: fn_24259
+CSkill::~CSkill() {
+  if (this->unknown_0264[0] != 0) {
+    g_windowMgr.Schedule(reinterpret_cast<UIWindow*>(this->unknown_0264[0]));
+    this->unknown_0264[0] = 0;
+  }
+
+  this->ReleaseModel();
+  for (std::uint64_t target : this->m_targets) {
+    CGameMode* mode = static_cast<CGameMode*>(g_modeMgr.GetGameMode());
+    reinterpret_cast<WorldObjects*>(mode->scene)->SendObjectMessage(this, target, 24, 0, 0, 0, 0);
+  }
+
+  this->m_targets.clear();
+}
+
+// OFFSET: 0x00E4B400
+// FUNCTION: fn_24268
+const char* CSkill::GetTrapModelName() {
+  switch (this->GetEffectiveJob(-1)) {
+    case 0x8F:
+    case 0xDA:
+    case 0xDE:
+    case 0xE6:
+      return "외부소품\\트랩03_3.rsm";
+    case 0x90:
+      return "외부소품\\트랩02.rsm";
+    case 0x91:
+    case 0xCB:
+      return "외부소품\\트랩01.rsm";
+    case 0x93:
+      return "외부소품\\트랩03.rsm";
+    case 0x94:
+      return "외부소품\\트랩03_6.rsm";
+    case 0x95:
+      return "외부소품\\트랩03_4.rsm";
+    case 0x96:
+      return "외부소품\\트랩03_5.rsm";
+    case 0x97:
+      return "외부소품\\트랩03_2.rsm";
+    case 0x98:
+      return "외부소품\\트랩04.rsm";
+    case 0x99:
+      return "외부소품\\트랩05.rsm";
+    case 0xD2:
+      return "event\\3차트랩_변화01.rsm";
+    case 0xD3:
+      return "event\\3차트랩_변수01.rsm";
+    case 0xD4:
+      return "event\\3차트랩_변지01.rsm";
+    case 0xD5:
+      return "event\\3차트랩_변풍01.rsm";
+    case 0xD6:
+      return "event\\3차트랩_화01.rsm";
+    case 0xD7:
+      return "event\\3차트랩_수01.rsm";
+    case 0xD8:
+      return "event\\3차트랩_풍01.rsm";
+    case 0xD9:
+      return "event\\3차트랩_지01.rsm";
+    case 0xE5:
+      return "event\\3차트랩_가시01.rsm";
+    case 0x5174:
+      return "effect\\deepblindtrap\\deep_trap.rsm2";
+    case 0x5175:
+      return "effect\\solidtrap\\sol_trap.rsm2";
+    case 0x5176:
+      return "effect\\swifttrap\\swi_trap.rsm2";
+    case 0x5177:
+      return "effect\\flametrap\\fla_trap.rsm2";
+    default:
+      return nullptr;
+  }
+}
+
+// OFFSET: 0x00E4B580
+// FUNCTION: fn_24269
+void CSkill::ReleaseModel() {
+  if (this->m_model == nullptr) {
+    return;
+  }
+
+  CGameMode* mode = static_cast<CGameMode*>(g_modeMgr.GetGameMode());
+  WorldSpatialTree* spatial = &mode->scene->spatial;
+  if (spatial != nullptr) {
+    spatial->RemoveModel(this->m_model, 0);
+  }
+
+  delete this->m_model;
+  this->m_model = nullptr;
+  if (this->m_effect != nullptr) {
+    this->m_effect->SendMsg(nullptr, 24, 0, 0, 0, 0, 0, 0);
+  }
+
+  this->m_effect = nullptr;
+  if (this->m_hasEffect) {
+    g_effectMgr->Find(this->skillAid, this->m_effectId)->RetireIfInactive();
+    this->m_hasEffect = false;
+  }
+}
 
 // OFFSET: 0x00E503F0
 // FUNCTION: fn_24294