Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp

Batch #16904 by eAthena: 1 byte-identical, 2 confirmed by peer review.

- fn_08447 CSkillAction_BO_DUST_EXPLOSION::OnSkillEffect: byte-identical
- fn_08315 CSkillInfo::DisplayName: logic confirmed by peer review (already on main)
- fn_08318 CSkillInfo::DisplayName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-11 11:06:23 +00:00
commit 1864c8de09

View file

@ -442,7 +442,7 @@ const char* CSkillInfo::DisplayName(LuaScript&, int skillId) {
}
const char* result = nullptr;
return g_session.m_hotkeyScript->Call("GetSkillName", "d>s", skillId, &result) ? result : "Unknown-Skill";
return g_session.m_hotkeyScript->Call("GetSkillName", "d>s", skillId, &result) == true ? result : "Unknown-Skill";
}
// OFFSET: 0x007739F0
@ -1813,12 +1813,13 @@ void CSkillAction_BO_DUST_EXPLOSION::OnSkillEffect(int level, CGameActor* source
}
const DustExplosionSpawner spawnDustExplosion{};
const vector3d& position = target->render.position;
for (int delay = 0; delay < 600; delay += 200) {
const int quadrant = std::ranges::max(std::rand() % 4, 0);
if (CEffect* effect = spawnDustExplosion(quadrant, target->render.position)) {
if (CEffect* effect = spawnDustExplosion(quadrant, position)) {
effect->SetDelay(delay);
}
if (CEffect* effect = spawnDustExplosion((quadrant + 2) % 4, target->render.position)) {
if (CEffect* effect = spawnDustExplosion((quadrant + 2) % 4, position)) {
effect->SetDelay(delay);
}
}