clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Decompile 2 functions in Source/Contents/Skills/PlayerSkillBundle.cpp, Source/Contents/Skills/PlayerSkillBundle.h, ...

Browse source 
Batch #13464 by SapitoSucio: 0 byte-identical, 2 confirmed by peer review.

- fn_08274 CPlayerSkillBundle::AddExtra: logic confirmed by peer review
- fn_23746 CSession::UpdateSkill: logic confirmed by peer review

Peer-reviewed-by: eAthena, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-06 19:56:51 +00:00
commit 293db20ff9
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Source/Contents/Skills/ClientSkills.cpp
View file

@ -240,7 +240,7 @@ bool CSession::UpdateSkill(const CSkillInfo& value, unsigned char notify, unsign
} else {
snapshot.unknown_0024 = UINT32_MAX;
snapshot.unknown_002C = 0;
this->m_skillBundle.AddExtra(snapshot, g_windowMgr);
this->m_skillBundle.AddExtra(snapshot);
}
}

4
Source/Contents/Skills/PlayerSkillBundle.cpp
View file

@ -168,9 +168,9 @@ void CPlayerSkillBundle::ClearExtra() {
// OFFSET: 0x007713E0
// FUNCTION: fn_08274
void CPlayerSkillBundle::AddExtra(const CSkillInfo& value, WindowManagerWindows& windows) {
void CPlayerSkillBundle::AddExtra(const CSkillInfo& value) {
this->extraIds.push_back(value.id);
if (UIWindow* window = windows.LookupWindow(37)) {
if (UIWindow* window = g_windowMgr.LookupWindow(37)) {
window->SendMsg(nullptr, 161, 0, 0, 0, 0);
}

2
Source/Contents/Skills/PlayerSkillBundle.h
View file

@ -36,7 +36,7 @@ public:
CSkillInfo* FindExtra(std::uint32_t id);
void ClearExtra();
bool RemoveExtra(std::uint32_t id);
void AddExtra(const CSkillInfo& value, WindowManagerWindows& windows);
void AddExtra(const CSkillInfo& value);
void NumberExtra();
void AddGrouped(int group, const CSkillInfo& value);
void ClearGroups();