clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Confirm 8 functions in Source/Contents/Items/ClientItemLists.cpp

Browse source 
Batch #16949 by eAthena: 0 byte-identical, 8 confirmed by peer review.

- fn_21640 CGameMode::ReceiveItem1738Add: logic confirmed by peer review (already on main)
- fn_21642 CGameMode::ReceiveItemSlotOptions: logic confirmed by peer review (already on main)
- fn_21645 CGameMode::ReceiveItem1740AddOptions: logic confirmed by peer review (already on main)
- fn_21646 CGameMode::ReceiveItem1740AddGrade: logic confirmed by peer review (already on main)
- fn_21647 CGameMode::ReceiveItem1738AddOptions: logic confirmed by peer review (already on main)
- fn_21648 CGameMode::ReceiveItem1738AddGrade: logic confirmed by peer review (already on main)
- fn_21832 CGameMode::ReceiveEquipItemList: logic confirmed by peer review (already on main)
- fn_21833 CGameMode::ReceiveItemListPart: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, alisonrag, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-11 13:46:15 +00:00
commit 45a975ac83
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Source/Contents/Items/ClientItemLists.cpp
View file

@ -256,7 +256,7 @@ void __fastcall RefreshItemWindows(UIWindowMgr* mgr) {
static int CountItemOptions(const ItemRandomOption* options) {
int count = 0;
for (int index = 0; index < 5; ++index) {
if (options[index].id != 0) {
if (0 != options[index].id) {
++count;
}
}
@ -1001,7 +1001,7 @@ void CSession::MergeShopItem(const ITEM_INFO& item) {
// OFFSET: 0x00DD7B80
// FUNCTION: fn_23299
bool CSession::AddCartItem(const ITEM_INFO& item, unsigned char refresh) {
__declspec(noinline) bool CSession::AddCartItem(const ITEM_INFO& item, unsigned char refresh) {
if (g_replayAnimationScaling && !Replay::Instance().header.options.Get(ReplayRecordOption::Item)) {
return true;
}