Batch #10396 by ragnarok-clanker: no function's compiled code changes; checked with 190 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h.
Merged directly by the admin, bypassing peer review, because part of the
original function was overwritten by the client's protector and can never
match. Task 16009 is marked done on purpose; do not resubmit it.
- Jump table 0xAD29E4: modes 0/1 go to 0xAD1E58, now "jmp 0x027AB0FE" into
an empty protector stub. Bytes 0xAD1E58..0xAD237D are garbage.
- The rest of case 0/1 survives from 0xAD237E (g_serviceFlag07 = 29,
strstr(g_launchServerName, "QmSakray"), key/address pair, StringFormat
into g_serviceAddress, then the admin/monster-job tail); ported as is.
- Live WinDbg run (servertype=primary): 0xAD1C90 is never called; the
protector loader in .data6 (sub_3DE8027) replaces it at runtime.
- Based on attempt 57915 (batch 10359), with g_session.unknown_58FA replaced
by g_launchServerName (same address, 0x1737F32). Key/string decryption
verified against the binary. td check --includers: no errors.
Batch #10394 by ragnarok-clanker: no function's compiled code changes; checked with 8 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10392 by ragnarok-clanker: no function's compiled code changes; checked with 8 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10391 by ragnarok-clanker: no function's compiled code changes; checked with 8 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10382 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_21112 CGameActor::SendMsg: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10367 by ragnarok-clanker: no function's compiled code changes; checked with 507 compiled unit(s), including every includer of Source/UI/Edit/UIEditCtrl.h, Source/UI/Window/UIWindowMgr.h.
Batch #10357 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_06597 Equipment: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10363 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_12346 UIItemCollectionWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10323 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_24372 sub_E5C430: logic confirmed by peer review
Peer-reviewed-by: tester, System4z, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10280 by ragnarok-clanker: forced by an admin (0 lower score(s), 115 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/ClientItemLists.h.
Deletes: Source/Contents/ClientItemLists.h
Batch #10279 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
Batch #10278 by ragnarok-clanker: forced by an admin (0 lower score(s), 68 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
Batch #10277 by ragnarok-clanker: forced by an admin (17 lower score(s), 63 changed function(s)); checked with 414 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelNode.h, Source/Contents/Models/ModelRendering.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldOcclusion.h, Source/Contents/World/WorldTerrainPicking.h, Source/Render/Projection/RendererViewport.h, Source/Render/Projection/RenderProjection.h.
Deletes: Source/Render/Projection/RenderProjection.h
Batch #10273 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 9 compiled unit(s), including every includer of Source/Contents/Schedule/CheckGDISchedule.h, Source/Contents/Schedule/TimeScheduler.h.
Batch #10272 by ragnarok-clanker: forced by an admin (1 lower score(s), 7 changed function(s)); checked with 282 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Actors/GameActor.h.
Batch #10269 by ragnarok-clanker: forced by an admin (2 lower score(s), 6 changed function(s)); checked with 102 compiled unit(s), including every includer of Source/Script/LuaScript.h.
Batch #10268 by ragnarok-clanker: forced by an admin (17 lower score(s), 85 changed function(s)); checked with 222 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Contents/Camera/CameraFrame.h, Source/Contents/Ground/TerrainHeight.h, Source/Contents/World/World.h, Source/Resource/World/TerrainResource.h.
Batch #10262 by ragnarok-clanker: forced by an admin (1 lower score(s), 22 changed function(s)); checked with 170 compiled unit(s), including every includer of Source/Contents/Ground/GroundGeometry.h, Source/Contents/Ground/GroundRendering.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldSpatialInitialization.h, Source/Contents/World/WorldSpatialTree.h.
Batch #10261 by ragnarok-clanker: forced by an admin (1 lower score(s), 9 changed function(s)); checked with 57 compiled unit(s), including every includer of Source/Client/Replay.h, Source/Client/ReplayPacketRecorder.h.
Deletes: Source/Client/ReplayPacketRecorder.h
Batch #10260 by ragnarok-clanker: forced by an admin (0 lower score(s), 5 changed function(s)); checked with 103 compiled unit(s), including every includer of Source/Contents/World/World.h, Source/Contents/World/WorldObjects.h.
Deletes: Source/Contents/World/WorldObjects.h
Batch #10257 by ragnarok-clanker: forced by an admin (7 lower score(s), 31 changed function(s)); checked with 95 compiled unit(s), including every includer of Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectAttachments.h.
Deletes: Source/Contents/Effects/EffectAttachments.h
Batch #10256 by ragnarok-clanker: forced by an admin (0 lower score(s), 8 changed function(s)); checked with 113 compiled unit(s), including every includer of Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelNode.h, Source/Contents/Models/ModelRendering.h, Source/Contents/World/World.h, Source/Contents/World/WorldModelLoading.h.
Batch #10253 by ragnarok-clanker: forced by an admin (2 lower score(s), 8 changed function(s)); checked with 24 compiled unit(s), including every includer of Source/Contents/GuildMgr.h, Source/Contents/Emblems/EmblemCache.h.
Deletes: Source/Contents/Emblems/EmblemCache.h
Batch #10252 by ragnarok-clanker: forced by an admin (1 lower score(s), 10 changed function(s)); checked with 11 compiled unit(s), including every includer of Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/SpriteDrawingPolicy.h.
Deletes: Source/Contents/Actors/SpriteDrawingPolicy.h
Batch #10251 by ragnarok-clanker: forced by an admin (2 lower score(s), 10 changed function(s)); checked with 244 compiled unit(s), including every includer of Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Store/MCStoreInfoBackup.h, Source/Contents/Store/MCStoreInfoBackupAsyncWork.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/MerchantShopRefresh.h.
Deletes: Source/UI/Shop/MerchantShopRefresh.h
Batch #10250 by ragnarok-clanker: forced by an admin (1 lower score(s), 2 changed function(s)); checked with 88 compiled unit(s), including every includer of Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h.
Batch #10248 by ragnarok-clanker: forced by an admin (0 lower score(s), 3 changed function(s)); checked with 241 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Jobs/JobNames.h.
Batch #10238 by ragnarok-clanker: forced by an admin (0 lower score(s), 15 changed function(s)); checked with 383 compiled unit(s), including every includer of Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectLists.h, Source/Render/DX9/RenderSystemDX9.h, Source/Render/DX9/RendererDX9.h, Source/Render/Renderer.h, Source/Render/DX9/RendererFrameDX9.h.
Deletes: Source/Render/DX9/RendererFrameDX9.h
Batch #10237 by ragnarok-clanker: forced by an admin (0 lower score(s), 90 changed function(s)); checked with 262 compiled unit(s), including every includer of Source/Client/Mode/CMode.h.
Batch #10235 by ragnarok-clanker: forced by an admin (0 lower score(s), 5 changed function(s)); checked with 39 compiled unit(s), including every includer of Source/Contents/Effects/EffectPrim.h, Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/EffectPrimitiveRendering.h, Source/Contents/Effects/EffectVisibility.h.
Deletes: Source/Contents/Effects/EffectPrimitiveRendering.h, Source/Contents/Effects/EffectVisibility.h
Batch #10231 by ragnarok-clanker: forced by an admin (5 lower score(s), 39 changed function(s)); checked with 495 compiled unit(s), including every includer of Source/Client/Mode/ModeTooltip.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Lists/UIDropDownBox.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
Deletes: Source/UI/Window/WindowOrdering.h
Batch #10230 by ragnarok-clanker: forced by an admin (9 lower score(s), 42 changed function(s)); checked with 339 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPainting.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/UI/UIBasicCtrl.h, Source/Network/Packets/SkillUpdatePacket.h.
Deletes: Source/Network/Packets/SkillUpdatePacket.h
Batch #10228 by ragnarok-clanker: forced by an admin (0 lower score(s), 7 changed function(s)); checked with 13 compiled unit(s), including every includer of Source/Contents/Effects/EffectPrimitiveMotion.h, Source/Contents/Effects/EffectPrim.h.
Batch #10224 by ragnarok-clanker: forced by an admin (0 lower score(s), 2 changed function(s)); checked with 22 compiled unit(s), including every includer of Source/UI/Window/UIWindowMgr.inl, Source/UI/Shortcuts/ShortcutVisibility.h.
Deletes: Source/UI/Shortcuts/ShortcutVisibility.h
Batch #10223 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 0 compiled unit(s), including every includer of Source/Contents/Configuration/ScriptOptions.h.
Deletes: Source/Contents/Configuration/ScriptOptions.h
Batch #10222 by ragnarok-clanker: forced by an admin (7 lower score(s), 45 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Messenger/ClientMessenger.h.
Batch #10221 by ragnarok-clanker: forced by an admin (3 lower score(s), 7 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Configuration/GraphicsConfiguration.h.
Deletes: Source/Contents/Configuration/GraphicsConfiguration.h
Batch #10220 by ragnarok-clanker: forced by an admin (5 lower score(s), 30 changed function(s)); checked with 24 compiled unit(s), including every includer of Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/ChatSuggestions.h.
Deletes: Source/UI/Chat/ChatSuggestions.h
Batch #10218 by ragnarok-clanker: forced by an admin (0 lower score(s), 10 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Session.h, Source/UI/Shortcuts/ShortcutDrop.h, Source/UI/Shortcuts/UIShortCutWnd.h, Source/UI/Shortcuts/ShortcutUse.h.
Deletes: Source/UI/Shortcuts/ShortcutUse.h
Batch #10214 by ragnarok-clanker: forced by an admin (0 lower score(s), 4 changed function(s)); checked with 17 compiled unit(s), including every includer of Source/Contents/UserData/CharacterConfigLoad.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutControlEvents.h, Source/UI/Shortcuts/ShortcutVisibility.h, Source/UI/Shortcuts/UIShortCutWnd.h.
