Commit graph

53 commits

Author SHA1 Message Date
ragnarok-clanker
d6bc9836d7 Maintenance: [forced, admin decision] Collapse the WindowManagerWindows adapter into UIWindowMgr, stage 1 of 2 (project decision: por
Batch #10019 by ragnarok-clanker: forced by an admin (23 lower score(s), 187 changed function(s)); checked with 447 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Mode/ModeDragState.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemCache.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/Party/AgencyRequestContext.h, Source/Contents/Party/ChangePartyMasterAsyncWork.h, Source/Contents/Party/LoadMyPartyAsyncWork.h, Source/Contents/Party/LoadPartyInfoAsyncWork.h, Source/Contents/Party/LoadPartyListAsyncWork.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/Party/RegisterPartyAsyncWork.h, Source/Contents/Party/StopRecruitingAsyncWork.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Chat/ChatSuggestions.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Lists/UIListBox.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/UIBasicCtrl.h, Source/UI/UIStaticItem.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/WindowManagerWindows.h, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
2026-11-02 14:09:20 +00:00
ragnarok-clanker
38d679d82f Decompile fn_06361 (CGameSettingsMgr::Init_Func)
Batch #10005 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06361 CGameSettingsMgr::Init_Func: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-11-02 13:19:44 +00:00
ragnarok-clanker
bd9abfbc56 Maintenance: CGameMode layout, remaining members after maintenance 00792cfe (replaces returned batch 9955, rebased on current main).
Batch #9986 by ragnarok-clanker: no function's compiled code changes; checked with 177 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h.
2026-11-02 12:44:07 +00:00
ragnarok-clanker
66d43b7d12 Decompile fn_06317 (CGameSettingsMgr::LoadSettings)
Batch #9818 by akreao: 0 byte-identical, 1 confirmed by peer review.

- fn_06317 CGameSettingsMgr::LoadSettings: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-02 01:02:20 +00:00
ragnarok-clanker
7b9ff1b0f7 Decompile 3 functions in Source/UI/Acceptance/UIChooseSellBuyWnd.cpp, Source/Contents/Configuration/ServiceConfiguration.h, ...
Batch #9377 by secret: 0 byte-identical, 3 confirmed by peer review.

- fn_12107 UIChooseWarpWnd::Slot44: logic confirmed by peer review
- fn_12110 UIExchangeWnd::Slot44: logic confirmed by peer review
- fn_12117 UISayDialogWnd::Slot44: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, Montyla, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 09:45:26 +00:00
ragnarok-clanker
af33e341bd Decompile fn_17811 (InitializeLanguage)
Batch #9151 by KWDev: 0 byte-identical, 1 confirmed by peer review.

- fn_17811 InitializeLanguage: logic confirmed by peer review

Peer-reviewed-by: youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 03:05:46 +00:00
ragnarok-clanker
4fd6cd3ad7 Maintenance: Resubmission of batch 9115 rebased onto main (it conflicted with 9108's CommonObject.cpp change, which it already contai
Batch #9132 by ragnarok-clanker: forced by an admin (2 lower score(s), 13 changed function(s)); checked with 22 compiled unit(s), including every includer of Source/Contents/ForbiddenWords.h, Source/Contents/Party/PartyInvitation.h, Source/File/CommonObject.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIPetInfoWnd.h.
2026-11-01 02:10:48 +00:00
ragnarok-clanker
e2adea64ff Maintenance: Replace raw address calls in SessionMessengerContext::sub_DD9D50 with declared functions (all unported, single caller, s
Batch #8904 by ragnarok-clanker: forced by an admin (0 lower score(s), 1 changed function(s)); checked with 4 compiled unit(s), including every includer of Source/Contents/SimpleStringMgr.h, Source/Contents/Configuration/GameSettingsMgr.h.
2026-10-31 23:01:41 +00:00
ragnarok-clanker
97cd41807e Decompile fn_06362 (ApplyServiceOptionItemWnd)
Batch #8871 by Romain: 0 byte-identical, 1 confirmed by peer review.

- fn_06362 ApplyServiceOptionItemWnd: logic confirmed by peer review

Peer-reviewed-by: Montyla, pedrao, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 22:07:18 +00:00
ragnarok-clanker
f1ffb5c8db Decompile fn_06362 (ApplyServiceOptionItemWnd)
Batch #8850 by KWDev: 0 byte-identical, 1 confirmed by peer review.

- fn_06362 ApplyServiceOptionItemWnd: logic confirmed by peer review

Peer-reviewed-by: Montyla, pedrao, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 22:01:06 +00:00
ragnarok-clanker
0240982a68 Decompile fn_17818 (ReadClientInfo)
Batch #8613 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_17818 ReadClientInfo: logic confirmed by peer review

Peer-reviewed-by: eAthena, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 19:44:26 +00:00
ragnarok-clanker
ba1fe23c29 Decompile fn_23651 (CSession::SaveOptionInfo)
Batch #8238 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23651 CSession::SaveOptionInfo: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, Romain, vinnyamancio, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 17:06:58 +00:00
ragnarok-clanker
8552c60086 Decompile fn_23604 (CSession::LoadOptionInfo)
Batch #8272 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23604 CSession::LoadOptionInfo: logic confirmed by peer review

Peer-reviewed-by: Yommy, System4z, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 16:00:20 +00:00
ragnarok-clanker
598fad89ee Decompile 10 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h, ...
Batch #8153 by secret: 1 byte-identical, 9 confirmed by peer review.

- fn_15940 CUIGameSettingsUI::ResetToDefaults: logic confirmed by peer review
- fn_15941 GameSettingsUI::CUIOptionItem::RunFunction: logic confirmed by peer review
- fn_15950 GameSettingsUI::CUIOptionItem::OnCheck: logic confirmed by peer review
- fn_15957 GameSettingsUI::CUIGroupSkin::OnSelect: logic confirmed by peer review
- fn_15969 GameSettingsUI::CUIListPage::BindOption: logic confirmed by peer review
- fn_16014 GameSettingsUI::CUIListPage::LoadOptions: logic confirmed by peer review
- fn_16030 GameSettingsUI::CUIListPage::RefreshHotkeyLabels: logic confirmed by peer review
- fn_16046 CUIGameSettingsUI::sub_A43BA0: byte-identical
- fn_16047 GameSettingsUI::CUIListPage::RefreshOptions: logic confirmed by peer review
- fn_16048 CUIGameSettingsUI::sub_A43C70: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 14:44:45 +00:00
ragnarok-clanker
8db9eacff4 Decompile fn_21321 (CPingLiveSchedule::Process)
Batch #8156 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21321 CPingLiveSchedule::Process: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, secret
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 14:35:16 +00:00
ragnarok-clanker
d971cb7a98 Decompile 2 functions in Source/Contents/ClientTiming.cpp, Source/Client/Replay.cpp, ...
Batch #7250 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_24203 CSession::BuildReservedReplayRecords: logic confirmed by peer review
- fn_06365 ShowPlayerLocation: logic confirmed by peer review

Peer-reviewed-by: meitogi, alisonrag, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 05:21:19 +00:00
ragnarok-clanker
158c77e1fe Decompile fn_19329 (Replay::CachePacket)
Batch #7224 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19329 Replay::CachePacket: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 05:01:50 +00:00
ragnarok-clanker
dfdd4fbf2f Decompile 6 functions in Source/Contents/Configuration/ServiceOptions.cpp, Source/Contents/Effects/MonsterSkillEffects.cpp, ...
Batch #7031 by Lumen: 2 byte-identical, 4 confirmed by peer review.

- fn_45463 RequestModeAction48: logic confirmed by peer review
- fn_45464 RequestModeAction61: logic confirmed by peer review
- fn_45465 NotifyGameModeOptionFirst: logic confirmed by peer review
- fn_45462 RequestPlayerAction31: logic confirmed by peer review
- fn_07176 CCurseOfCubeEffect::Restart: byte-identical
- fn_07177 CCurseOfCubeEffect::Slot01: byte-identical

Peer-reviewed-by: ragnarok-clanker, alisonrag, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 03:22:35 +00:00
ragnarok-clanker
437cdd7344 Decompile fn_45461 (GreetFriends)
Batch #6559 by System4z: 0 byte-identical, 1 confirmed by peer review.

- fn_45461 GreetFriends: logic confirmed by peer review

Peer-reviewed-by: eAthena, gordaoprogramas, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:19:13 +00:00
ragnarok-clanker
04edb6b31b Decompile fn_06356 (ApplyServiceOptionJitterScale)
Batch #6331 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_06356 ApplyServiceOptionJitterScale: logic confirmed by peer review

Peer-reviewed-by: alisonrag, superintelligence, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 22:03:45 +00:00
ragnarok-clanker
f621c6d8b9 Decompile fn_17810 (sub_AD1270)
Batch #5836 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_17810 sub_AD1270: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 18:03:47 +00:00
ragnarok-clanker
988001b62e Decompile fn_17809 (LoadLoadingScreens)
Batch #5870 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_17809 LoadLoadingScreens: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 16:49:38 +00:00
ragnarok-clanker
f67d21742e Confirm 4 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #5800 by Yommy: 0 byte-identical, 4 confirmed by peer review.

- fn_06355 ApplyServiceOptionXmasWeather: logic confirmed by peer review (already on main)
- fn_06358 ApplyServiceOptionWithNotice: logic confirmed by peer review (already on main)
- fn_06360 ApplyServiceOptionActorRefresh: logic confirmed by peer review (already on main)
- fn_06377 ApplyServiceOptionWindows189: logic confirmed by peer review (already on main)

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 15:49:11 +00:00
ragnarok-clanker
eff783d8ce Decompile fn_06357 (ApplyServiceOptionMapFog)
Batch #5583 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06357 ApplyServiceOptionMapFog: logic confirmed by peer review

Peer-reviewed-by: willerthal, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:38:00 +00:00
ragnarok-clanker
953c0fdb28 Decompile fn_06371 (ApplyServiceOptionWindow159)
Batch #5561 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06371 ApplyServiceOptionWindow159: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:17:48 +00:00
ragnarok-clanker
5f99fe86ef Decompile fn_06364 (ApplyServiceOptionWindow27)
Batch #5538 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06364 ApplyServiceOptionWindow27: logic confirmed by peer review

Peer-reviewed-by: willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 12:56:26 +00:00
ragnarok-clanker
95e750c526 Decompile 4 functions in Source/Client/Input/Language.cpp, Source/Client/Input/Language.h, ...
Batch #5400 by Yommy: 1 byte-identical, 3 confirmed by peer review.

- fn_45450 SuggestChatCommand: logic confirmed by peer review
- fn_17806 SubACFCE0: byte-identical
- fn_17807 GetLicenceText: logic confirmed by peer review
- fn_17808 InitializeServiceStrings: logic confirmed by peer review

Peer-reviewed-by: willerthal, SapitoSucio, ragnarok-clanker, tayoba, bigodeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 12:22:01 +00:00
ragnarok-clanker
c7e5d89b0d Decompile 3 functions in Source/Script/LuaScript.cpp, Source/Client/Session.h, ...
Batch #5332 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_18350 GetCmdOnOffValue: logic confirmed by peer review
- fn_18351 SetCmdOnOffList: logic confirmed by peer review
- fn_18358 AddIngredient: logic confirmed by peer review

Peer-reviewed-by: eAthena, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 10:49:18 +00:00
ragnarok-clanker
c18238d97f Decompile fn_06322 (CGameSettingsMgr::ResetToDefaults)
Batch #5369 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06322 CGameSettingsMgr::ResetToDefaults: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 10:47:00 +00:00
ragnarok-clanker
79db1039a2 Decompile fn_06363 (ApplyServiceOptionWeatherFlag)
Batch #5202 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_06363 ApplyServiceOptionWeatherFlag: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, meitogi, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:54:10 +00:00
ragnarok-clanker
63bef25c13 Decompile fn_06369 (ApplyServiceOptionAskOnDisable)
Batch #5117 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06369 ApplyServiceOptionAskOnDisable: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 08:27:16 +00:00
ragnarok-clanker
305e7a6f16 Decompile fn_06302 (Noop)
Batch #5105 by SapitoSucio: 1 byte-identical, 0 confirmed by peer review.

- fn_06302 Noop: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-30 08:09:10 +00:00
ragnarok-clanker
d9878c9459 Decompile fn_23798 (CSession::GetOptionFloat)
Batch #4598 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23798 CSession::GetOptionFloat: logic confirmed by peer review

Peer-reviewed-by: youko, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 05:11:41 +00:00
ragnarok-clanker
83645a392b Decompile fn_17330 (Singleton<CGameSettingsMgr>::GetInstance)
Batch #4731 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17330 Singleton<CGameSettingsMgr>::GetInstance: logic confirmed by peer review

Peer-reviewed-by: youko, Qwenkler3.8
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 04:41:35 +00:00
ragnarok-clanker
c3ae8f4c04 Decompile 2 functions in Source/Contents/Configuration/ServiceOptions.cpp, Source/Contents/Skills/ClientSkills.h
Batch #4605 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_06354 ToggleSitStand: logic confirmed by peer review
- fn_06366 ApplyServiceOptionSessionFlag: logic confirmed by peer review

Peer-reviewed-by: willerthal, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 04:05:10 +00:00
ragnarok-clanker
de1c91b331 Decompile 2 functions in Source/Contents/Configuration/ServiceOptions.cpp, Source/Script/LuaScript.h
Batch #4207 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_06321 CGameSettingsMgr::ReadOptionTable: logic confirmed by peer review
- fn_06359 ShowHelpMessages: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 02:43:48 +00:00
ragnarok-clanker
6a5b0c5e8e Decompile 3 functions in Source/Contents/Configuration/ServiceOptions.cpp, Source/Client/Mode/CGameMode.h
Batch #4050 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_06350 RotatePlayerDirection: logic confirmed by peer review
- fn_06351 SendConfigServiceOption: logic confirmed by peer review
- fn_06380 ApplyServiceOptionHideWindow: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, superintelligence, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:49:21 +00:00
ragnarok-clanker
519897f39c Decompile 11 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Contents/Configuration/ServiceOptions.cpp
Batch #3991 by eAthena: 0 byte-identical, 11 confirmed by peer review.

- fn_06282 GetLocation: logic confirmed by peer review
- fn_06283 GetMapName: logic confirmed by peer review
- fn_06285 GetPureJob: logic confirmed by peer review
- fn_06290 IsPremiumPcCafe: logic confirmed by peer review
- fn_06291 C_Logger: logic confirmed by peer review
- fn_06299 CGameSettingsMgr::CGameSettingsMgr: logic confirmed by peer review
- fn_06312 CGameSettingsMgr::sub_6C0C40: logic confirmed by peer review
- fn_06313 CGameSettingsMgr::RunFunction: logic confirmed by peer review
- fn_06314 FindServiceOption: logic confirmed by peer review
- fn_06315 CGameSettingsMgr::FindOption: logic confirmed by peer review
- fn_06316 CGameSettingsMgr::GetOptionIds: logic confirmed by peer review

Peer-reviewed-by: willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:25:49 +00:00
ragnarok-clanker
4ac8f3b2a5 Decompile 3 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #3646 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_06352 ApplyServiceOptionFlags: logic confirmed by peer review
- fn_06353 ApplyServiceOption: logic confirmed by peer review
- fn_06378 ApplyServiceOptionNotifyWindow: logic confirmed by peer review

Peer-reviewed-by: youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:54:13 +00:00
ragnarok-clanker
82a9924d2b Decompile 12 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #3210 by willerthal: 0 byte-identical, 12 confirmed by peer review.

- fn_06368 SendServiceOptionPacket: logic confirmed by peer review
- fn_06370 NotifyServiceOption: logic confirmed by peer review
- fn_06372 NotifyGameModeOption: logic confirmed by peer review
- fn_06373 NotifyGameModeOptionAlt: logic confirmed by peer review
- fn_06374 NotifyGameModeMenu: logic confirmed by peer review
- fn_06375 ApplyServiceOptionWindow190: logic confirmed by peer review
- fn_06376 ApplyServiceOptionWindow267: logic confirmed by peer review
- fn_06379 ApplyServiceOptionWindow268: logic confirmed by peer review
- fn_06381 EnableWhisperBlock: logic confirmed by peer review
- fn_06382 DisableWhisperBlock: logic confirmed by peer review
- fn_06383 SendWhisperBlockPacket: logic confirmed by peer review
- fn_06384 ApplyServiceOptionAndSnap: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:57:35 +00:00
ragnarok-clanker
81c6115b7b Decompile fn_23917 (OptionWriter::Float)
Batch #3211 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_23917 OptionWriter::Float: logic confirmed by peer review

Peer-reviewed-by: meitogi, Lumen
Reviewed-by: ragnarok-clanker
2026-10-29 21:51:04 +00:00
ragnarok-clanker
428e3835e9 Decompile 55 functions in Source/Client/Session.h, Source/Contents/BodyResources.cpp, ...
Batch #3212 by youko: 55 byte-identical, 0 confirmed by peer review.

- fn_23950 EncryptedName<10,-1315859149>::Text: byte-identical
- fn_23951 EncryptedName<10,-979039381>::Text: byte-identical
- fn_23952 EncryptedName<10,-617908319>::Text: byte-identical
- fn_23953 EncryptedName<10,-3263989789>::Text: byte-identical
- fn_23954 EncryptedName<10,-1682334759>::Text: byte-identical
- fn_23955 EncryptedName<10,898467589>::Text: byte-identical
- fn_23956 EncryptedName<10,2204305161>::Text: byte-identical
- fn_23957 EncryptedName<10,3344639417>::Text: byte-identical
- fn_23958 EncryptedName<10,199223703>::Text: byte-identical
- fn_23959 EncryptedName<10,4261389595>::Text: byte-identical
- fn_23960 EncryptedName<10,4123116959>::Text: byte-identical
- fn_23961 EncryptedName<10,561237833>::Text: byte-identical
- fn_23962 EncryptedName<16,-1980669487>::Text: byte-identical
- fn_23963 EncryptedName<16,-113271841>::Text: byte-identical
- fn_23964 EncryptedName<16,-1517315221>::Text: byte-identical
- fn_23965 EncryptedName<16,1739409375>::Text: byte-identical
- fn_23966 EncryptedName<16,3417698647>::Text: byte-identical
- fn_23967 EncryptedName<18,-2999633023>::Text: byte-identical
- fn_23968 EncryptedName<18,-1585628829>::Text: byte-identical
- fn_23969 EncryptedName<18,-3124629243>::Text: byte-identical
- fn_23970 EncryptedName<18,-3401353789>::Text: byte-identical
- fn_23971 EncryptedName<18,-3305026235>::Text: byte-identical
- fn_23972 EncryptedName<18,-2753699959>::Text: byte-identical
- fn_23973 EncryptedName<18,-2090247411>::Text: byte-identical
- fn_23974 EncryptedName<18,-1108884035>::Text: byte-identical
- fn_23975 EncryptedName<18,2174745559>::Text: byte-identical
- fn_23976 EncryptedName<18,2916963279>::Text: byte-identical
- fn_23977 EncryptedName<18,1037158757>::Text: byte-identical
- fn_23978 EncryptedName<18,2544074191>::Text: byte-identical
- fn_23979 EncryptedName<18,3947304279>::Text: byte-identical
- fn_23980 EncryptedName<18,957680539>::Text: byte-identical
- fn_23981 EncryptedName<18,459105731>::Text: byte-identical
- fn_23982 EncryptedName<18,2006784475>::Text: byte-identical
- fn_23983 EncryptedName<18,1697449919>::Text: byte-identical
- fn_23984 EncryptedName<18,1069021477>::Text: byte-identical
- fn_23985 EncryptedName<18,2669800313>::Text: byte-identical
- fn_23986 EncryptedName<20,-372429951>::Text: byte-identical
- fn_23987 EncryptedName<20,595816843>::Text: byte-identical
- fn_23988 EncryptedName<20,3849141641>::Text: byte-identical
- fn_23989 EncryptedName<20,665307127>::Text: byte-identical
- fn_23990 EncryptedName<22,-1343680015>::Text: byte-identical
- fn_23991 EncryptedName<22,-3203960915>::Text: byte-identical
- fn_23992 EncryptedName<22,3944978353>::Text: byte-identical
- fn_23993 EncryptedName<22,2745126827>::Text: byte-identical
- fn_23994 EncryptedName<22,2030259687>::Text: byte-identical
- fn_23995 EncryptedName<23,-2258505739>::Text: byte-identical
- fn_23996 EncryptedName<23,3914540533>::Text: byte-identical
- fn_23997 EncryptedName<23,935698863>::Text: byte-identical
- fn_23998 EncryptedName<24,2401333041>::Text: byte-identical
- fn_23999 EncryptedName<24,937134379>::Text: byte-identical
- fn_24000 EncryptedName<24,1105683737>::Text: byte-identical
- fn_24001 EncryptedName<25,-4062891603>::Text: byte-identical
- fn_24002 EncryptedName<25,58020621>::Text: byte-identical
- fn_24003 EncryptedName<25,1696325589>::Text: byte-identical
- fn_24004 EncryptedName<25,3542311337>::Text: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:57:52 +00:00
ragnarok-clanker
c68f8360de Decompile 2 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #2786 by Lumen: 0 byte-identical, 2 confirmed by peer review.

- fn_06323 GameSettings::ToggleOption: logic confirmed by peer review
- fn_06324 SetOption: logic confirmed by peer review

Peer-reviewed-by: willerthal, youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:00:34 +00:00
ragnarok-clanker
dcc654e1d6 Decompile 2 functions in Source/Client/Mode/ModeLifetime.cpp, Source/Contents/Configuration/ServiceConfiguration.cpp, ...
Batch #2128 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17819 SetServiceFlags: logic confirmed by peer review
- fn_17822 CMode::`scalar deleting destructor': logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/Mode/ModeLifetime.cpp
2026-10-29 12:55:03 +00:00
ragnarok-clanker
ef13e565dd Decompile 2 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h, ...
Batch #1897 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23644 CSession::LoadNavigationScripts: logic confirmed by peer review
- fn_23645 CSession::LoadRobeAlpha: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:27:26 +00:00
ragnarok-clanker
e1d9e25c29 Decompile fn_06320 (GameSettings::ApplyScriptOption)
Batch #1686 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_06320 GameSettings::ApplyScriptOption: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:20:58 +00:00
ragnarok-clanker
9312817430 Maintenance: Define two globals that main reads but never defines. g_applicationDirectory (gl_24584, 0x173AD78, char[0x80]) has one w
Batch #1570 by ragnarok-clanker: no function's compiled code changes; checked with 5 compiled unit(s), including every includer of Source/Client/Application/Launcher.h, Source/Client/Input/InputCharset.h.
2026-10-28 18:59:30 +00:00
ragnarok-clanker
44f60ba6ca Decompile 6 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1038 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_07649 CMiniPartyWndAreaMgr::CMiniPartyWndAreaMgr: logic confirmed by peer review
- fn_17099 UIWindowMgr::~UIWindowMgr: logic confirmed by peer review
- fn_17233 UIWindowMgr::Shutdown: logic confirmed by peer review
- fn_09716 CSnapMgr::MoveEdge: logic confirmed by peer review
- fn_06318 ServiceOptions::Get: logic confirmed by peer review (already on main)
- fn_06325 ServiceOptions::Set: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-27 11:01:30 +00:00
ragnarok-clanker
f3ceb09e9d Merge commit '6c40a36577' 2026-10-27 10:06:35 +00:00
ragnarok-clanker
01aeb424f6 Maintenance: Real scalar owner for gl24542 signed-byte g_language at16D3B07 and gl24529 int g_serviceType16D3B10. PE section .data Vi
Batch #1019 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s), including every includer of Source/Contents/Configuration/ServiceConfiguration.h.
Adds to the build: Source/Contents/Configuration/ServiceConfiguration.cpp
2026-10-27 09:31:50 +00:00