ragnarok-clanker
f8d3e8622d
Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
...
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
2026-11-06 16:30:12 +00:00
ragnarok-clanker
b79407bc49
Decompile 2 functions in Source/UI/Window/UIRPImageWnd2.cpp, Source/UI/Window/UIRPImageWnd2.h, ...
...
Batch #6184 by eAthena: 0 byte-identical, 2 confirmed by peer review.
- fn_12951 UIRPImageWnd2::SetImage: logic confirmed by peer review
- fn_12966 UIStaticText_LF::SetText: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 20:58:52 +00:00
ragnarok-clanker
1ff6ad3bf7
Decompile 23 functions in Source/UI/Quest/UIQuestDisplay.cpp, Source/UI/Quest/UIQuestDisplay.h, ...
...
Batch #4400 by youko: 8 byte-identical, 15 confirmed by peer review.
- fn_12912 UIRPImageWnd2::Paint: logic confirmed by peer review
- fn_12914 UIShowWarpWnd::Paint: byte-identical
- fn_12916 UITransMenuWnd::Paint: logic confirmed by peer review
- fn_12917 UIDebuffRemoveWnd::Slot25: byte-identical
- fn_12918 UIMileageWnd::Slot25: byte-identical
- fn_12919 UINoteWnd_Scroll::Slot25: logic confirmed by peer review
- fn_12920 UIStaticText_LF::Slot25: logic confirmed by peer review
- fn_12921 UITransMenuWnd::Slot25: logic confirmed by peer review
- fn_12922 UIDebuffRemoveWnd::Slot31: byte-identical
- fn_12923 UIMileageWnd::Slot31: logic confirmed by peer review
- fn_12924 UINoteWnd_Scroll::Slot31: logic confirmed by peer review
- fn_12925 UIStaticText_LF::Slot31: logic confirmed by peer review
- fn_12926 UIMileageWnd::Slot28: logic confirmed by peer review
- fn_12927 UIOpenMailBoxWnd::Slot53: byte-identical
- fn_12928 UIDebuffRemoveWnd::Slot27: byte-identical
- fn_12929 UIMileageWnd::Slot27: byte-identical
- fn_12930 UITransMenuWnd::Slot27: logic confirmed by peer review
- fn_12932 UIMileageWnd::Slot19: logic confirmed by peer review
- fn_12933 UIOpenRoulletteWnd::Slot19: byte-identical
- fn_12934 UIQuestDisplay::Slot33: logic confirmed by peer review
- fn_12935 UINoteWnd_Scroll::Slot35: logic confirmed by peer review
- fn_12936 UIStaticText_LF::Slot35: logic confirmed by peer review
- fn_12937 UITransMenuWnd::Resize: logic confirmed by peer review
Peer-reviewed-by: eAthena, KWDev
Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/Text/UIStaticText_LF.cpp, Source/UI/Window/UINoteWnd.cpp, Source/UI/Window/UIRPImageWnd2.cpp, Source/UI/Window/UIShowWarpWnd.cpp
2026-10-30 03:41:58 +00:00