Commit graph

54 commits

Author SHA1 Message Date
ragnarok-clanker
38bd0ddc2b Decompile fn_20390 (CConnection::Close)
Batch #14389 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_20390 CConnection::Close: logic confirmed by peer review

Peer-reviewed-by: secret, aDw, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 08:10:13 +00:00
ragnarok-clanker
2bf070d8cc Decompile fn_22266 (CLoginMode::SubD8D500)
Batch #13669 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_22266 CLoginMode::SubD8D500: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 21:14:57 +00:00
ragnarok-clanker
5914b15581 Decompile 3 functions in Source/Network/ClientOptionPacket.cpp
Batch #13426 by SapitoSucio: 3 byte-identical, 0 confirmed by peer review.

- fn_24219 CSession::SendClientOption: byte-identical
- fn_24227 CSession::SendHomunculusAutoFeedOption: byte-identical
- fn_24234 CSession::SendPetAutoFeedOption: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 16:39:41 +00:00
ragnarok-clanker
d8b57b8f4a Decompile fn_20418 (CPacketQueue::CPacketQueue)
Batch #13240 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_20418 CPacketQueue::CPacketQueue: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 12:13:33 +00:00
ragnarok-clanker
fec919b88e Maintenance: Link-completeness fixes so the whole client links into one executable (all units in data/compile.json plus exe-only thir
Batch #13186 by ragnarok-clanker: forced by an admin (40 lower score(s), 206 changed function(s)); checked with 620 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h, Source/Client/Timer.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/ServiceOptions.h, Source/Contents/Skills/SkillTreeScript.h, Source/Render/DX9/D3DX9Runtime.h, Source/Resource/GifResource.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Cooldowns/CooldownOwner.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIReputeWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/EncryptedName.h.
2026-11-06 10:56:48 +00:00
ragnarok-clanker
72afe5a4a6 Confirm fn_03952 (CCURLMgr::Initialize)
Batch #13092 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_03952 CCURLMgr::Initialize: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-06 05:07:06 +00:00
ragnarok-clanker
a4b819bcbe Decompile fn_20387 (CheckConnectionRuntime)
Batch #12680 by spider: 1 byte-identical, 0 confirmed by peer review.

- fn_20387 CheckConnectionRuntime: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 23:48:05 +00:00
ragnarok-clanker
3654696d35 Decompile fn_20387 (CheckConnectionRuntime)
Batch #12555 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_20387 CheckConnectionRuntime: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 20:11:33 +00:00
ragnarok-clanker
0cca901c29 Decompile fn_24219 (CSession::SendClientOption)
Batch #12527 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_24219 CSession::SendClientOption: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:53:43 +00:00
ragnarok-clanker
0f057b5609 Decompile fn_21367 (SendGameTick)
Batch #12298 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_21367 SendGameTick: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:08:03 +00:00
ragnarok-clanker
62d686e626 Decompile fn_20424 (CPacketQueue::Prepend)
Batch #12265 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_20424 CPacketQueue::Prepend: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 14:50:54 +00:00
ragnarok-clanker
2a768fc6d8 Decompile 2 functions in Source/Network/TextEncoding.cpp
Batch #12147 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_18265 EncodeText: logic confirmed by peer review
- fn_02795 FindSubstring: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:30:18 +00:00
ragnarok-clanker
880ec06f38 Decompile 4 functions in Source/Network/TextEncoding.cpp
Batch #12152 by cremane: 4 byte-identical, 0 confirmed by peer review.

- fn_18243 ToUtf8: byte-identical
- fn_18257 LowercaseText: byte-identical
- fn_18258 DecodeText: byte-identical
- fn_18264 FromUtf8: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 11:53:04 +00:00
ragnarok-clanker
ee4a098874 Decompile fn_20388 (Cleanup)
Batch #12017 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_20388 Cleanup: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 08:27:42 +00:00
ragnarok-clanker
d9c3c1d6fe Confirm 3 functions in Source/Network/Connection/Connection.cpp, Source/Network/Connection/Connection.h
Batch #11914 by StrawberrysherbetIX: 0 byte-identical, 3 confirmed by peer review.

- fn_20397 CConnection::Receive: logic confirmed by peer review (already on main)
- fn_20398 CConnection::Flush: logic confirmed by peer review (already on main)
- fn_20407 CConnection::SetBlock: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane, KWDev, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 05:30:24 +00:00
ragnarok-clanker
3fa014f408 Decompile 2 functions in Source/Network/Packets/PacketLengths.cpp
Batch #11585 by SapitoSucio: 0 byte-identical, 2 confirmed by peer review.

- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18383 PacketLengths::PacketLengths: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, cremane, KWDev, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:42:59 +00:00
ragnarok-clanker
68442f7e23 Decompile 2 functions in Source/Network/Packets/PacketLengths.cpp
Batch #11407 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_20391 PacketLengths::FixedLength: byte-identical (already on main)
- fn_18388 PacketLengths::Lookup: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 00:04:46 +00:00
ragnarok-clanker
5b99f20ebb Decompile fn_03955 (CCURLPostHander::CCURLPostHander)
Batch #11130 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_03955 CCURLPostHander::CCURLPostHander: byte-identical

Peer-reviewed-by: Yommy, kyoshi, SapitoSucio
Merged automatically: every function is byte-identical to the original.
2026-11-04 23:36:45 +00:00
ragnarok-clanker
d92aee6684 Decompile 2 functions in Source/Network/Connection/ConnectionRuntime.cpp
Batch #10531 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_20408 InitializeConnections: logic confirmed by peer review
- fn_20387 CheckConnectionRuntime: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 23:04:03 +00:00
ragnarok-clanker
04662f3c3e Decompile 2 functions in Source/Network/Packets/PacketLengths.cpp
Batch #11222 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_18385 PacketLengths::Register: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:34:40 +00:00
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
9a3c7a1bbb Decompile fn_03961 (CCURLPostHander::WriteResponse)
Batch #11168 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_03961 CCURLPostHander::WriteResponse: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-04 20:41:25 +00:00
ragnarok-clanker
9b04a3cae5 Maintenance: [forced, user-approved] Family G18: remove the Skills bundle family (ClientSkills, SkillUseLevels, SkillWindows, Compani
Batch #10230 by ragnarok-clanker: forced by an admin (9 lower score(s), 42 changed function(s)); checked with 339 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPainting.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/UI/UIBasicCtrl.h, Source/Network/Packets/SkillUpdatePacket.h.
Deletes: Source/Network/Packets/SkillUpdatePacket.h
2026-11-03 09:49:00 +00:00
ragnarok-clanker
d6bc9836d7 Maintenance: [forced, admin decision] Collapse the WindowManagerWindows adapter into UIWindowMgr, stage 1 of 2 (project decision: por
Batch #10019 by ragnarok-clanker: forced by an admin (23 lower score(s), 187 changed function(s)); checked with 447 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Mode/ModeDragState.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemCache.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/Party/AgencyRequestContext.h, Source/Contents/Party/ChangePartyMasterAsyncWork.h, Source/Contents/Party/LoadMyPartyAsyncWork.h, Source/Contents/Party/LoadPartyInfoAsyncWork.h, Source/Contents/Party/LoadPartyListAsyncWork.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/Party/RegisterPartyAsyncWork.h, Source/Contents/Party/StopRecruitingAsyncWork.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Chat/ChatSuggestions.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Lists/UIListBox.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/UIBasicCtrl.h, Source/UI/UIStaticItem.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/WindowManagerWindows.h, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
2026-11-02 14:09:20 +00:00
ragnarok-clanker
f2b0356b3d Decompile fn_20411 (PacketCodecStub)
Batch #8693 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_20411 PacketCodecStub: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, System4z, vinnyamancio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 20:17:41 +00:00
ragnarok-clanker
7d59dd5c78 Decompile 2 functions in Source/Network/Connection/Connection.cpp
Batch #7425 by gordaoprogramas: 0 byte-identical, 2 confirmed by peer review.

- fn_20410 ReleaseConnectionBlocks: logic confirmed by peer review
- fn_20412 FindCodeMarker: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:58:53 +00:00
ragnarok-clanker
cbaaa30f21 Decompile fn_21631 (CGameMode::ReceivePlayerNameUpdate)
Batch #7315 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21631 CGameMode::ReceivePlayerNameUpdate: logic confirmed by peer review

Peer-reviewed-by: meitogi, gordaoprogramas, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:32:22 +00:00
ragnarok-clanker
74499f1b99 Decompile fn_21633 (CGameMode::ReceiveActorNameTitle)
Batch #7028 by Bielhp: 0 byte-identical, 1 confirmed by peer review.

- fn_21633 CGameMode::ReceiveActorNameTitle: logic confirmed by peer review

Peer-reviewed-by: Lumen, Snow, Landruca
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 03:28:08 +00:00
ragnarok-clanker
c5a687e68c Decompile 2 functions in Source/Contents/NavigationRequest.cpp, Source/Contents/NavigationManager.h, ...
Batch #6697 by eAthena: 1 byte-identical, 1 confirmed by peer review.

- fn_19486 CNaviInfo::GetNameLength: byte-identical
- fn_20392 CRagConnection::GetPacketType: logic confirmed by peer review

Peer-reviewed-by: superintelligence, KWDev, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:41:48 +00:00
ragnarok-clanker
4a7e6ed37a Decompile 2 functions in Source/Client/Session.h, Source/Contents/Actors/GroundScope.cpp, ...
Batch #4909 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_24227 CSession::SendHomunculusAutoFeedOption: logic confirmed by peer review
- fn_24234 CSession::SendPetAutoFeedOption: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 07:07:04 +00:00
ragnarok-clanker
05be22bdcf Decompile 22 functions in Source/Client/Session.h, Source/Contents/Actors/GroundScope.cpp, ...
Batch #4990 by youko: 3 byte-identical, 19 confirmed by peer review.

- fn_24228 ReadMessengerMembers: logic confirmed by peer review
- fn_24229 ReadItemList: logic confirmed by peer review
- fn_24230 ReadItemArray: logic confirmed by peer review
- fn_24232 CSession::SetUnknown5BC0: logic confirmed by peer review
- fn_24236 MessengerMember::Deserialize: logic confirmed by peer review
- fn_24247 ClientItemLists::SetItems1750: logic confirmed by peer review
- fn_24249 AppendBytes: logic confirmed by peer review
- fn_24258 CMsgEffect::~CMsgEffect: logic confirmed by peer review
- fn_24259 CSkill::~CSkill: logic confirmed by peer review
- fn_24267 CGroundScope::SkillScopeType: logic confirmed by peer review
- fn_24268 CSkill::GetTrapModelName: logic confirmed by peer review
- fn_24269 CSkill::ReleaseModel: logic confirmed by peer review
- fn_24270 CMsgEffect::UsesMsgEffect: logic confirmed by peer review
- fn_24275 CGraffiSkill::ReleaseTexture: byte-identical
- fn_24277 CArrowEffect::Reset: logic confirmed by peer review
- fn_24278 CEffectMaker::Reset: byte-identical
- fn_24279 CGraffiSkill::BuildTexture: logic confirmed by peer review
- fn_24280 CArrowEffect::OnProcess: logic confirmed by peer review
- fn_24281 CDummyEffectLauncher::OnProcess: logic confirmed by peer review
- fn_24282 CEffectMaker::OnProcess: logic confirmed by peer review
- fn_24283 CGraffiSkill::OnProcess: byte-identical
- fn_24285 CMandraAttackEffect::OnProcess: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Actors/GraffiSkill.cpp, Source/Contents/Effects/ArrowEffect.cpp, Source/Contents/Effects/DummyEffectLauncher.cpp, Source/Contents/Effects/MandraAttackEffect.cpp, Source/Contents/Effects/MsgEffect.cpp
2026-10-30 06:43:59 +00:00
ragnarok-clanker
427f369e30 Decompile 8 functions in Source/UI/Quest/UIRenewQuestUI.cpp, Source/UI/Quest/UIRenewQuestUI.h, ...
Batch #4151 by superintelligence: 7 byte-identical, 1 confirmed by peer review.

- fn_16605 CUIRenewQuestUI::OnCallback6: byte-identical
- fn_16606 CUIRenewQuestUI::OnCallback50: byte-identical
- fn_16607 CUIRenewQuestUI::OnCallback43: byte-identical
- fn_16608 CUIRenewQuestUI::OnCallback80: byte-identical
- fn_16609 CUIRenewQuestUI::OnCallback74: byte-identical
- fn_16611 CUIRenewQuestUI::OnCallback56: byte-identical
- fn_16614 CUIListBoxEx<RenewQuestUI::CUIQuestItem,unsigned long>::ClearData: byte-identical (annotation added to existing code)
- fn_16615 CUIRenewQuestUI::MatchesFilter: logic confirmed by peer review

Peer-reviewed-by: youko, zindokar
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 01:33:15 +00:00
ragnarok-clanker
bcad19503c Decompile fn_02795 (FindSubstring)
Batch #3573 by Lumen: 0 byte-identical, 1 confirmed by peer review.

- fn_02795 FindSubstring: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:49:37 +00:00
ragnarok-clanker
4843546129 Decompile fn_02832 (LowercaseWide)
Batch #2890 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_02832 LowercaseWide: logic confirmed by peer review

Peer-reviewed-by: willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:55:12 +00:00
ragnarok-clanker
ffe4146a12 Decompile fn_22267 (SendExecutableDigest)
Batch #2187 by ntrl: 0 byte-identical, 1 confirmed by peer review.

- fn_22267 SendExecutableDigest: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Network/ExecutableDigestPacket.cpp
2026-10-29 15:18:09 +00:00
ragnarok-clanker
0d85318063 Decompile fn_21367 (SendGameTick)
Batch #2182 by ntrl: 0 byte-identical, 1 confirmed by peer review.

- fn_21367 SendGameTick: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Network/GameTickPacket.cpp
2026-10-29 15:16:59 +00:00
ragnarok-clanker
bc7be6e928 Rename ConnectionBuffer -> CPacketQueue (DHXJ; methods GetData/GetSize/Init/InsertData/PeekData/RemoveData; file -> PacketQueue.{h,cpp}), CConnection::SetBlock, CEffectPrim::Prim3DParticleGravity. Pure rename, codegen unchanged (109/109 functions, byte-identical). 2026-10-29 13:22:00 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
9aea62bd9b Decompile 47 functions in Source/Client/ClientOptions.cpp, Source/Client/Session.h, ...
Batch #1675 by ragnarok-clanker: 2 byte-identical, 45 confirmed by peer review.

- fn_10839 UIButton::Slot25: logic confirmed by peer review
- fn_10852 UIButton::Slot31: logic confirmed by peer review
- fn_10868 UIButton::Slot27: logic confirmed by peer review
- fn_10930 UIStaticBitmap::SetBitmap: logic confirmed by peer review
- fn_10931 UIBitmapButton::SetBitmap: logic confirmed by peer review
- fn_11320 UIComboBoxEx2::Slot15: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review
- fn_11381 UIScrollBar::Paint: logic confirmed by peer review
- fn_11383 UIScrollBar_Navi::Paint: logic confirmed by peer review
- fn_11425 UIScrollBar::Slot25: logic confirmed by peer review
- fn_11440 UIScrollBar::Slot31: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review
- fn_11468 UIScrollBar::Slot27: logic confirmed by peer review
- fn_11471 UITextButton::Slot27: logic confirmed by peer review
- fn_11494 UITextButton::Slot33: logic confirmed by peer review
- fn_11779 UIFrameWnd::Slot25: logic confirmed by peer review
- fn_11781 UIFrameWnd::Slot31: logic confirmed by peer review
- fn_11786 UIFrameWnd::Slot27: logic confirmed by peer review
- fn_12610 CSession::GetOption: logic confirmed by peer review
- fn_12689 ActivateShortcut: logic confirmed by peer review
- fn_12711 ShortcutTooltip::Hover: logic confirmed by peer review
- fn_12724 ShortcutDetails::Open: logic confirmed by peer review (already on main)
- fn_12760 UIShortCutWnd::SendMsg: logic confirmed by peer review
- fn_17144 UIWindowMgr::RemoveOrder: logic confirmed by peer review
- fn_17158 UIWindowMgr::Capture: byte-identical
- fn_17180 UIWindowMgr::BringToFront: logic confirmed by peer review
- fn_17192 UIWindowMgr::IsOrderFixed: logic confirmed by peer review
- fn_17232 UIWindowMgr::ReleaseCapture: byte-identical
- fn_17255 UIWindowMgr::SetCapture: logic confirmed by peer review
- fn_20382 CConnection::CConnection: logic confirmed by peer review
- fn_20383 CRagConnection::CRagConnection: logic confirmed by peer review
- fn_20384 CConnection::~CConnection: logic confirmed by peer review (already on main)
- fn_20389 CConnection::Connect: logic confirmed by peer review
- fn_20390 CConnection::Close: logic confirmed by peer review
- fn_20409 GetRagConnection: logic confirmed by peer review
- fn_21406 AutomaticSkills::Complete: logic confirmed by peer review
- fn_03927 CCharacterLinkedUserDataMgr::CompleteLoad: logic confirmed by peer review
- fn_03933 CCharacterLinkedUserDataMgr::Save: logic confirmed by peer review
- fn_03937 CSession::SetOption: logic confirmed by peer review
- fn_11073 UIScrollBar::UIScrollBar: logic confirmed by peer review
- fn_11102 UIComboBoxEx2::~UIComboBoxEx2: logic confirmed by peer review (already on main)
- fn_09150 AutomaticSkills::DisableAll: logic confirmed by peer review
- fn_09153 AutomaticSkills::Use: logic confirmed by peer review
- fn_10689 UIBitmapButton::~UIBitmapButton: logic confirmed by peer review (already on main)
- fn_10795 UIBitmapButton::Paint: logic confirmed by peer review
- fn_10817 UIStaticBitmap::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:01:00 +00:00
ragnarok-clanker
6f3ef794d3 Decompile 2 functions in Source/Network/Packets/PacketLengths.cpp, Source/Network/Packets/PacketLengths.h
Batch #1603 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_18384 PacketLengths::~PacketLengths: logic confirmed by peer review
- fn_18385 PacketLengths::Register: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:43:09 +00:00
ragnarok-clanker
1ebead0e33 Decompile fn_21632 (CGameMode::ReceiveActorNameAll)
Batch #1591 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21632 CGameMode::ReceiveActorNameAll: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Network/ActorNamePacket.cpp
2026-10-28 19:42:41 +00:00
ragnarok-clanker
ac43540f18 Decompile fn_24219 (SendClientOption)
Batch #1572 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_24219 SendClientOption: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Network/ClientOptionPacket.cpp
2026-10-28 19:10:30 +00:00
ragnarok-clanker
25e5bacc00 Decompile fn_22268 (SendClientKeepalive)
Batch #1568 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_22268 SendClientKeepalive: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Network/ClientKeepalive.cpp
2026-10-28 19:10:27 +00:00
ragnarok-clanker
63b1377599 Decompile 5 functions in Source/Client/ReplayPacketRecorder.h, Source/Contents/Emblems/EmblemUpload.h, ...
Batch #1488 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18386 PacketLengths::IsRecorded: logic confirmed by peer review
- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18388 PacketLengths::Lookup: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
- fn_18171 ResourceFailures::Report: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 16:45:10 +00:00
ragnarok-clanker
f93ee1d6fb Decompile 2 functions in Source/Network/Connection/Connection.cpp
Batch #1302 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_20395 Nullsub435: byte-identical
- fn_20396 Nullsub436: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 08:35:12 +00:00
ragnarok-clanker
5bc5660a42 ♻️ refactor(replay): replaced magic packet IDs with named constants and added replay record options
(cherry picked from commit 22cea43ea370006c67a8f9628e0b709c35fce803)
2026-10-27 14:43:03 +00:00
ragnarok-clanker
bed005bc9d Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Network headers (ConnectionBuffer, CURLMgr, PacketLength
Batch #1058 by ragnarok-clanker: no function's compiled code changes; checked with 28 compiled unit(s), including every includer of Source/Network/Connection/ConnectionBuffer.h, Source/Network/Http/CURLMgr.h, Source/Network/Packets/PacketLengths.h.
2026-10-27 13:41:30 +00:00
ragnarok-clanker
ff15df90ad 📝 docs(annotations): marked inlined functions across modules 2026-10-27 10:42:13 +01:00
ragnarok-clanker
b7c7ea1461 Decompile 3 functions in Source/Network/TextEncoding.cpp, Source/Network/TextEncoding.h
Batch #852 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_18257 LowercaseText: logic confirmed by peer review
- fn_18258 DecodeText: logic confirmed by peer review
- fn_18265 EncodeText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 22:53:18 +00:00
ragnarok-clanker
1dccbfbae5 Maintenance: Annotate globals on their definitions only; drop annotations from header externs
Batch #904 by ragnarok-clanker: no function's compiled code changes; checked with 3 compiled unit(s), including every includer of Source/Contents/MessageTable.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemDataMgr.h, Source/Contents/Hotkeys/UserHotkeyMgr.h, Source/Contents/Messenger/WhisperBlockMgr.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/CharacterLinkedUserDataMgr.h, Source/Network/TextEncoding.h, Source/Network/Http/CURLMgr.h, Source/Render/Textures/Texture.h, Source/UI/Layout/SnapMgr.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIWindow.h, Source/Utility/Async/NMessageMgr.h.
2026-10-26 18:25:54 +00:00