Commit graph

53 commits

Author SHA1 Message Date
ragnarok-clanker
ca75e5f95f Decompile fn_02228 (CRendererDX9::DrawAuxiliaryQueue)
Batch #14655 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_02228 CRendererDX9::DrawAuxiliaryQueue: logic confirmed by peer review

Peer-reviewed-by: secret, codeplay, raiken
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 12:51:47 +00:00
ragnarok-clanker
0411594ce7 Decompile fn_02217 (CRendererDX9::ApplyFog)
Batch #14235 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_02217 CRendererDX9::ApplyFog: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 07:34:53 +00:00
ragnarok-clanker
9ba8de11f2 Decompile fn_01913 (DeviceOwnerDX9::CheckState)
Batch #14343 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_01913 DeviceOwnerDX9::CheckState: logic confirmed by peer review

Peer-reviewed-by: secret, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 07:28:23 +00:00
ragnarok-clanker
dc85d4ffa0 Decompile fn_02236 (CRendererDX9::SaveScreenshot)
Batch #14207 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_02236 CRendererDX9::SaveScreenshot: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:16:13 +00:00
ragnarok-clanker
a83e704028 Decompile fn_02485 (CTextureDX9::Lock)
Batch #13994 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_02485 CTextureDX9::Lock: logic confirmed by peer review

Peer-reviewed-by: Yommy, SapitoSucio, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 04:11:38 +00:00
ragnarok-clanker
e986fd06e3 Decompile 2 functions in Source/Render/DX9/TextureDX9.cpp
Batch #13897 by eAthena: 1 byte-identical, 1 confirmed by peer review.

- fn_02476 CTextureDX9::CTextureDX9: logic confirmed by peer review
- fn_02352 CreateTextureDX9: byte-identical

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 23:31:14 +00:00
ragnarok-clanker
e8b2f375ed Decompile 10 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Items/ItemInfo.cpp, ...
Batch #13444 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_23807 CSession::GetPetFood: byte-identical
- fn_23813 CSession::GetPetJobByEggItem: byte-identical
- fn_23816 CSession::GetPetString: byte-identical
- fn_20077 CRagEffect::LexDivina: byte-identical
- fn_06573 ITEM_INFO::Assign: byte-identical
- fn_07702 UIMessengerGroupWnd::DropMember: byte-identical
- fn_10118 UIRPData::~UIRPData: byte-identical
- fn_08276 CPlayerSkillBundle::RemoveExtra: byte-identical
- fn_08129 CRuneSystemMgr::GetGradeFailValue: byte-identical
- fn_02432 CSurfaceDX9::Resize: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 17:00:22 +00:00
ragnarok-clanker
57fdd53273 Decompile fn_02362 (CRenderSystemDX9::CreateSurfaceOrTexture)
Batch #13224 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_02362 CRenderSystemDX9::CreateSurfaceOrTexture: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 12:00:20 +00:00
ragnarok-clanker
fec919b88e Maintenance: Link-completeness fixes so the whole client links into one executable (all units in data/compile.json plus exe-only thir
Batch #13186 by ragnarok-clanker: forced by an admin (40 lower score(s), 206 changed function(s)); checked with 620 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h, Source/Client/Timer.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/ServiceOptions.h, Source/Contents/Skills/SkillTreeScript.h, Source/Render/DX9/D3DX9Runtime.h, Source/Resource/GifResource.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Cooldowns/CooldownOwner.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIReputeWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/EncryptedName.h.
2026-11-06 10:56:48 +00:00
ragnarok-clanker
daacec6d2f Decompile 10 functions in Source/Render/DX9/RendererDX9Operations.cpp, Source/Utility/Text/StringUtil.cpp, ...
Batch #13116 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_02239 CRendererDX9::SetLighting: byte-identical
- fn_02757 CountCharacters: byte-identical
- fn_03898 UIChangeMaterialWnd_List::ShiftSelectedIndex: byte-identical
- fn_04317 UIReputeWnd::SetPage: byte-identical
- fn_09718 CSnapMgr::MoveConnected: byte-identical
- fn_09918 UIRefining_Notice::Slot19: byte-identical
- fn_10838 UIBitmapTab::Slot25: byte-identical
- fn_17501 C3dActor::SetSpeed: byte-identical
- fn_18836 CParticle::SetQuad: byte-identical
- fn_19338 ReplayFileList::Select: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 05:24:06 +00:00
ragnarok-clanker
1731ecbb19 Decompile fn_02237 (CRendererDX9::SaveLogo)
Batch #12971 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_02237 CRendererDX9::SaveLogo: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 03:46:14 +00:00
ragnarok-clanker
ace21574e0 Decompile 25 functions in Source/Render/DX9/DeviceStateDX9.cpp, Source/Contents/Items/BarterMarketItemMgr.cpp, ...
Batch #12861 by KWDev: 25 byte-identical, 0 confirmed by peer review.

- fn_01999 DeviceStateDX9::SetFVF: byte-identical
- fn_03738 CBarterMarketItemMgr::GetAmountById: byte-identical
- fn_03765 CExpandedBarterMarketItemMgr::GetItemValueById: byte-identical
- fn_03768 CExpandedBarterMarketItemMgr::GetItemFactorById: byte-identical
- fn_03771 CExpandedBarterMarketItemMgr::GetValueById: byte-identical
- fn_04794 CSession::AddItem1784: byte-identical
- fn_08113 CTagData::UpdateActiveCount: byte-identical
- fn_08269 CPlayerSkillBundle::UpdatePending: byte-identical
- fn_08277 CPlayerSkillBundle::FindExtra: byte-identical
- fn_09851 UIMacroReporterWnd::Slot31: byte-identical
- fn_10062 UIRodexInboxWnd::RemoveInboxMail: byte-identical
- fn_11524 UIChatHisBox::Resize: byte-identical
- fn_16039 GameSettingsUI::CUIGroupSkin::Refresh: byte-identical
- fn_16979 UIWindow::FindUid: byte-identical
- fn_17144 UIWindowMgr::RemoveOrder: byte-identical
- fn_17165 UIWindowMgr::FindSnapExcludedWindow: byte-identical
- fn_17414 CWebBrowser::Normalize: byte-identical
- fn_18045 GuildInfo::UpdateMemberStatus: byte-identical
- fn_18046 GuildInfo::SetMemberOnline: byte-identical
- fn_18309 TELEXInputMode::IsModifierKey: byte-identical
- fn_21008 CRenderObject::Face: byte-identical
- fn_23740 CSession::UpdateAdditionalSkill: byte-identical
- fn_23741 CSession::UpdateHomunSkill: byte-identical
- fn_23742 CSession::UpdateMercSkill: byte-identical
- fn_23777 CSession::FindUnknown0778: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 02:07:05 +00:00
ragnarok-clanker
4d47140980 Decompile fn_02437 (?BitsPerPixel@?A0x6d8cd988@@YAHW4_D3DFORMAT@@@Z)
Batch #12710 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_02437 ?BitsPerPixel@?A0x6d8cd988@@YAHW4_D3DFORMAT@@@Z: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 00:06:55 +00:00
ragnarok-clanker
cb793e55f6 Decompile 7 functions in Source/Render/DX9/TextureDX9.cpp
Batch #12668 by cremane: 7 byte-identical, 0 confirmed by peer review.

- fn_02474 CTextureDX9::CTextureDX9: byte-identical (already on main)
- fn_02478 CTextureDX9::Fill: byte-identical (already on main)
- fn_02479 CTextureDX9::CopyTexture: byte-identical (already on main)
- fn_02482 CTextureDX9::Filter: byte-identical
- fn_02486 CTextureDX9::ReleaseDC: byte-identical (already on main)
- fn_02489 CTextureDX9::Unlock: byte-identical (already on main)
- fn_02492 CTextureDX9::Update: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-05 23:39:28 +00:00
ragnarok-clanker
c1f673a6bd Decompile fn_02220 (CRendererDX9::DrawAuxiliaryPrimitive)
Batch #12254 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_02220 CRendererDX9::DrawAuxiliaryPrimitive: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:27:57 +00:00
ragnarok-clanker
0631a3548c Decompile 2 functions in Source/Render/DX9/RendererFogDX9.cpp, Source/Render/DX9/RendererDX9.cpp, ...
Batch #12214 by cremane: 1 byte-identical, 1 confirmed by peer review.

- fn_02217 CRendererDX9::ApplyFog: logic confirmed by peer review
- fn_02230 CRendererDX9::SetFog: byte-identical

Peer-reviewed-by: Yommy, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:48:23 +00:00
ragnarok-clanker
b0e3c33465 Decompile 3 functions in Source/Render/DX9/RendererDX9Operations.cpp
Batch #11665 by cremane: 3 byte-identical, 0 confirmed by peer review.

- fn_02214 CRendererDX9::ClearDepth: byte-identical
- fn_02218 CRendererDX9::DrawPrimitive: byte-identical
- fn_02219 CRendererDX9::DrawLightmappedPrimitive: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 04:13:00 +00:00
ragnarok-clanker
b70c0a9dc5 Decompile fn_02224 (CRendererDX9::DrawAlphaQueues)
Batch #11661 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_02224 CRendererDX9::DrawAlphaQueues: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 04:11:40 +00:00
ragnarok-clanker
95a9e97915 Decompile fn_01913 (DeviceOwnerDX9::CheckState)
Batch #11628 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_01913 DeviceOwnerDX9::CheckState: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:58:30 +00:00
ragnarok-clanker
61b3e2ea52 Confirm fn_01914 (DeviceOwnerDX9::CreateDevice)
Batch #11614 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.

- fn_01914 DeviceOwnerDX9::CreateDevice: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:54:39 +00:00
ragnarok-clanker
3170364197 Decompile 3 functions in Source/Render/BlendColor.cpp, Source/Render/BlendColor.h, ...
Batch #11581 by cremane: 1 byte-identical, 2 confirmed by peer review.

- fn_02095 CRenderer::BlendColor: logic confirmed by peer review
- fn_02078 CRendererDX7::ClearWorld: logic confirmed by peer review
- fn_02215 CRendererDX9::ClearWorld: byte-identical

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:41:18 +00:00
ragnarok-clanker
117757ab66 Decompile 4 functions in Source/Render/DX9/DeviceStateDX9.cpp, Source/Render/DX9/DeviceOwnerDX9.cpp
Batch #11443 by Yommy: 3 byte-identical, 1 confirmed by peer review.

- fn_01919 DeviceOwnerDX9::SetInitialStates: byte-identical
- fn_01992 ScopedDeviceStateDX9::ScopedDeviceStateDX9: logic confirmed by peer review
- fn_01994 DeviceStateDX9::End: byte-identical
- fn_01997 DeviceStateDX9::Initialize: byte-identical

Peer-reviewed-by: KWDev, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:04:24 +00:00
ragnarok-clanker
619adb3a19 Decompile fn_02362 (CRenderSystemDX9::CreateSurfaceOrTexture)
Batch #11491 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_02362 CRenderSystemDX9::CreateSurfaceOrTexture: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:48:53 +00:00
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
a238ac7b9e Decompile fn_01993 (DeviceStateDX9::Begin)
Batch #11161 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_01993 DeviceStateDX9::Begin: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-04 20:27:48 +00:00
ragnarok-clanker
68c8d0dc48 Decompile 4 functions in Source/Render/DX9/BackBufferDX9.cpp, Source/Render/DX9/RendererDX9.cpp, ...
Batch #10843 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_45506 DeviceOwnerDX9::CaptureBackBuffer: byte-identical (annotation added to existing code)
- fn_45507 DeviceOwnerDX9::RestoreBackBuffer: byte-identical (annotation added to existing code)
- fn_45508 ReleaseApplicationCursor: logic confirmed by peer review
- fn_06367 ApplyServiceOptionCursorClip: logic confirmed by peer review

Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 18:23:10 +00:00
ragnarok-clanker
66d7d76302 Maintenance: Owner-approved acceptance of KWDev batch 10495 (identical payload). fn_45500 DeviceOwnerDX9::UpdateMipmapFiltering 0x54C
Batch #10498 by ragnarok-clanker: forced by an admin (0 lower score(s), 3 changed function(s)); checked with 2 compiled unit(s).
2026-11-04 10:34:53 +00:00
ragnarok-clanker
1b4f4aa498 Decompile fn_02366 (CRenderSystemDX9::RestoreDisplayMode)
Batch #10496 by KWDev: 1 byte-identical, 0 confirmed by peer review.

- fn_02366 CRenderSystemDX9::RestoreDisplayMode: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-04 10:28:27 +00:00
ragnarok-clanker
7d8faccaa9 Decompile 17 functions in Source/Render/DX9/TextureDX9.cpp
Batch #10467 by KWDev: 0 byte-identical, 17 confirmed by peer review.

- fn_02474 CTextureDX9::CTextureDX9: logic confirmed by peer review (already on main)
- fn_02475 CTextureDX9::CTextureDX9: logic confirmed by peer review (already on main)
- fn_02476 CTextureDX9::CTextureDX9: logic confirmed by peer review
- fn_02478 CTextureDX9::Fill: logic confirmed by peer review (already on main)
- fn_02479 CTextureDX9::CopyTexture: logic confirmed by peer review (already on main)
- fn_02480 CTextureDX9::Create: logic confirmed by peer review
- fn_02481 CTextureDX9::Resize: logic confirmed by peer review (already on main)
- fn_02482 CTextureDX9::Filter: logic confirmed by peer review (already on main)
- fn_02483 CTextureDX9::GetDC: logic confirmed by peer review (already on main)
- fn_02484 CTextureDX9::ClearSurface: logic confirmed by peer review (already on main)
- fn_02485 CTextureDX9::Lock: logic confirmed by peer review (already on main)
- fn_02486 CTextureDX9::ReleaseDC: logic confirmed by peer review (already on main)
- fn_02489 CTextureDX9::Unlock: logic confirmed by peer review (already on main)
- fn_02490 CTextureDX9::UploadSurface: logic confirmed by peer review
- fn_02491 CTextureDX9::Upload: logic confirmed by peer review
- fn_02492 CTextureDX9::Update: logic confirmed by peer review (already on main)
- fn_02493 CTextureDX9::UploadSprite: logic confirmed by peer review (already on main)

Peer-reviewed-by: ragnarok-clanker, Yommy
Reviewed-by: ragnarok-clanker
2026-11-04 09:41:32 +00:00
ragnarok-clanker
e7f4eb710f Maintenance: [forced, user-approved] R10b: remove invented RendererPresentation, RendererPresentationDX7 and TextureDX7Context. Evide
Batch #10266 by ragnarok-clanker: forced by an admin (1 lower score(s), 12 changed function(s)); checked with 32 compiled unit(s), including every includer of Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/TextureAllocationDX7.h, Source/Render/DX7/TextureDX7.h, Source/Render/DX9/RendererDX9.h, Source/Render/RendererDX7.h, Source/Render/DX7/RendererPresentationDX7.h, Source/Render/DX9/RendererPresentation.h.
Deletes: Source/Render/DX7/RendererPresentationDX7.h, Source/Render/DX9/RendererPresentation.h
2026-11-03 14:14:42 +00:00
ragnarok-clanker
643cf8e993 Maintenance: [forced, user-approved] R10a: remove the invented DX7 view structs RendererDX7Operations {owner, device}, QueuedDrawingD
Batch #10263 by ragnarok-clanker: forced by an admin (1 lower score(s), 16 changed function(s)); checked with 333 compiled unit(s), including every includer of Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/QueuedDrawingDX7.h, Source/Render/DX9/RendererFogDX9.h, Source/Render/RendererDX7.h, Source/Render/DX7/RendererDX7Operations.h, Source/Render/DX7/TextureBindingDX7.h.
Deletes: Source/Render/DX7/RendererDX7Operations.h, Source/Render/DX7/TextureBindingDX7.h
2026-11-03 14:00:14 +00:00
ragnarok-clanker
15ee30e2aa Maintenance: [forced, user-approved] R9: remove the invented TextureDX9Context, SurfaceDX9Context and RendererDX9Operations, plus the
Batch #10258 by ragnarok-clanker: forced by an admin (9 lower score(s), 44 changed function(s)); checked with 318 compiled unit(s), including every includer of Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/DX9/RenderSystemDX9.h, Source/Render/DX9/RendererDX9.h, Source/Render/DX9/RendererFogDX9.h, Source/Render/DX9/SurfaceDX9.h, Source/Render/DX9/TextureDX9.h, Source/Render/Renderer.h, Source/Render/RendererDX7.h, Source/Render/Textures/SpriteAtlas.h, Source/Render/DX9/RendererDX9Operations.h.
Deletes: Source/Render/DX9/RendererDX9Operations.h
2026-11-03 13:19:27 +00:00
ragnarok-clanker
d4568519de Maintenance: [forced, user-approved] R7b+R7c (resubmit of returned 10244, rebased on 947ce989): remove the invented FogConfiguration,
Batch #10247 by ragnarok-clanker: forced by an admin (3 lower score(s), 26 changed function(s)); checked with 330 compiled unit(s), including every includer of Source/Render/DX7/RendererFogDX7.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/DX9/RenderSystemDX9.h, Source/Render/DX9/RendererDX9.h, Source/Render/DX9/RendererDX9Operations.h, Source/Render/DX9/RendererFogDX9.h, Source/Render/DX9/RendererPresentation.h, Source/Render/DeviceContext/DCSurface.h, Source/Render/Projection/RendererViewport.h, Source/Render/RenderAdapter.h, Source/Render/SpriteGeometry.h, Source/Render/TextureQuad.h, Source/Render/FogConfiguration.h.
Deletes: Source/Render/FogConfiguration.h
2026-11-03 12:07:29 +00:00
ragnarok-clanker
b2e04b8f13 Maintenance: [forced, user-approved] R7a: remove the invented D3DX9Runtime (LoadLibraryA D3DX9_43.dll + GetProcAddress table) and its
Batch #10241 by ragnarok-clanker: forced by an admin (1 lower score(s), 23 changed function(s)); checked with 303 compiled unit(s), including every includer of Source/Render/DX9/D3DX9Runtime.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/DX9/RenderSystemDX9.h, Source/Render/DX9/RendererDX9.h, Source/Render/DX9/RendererFogDX9.h, Source/Render/DX9/TextureDX9.h.
2026-11-03 11:32:34 +00:00
ragnarok-clanker
a9fa933652 Maintenance: [forced, user-approved] R5: remove the null EffectRetirement reference (GameMode.cpp:2776, last nullptr-reference argume
Batch #10238 by ragnarok-clanker: forced by an admin (0 lower score(s), 15 changed function(s)); checked with 383 compiled unit(s), including every includer of Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectLists.h, Source/Render/DX9/RenderSystemDX9.h, Source/Render/DX9/RendererDX9.h, Source/Render/Renderer.h, Source/Render/DX9/RendererFrameDX9.h.
Deletes: Source/Render/DX9/RendererFrameDX9.h
2026-11-03 10:56:12 +00:00
ragnarok-clanker
918b893022 Decompile 2 functions in Source/Contents/World/WorldActors.cpp, Source/Contents/World/World.h, ...
Batch #8203 by pedrao: 0 byte-identical, 2 confirmed by peer review.

- fn_17672 CWorld::CreatePlayer: logic confirmed by peer review
- fn_02352 CreateTextureDX9: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 15:11:25 +00:00
ragnarok-clanker
f4248c42f2 Decompile fn_02293 (RenderSystemHolder::Initialize)
Batch #4256 by Millenium: 0 byte-identical, 1 confirmed by peer review.

- fn_02293 RenderSystemHolder::Initialize: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 02:18:51 +00:00
ragnarok-clanker
daee90c73d Decompile fn_02213 (DeviceOwnerDX9::SaveState)
Batch #2880 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_02213 DeviceOwnerDX9::SaveState: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 20:01:06 +00:00
ragnarok-clanker
1130ab61e1 Decompile fn_01917 (DeviceOwnerDX9::RestoreDisplayMode)
Batch #2848 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_01917 DeviceOwnerDX9::RestoreDisplayMode: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 19:34:29 +00:00
ragnarok-clanker
87bb32cef8 Decompile 48 functions in Source/Client/ModeFade.cpp, Source/Client/ModeFade.h, ...
Batch #2457 by ragnarok-clanker: 0 byte-identical, 48 confirmed by peer review.

- fn_00152 TextureCache::TextureCache: logic confirmed by peer review
- fn_01952 DrawAlphaRectangle: logic confirmed by peer review
- fn_01953 DrawBlendedRectangle: logic confirmed by peer review
- fn_01954 DrawTexturedRectangle: logic confirmed by peer review
- fn_01955 DrawTextureRegion: logic confirmed by peer review
- fn_02237 CRendererDX9::SaveLogo: logic confirmed by peer review
- fn_02353 CRenderSystemDX9::CRenderSystemDX9: logic confirmed by peer review
- fn_02447 TextureCache::~TextureCache: logic confirmed by peer review (already on main)
- fn_02449 TextureCache::Upload: logic confirmed by peer review
- fn_02451 TextureCache::Clear: logic confirmed by peer review (already on main)
- fn_02452 TextureCache::Remove: logic confirmed by peer review (already on main)
- fn_02453 TextureCache::Default: logic confirmed by peer review
- fn_02454 TextureCache::Load: logic confirmed by peer review (already on main)
- fn_02455 TextureCache::Create: logic confirmed by peer review
- fn_02456 TextureCache::Reload: logic confirmed by peer review
- fn_02457 TextureCache::ClearUnused: logic confirmed by peer review
- fn_07897 EZeffectClip::Texture: logic confirmed by peer review
- fn_07898 EZeffectClip::Texture: logic confirmed by peer review
- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review
- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review
- fn_08010 C3dGrannyModelRes::CreateTexture: logic confirmed by peer review
- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review
- fn_09166 BinkMovies::Update: logic confirmed by peer review
- fn_10122 UIRPData::DrawNamed: logic confirmed by peer review
- fn_12091 UIWhisperWnd::Slot43: logic confirmed by peer review
- fn_17556 GroundGeometry::Build: logic confirmed by peer review
- fn_17565 GroundGeometry::BuildLightmaps: logic confirmed by peer review
- fn_17581 GroundWaterState::Update: logic confirmed by peer review
- fn_17587 GroundGeometry::DrawGrid: logic confirmed by peer review
- fn_17599 GroundWaterState::Import: logic confirmed by peer review
- fn_17842 ModeFade::Draw: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_20019 CRagEffect::Blessing: logic confirmed by peer review
- fn_20023 CRagEffect::Bottom: logic confirmed by peer review
- fn_20024 CRagEffect::BowlingBash: logic confirmed by peer review
- fn_20025 CRagEffect::CartRevolution: logic confirmed by peer review
- fn_20042 CRagEffect::Entry: logic confirmed by peer review
- fn_20054 CRagEffect::FrostDiver: logic confirmed by peer review
- fn_20058 CRagEffect::GrimTooth: logic confirmed by peer review
- fn_20066 CRagEffect::Hit4: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20105 CRagEffect::SonicBlowHit: logic confirmed by peer review
- fn_20109 CRagEffect::SprayPond: logic confirmed by peer review
- fn_20124 CRagEffect::Yufitel: logic confirmed by peer review
- fn_20132 CRagEffect::AirTexture: logic confirmed by peer review
- fn_20133 CRagEffect::AttackEnergy2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 18:23:21 +00:00
ragnarok-clanker
7dae59d785 Decompile fn_02241 (RendererDX9Operations::SetTextureMode)
Batch #1632 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_02241 RendererDX9Operations::SetTextureMode: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:46:29 +00:00
ragnarok-clanker
393775bbf0 Decompile fn_01912 (DeviceOwnerDX9::CanAutoGenerateMipmaps)
Batch #1627 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_01912 DeviceOwnerDX9::CanAutoGenerateMipmaps: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Render/DeviceCapabilitiesDX9.cpp
2026-10-28 19:46:09 +00:00
ragnarok-clanker
0f0bb27176 Maintenance: Remove misplaced fn_02429 annotation: 0x5708F0 is CSurfaceDX9's scalar deleting destructor (compiler generated); fn_0242
Batch #1477 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s).
2026-10-28 15:34:08 +00:00
ragnarok-clanker
6edd69f2e2 Decompile fn_02429 (CSurfaceDX9::~CSurfaceDX9)
Batch #1457 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02429 CSurfaceDX9::~CSurfaceDX9: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
2026-10-28 13:29:16 +00:00
ragnarok-clanker
899049e990 Decompile 14 functions in Source/Render/RendererDX7.cpp, Source/Render/RendererDX7.h, ...
Batch #1427 by Yommy: 0 byte-identical, 14 confirmed by peer review.

- fn_02113 CRendererDX7::SetClearColor: logic confirmed by peer review (annotation added to existing code)
- fn_02117 CRendererDX7::SetTextureFormat: logic confirmed by peer review (annotation added to existing code)
- fn_02487 ?Color4444@?A0xa800f118@@YAGI@Z: logic confirmed by peer review (annotation added to existing code)
- fn_02488 ?Color565@?A0xa800f118@@YAGI@Z: logic confirmed by peer review (annotation added to existing code)
- fn_17486 RenderVertexPool::Block::Append: logic confirmed by peer review (annotation added to existing code)
- fn_01953 DrawBlendedRectangle: logic confirmed by peer review (annotation added to existing code)
- fn_01954 DrawTexturedRectangle: logic confirmed by peer review (annotation added to existing code)
- fn_01955 DrawTextureRegion: logic confirmed by peer review (annotation added to existing code)
- fn_01944 DrawScreenQuad: logic confirmed by peer review (annotation added to existing code)
- fn_01951 DrawScreenLine: logic confirmed by peer review (annotation added to existing code)
- fn_02101 RhwToDepth: logic confirmed by peer review (annotation added to existing code)
- fn_10121 UIRPData::DrawStretched: logic confirmed by peer review (annotation added to existing code)
- fn_10122 UIRPData::DrawNamed: logic confirmed by peer review (annotation added to existing code)
- fn_10123 UIRPData::SetSolid: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
2026-10-28 13:16:54 +00:00
ragnarok-clanker
471f0c1fe2 Decompile fn_02115 (CRendererDX7::SetCamera)
Batch #1430 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_02115 CRendererDX7::SetCamera: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Render/RendererDX7.cpp, Source/Render/ScreenRectangle.cpp, Source/Render/ScreenGeometry.cpp, Source/Render/TextureQuad.cpp, Source/Render/UIRPDataDrawing.cpp
2026-10-28 12:45:51 +00:00
ragnarok-clanker
cbbf28e4de Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Render headers (DX7, DX9, Primitives, Text, Textures)
Batch #1060 by ragnarok-clanker: no function's compiled code changes; checked with 188 compiled unit(s), including every includer of Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/DirectDrawEnumeration.h, Source/Render/DX7/RenderSystemDX7.h, Source/Render/DX7/RendererFogDX7.h, Source/Render/DX7/SurfaceDX7.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/DX9/DeviceStateDX9.h, Source/Render/DX9/RendererFogDX9.h, Source/Render/DeviceContext/DCSurface.h, Source/Render/DisplayMode.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderCommandPool.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Primitives/RenderPrimitivePool.h, Source/Render/Primitives/RenderQueues.h, Source/Render/Primitives/RenderVertexPool.h, Source/Render/Projection/RendererViewport.h, Source/Render/RenderAdapter.h, Source/Render/Renderer.h, Source/Render/RendererBackBuffer.h, Source/Render/Text/TextContext.h, Source/Render/Textures/BitmapTextureCache.h, Source/Render/Textures/SpriteAtlas.h, Source/Render/Textures/Surface.h.
2026-10-27 13:48:11 +00:00
ragnarok-clanker
ff15df90ad 📝 docs(annotations): marked inlined functions across modules 2026-10-27 10:42:13 +01:00
ragnarok-clanker
add868efe7 ♻️ refactor(source): removed unused includes and add INLINE comments 2026-10-27 10:09:10 +01:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00