Batch #10453 by Toshiro: 0 byte-identical, 1 confirmed by peer review.
- fn_17207 UIWindowMgr::sub_A978D0: logic confirmed by peer review
Peer-reviewed-by: secret, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10444 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_21595 CGameMode::sub_D08910: logic confirmed by peer review
Peer-reviewed-by: secret, willerthal, KWDev, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10454 by KWDev: 0 byte-identical, 1 confirmed by peer review.
- fn_45489 UIItemStoreSubWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: secret, Toshiro, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10452 by KWDev: 0 byte-identical, 3 confirmed by peer review.
- fn_45491 CUISelectPackageItemBox::Slot15: logic confirmed by peer review
- fn_45493 CUISelectPackageItemBox::OnClose: logic confirmed by peer review
- fn_45494 CUISelectPackageItemBox::OnClickClose: logic confirmed by peer review
Peer-reviewed-by: secret, Toshiro, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10446 by KWDev: 0 byte-identical, 1 confirmed by peer review.
- fn_45486 UIListBoxNavi::AddLine: logic confirmed by peer review
Peer-reviewed-by: vinnyamancio, Toshiro, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10442 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_22297 CLoginMode::Slot7: logic confirmed by peer review
Peer-reviewed-by: willerthal, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10434 by ragnarok-clanker: no function's compiled code changes; checked with 266 compiled unit(s), including every includer of Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Window/UISeekPartyWnd.h.
Batch #10430 by ragnarok-clanker: no function's compiled code changes; checked with 530 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/RenderObject.h, Source/Contents/ClientState.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Messenger/MessengerMember.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/UIBartermarketWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindowMgr.h.
Batch #10425 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_12939 UIBalloonOpenBtn::SendMsg: logic confirmed by peer review
Peer-reviewed-by: gordaoprogramas, cremane, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10414 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10403 by ragnarok-clanker: no function's compiled code changes; checked with 508 compiled unit(s), including every includer of Source/UI/Window/UIWindowMgr.h.
Batch #10400 by ragnarok-clanker: no function's compiled code changes; checked with 13 compiled unit(s), including every includer of Source/UI/Window/UINavigationWnd.h.
Batch #10386 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.
- fn_12750 UINewChatWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: dori, cremane, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Chat/UINewChatWnd.cpp
Merged directly by the admin, bypassing peer review, because part of the
original function was overwritten by the client's protector and can never
match. Task 16009 is marked done on purpose; do not resubmit it.
- Jump table 0xAD29E4: modes 0/1 go to 0xAD1E58, now "jmp 0x027AB0FE" into
an empty protector stub. Bytes 0xAD1E58..0xAD237D are garbage.
- The rest of case 0/1 survives from 0xAD237E (g_serviceFlag07 = 29,
strstr(g_launchServerName, "QmSakray"), key/address pair, StringFormat
into g_serviceAddress, then the admin/monster-job tail); ported as is.
- Live WinDbg run (servertype=primary): 0xAD1C90 is never called; the
protector loader in .data6 (sub_3DE8027) replaces it at runtime.
- Based on attempt 57915 (batch 10359), with g_session.unknown_58FA replaced
by g_launchServerName (same address, 0x1737F32). Key/string decryption
verified against the binary. td check --includers: no errors.
Batch #10391 by ragnarok-clanker: no function's compiled code changes; checked with 8 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10377 by dori: 0 byte-identical, 2 confirmed by peer review.
- fn_17221 UIWindowMgr::sub_AA35F0: logic confirmed by peer review
- fn_12582 UINewChatWnd::ToggleInput: logic confirmed by peer review (already on main)
Peer-reviewed-by: gordaoprogramas, Toshiro, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10388 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_17216 ToggleGameSettingsTab4: logic confirmed by peer review
Peer-reviewed-by: gordaoprogramas, Toshiro, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10382 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_21112 CGameActor::SendMsg: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10384 by ragnarok-clanker: no function's compiled code changes; checked with 3 compiled unit(s), including every includer of Source/UI/Shop/UIMerchantItemMyShopWnd.h.
Batch #10367 by ragnarok-clanker: no function's compiled code changes; checked with 507 compiled unit(s), including every includer of Source/UI/Edit/UIEditCtrl.h, Source/UI/Window/UIWindowMgr.h.
Batch #10366 by Lumen: 0 byte-identical, 1 confirmed by peer review.
- fn_11805 UILoginWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: youko, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10351 by kyoshi: 0 byte-identical, 2 confirmed by peer review.
- fn_12376 UISecondPasswordEditWnd::SendMsg: logic confirmed by peer review
- fn_12377 UISecondPasswordInputWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: willerthal, Lumen, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10361 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_12644 UINewChatWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: willerthal, Lumen, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10365 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_12732 UINewChatWnd::ApplyInputLayout: logic confirmed by peer review
Peer-reviewed-by: willerthal, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10363 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_12346 UIItemCollectionWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10362 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_12208 UInCashWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10360 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_12171 UIEquipWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10354 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_12330 UIChatRoomMakeWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10353 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_12329 UIChatRoomChangeWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10352 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_13427 UIMerchantItemMyShopWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10349 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_13433 UIMerchantShopMakeWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Lumen, kyoshi, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10346 by KWDev: 0 byte-identical, 1 confirmed by peer review.
- fn_13316 UIItemStoreWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: ntrl, youko, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10327 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_13435 UISkillListWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, tester, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10313 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_13324 UIMerchantShopMakeWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: tester, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10316 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.
- fn_12391 UInCashWnd::SendMsg: logic confirmed by peer review
- fn_12161 UIChatRoomMakeWnd::Slot15: logic confirmed by peer review
- fn_12191 UIPartySettingWnd::Slot15: logic confirmed by peer review
- fn_12204 UITipboxWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: tester, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10280 by ragnarok-clanker: forced by an admin (0 lower score(s), 115 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/ClientItemLists.h.
Deletes: Source/Contents/ClientItemLists.h
Batch #10279 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
Batch #10278 by ragnarok-clanker: forced by an admin (0 lower score(s), 68 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
Batch #10275 by ragnarok-clanker: forced by an admin (1 lower score(s), 1 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
Batch #10274 by ragnarok-clanker: forced by an admin (3 lower score(s), 9 changed function(s)); checked with 348 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/UI/Shortcuts/ShortcutCooldowns.h.
Batch #10271 by ragnarok-clanker: forced by an admin (3 lower score(s), 12 changed function(s)); checked with 8 compiled unit(s), including every includer of Source/UI/Shortcuts/UIShortCutWnd.h, Source/UI/Shortcuts/ShortcutControls.h.
Deletes: Source/UI/Shortcuts/ShortcutControls.h
Batch #10269 by ragnarok-clanker: forced by an admin (2 lower score(s), 6 changed function(s)); checked with 102 compiled unit(s), including every includer of Source/Script/LuaScript.h.
Batch #10268 by ragnarok-clanker: forced by an admin (17 lower score(s), 85 changed function(s)); checked with 222 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Contents/Camera/CameraFrame.h, Source/Contents/Ground/TerrainHeight.h, Source/Contents/World/World.h, Source/Resource/World/TerrainResource.h.
Batch #10267 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 1 compiled unit(s), including every includer of Source/UI/Shortcuts/ShortcutPainting.h.
Deletes: Source/UI/Shortcuts/ShortcutPainting.h
Batch #10261 by ragnarok-clanker: forced by an admin (1 lower score(s), 9 changed function(s)); checked with 57 compiled unit(s), including every includer of Source/Client/Replay.h, Source/Client/ReplayPacketRecorder.h.
Deletes: Source/Client/ReplayPacketRecorder.h
