Batch #12260 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_13667 NormalItemSlotWindow::IsValid: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11896 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_03696 CLoadPartyInfoAsyncWork::Complete: logic confirmed by peer review
Peer-reviewed-by: KWDev, dori, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11939 by Yommy: 0 byte-identical, 3 confirmed by peer review.
- fn_23820 ?HotkeyIndex@?A0x4a49dd05@@YAHAAVLuaScript@@HH@Z: logic confirmed by peer review
- fn_04061 CUserHotkeyMgr::Capture: logic confirmed by peer review
- fn_04060 CUserHotkeyMgr::HasUserAssignments: logic confirmed by peer review
Peer-reviewed-by: KWDev, dori, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12347 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_19768 CEffectPrim::InitSegment: logic confirmed by peer review
Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12490 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_18348 ?AddNeededSkill@?A0xf8bc354c@@YAHPAUlua_State@@@Z: logic confirmed by peer review
Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12484 by cremane: 0 byte-identical, 5 confirmed by peer review.
- fn_17921 WorldViewSpatial::ClassifyAxisAligned: logic confirmed by peer review
- fn_17922 WorldViewSpatial::ClassifyOriented: logic confirmed by peer review
- fn_17930 CView::Render: logic confirmed by peer review
- fn_17923 WorldViewSpatial::CollectNode: logic confirmed by peer review
- fn_17919 WorldViewSpatial::Collect: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12467 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_04357 CWorldViewWorld::MapAt: logic confirmed by peer review
Peer-reviewed-by: Yommy, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12475 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_17920 CView::Refresh: logic confirmed by peer review
Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12419 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_06593 ITEM_INFO::Slots: logic confirmed by peer review
- fn_06581 ITEM_INFO::DisplayName: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12472 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_17926 CameraState::Smooth: logic confirmed by peer review
Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12466 by cremane: 2 byte-identical, 1 confirmed by peer review.
- fn_18790 HasEffectScript: logic confirmed by peer review
- fn_18795 ReadEffectScriptV1: byte-identical
- fn_18796 ReadEffectScriptV2: byte-identical
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12291 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_19185 CSphereWind2Effect::Slot03: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12459 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_19985 CEffectPrim::RenderCurvedFanTrail: logic confirmed by peer review
Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10622 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_03700 CLoadPartyListAsyncWork::Bind: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, KWDev, Tanke, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12397 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_19616 CNavigationManager::LoadReplayState: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12450 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_03657 CAdventurerAgencyMgr::RequestChangeMaster: logic confirmed by peer review
Peer-reviewed-by: Yommy, KWDev, Toshiro, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12444 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_07838 C3dAttr::Height: logic confirmed by peer review
Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12355 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review
- fn_19574 CNavigationManager::ClearRouteNodes: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12436 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_07710 UIMessengerGroupWnd::Slot31: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12351 by unna: 0 byte-identical, 2 confirmed by peer review.
- fn_23341 CSession::RemoveItem1740: logic confirmed by peer review
- fn_23351 CSession::RemoveItem1738: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12435 by Yommy: 0 byte-identical, 3 confirmed by peer review.
- fn_17685 CWorld::OnExitFrame: logic confirmed by peer review
- fn_17698 CWorld::SendObjectMessage: logic confirmed by peer review
- fn_21303 CGameMode::SpawnCashEmotion: logic confirmed by peer review
Peer-reviewed-by: KWDev, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12431 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_02928 CCashEmotionMgr::~CCashEmotionMgr: logic confirmed by peer review
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12423 by Yommy: 0 byte-identical, 2 confirmed by peer review.
- fn_03465 CAccountLinkedUserDataMgr::CompleteLoad: logic confirmed by peer review
- fn_03468 CAccountLinkedUserDataMgr::Load: logic confirmed by peer review
Peer-reviewed-by: KWDev, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12420 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_17932 CameraShake::Start: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12417 by cremane: 0 byte-identical, 5 confirmed by peer review.
- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
- fn_03658 CAdventurerAgencyMgr::CompleteChangeMaster: logic confirmed by peer review
- fn_03660 CAdventurerAgencyMgr::CompleteMyParty: logic confirmed by peer review
- fn_03664 CAdventurerAgencyMgr::CompletePartyInfo: logic confirmed by peer review
- fn_03662 CAdventurerAgencyMgr::CompleteList: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12413 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_23387 LookupClientItemByIdentity: logic confirmed by peer review
Peer-reviewed-by: KWDev, Toshiro, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11991 by Yommy: 0 byte-identical, 3 confirmed by peer review.
- fn_19991 CEffectPrim::RenderJitterSweeps: logic confirmed by peer review
- fn_19992 CEffectPrim::RenderBladeQuads: logic confirmed by peer review
- fn_19994 CEffectPrim::RenderArcWalls: logic confirmed by peer review
Peer-reviewed-by: dori, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12334 by eAthena: 0 byte-identical, 2 confirmed by peer review.
- fn_22596 CGrannyPc::RenderModel: logic confirmed by peer review
- fn_22651 CPc::ChangeState: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12153 by cremane: 0 byte-identical, 3 confirmed by peer review.
- fn_07089 CPowderingEffect::Slot01: logic confirmed by peer review
- fn_07090 CPowderingEffect::sub_709570: logic confirmed by peer review
- fn_07094 CPowderingEffect::Slot03: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12398 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_21154 CRenderObject::SetTlvert: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #11933 by Yommy: 0 byte-identical, 5 confirmed by peer review.
- fn_05439 CRenewQuestMgr::GetFilterName: logic confirmed by peer review
- fn_05442 RenewQuestOngoingInfo::GetHuntText: logic confirmed by peer review
- fn_05447 CRenewQuestMgr::WriteOngoingQuests: logic confirmed by peer review
- fn_05454 CRenewQuestMgr::IsInFilter: logic confirmed by peer review
- fn_05461 CRenewQuestMgr::SendQuestStatusRequest: logic confirmed by peer review
Peer-reviewed-by: KWDev, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12373 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_19381 CNaviData::ClearAll: logic confirmed by peer review
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12389 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_17884 CPathFinder::Clear: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12388 by cremane: 1 byte-identical, 1 confirmed by peer review.
- fn_19429 CNaviInfo::~CNaviInfo: byte-identical
- fn_19575 CNavigationManager::ClearNodePaths: logic confirmed by peer review
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12349 by cremane: 2 byte-identical, 0 confirmed by peer review.
- fn_19673 CEntryQueueMgr::OnResultNotice: byte-identical
- fn_19674 CEntryQueueMgr::OnNotify: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12384 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_21954 CGuildMgr::ReceiveEmblem: logic confirmed by peer review
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12299 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_18368 FillMessageBuckets: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12276 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_19610 CNavigationManager::SavedTargetText: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12269 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_06840 CAxeBoomerang::Slot01: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12242 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_06853 CAMachineEffect::Slot03: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12243 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_19996 CEffectPrim::RenderTwinGlowSquares: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12369 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_21647 CGameMode::ReceiveItem1738AddOptions: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12367 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_19990 CEffectPrim::RenderTrailingArc: logic confirmed by peer review
Peer-reviewed-by: KWDev, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12332 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_23797 HotkeyCount: logic confirmed by peer review
Peer-reviewed-by: KWDev, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
TableMng.cpp redeclared a partial, mismatched YExcel API (CompoundDocument
instead of YCompoundFiles::CompoundFile, SetIntegerAlt/SetWStringAlt instead
of BasicExcelCell::Set(int)/Set(const wchar_t*), non-const getters, int
GetTotalRows/GetTotalCols, New(size_t)), so nothing could define it. The
YExcel span was already skipped as runtime_library code.
- ThirdParty/BasicExcel: Yap Chun Wei's public-domain BasicExcel 1.14.
Matches the binary: sizeof(CompoundFile)=0x330, workbook_ at 0x330,
worksheets_ at 0x488, yesheets_ at 0x494, BasicExcelCell 0x28, Workbook()
BOF constants 0x50600/0x7CD19A0/0xC0C9/0x306. Local changes:
- BasicExcel gains unknown_04A0[0x108]: all four operator new calls in
the original allocate 0x5A8, no code reads the tail.
- the default constructor is defined by TableMng.cpp (fn_20498).
- operator<<(wchar_t*) keeps its pre-C++20 overload explicitly.
- TableMng.cpp includes the real header; scores of its 13 functions are
unchanged (td check).
- data/compile.json: shape 4 gets -I ThirdParty/BasicExcel; the library is
shape 11 (shape 8 without the jsoncpp defines/include).
Batch #12329 by unna: 0 byte-identical, 2 confirmed by peer review.
- fn_04294 CReputeMgr::sub_60DC70: logic confirmed by peer review
- fn_04295 CReputeMgr::sub_60E090: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12322 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12321 by cremane: 0 byte-identical, 3 confirmed by peer review.
- fn_19746 EquipmentResourceMgr::GetAccessoryResourceName: logic confirmed by peer review
- fn_19747 EquipmentResourceMgr::GetNamedAccessoryResourceName: logic confirmed by peer review
- fn_19748 EquipmentResourceMgr::GetBodyPalName: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
