Commit graph

53 commits

Author SHA1 Message Date
ragnarok-clanker
df3c4fe7f0 Decompile fn_03440 (CAccountLinkedUserDataLoadAsyncWork::CAccountLinkedUserDataLoadAsyncWork)
Batch #14722 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03440 CAccountLinkedUserDataLoadAsyncWork::CAccountLinkedUserDataLoadAsyncWork: logic confirmed by peer review

Peer-reviewed-by: secret, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 17:23:18 +00:00
ragnarok-clanker
ea017fa0f9 Decompile fn_03944 (CCharacterLinkedUserDataSaveAsyncWork::CCharacterLinkedUserDataSaveAsyncWork)
Batch #14557 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03944 CCharacterLinkedUserDataSaveAsyncWork::CCharacterLinkedUserDataSaveAsyncWork: logic confirmed by peer review

Peer-reviewed-by: secret, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 17:15:46 +00:00
ragnarok-clanker
383094ec81 Decompile fn_03916 (CCharacterLinkedUserDataLoadAsyncWork::CCharacterLinkedUserDataLoadAsyncWork)
Batch #14556 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03916 CCharacterLinkedUserDataLoadAsyncWork::CCharacterLinkedUserDataLoadAsyncWork: logic confirmed by peer review

Peer-reviewed-by: secret, Tanke, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 12:37:09 +00:00
ragnarok-clanker
b2d50653e4 Decompile fn_03478 (CAccountLinkedUserDataSaveAsyncWork::CAccountLinkedUserDataSaveAsyncWork)
Batch #14555 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03478 CAccountLinkedUserDataSaveAsyncWork::CAccountLinkedUserDataSaveAsyncWork: logic confirmed by peer review

Peer-reviewed-by: secret, Tanke, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 11:51:20 +00:00
ragnarok-clanker
d68921499a Decompile fn_03933 (CCharacterLinkedUserDataMgr::Save)
Batch #14116 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03933 CCharacterLinkedUserDataMgr::Save: logic confirmed by peer review

Peer-reviewed-by: secret, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:24:03 +00:00
ragnarok-clanker
c4fa7c482f Decompile fn_03949 (CCharacterLinkedUserDataSaveAsyncWork::Execute)
Batch #14202 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_03949 CCharacterLinkedUserDataSaveAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:12:06 +00:00
ragnarok-clanker
0ddc3fd351 Decompile fn_03921 (CCharacterLinkedUserDataLoadAsyncWork::Execute)
Batch #13751 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_03921 CCharacterLinkedUserDataLoadAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: Yommy, aDw, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:02:05 +00:00
ragnarok-clanker
381f73a4eb Decompile fn_13667 (NormalItemSlotWindow::IsValid)
Batch #13211 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_13667 NormalItemSlotWindow::IsValid: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 11:51:09 +00:00
ragnarok-clanker
c111dde0b7 Decompile fn_03483 (CAccountLinkedUserDataSaveAsyncWork::Execute)
Batch #12929 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03483 CAccountLinkedUserDataSaveAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: aDw, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 03:14:14 +00:00
ragnarok-clanker
435645593b Decompile fn_13730 (SubChatHisWndInfo::Reset)
Batch #12781 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_13730 SubChatHisWndInfo::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 00:46:30 +00:00
ragnarok-clanker
f29d8616e0 Decompile fn_13708 (MerchantItemShopWndInfo::Reset)
Batch #12730 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_13708 MerchantItemShopWndInfo::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 00:18:58 +00:00
ragnarok-clanker
dbcf190515 Decompile fn_03467 (CAccountLinkedUserDataMgr::RefreshUrls)
Batch #12620 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03467 CAccountLinkedUserDataMgr::RefreshUrls: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, KWDev, kyoshi, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 22:54:45 +00:00
ragnarok-clanker
8bfebeaa17 Decompile fn_13667 (NormalItemSlotWindow::IsValid)
Batch #12260 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_13667 NormalItemSlotWindow::IsValid: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:01:02 +00:00
ragnarok-clanker
edfa4888c4 Decompile 2 functions in Source/Contents/UserData/AccountLinkedUserDataMgr.cpp
Batch #12423 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_03465 CAccountLinkedUserDataMgr::CompleteLoad: logic confirmed by peer review
- fn_03468 CAccountLinkedUserDataMgr::Load: logic confirmed by peer review

Peer-reviewed-by: KWDev, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 15:02:21 +00:00
ragnarok-clanker
ca6d091e0e Confirm fn_03459 (CAccountLinkedUserDataMgr::Initialize)
Batch #11957 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_03459 CAccountLinkedUserDataMgr::Initialize: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-05 05:44:53 +00:00
ragnarok-clanker
7304edc8eb Decompile fn_03932 (CCharacterLinkedUserDataMgr::Load)
Batch #11735 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03932 CCharacterLinkedUserDataMgr::Load: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 04:33:21 +00:00
ragnarok-clanker
4b930c9885 Confirm fn_07683 (UIFriendOptionWnd::SendMsg)
Batch #11501 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.

- fn_07683 UIFriendOptionWnd::SendMsg: logic confirmed by peer review (already on main)

Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:54:51 +00:00
ragnarok-clanker
3c363a446c Decompile 3 functions in Source/Contents/UserData/AccountLinkedUserDataSaveAsyncWork.cpp
Batch #10877 by StrawberrysherbetIX: 0 byte-identical, 3 confirmed by peer review.

- fn_03478 CAccountLinkedUserDataSaveAsyncWork::CAccountLinkedUserDataSaveAsyncWork: logic confirmed by peer review
- fn_03480 CAccountLinkedUserDataSaveAsyncWork::Bind: logic confirmed by peer review
- fn_03483 CAccountLinkedUserDataSaveAsyncWork::Execute: logic confirmed by peer review (already on main)

Peer-reviewed-by: SapitoSucio, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 21:56:39 +00:00
ragnarok-clanker
b435909a9c Confirm fn_03468 (CAccountLinkedUserDataMgr::Load)
Batch #11128 by kyoshi: 0 byte-identical, 1 confirmed by peer review.

- fn_03468 CAccountLinkedUserDataMgr::Load: logic confirmed by peer review (already on main)

Peer-reviewed-by: ragnarok-clanker, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 19:54:31 +00:00
ragnarok-clanker
36ce2e4a14 Decompile fn_03483 (CAccountLinkedUserDataSaveAsyncWork::Execute)
Batch #10527 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03483 CAccountLinkedUserDataSaveAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 17:35:45 +00:00
ragnarok-clanker
d7b0c9ab99 Decompile 3 functions in Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.cpp
Batch #10824 by cremane: 0 byte-identical, 3 confirmed by peer review.

- fn_03440 CAccountLinkedUserDataLoadAsyncWork::CAccountLinkedUserDataLoadAsyncWork: logic confirmed by peer review
- fn_03445 CAccountLinkedUserDataLoadAsyncWork::Bind: logic confirmed by peer review
- fn_03449 CAccountLinkedUserDataLoadAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 17:35:07 +00:00
ragnarok-clanker
986a10f543 Decompile 3 functions in Source/Contents/UserData/CharacterLinkedUserDataLoadAsyncWork.cpp
Batch #10625 by cremane: 0 byte-identical, 3 confirmed by peer review.

- fn_03916 CCharacterLinkedUserDataLoadAsyncWork::CCharacterLinkedUserDataLoadAsyncWork: logic confirmed by peer review
- fn_03918 CCharacterLinkedUserDataLoadAsyncWork::Bind: logic confirmed by peer review
- fn_03921 CCharacterLinkedUserDataLoadAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 16:59:31 +00:00
ragnarok-clanker
f08b7bc915 Confirm fn_03934 (CCharacterLinkedUserDataMgr::Reset)
Batch #10629 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_03934 CCharacterLinkedUserDataMgr::Reset: logic confirmed by peer review (already on main)

Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 16:52:20 +00:00
ragnarok-clanker
a927755fae Decompile 3 functions in Source/Contents/UserData/CharacterLinkedUserDataSaveAsyncWork.cpp
Batch #10626 by cremane: 0 byte-identical, 3 confirmed by peer review.

- fn_03944 CCharacterLinkedUserDataSaveAsyncWork::CCharacterLinkedUserDataSaveAsyncWork: logic confirmed by peer review
- fn_03946 CCharacterLinkedUserDataSaveAsyncWork::Bind: logic confirmed by peer review
- fn_03949 CCharacterLinkedUserDataSaveAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Lumen, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 16:16:38 +00:00
ragnarok-clanker
2d55a137fc Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is
Batch #10269 by ragnarok-clanker: forced by an admin (2 lower score(s), 6 changed function(s)); checked with 102 compiled unit(s), including every includer of Source/Script/LuaScript.h.
2026-11-03 14:40:29 +00:00
ragnarok-clanker
749039eea6 Maintenance: [forced, user-approved] Family G30: remove ModeBaseEvents, CharacterConfigSave, AccountConfigLoad. ModeBaseEvents::Send
Batch #10264 by ragnarok-clanker: forced by an admin (2 lower score(s), 29 changed function(s)); checked with 511 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Hotkeys/EmotionHotkeys.h, Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/CharacterLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Client/ModeBaseEvents.h, Source/Contents/UserData/AccountConfigLoad.h, Source/Contents/UserData/CharacterConfigSave.h.
Deletes: Source/Client/ModeBaseEvents.h, Source/Contents/UserData/AccountConfigLoad.h, Source/Contents/UserData/CharacterConfigSave.h
2026-11-03 14:13:27 +00:00
ragnarok-clanker
bd0ade90cd Maintenance: [forced, user-approved] Family G27 (resubmit of 10254 rebased on e235d90a; only conflict was the AsyncWorkMgr.h forward
Batch #10259 by ragnarok-clanker: forced by an admin (1 lower score(s), 11 changed function(s)); checked with 508 compiled unit(s), including every includer of Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Skills/SkillLevelRegistry.h, Source/Contents/UserData/CharacterLinkedUserDataLoadAsyncWork.h, Source/Contents/UserData/CharacterLinkedUserDataMgr.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Contents/Skills/SkillLevelConfig.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/UI/Shortcuts/NormalItemSlotLoad.h.
Deletes: Source/Contents/Skills/SkillLevelConfig.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/UI/Shortcuts/NormalItemSlotLoad.h
2026-11-03 13:32:00 +00:00
ragnarok-clanker
5062bd4572 Maintenance: [forced, user-approved] Family G11: remove ShortcutVisibility (WindowManagerWindows& windows, WindowOrdering& ordering,
Batch #10214 by ragnarok-clanker: forced by an admin (0 lower score(s), 4 changed function(s)); checked with 17 compiled unit(s), including every includer of Source/Contents/UserData/CharacterConfigLoad.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutControlEvents.h, Source/UI/Shortcuts/ShortcutVisibility.h, Source/UI/Shortcuts/UIShortCutWnd.h.
2026-11-02 23:45:02 +00:00
ragnarok-clanker
d6bc9836d7 Maintenance: [forced, admin decision] Collapse the WindowManagerWindows adapter into UIWindowMgr, stage 1 of 2 (project decision: por
Batch #10019 by ragnarok-clanker: forced by an admin (23 lower score(s), 187 changed function(s)); checked with 447 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Mode/ModeDragState.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemCache.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/Party/AgencyRequestContext.h, Source/Contents/Party/ChangePartyMasterAsyncWork.h, Source/Contents/Party/LoadMyPartyAsyncWork.h, Source/Contents/Party/LoadPartyInfoAsyncWork.h, Source/Contents/Party/LoadPartyListAsyncWork.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/Party/RegisterPartyAsyncWork.h, Source/Contents/Party/StopRecruitingAsyncWork.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Chat/ChatSuggestions.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Lists/UIListBox.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/UIBasicCtrl.h, Source/UI/UIStaticItem.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/WindowManagerWindows.h, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
2026-11-02 14:09:20 +00:00
ragnarok-clanker
48a5e62a7c Decompile fn_24358 (ShutdownManagers)
Batch #9112 by Bielhp: 0 byte-identical, 1 confirmed by peer review.

- fn_24358 ShutdownManagers: logic confirmed by peer review

Peer-reviewed-by: youko, vinnyamancio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 03:04:23 +00:00
ragnarok-clanker
2c5a3974bf Decompile fn_21288 (CGameMode::InitializeState)
Batch #8883 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_21288 CGameMode::InitializeState: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, Romain, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 00:29:25 +00:00
ragnarok-clanker
2dcdf393ec Decompile 3 functions in Source/Client/Mode/GameModeActorEffects.cpp, Source/Client/Mode/CGameMode.h, ...
Batch #7443 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_21289 CGameMode::RefreshActorJobEffects: logic confirmed by peer review
- fn_13737 UIWindowMgr::ResetUIRectInfo: logic confirmed by peer review
- fn_11325 UIItemStoreComboBoxWnd::Slot15: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, superintelligence, kyoshi, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/Mode/GameModeActorEffects.cpp, Source/UI/Lists/UIItemStoreComboBox.cpp
2026-10-31 07:25:15 +00:00
ragnarok-clanker
3830bd03ca Decompile fn_03940 (CCharacterLinkedUserDataMgr::Save'::8'::SaveUseSkillLevel::operator())
Batch #6629 by System4z: 0 byte-identical, 1 confirmed by peer review.

- fn_03940 `CCharacterLinkedUserDataMgr::Save'::`8'::SaveUseSkillLevel::operator(): logic confirmed by peer review

Peer-reviewed-by: alisonrag, SapitoSucio, vinnyamancio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:27:57 +00:00
ragnarok-clanker
85eeed6fea Decompile 6 functions in Source/Contents/UserData/NormalItemSlots.cpp, Source/UI/Navigation/UINavigationV4Wnd.h, ...
Batch #5350 by eAthena: 1 byte-identical, 5 confirmed by peer review.

- fn_13738 NavigationWindowInfo::Clamp: logic confirmed by peer review
- fn_13745 UIParaResultWnd::AddItem: logic confirmed by peer review
- fn_13746 UIParaResultWnd::AddItem: logic confirmed by peer review
- fn_13747 UIParaItemPurchaseWnd::Slot10: logic confirmed by peer review
- fn_13748 UIParaItemShopWnd::Slot10: logic confirmed by peer review
- fn_13749 UIParaResultWnd::Slot10: byte-identical

Peer-reviewed-by: meitogi, alisonrag, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Item/UIParaItemShopWnd.cpp
2026-10-30 10:37:42 +00:00
ragnarok-clanker
9a426179d1 Decompile 11 functions in Source/Contents/UserData/NormalItemSlots.cpp, Source/Contents/UserData/NormalItemSlots.h
Batch #4435 by eAthena: 8 byte-identical, 3 confirmed by peer review.

- fn_13726 UnusedWndInfoC::Reset: byte-identical
- fn_13727 UnusedWndInfoD::Reset: byte-identical
- fn_13728 SkillListWndInfo::Reset: byte-identical
- fn_13729 StatusWndInfo::Reset: byte-identical
- fn_13730 SubChatHisWndInfo::Reset: logic confirmed by peer review
- fn_13731 AdvenPartyBoardWndInfo::Reset: byte-identical
- fn_13732 ApplyForPartyWndInfo::Reset: byte-identical
- fn_13733 RegisterPartyWndInfo::Reset: byte-identical
- fn_13734 WhisperWndInfo::Reset: byte-identical
- fn_13735 MacroReporterWndInfo::Reset: logic confirmed by peer review
- fn_13736 PreviewEquipWndInfo::Reset: logic confirmed by peer review

Peer-reviewed-by: willerthal, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 03:17:09 +00:00
ragnarok-clanker
dcbab32c07 Decompile fn_13628 (EquipWndInfo::IsValid)
Batch #4191 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_13628 EquipWndInfo::IsValid: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 01:59:08 +00:00
ragnarok-clanker
e2008265c8 Decompile 2 functions in Source/Contents/UserData/NormalItemSlots.cpp, Source/Contents/UserData/NormalItemSlots.h
Batch #2788 by willerthal: 0 byte-identical, 2 confirmed by peer review.

- fn_13665 ReplayRECControlWndInfo::IsValid: logic confirmed by peer review
- fn_13666 SayDialogWndInfo::IsValid: logic confirmed by peer review

Peer-reviewed-by: bigodeira, youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:28:21 +00:00
ragnarok-clanker
770e551838 Decompile fn_13656 (UnusedWndInfoB::IsValid)
Batch #2790 by willerthal: 1 byte-identical, 0 confirmed by peer review.

- fn_13656 UnusedWndInfoB::IsValid: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 19:02:03 +00:00
ragnarok-clanker
d4226e4710 Decompile 41 functions in Source/Contents/UserData/NormalItemSlots.cpp, Source/Contents/UserData/NormalItemSlots.h
Batch #2684 by youko: 0 byte-identical, 41 confirmed by peer review.

- fn_13620 AchTracingWndInfo::IsValid: logic confirmed by peer review
- fn_13621 BasicInfoWndInfo::IsValid: logic confirmed by peer review
- fn_13622 CashEmotionListWndInfo::IsValid: logic confirmed by peer review
- fn_13623 ChatRoomWndInfo::IsValid: logic confirmed by peer review
- fn_13624 ChooseWndInfo::IsValid: logic confirmed by peer review
- fn_13625 ClanWndInfo::IsValid: logic confirmed by peer review
- fn_13626 CombinedCardItemCollectionWndInfo::IsValid: logic confirmed by peer review
- fn_13627 EmotionWndInfo::IsValid: logic confirmed by peer review
- fn_13629 ExchangeAcceptWndInfo::IsValid: logic confirmed by peer review
- fn_13631 GuildHelperWndInfo::IsValid: logic confirmed by peer review
- fn_13632 GuildWndInfo::IsValid: logic confirmed by peer review
- fn_13633 HomunInfoWndInfo::IsValid: logic confirmed by peer review
- fn_13634 ItemCollectionWndInfo::IsValid: logic confirmed by peer review
- fn_13635 ItemCompositionWndInfo::IsValid: logic confirmed by peer review
- fn_13636 ItemStoreFindWndInfo::IsValid: logic confirmed by peer review
- fn_13637 ItemIdentifyWndInfo::IsValid: logic confirmed by peer review
- fn_13638 ItemParamChangeDisplayWndInfo::IsValid: logic confirmed by peer review
- fn_13639 ItemPurchaseWndInfo::IsValid: logic confirmed by peer review
- fn_13640 ItemSellWndInfo::IsValid: logic confirmed by peer review
- fn_13641 ItemShopWndInfo::IsValid: logic confirmed by peer review
- fn_13642 ItemStoreFindListInfo::IsValid: logic confirmed by peer review
- fn_13643 ItemStoreFindSlotInfo::IsValid: logic confirmed by peer review
- fn_13644 ItemWndInfo::IsValid: logic confirmed by peer review
- fn_13645 EntryQueueWndInfo::IsValid: logic confirmed by peer review
- fn_13646 MiniMapWndInfo::IsValid: logic confirmed by peer review
- fn_13647 MerInfoWndInfo::IsValid: logic confirmed by peer review
- fn_13648 MerchantItemMyShopWndInfo::IsValid: logic confirmed by peer review
- fn_13649 MerchantItemPurchaseWndInfo::IsValid: logic confirmed by peer review
- fn_13650 MerchantItemShopWndInfo::IsValid: logic confirmed by peer review
- fn_13651 MerchantItemWndInfo::IsValid: logic confirmed by peer review
- fn_13652 MerchantMirrorItemWndInfo::IsValid: logic confirmed by peer review
- fn_13653 MerchantShopMakeWndInfo::IsValid: logic confirmed by peer review
- fn_13654 MessengerGroupWndInfo::IsValid: logic confirmed by peer review
- fn_13655 NCashWndInfo::IsValid: logic confirmed by peer review
- fn_13657 SeekPartyWndInfo::IsValid: logic confirmed by peer review
- fn_13658 SeekPartyListWndInfo::IsValid: logic confirmed by peer review
- fn_13659 SeekPartyMBWndInfo::IsValid: logic confirmed by peer review
- fn_13660 JobListWndInfo::IsValid: logic confirmed by peer review
- fn_13661 PartySettingWndInfo::IsValid: logic confirmed by peer review
- fn_13662 PetInfoWndInfo::IsValid: logic confirmed by peer review
- fn_13664 QuickSlotWndInfo::IsValid: logic confirmed by peer review

Peer-reviewed-by: willerthal
Reviewed-by: ragnarok-clanker
2026-10-29 18:29:09 +00:00
ragnarok-clanker
26f2e33008 Decompile fn_13663 (QuestDisplayInfo::IsValid)
Batch #2687 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_13663 QuestDisplayInfo::IsValid: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 18:25:09 +00:00
ragnarok-clanker
da7c7a6ca7 Decompile fn_13678 (BasicInfoWndInfo::Reset)
Batch #2362 by alisonrag: 0 byte-identical, 1 confirmed by peer review.

- fn_13678 BasicInfoWndInfo::Reset: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 15:48:55 +00:00
ragnarok-clanker
4640388907 Decompile fn_13630 (FriendOptionWndInfo::IsValid)
Batch #2078 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_13630 FriendOptionWndInfo::IsValid: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 09:56:11 +00:00
ragnarok-clanker
891500760e Decompile fn_07683 (UIFriendOptionWnd::SendMsg)
Batch #1962 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_07683 UIFriendOptionWnd::SendMsg: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Reviewed-by: ragnarok-clanker
2026-10-29 08:58:31 +00:00
ragnarok-clanker
a748c78604 Decompile 3 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h, ...
Batch #1940 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_23761 ShortcutBindings::ClearAdditionalSkills: logic confirmed by peer review
- fn_23768 CharacterConfigSave::SkillLevel: logic confirmed by peer review
- fn_23778 CSession::FindGameActor: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy
Reviewed-by: ragnarok-clanker
2026-10-29 00:11:41 +00:00
ragnarok-clanker
9aea62bd9b Decompile 47 functions in Source/Client/ClientOptions.cpp, Source/Client/Session.h, ...
Batch #1675 by ragnarok-clanker: 2 byte-identical, 45 confirmed by peer review.

- fn_10839 UIButton::Slot25: logic confirmed by peer review
- fn_10852 UIButton::Slot31: logic confirmed by peer review
- fn_10868 UIButton::Slot27: logic confirmed by peer review
- fn_10930 UIStaticBitmap::SetBitmap: logic confirmed by peer review
- fn_10931 UIBitmapButton::SetBitmap: logic confirmed by peer review
- fn_11320 UIComboBoxEx2::Slot15: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review
- fn_11381 UIScrollBar::Paint: logic confirmed by peer review
- fn_11383 UIScrollBar_Navi::Paint: logic confirmed by peer review
- fn_11425 UIScrollBar::Slot25: logic confirmed by peer review
- fn_11440 UIScrollBar::Slot31: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review
- fn_11468 UIScrollBar::Slot27: logic confirmed by peer review
- fn_11471 UITextButton::Slot27: logic confirmed by peer review
- fn_11494 UITextButton::Slot33: logic confirmed by peer review
- fn_11779 UIFrameWnd::Slot25: logic confirmed by peer review
- fn_11781 UIFrameWnd::Slot31: logic confirmed by peer review
- fn_11786 UIFrameWnd::Slot27: logic confirmed by peer review
- fn_12610 CSession::GetOption: logic confirmed by peer review
- fn_12689 ActivateShortcut: logic confirmed by peer review
- fn_12711 ShortcutTooltip::Hover: logic confirmed by peer review
- fn_12724 ShortcutDetails::Open: logic confirmed by peer review (already on main)
- fn_12760 UIShortCutWnd::SendMsg: logic confirmed by peer review
- fn_17144 UIWindowMgr::RemoveOrder: logic confirmed by peer review
- fn_17158 UIWindowMgr::Capture: byte-identical
- fn_17180 UIWindowMgr::BringToFront: logic confirmed by peer review
- fn_17192 UIWindowMgr::IsOrderFixed: logic confirmed by peer review
- fn_17232 UIWindowMgr::ReleaseCapture: byte-identical
- fn_17255 UIWindowMgr::SetCapture: logic confirmed by peer review
- fn_20382 CConnection::CConnection: logic confirmed by peer review
- fn_20383 CRagConnection::CRagConnection: logic confirmed by peer review
- fn_20384 CConnection::~CConnection: logic confirmed by peer review (already on main)
- fn_20389 CConnection::Connect: logic confirmed by peer review
- fn_20390 CConnection::Close: logic confirmed by peer review
- fn_20409 GetRagConnection: logic confirmed by peer review
- fn_21406 AutomaticSkills::Complete: logic confirmed by peer review
- fn_03927 CCharacterLinkedUserDataMgr::CompleteLoad: logic confirmed by peer review
- fn_03933 CCharacterLinkedUserDataMgr::Save: logic confirmed by peer review
- fn_03937 CSession::SetOption: logic confirmed by peer review
- fn_11073 UIScrollBar::UIScrollBar: logic confirmed by peer review
- fn_11102 UIComboBoxEx2::~UIComboBoxEx2: logic confirmed by peer review (already on main)
- fn_09150 AutomaticSkills::DisableAll: logic confirmed by peer review
- fn_09153 AutomaticSkills::Use: logic confirmed by peer review
- fn_10689 UIBitmapButton::~UIBitmapButton: logic confirmed by peer review (already on main)
- fn_10795 UIBitmapButton::Paint: logic confirmed by peer review
- fn_10817 UIStaticBitmap::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:01:00 +00:00
ragnarok-clanker
b9474e7c82 Decompile fn_23379 (CSession::HomunSkillLevel)
Batch #1465 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23379 CSession::HomunSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 13:55:33 +00:00
ragnarok-clanker
cb0da9d674 Decompile fn_13690 (GuildWndInfo::Reset)
Batch #1313 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_13690 GuildWndInfo::Reset: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:07:13 +00:00
ragnarok-clanker
c4f234ff68 Decompile 12 functions in Source/Contents/UserData/NormalItemSlots.cpp, Source/Contents/UserData/NormalItemSlots.h, ...
Batch #1160 by eAthena: 0 byte-identical, 12 confirmed by peer review.

- fn_13668 SkillListWndInfo::IsValid: logic confirmed by peer review
- fn_13669 StatusWndInfo::IsValid: logic confirmed by peer review
- fn_13670 SubChatHisWndInfo::IsValid: logic confirmed by peer review
- fn_13671 AdvenPartyBoardWndInfo::IsValid: logic confirmed by peer review
- fn_13672 ApplyForPartyWndInfo::IsValid: logic confirmed by peer review
- fn_13673 RegisterPartyWndInfo::IsValid: logic confirmed by peer review
- fn_13674 WhisperWndInfo::IsValid: logic confirmed by peer review
- fn_13675 MacroReporterWndInfo::IsValid: logic confirmed by peer review
- fn_13676 PreviewEquipWndInfo::IsValid: logic confirmed by peer review
- fn_13677 AchTracingWndInfo::Reset: logic confirmed by peer review
- fn_13693 ItemCompositionWndInfo::Reset: logic confirmed by peer review
- fn_13695 ItemIdentifyWndInfo::Reset: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 21:07:07 +00:00
ragnarok-clanker
9fef90851e Decompile 14 functions in Source/Contents/UserData/NormalItemSlots.cpp, Source/Contents/UserData/NormalItemSlots.h, ...
Batch #1162 by eAthena: 14 byte-identical, 0 confirmed by peer review.

- fn_13679 CashEmotionListWndInfo::Reset: byte-identical
- fn_13680 ChatRoomWndInfo::Reset: byte-identical
- fn_13681 ChooseWndInfo::Reset: byte-identical
- fn_13682 ClanWndInfo::Reset: byte-identical
- fn_13683 CombinedCardItemCollectionWndInfo::Reset: byte-identical
- fn_13684 UnusedWndInfoA::Reset: byte-identical
- fn_13685 EmotionWndInfo::Reset: byte-identical
- fn_13686 EquipWndInfo::Reset: byte-identical
- fn_13687 ExchangeAcceptWndInfo::Reset: byte-identical
- fn_13688 FriendOptionWndInfo::Reset: byte-identical
- fn_13689 GuildHelperWndInfo::Reset: byte-identical
- fn_13691 HomunInfoWndInfo::Reset: byte-identical
- fn_13692 ItemCollectionWndInfo::Reset: byte-identical
- fn_13694 ItemStoreFindWndInfo::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:45:34 +00:00
ragnarok-clanker
9ac3d05245 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Contents headers (part 2: Items, Models, Movies, Skills,
Batch #1063 by ragnarok-clanker: no function's compiled code changes; checked with 62 compiled unit(s), including every includer of Source/Contents/Items/ItemNaming.h, Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelRendering.h, Source/Contents/Models/ModelSpatial.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/Movies/BinkMovies.h, Source/Contents/PlayerNameDictionary.h, Source/Contents/Skills/AutomaticSkills.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/WorldModelLoading.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldRayQuery.h.
2026-10-27 13:52:05 +00:00