Commit graph

36 commits

Author SHA1 Message Date
ragnarok-clanker
e5d4b3b94c Decompile fn_17510 (C3dActor::CopyVolumes)
Batch #12528 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_17510 C3dActor::CopyVolumes: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:54:18 +00:00
ragnarok-clanker
3f9b790c6e Decompile fn_17493 (C3dActorV1::Update)
Batch #12405 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_17493 C3dActorV1::Update: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:01:26 +00:00
ragnarok-clanker
dd95a31022 Decompile 3 functions in Source/Contents/Models/ModelAnimation.cpp, Source/Contents/Models/ModelAnimation.h, ...
Batch #12238 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_01721 SampleLegacyPosition: logic confirmed by peer review
- fn_01722 SampleModelPosition: logic confirmed by peer review
- fn_01723 SampleLegacyRotation: logic confirmed by peer review

Peer-reviewed-by: KWDev, Toshiro, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:29:45 +00:00
ragnarok-clanker
f0cd1e9d13 Decompile 2 functions in Source/Contents/Models/ModelActorBounds.cpp
Batch #12165 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_17512 C3dActorV1::UpdateBounds: logic confirmed by peer review
- fn_17513 C3dActorV2::UpdateBounds: logic confirmed by peer review

Peer-reviewed-by: Tanke, cremane, raiken
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:00:08 +00:00
ragnarok-clanker
a20ef24120 Decompile 2 functions in Source/Contents/Models/ModelRendering.cpp, Source/Contents/Models/ModelRendering.h
Batch #12104 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_17499 C3dNodeV1::Draw: logic confirmed by peer review
- fn_17500 C3dNodeV2::Draw: logic confirmed by peer review

Peer-reviewed-by: KWDev, SapitoSucio, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 10:39:56 +00:00
ragnarok-clanker
116928a879 Decompile fn_17509 (C3dNode::OverrideColors)
Batch #11964 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_17509 C3dNode::OverrideColors: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 05:47:54 +00:00
ragnarok-clanker
9c0e63c95d Decompile fn_17494 (C3dActorV2::Update)
Batch #11713 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_17494 C3dActorV2::Update: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 04:29:31 +00:00
ragnarok-clanker
7533983e8a Decompile 2 functions in Source/Contents/Models/ModelNode.cpp
Batch #11688 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_17507 C3dNodeV1::Animate: logic confirmed by peer review
- fn_17508 C3dNodeV2::Animate: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 04:23:20 +00:00
ragnarok-clanker
fc53db8f39 Confirm fn_01724 (SampleModelRotation)
Batch #11644 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.

- fn_01724 SampleModelRotation: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 04:03:01 +00:00
ragnarok-clanker
4d023e3b1a Confirm 2 functions in Source/Contents/Models/ModelNode.cpp, Source/Contents/Models/ModelNode.h
Batch #11627 by StrawberrysherbetIX: 0 byte-identical, 2 confirmed by peer review.

- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review (already on main)
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:58:08 +00:00
ragnarok-clanker
99698b5fd7 Confirm 2 functions in Source/Contents/Models/ModelActorBounds.cpp
Batch #11481 by kyoshi: 0 byte-identical, 2 confirmed by peer review.

- fn_17512 C3dActorV1::UpdateBounds: logic confirmed by peer review (already on main)
- fn_17513 C3dActorV2::UpdateBounds: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:09:25 +00:00
ragnarok-clanker
344f57c8a8 Decompile 3 functions in Source/Contents/Models/ModelTextureAnimation.cpp
Batch #11500 by cremane: 0 byte-identical, 3 confirmed by peer review.

- fn_01728 ModelKeyList1::Read: logic confirmed by peer review
- fn_01729 ModelKeyList2::Read: logic confirmed by peer review
- fn_01731 ModelKeyList4::Read: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:52:58 +00:00
ragnarok-clanker
037bd46842 Decompile 2 functions in Source/Contents/Models/ModelLighting.cpp
Batch #11286 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_17491 C3dNode::Find: logic confirmed by peer review
- fn_17521 C3dNode::Prepare: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:34:51 +00:00
ragnarok-clanker
7cc4fdd58e Decompile 2 functions in Source/Contents/Models/ModelActorBounds.cpp, Source/Resource/Models/ModelResource.h
Batch #10504 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17512 C3dActorV1::UpdateBounds: logic confirmed by peer review
- fn_17513 C3dActorV2::UpdateBounds: logic confirmed by peer review

Peer-reviewed-by: Yommy, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:57:59 +00:00
ragnarok-clanker
55ac289a3b Decompile fn_17500 (C3dNodeV2::Draw)
Batch #10564 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_17500 C3dNodeV2::Draw: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:43:25 +00:00
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
bce396c837 Confirm fn_17487 (C3dActor::MarkOccluded)
Batch #10695 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17487 C3dActor::MarkOccluded: logic confirmed by peer review (already on main)

Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 16:50:15 +00:00
ragnarok-clanker
750f35b3dd Maintenance: [forced, user-approved] Family W5 (resubmission of 10276 without the STATIC lines; replaces agent 2's 10270, returned by
Batch #10277 by ragnarok-clanker: forced by an admin (17 lower score(s), 63 changed function(s)); checked with 414 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelNode.h, Source/Contents/Models/ModelRendering.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldOcclusion.h, Source/Contents/World/WorldTerrainPicking.h, Source/Render/Projection/RendererViewport.h, Source/Render/Projection/RenderProjection.h.
Deletes: Source/Render/Projection/RenderProjection.h
2026-11-03 15:49:14 +00:00
ragnarok-clanker
26277f915c Maintenance: [forced, user-approved] Family W3: remove invented ModelLightingContext and WorldModelLoading. Evidence: C3dActor::Prepa
Batch #10256 by ragnarok-clanker: forced by an admin (0 lower score(s), 8 changed function(s)); checked with 113 compiled unit(s), including every includer of Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelNode.h, Source/Contents/Models/ModelRendering.h, Source/Contents/World/World.h, Source/Contents/World/WorldModelLoading.h.
2026-11-03 12:59:38 +00:00
ragnarok-clanker
402041a79d Decompile fn_17480 (C3dActorV2::Assign)
Batch #8474 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_17480 C3dActorV2::Assign: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 18:10:38 +00:00
ragnarok-clanker
dc2f3a8f88 Align method names with DHXJ (call-graph matches): CEffectPrim::Prim3DParticle/Prim3DParticleNoMaster/Prim3DParticleOrbit, matrix::AppendScale/AppendXRotation/AppendZRotation/AppendTranslate/MakeYRotation/MakeZRotation, CRenderObject::CalcDist (2 overloads). Pure rename, codegen unchanged (504/504 functions identical with includers). 2026-10-29 13:12:37 +01:00
ragnarok-clanker
e9b98b8c69 Rename AffineMatrix -> matrix (DHXJ); clashes with variables named matrix use the elaborated form 'struct matrix'. Pure rename, codegen unchanged (383/383 functions identical with includers). 2026-10-29 12:33:14 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
5b61d1ac08 Decompile fn_17498 (C3dNode::Draw)
Batch #1635 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17498 C3dNode::Draw: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:46:47 +00:00
ragnarok-clanker
0e94db9d83 Decompile fn_01730 (ModelKeyList3::Read)
Batch #1597 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_01730 ModelKeyList3::Read: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
2026-10-28 19:42:35 +00:00
ragnarok-clanker
e53f03279f Decompile 4 functions in Source/Contents/Models/ModelTextureAnimation.cpp
Batch #1256 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_01728 ModelKeyList1::Read: logic confirmed by peer review
- fn_01729 ModelKeyList2::Read: logic confirmed by peer review
- fn_01731 ModelKeyList4::Read: logic confirmed by peer review
- fn_01732 ModelTextureChannelMap::Read: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 23:35:26 +00:00
ragnarok-clanker
fe5a446879 Decompile 2 functions in Source/Contents/Models/ModelActor.cpp, Source/Contents/Models/ModelActor.h
Batch #1134 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17495 C3dActor::Draw: logic confirmed by peer review
- fn_17518 C3dActor::Prepare: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 21:05:38 +00:00
ragnarok-clanker
c733fbc98c Decompile 5 functions in Source/Contents/Models/ModelActor.cpp, Source/Contents/Models/ModelActor.h
Batch #1137 by eAthena: 5 byte-identical, 0 confirmed by peer review.

- fn_17478 C3dActor::Assign: byte-identical
- fn_17488 C3dActor::Find: byte-identical
- fn_17492 C3dActor::Update: byte-identical
- fn_17503 C3dActor::Animate: byte-identical
- fn_17511 C3dActor::UpdateBounds: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:17:56 +00:00
ragnarok-clanker
eb3e3b8b08 Decompile 11 functions in Source/Contents/Models/ModelLighting.cpp, Source/Contents/Models/ModelNode.cpp, ...
Batch #1082 by ragnarok-clanker: 0 byte-identical, 11 confirmed by peer review.

- fn_02007 ModelMesh::ModelMesh: logic confirmed by peer review
- fn_02009 ModelMesh::~ModelMesh: logic confirmed by peer review
- fn_02011 ModelMesh::CalculateNormals: logic confirmed by peer review
- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review
- fn_07997 AnimatedModelRecord::~AnimatedModelRecord: logic confirmed by peer review
- fn_08023 C3dAnimModelRes::Unload: logic confirmed by peer review
- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review
- fn_17514 C3dNode::AccumulateBounds: logic confirmed by peer review
- fn_17515 C3dNode::SampleGroundColors: logic confirmed by peer review
- fn_17521 C3dNode::Prepare: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 16:31:29 +00:00
ragnarok-clanker
9ac3d05245 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Contents headers (part 2: Items, Models, Movies, Skills,
Batch #1063 by ragnarok-clanker: no function's compiled code changes; checked with 62 compiled unit(s), including every includer of Source/Contents/Items/ItemNaming.h, Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelRendering.h, Source/Contents/Models/ModelSpatial.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/Movies/BinkMovies.h, Source/Contents/PlayerNameDictionary.h, Source/Contents/Skills/AutomaticSkills.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/WorldModelLoading.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldRayQuery.h.
2026-10-27 13:52:05 +00:00
ragnarok-clanker
ff15df90ad 📝 docs(annotations): marked inlined functions across modules 2026-10-27 10:42:13 +01:00
ragnarok-clanker
c5aea5fa76 📝 docs(models,render): added inlined comments to functions 2026-10-27 09:57:08 +01:00
ragnarok-clanker
220df4d318 Decompile 12 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/ModelResource.h, ...
Batch #959 by ragnarok-clanker: 0 byte-identical, 12 confirmed by peer review.

- fn_07948 C3dModelRes::Unload: logic confirmed by peer review (already on main)
- fn_07949 C3dModelResV1::Create: logic confirmed by peer review (already on main)
- fn_07982 C3dModelRes::C3dModelRes: logic confirmed by peer review (already on main)
- fn_07995 C3dModelRes::~C3dModelRes: logic confirmed by peer review (already on main)
- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review
- fn_08012 C3dModelRes::FindNode: logic confirmed by peer review (already on main)
- fn_07985 ModelNode::ModelNode: logic confirmed by peer review
- fn_07950 C3dModelResV1::Load: logic confirmed by peer review (already on main)
- fn_07983 C3dModelResV1::C3dModelResV1: logic confirmed by peer review (already on main)
- fn_07984 C3dModelResV2::C3dModelResV2: logic confirmed by peer review (already on main)
- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 08:05:28 +00:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00