clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
5,791 commits 2 branches 0 tags 44 MiB
Commit graph

6 commits

Author SHA1 Message Date
ragnarok-clanker
3f8411389e Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids 
Batch #13406 by ragnarok-clanker: no function's compiled code changes; checked with 124 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/SpriteParticle.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/Contents/Actors/Skill.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/Contents/Effects/HealEffect.h, Source/Contents/AchievementMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/Contents/Effects/LightSphereEffect.h, Source/Contents/Effects/BlastForge.h, Source/Security/NProtectGameGuardMgr.h, Source/Contents/Effects/MapChainEffect.h, Source/Utility/Math/Int64Math.h.
 2026-11-06 16:08:47 +00:00
ragnarok-clanker
1f50a1f230 Confirm fn_19074 (CHealEffect::SpawnParticles) 
Batch #10737 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19074 CHealEffect::SpawnParticles: logic confirmed by peer review (already on main)

Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-04 18:40:04 +00:00
ragnarok-clanker
0a1446fe48 Decompile 3 functions in Source/Contents/Effects/HealEffect.cpp, Source/Contents/Effects/HealEffect.h 
Batch #5321 by sherollyner: 0 byte-identical, 3 confirmed by peer review.

- fn_19076 CHealEffect::Slot03: logic confirmed by peer review
- fn_19077 CHealEffect::Slot04: logic confirmed by peer review
- fn_19078 CHealEffect::sub_B69E30: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 10:20:35 +00:00
ragnarok-clanker
0a0be86c67 Decompile fn_19075 (CHealEffect::Slot06) 
Batch #4258 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_19075 CHealEffect::Slot06: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-30 01:57:00 +00:00
ragnarok-clanker
44d6e4d7b1 Decompile fn_19070 (CHealEffect::sub_B67F90) 
Batch #4233 by bigodeira: 0 byte-identical, 1 confirmed by peer review.

- fn_19070 CHealEffect::sub_B67F90: logic confirmed by peer review

Peer-reviewed-by: eAthena, KWDev, OrangeCat
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 01:54:26 +00:00
ragnarok-clanker
eeceefed66 Decompile 14 functions in Source/Contents/Effects/FlowerCastingEffect.cpp, Source/Contents/Effects/FlowerCastingEffect.h, ... 
Batch #4160 by youko: 4 byte-identical, 10 confirmed by peer review.

- fn_19059 CFlowerCastingEffect::AddRing: logic confirmed by peer review
- fn_19060 CFlowerCastingEffect::Close: byte-identical
- fn_19061 CFlowerCastingEffect::Slot01: logic confirmed by peer review
- fn_19062 CFlowerCastingEffect::Slot06: byte-identical
- fn_19063 CFlowerCastingEffect::Slot03: logic confirmed by peer review
- fn_19064 CFlowerCastingEffect::Slot04: logic confirmed by peer review
- fn_19065 CHealEffect::CHealEffect: logic confirmed by peer review
- fn_19067 CHealEffect::AddSparks: logic confirmed by peer review
- fn_19068 CHealEffect::AddColumn: logic confirmed by peer review
- fn_19069 CHealEffect::AddCone: logic confirmed by peer review
- fn_19071 CHealEffect::Close: byte-identical
- fn_19072 CHealEffect::Slot01: byte-identical
- fn_19073 CHealEffect::Slot12: logic confirmed by peer review
- fn_19074 CHealEffect::SpawnParticles: logic confirmed by peer review

Peer-reviewed-by: Yommy, superintelligence, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Effects/FlowerCastingEffect.cpp, Source/Contents/Effects/HealEffect.cpp
 2026-10-30 01:35:50 +00:00