Commit graph

25 commits

Author SHA1 Message Date
ragnarok-clanker
db00a48497 🛠️ refactor(effects): replaced magic number 2343 with EF_UNK_2343 enum constant 2026-10-27 09:26:08 +01:00
ragnarok-clanker
220df4d318 Decompile 12 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/ModelResource.h, ...
Batch #959 by ragnarok-clanker: 0 byte-identical, 12 confirmed by peer review.

- fn_07948 C3dModelRes::Unload: logic confirmed by peer review (already on main)
- fn_07949 C3dModelResV1::Create: logic confirmed by peer review (already on main)
- fn_07982 C3dModelRes::C3dModelRes: logic confirmed by peer review (already on main)
- fn_07995 C3dModelRes::~C3dModelRes: logic confirmed by peer review (already on main)
- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review
- fn_08012 C3dModelRes::FindNode: logic confirmed by peer review (already on main)
- fn_07985 ModelNode::ModelNode: logic confirmed by peer review
- fn_07950 C3dModelResV1::Load: logic confirmed by peer review (already on main)
- fn_07983 C3dModelResV1::C3dModelResV1: logic confirmed by peer review (already on main)
- fn_07984 C3dModelResV2::C3dModelResV2: logic confirmed by peer review (already on main)
- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 08:05:28 +00:00
ragnarok-clanker
db06901420 Confirm fn_45422 (CSoundMgr::~CSoundMgr)
Batch #981 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_45422 CSoundMgr::~CSoundMgr: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-27 00:22:50 +00:00
ragnarok-clanker
4def72328f Decompile 2 functions in Source/Contents/Hotkeys/HotkeyInfo.cpp, Source/Contents/Hotkeys/HotkeyInfo.h
Batch #895 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_10278 SkillTooltipPercent: logic confirmed by peer review
- fn_10279 SkillTooltipFlat: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 22:56:15 +00:00
ragnarok-clanker
ff36f34044 Decompile 5 functions in Source/Contents/TipBoxTitles.cpp, Source/Contents/TipBoxTitles.h
Batch #894 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_09122 CTipBoxMgr::AddParagraph: logic confirmed by peer review
- fn_09123 CTipBoxMgr::Create: logic confirmed by peer review
- fn_09124 CTipBoxMgr::Destroy: logic confirmed by peer review
- fn_09125 CTipBoxMgr::SelectRandomTip: logic confirmed by peer review
- fn_09126 CTipBoxMgr::GetTip: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 22:56:14 +00:00
ragnarok-clanker
e0997ca0e5 Decompile 3 functions in Source/Contents/ActorNameCard.cpp, Source/Contents/ActorNameCard.h
Batch #890 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_03484 CActorNameCard::CActorNameCard: logic confirmed by peer review
- fn_03485 CActorNameCard::~CActorNameCard: logic confirmed by peer review
- fn_03493 CActorNameCardHolder::~CActorNameCardHolder: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 22:55:47 +00:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00
ragnarok-clanker
31bd9d1952 Decompile 2 functions in Source/Contents/Hotkeys/UserHotkeyScript.cpp, Source/Contents/Hotkeys/UserHotkeyScript.h
Batch #910 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_04064 ChangeUserHotkey: logic confirmed by peer review
- fn_03473 LoadUserHotkeyTab: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 22:07:49 +00:00
ragnarok-clanker
3897c27241 Decompile 4 functions in Source/Contents/ActorGeometry.cpp, Source/Contents/Actors/RenderObject.h, ...
Batch #837 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_21007 CRenderObject::Heading: logic confirmed by peer review
- fn_21008 CRenderObject::Face: logic confirmed by peer review
- fn_21009 CRenderObject::HorizontalDistance: logic confirmed by peer review
- fn_21010 CRenderObject::Distance: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ActorGeometry.cpp
2026-10-26 21:51:37 +00:00
ragnarok-clanker
b2d178ac32 Decompile fn_17876 (MovementRouteInterpolation::Sample)
Batch #838 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17876 MovementRouteInterpolation::Sample: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 21:50:25 +00:00
ragnarok-clanker
5bd1a554b0 Decompile 3 functions in Source/Contents/Items/ItemDescription.cpp, Source/Contents/Items/ItemDescription.h
Batch #930 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_06546 EnsureItemCardName: logic confirmed by peer review
- fn_06547 EnsureItemDescriptionLines: logic confirmed by peer review
- fn_06579 FindItemDescription: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 21:46:27 +00:00
ragnarok-clanker
7541fbec29 Decompile 6 functions in Source/Contents/GuildMgr.cpp, Source/Contents/GuildMgr.h, ...
Batch #889 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_05147 CGuild::CGuild: logic confirmed by peer review
- fn_05148 CGuild::~CGuild: logic confirmed by peer review
- fn_05172 CGuildMgr::Create: logic confirmed by peer review
- fn_05173 CGuildMgr::Destroy: logic confirmed by peer review
- fn_05175 CGuildMgr::GetEmblemVersion: logic confirmed by peer review
- fn_05181 CGuildMgr::SetEmblemVersion: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/GuildMgr.cpp, Source/Contents/GuildEmblemState.cpp
2026-10-26 21:46:02 +00:00
ragnarok-clanker
6f8a35191a Decompile 2 functions in Source/Contents/Jobs/JobNames.cpp
Batch #929 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_24165 JobNames::BaseJob: logic confirmed by peer review
- fn_23396 JobNames::Lookup: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 21:45:07 +00:00
ragnarok-clanker
1122aa7c98 Decompile 7 functions in Source/Contents/Jobs/JobId.h, Source/Contents/Jobs/JobInheritance.cpp, ...
Batch #921 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_23461 GetRealWeaponId: logic confirmed by peer review
- fn_23585 ?IsTreeGroupTwo@?A0x66373c89@@YA_NH@Z: logic confirmed by peer review
- fn_23586 ?IsTreeGroupThree@?A0x66373c89@@YA_NH@Z: logic confirmed by peer review
- fn_23587 IsPlayerJob: logic confirmed by peer review
- fn_23907 JobInheritance::InitializeSkillTree: logic confirmed by peer review
- fn_23495 JobNames::Initialize: logic confirmed by peer review
- fn_23444 AttackMotionLength: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 21:33:33 +00:00
ragnarok-clanker
ab4f30f7b0 Maintenance: Remove unused cstdint and string includes from JobNames.h; types and declarations unchanged. Checked exact header payloa
Batch #912 by ragnarok-clanker: no function's compiled code changes; checked with 4 compiled unit(s), including every includer of Source/Contents/Jobs/JobNames.h.
2026-10-26 20:58:39 +00:00
ragnarok-clanker
f575258340 Maintenance: Define every global once in its owner unit; session members replace member globals
Batch #906 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Client/Session.h, Source/Client/Registry.h, Source/Client/Application/LaunchInfo.h, Source/Client/Application/Launcher.h, Source/Client/Mode/ActiveGameMode.h, Source/Render/DeviceSelection.h.
Adds to the build: Source/Client/Session.cpp, Source/Client/Registry.cpp, Source/Client/Application/LaunchInfo.cpp, Source/Render/DeviceSelection.cpp
2026-10-26 18:34:25 +00:00
ragnarok-clanker
1dccbfbae5 Maintenance: Annotate globals on their definitions only; drop annotations from header externs
Batch #904 by ragnarok-clanker: no function's compiled code changes; checked with 3 compiled unit(s), including every includer of Source/Contents/MessageTable.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemDataMgr.h, Source/Contents/Hotkeys/UserHotkeyMgr.h, Source/Contents/Messenger/WhisperBlockMgr.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/CharacterLinkedUserDataMgr.h, Source/Network/TextEncoding.h, Source/Network/Http/CURLMgr.h, Source/Render/Textures/Texture.h, Source/UI/Layout/SnapMgr.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIWindow.h, Source/Utility/Async/NMessageMgr.h.
2026-10-26 18:25:54 +00:00
ragnarok-clanker
710d01dd99 Decompile fn_03502 (CActorNameCardHolder::Clear)
Batch #891 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_03502 CActorNameCardHolder::Clear: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-26 12:02:11 +00:00
ragnarok-clanker
1deabc9a4d Decompile fn_03487 (CActorNameCard::Reset)
Batch #887 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_03487 CActorNameCard::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/ActorNameCard.cpp, Source/Contents/ActorNameDirectory.cpp
2026-10-26 11:54:34 +00:00
ragnarok-clanker
f770bd3ae2 Decompile fn_17877 (MovementRouteInterpolation::Segment)
Batch #839 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_17877 MovementRouteInterpolation::Segment: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/MovementRouteInterpolation.cpp
2026-10-25 18:40:03 +00:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
ragnarok-clanker
27d9194df4 Decompile 2 functions in Source/Contents/ModelNode.cpp, Source/Contents/ModelNode.h
Batch #119 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_17481 C3dNode::Initialize: byte-identical
- fn_17506 C3dNode::Animate: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-24 18:02:31 +00:00
ragnarok-clanker
98f18d9f79 Decompile fn_21063 (EffectActor::EffectVisible)
Batch #99 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_21063 EffectActor::EffectVisible: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-24 14:50:53 +00:00
ragnarok-clanker
d456e8f64a Initial rodecomp source snapshot 2026-10-24 00:35:19 +00:00