Commit graph

54 commits

Author SHA1 Message Date
ragnarok-clanker
5ad8e0c58c Maintenance: Resubmission of 16340 over main 047268c0 (conflict in UICashEmotionPack::GetPriceText resolved keeping main's new body).
Batch #16351 by ragnarok-clanker: no function's compiled code changes; checked with 784 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Browser/BrowserCommandTarget.h, Source/Client/Browser/BrowserDocumentUI.h, Source/Client/Browser/BrowserInPlace.h, Source/Client/Browser/WebBrowser.h, Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/Client/Input/Mouse.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StovePCSDK.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GndRiser.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/MousePointer.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClanInfo.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/ArrowEffect.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/DummyEffectLauncher.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/EffectTypes.h, Source/Contents/Effects/ElectricEffect.h, Source/Contents/Effects/EmitterEffect.h, Source/Contents/Effects/FortuneKissEffect.h, Source/Contents/Effects/MagicFloorEffect.h, Source/Contents/Effects/MandraAttackEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RichManKim.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StarEffect.h, Source/Contents/Effects/WhirlwindEffect.h, Source/Contents/EnchantMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/GuildInfo.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemInfo.h, Source/Contents/Items/RuneSystem.h, Source/Contents/MapSkyMgr.h, Source/Contents/Models/ModelActor.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/NavigationManager.h, Source/Contents/Party/PartyBookingMgr.h, Source/Contents/PetEvolutionMgr.h, Source/Contents/RenewQuestMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/Schedule/Schedule.h, Source/Contents/Schedule/ShutDownSchedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/Store/MCStoreInfoBackupAsyncWork.h, Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/WorldView/WorldViewData.h, Source/Network/Connection/Connection.h, Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/DirectDrawEnumeration.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/RendererDX7.h, Source/Render/Text/EmbedFont.h, Source/Render/Text/TextContext.h, Source/Render/Textures/Texture.h, Source/Resource/BinkRuntime.h, Source/Resource/GifResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelMesh.h, Source/Resource/ResourceMgr.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Security/NProtectGameGuardMgr.h, Source/Security/ReassemblyPacketMgr.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Dialogs/UILoadingWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/TableBox.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Lists/UIVScrollBar.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIRequestJoinPartyWnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/TextMarkup.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewer.h, Source/UI/Text/UITransBalloonText.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowId.h, Source/Utility/Async/NAsyncWork.h, Source/Utility/Async/NRecycleObjectPoolMgr.h, Source/Utility/JsonCppLoader.h, Source/Utility/Lexicon/LexiconSerializer.h, Source/Utility/NFileLog.h, Source/Utility/Threading/NThread.h.
2026-11-10 17:38:25 +00:00
ragnarok-clanker
4f5f6f4b59 Decompile fn_03656 (CAdventurerAgencyMgr::LoadList)
Batch #15934 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03656 CAdventurerAgencyMgr::LoadList: logic confirmed by peer review

Peer-reviewed-by: eAthena, bgamez23
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 12:12:35 +00:00
ragnarok-clanker
39b5d358f8 Decompile fn_03708 (CRegisterPartyAsyncWork::Complete)
Batch #15247 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03708 CRegisterPartyAsyncWork::Complete: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 18:39:50 +00:00
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
521b52384c Maintenance: Replace LookupMessage(<integer>) with the existing MSGSTRINGID constant of the same value (3596 sites, 162 files; each v
Batch #14938 by ragnarok-clanker: no function's compiled code changes; checked with 162 compiled unit(s).
2026-11-08 14:19:01 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 13:56:42 +00:00
ragnarok-clanker
e79bbfcda9 Confirm 14 functions in Source/Utility/Async/NRecycleObject.h, Source/Contents/Async/AsyncWorkRecycleObjectPoolMgr.cpp, ...
Batch #14814 by kyoshi: 0 byte-identical, 14 confirmed by peer review.

- fn_02567 NRecycleObjectPool<CAccountLinkedUserDataLoadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02568 NRecycleObjectPool<CLoadPartyInfoAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02569 NRecycleObjectPool<CChangePartyMasterAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02570 NRecycleObjectPool<CStopRecruitingAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02571 NRecycleObjectPool<CRegisterPartyAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02572 NRecycleObjectPool<CLoadMyPartyAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02573 NRecycleObjectPool<CLoadPartyListAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02574 NRecycleObjectPool<CMCStoreInfoBackupSaveAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02575 NRecycleObjectPool<CMCStoreInfoBackupLoadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02576 NRecycleObjectPool<CEmblemDataDownloadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02577 NRecycleObjectPool<CEmblemDataUploadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02578 NRecycleObjectPool<CCharacterLinkedUserDataSaveAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02579 NRecycleObjectPool<CCharacterLinkedUserDataLoadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02580 NRecycleObjectPool<CAccountLinkedUserDataSaveAsyncWork>::Release: logic confirmed by peer review (already on main)

Peer-reviewed-by: secret, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 18:59:06 +00:00
ragnarok-clanker
690689a103 Decompile fn_03692 (CLoadPartyInfoAsyncWork::CLoadPartyInfoAsyncWork)
Batch #14540 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03692 CLoadPartyInfoAsyncWork::CLoadPartyInfoAsyncWork: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, secret, kyoshi, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 18:33:45 +00:00
ragnarok-clanker
3e443e4476 Decompile fn_03677 (CChangePartyMasterAsyncWork::CChangePartyMasterAsyncWork)
Batch #14551 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03677 CChangePartyMasterAsyncWork::CChangePartyMasterAsyncWork: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, kyoshi, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 17:58:11 +00:00
ragnarok-clanker
a2b1283c91 Decompile fn_03711 (CStopRecruitingAsyncWork::CStopRecruitingAsyncWork)
Batch #14553 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03711 CStopRecruitingAsyncWork::CStopRecruitingAsyncWork: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, secret, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 15:46:06 +00:00
ragnarok-clanker
813313175b Decompile fn_03698 (CLoadPartyListAsyncWork::CLoadPartyListAsyncWork)
Batch #14684 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_03698 CLoadPartyListAsyncWork::CLoadPartyListAsyncWork: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 14:08:22 +00:00
ragnarok-clanker
dc971e40e0 Decompile 3 functions in Source/Contents/Party/LoadMyPartyAsyncWork.cpp
Batch #14651 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_03685 CLoadMyPartyAsyncWork::CLoadMyPartyAsyncWork: logic confirmed by peer review
- fn_03687 CLoadMyPartyAsyncWork::Bind: logic confirmed by peer review
- fn_03690 CLoadMyPartyAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: Tanke, Toshiro, codeplay, raiken, secret
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 12:40:57 +00:00
ragnarok-clanker
73e122304d Decompile fn_03683 (CChangePartyMasterAsyncWork::Execute)
Batch #13713 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_03683 CChangePartyMasterAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:54:22 +00:00
ragnarok-clanker
5327880963 Decompile 7 functions in Source/Contents/Party/LoadPartyListAsyncWork.cpp, Source/Contents/Party/RegisterPartyAsyncWork.cpp, ...
Batch #14263 by eAthena: 0 byte-identical, 7 confirmed by peer review.

- fn_03704 CRegisterPartyAsyncWork::CRegisterPartyAsyncWork: logic confirmed by peer review
- fn_03706 CRegisterPartyAsyncWork::Bind: logic confirmed by peer review
- fn_04241 CMCStoreInfoBackupLoadAsyncWork::CMCStoreInfoBackupLoadAsyncWork: logic confirmed by peer review
- fn_04243 CMCStoreInfoBackupLoadAsyncWork::Bind: logic confirmed by peer review
- fn_04247 CMCStoreInfoBackupSaveAsyncWork::CMCStoreInfoBackupSaveAsyncWork: logic confirmed by peer review
- fn_04249 CMCStoreInfoBackupSaveAsyncWork::Bind: logic confirmed by peer review
- fn_10247 CSignBoardMgr::Initialize: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, secret, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:43:46 +00:00
ragnarok-clanker
eb92b82f61 Decompile fn_03697 (CLoadPartyInfoAsyncWork::Execute)
Batch #13715 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_03697 CLoadPartyInfoAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 05:42:37 +00:00
ragnarok-clanker
563b50f12c Decompile fn_03716 (CStopRecruitingAsyncWork::Execute)
Batch #13999 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_03716 CStopRecruitingAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 04:16:35 +00:00
ragnarok-clanker
fce5600a0b Decompile fn_18447 (PartyBookingMgr::MakeEntry)
Batch #13182 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_18447 PartyBookingMgr::MakeEntry: logic confirmed by peer review

Peer-reviewed-by: eAthena, Tanke, Toshiro, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 20:23:51 +00:00
ragnarok-clanker
c28907883a Decompile fn_21788 (ReceivePartyJoinResult)
Batch #13300 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_21788 ReceivePartyJoinResult: logic confirmed by peer review

Peer-reviewed-by: Tanke, Toshiro, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 14:31:38 +00:00
ragnarok-clanker
30557a4ee2 Decompile fn_03668 (CAdventurerAgencyMgr::CompleteStopRecruiting)
Batch #13251 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03668 CAdventurerAgencyMgr::CompleteStopRecruiting: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 12:21:40 +00:00
ragnarok-clanker
24dd8ecf83 Decompile fn_03668 (CAdventurerAgencyMgr::CompleteStopRecruiting)
Batch #12354 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03668 CAdventurerAgencyMgr::CompleteStopRecruiting: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 21:12:18 +00:00
ragnarok-clanker
6194c1f1aa Decompile fn_03655 (CAdventurerAgencyMgr::ServiceUrl)
Batch #12532 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03655 CAdventurerAgencyMgr::ServiceUrl: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, gordaoprogramas, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 17:41:17 +00:00
ragnarok-clanker
9cca5ba887 Decompile fn_03666 (CAdventurerAgencyMgr::CompleteRegistration)
Batch #12348 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03666 CAdventurerAgencyMgr::CompleteRegistration: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:02:36 +00:00
ragnarok-clanker
e1f4be4caa Decompile fn_03696 (CLoadPartyInfoAsyncWork::Complete)
Batch #11896 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03696 CLoadPartyInfoAsyncWork::Complete: logic confirmed by peer review

Peer-reviewed-by: KWDev, dori, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:00:02 +00:00
ragnarok-clanker
6d5e430612 Decompile fn_03700 (CLoadPartyListAsyncWork::Bind)
Batch #10622 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03700 CLoadPartyListAsyncWork::Bind: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, Tanke, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 15:33:15 +00:00
ragnarok-clanker
200e2e1a60 Decompile fn_03657 (CAdventurerAgencyMgr::RequestChangeMaster)
Batch #12450 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03657 CAdventurerAgencyMgr::RequestChangeMaster: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev, Toshiro, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 15:28:15 +00:00
ragnarok-clanker
7fba6a39de Decompile 5 functions in Source/Contents/Emblems/EmblemUpload.cpp, Source/Contents/Party/ChangePartyMasterCompletion.cpp, ...
Batch #12417 by cremane: 0 byte-identical, 5 confirmed by peer review.

- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
- fn_03658 CAdventurerAgencyMgr::CompleteChangeMaster: logic confirmed by peer review
- fn_03660 CAdventurerAgencyMgr::CompleteMyParty: logic confirmed by peer review
- fn_03664 CAdventurerAgencyMgr::CompletePartyInfo: logic confirmed by peer review
- fn_03662 CAdventurerAgencyMgr::CompleteList: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 14:58:18 +00:00
ragnarok-clanker
30c77666bf Decompile 3 functions in Source/Contents/Party/LoadPartyInfoAsyncWork.cpp
Batch #12166 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_03692 CLoadPartyInfoAsyncWork::CLoadPartyInfoAsyncWork: logic confirmed by peer review
- fn_03694 CLoadPartyInfoAsyncWork::Bind: logic confirmed by peer review
- fn_03697 CLoadPartyInfoAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: KWDev, SapitoSucio, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:00:14 +00:00
ragnarok-clanker
c65bdc7b82 Decompile 3 functions in Source/Contents/Party/PartyBookingMgr.cpp
Batch #11989 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_18442 PartyBookingMgr::FlushPending: byte-identical
- fn_18448 PartyBookingMgr::OnAdvertisement: byte-identical
- fn_18452 PartyBookingMgr::SetJobs: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 08:08:11 +00:00
ragnarok-clanker
22bec63e15 Decompile fn_21788 (ReceivePartyJoinResult)
Batch #11600 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_21788 ReceivePartyJoinResult: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:49:47 +00:00
ragnarok-clanker
74b509dfc6 Decompile 7 functions in Source/Contents/Party/AgencyRequests.cpp
Batch #11479 by cremane: 0 byte-identical, 7 confirmed by peer review.

- fn_03659 CAdventurerAgencyMgr::RequestMyParty: logic confirmed by peer review
- fn_03661 CAdventurerAgencyMgr::RequestList: logic confirmed by peer review
- fn_03663 CAdventurerAgencyMgr::RequestInfo: logic confirmed by peer review
- fn_03665 CAdventurerAgencyMgr::RequestRegistration: logic confirmed by peer review
- fn_03667 CAdventurerAgencyMgr::RequestSearch: logic confirmed by peer review
- fn_03669 CAdventurerAgencyMgr::RequestStop: logic confirmed by peer review
- fn_03670 CAdventurerAgencyMgr::RequestStop: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:44:31 +00:00
ragnarok-clanker
a5c509728b Decompile 2 functions in Source/Contents/Party/LoadPartyListAsyncWork.cpp
Batch #11447 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_03698 CLoadPartyListAsyncWork::CLoadPartyListAsyncWork: logic confirmed by peer review
- fn_03703 CLoadPartyListAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, Tanke, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:28:52 +00:00
ragnarok-clanker
d21ff433e1 Decompile fn_03664 (CAdventurerAgencyMgr::CompletePartyInfo)
Batch #11092 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_03664 CAdventurerAgencyMgr::CompletePartyInfo: logic confirmed by peer review

Peer-reviewed-by: Yommy, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 23:23:11 +00:00
ragnarok-clanker
6e0d9ab420 Decompile 3 functions in Source/Contents/Party/StopRecruitingAsyncWork.cpp
Batch #10623 by cremane: 0 byte-identical, 3 confirmed by peer review.

- fn_03711 CStopRecruitingAsyncWork::CStopRecruitingAsyncWork: logic confirmed by peer review
- fn_03713 CStopRecruitingAsyncWork::Bind: logic confirmed by peer review
- fn_03716 CStopRecruitingAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:46:18 +00:00
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
d16fdabd7d Decompile 3 functions in Source/Contents/Party/RegisterPartyAsyncWork.cpp
Batch #10566 by cremane: 0 byte-identical, 3 confirmed by peer review.

- fn_03704 CRegisterPartyAsyncWork::CRegisterPartyAsyncWork: logic confirmed by peer review
- fn_03706 CRegisterPartyAsyncWork::Bind: logic confirmed by peer review
- fn_03709 CRegisterPartyAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 17:20:09 +00:00
ragnarok-clanker
3b9f4a1648 Decompile fn_03683 (CChangePartyMasterAsyncWork::Execute)
Batch #10718 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03683 CChangePartyMasterAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 17:01:15 +00:00
ragnarok-clanker
f15059a9ba Decompile fn_03697 (CLoadPartyInfoAsyncWork::Execute)
Batch #10536 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_03697 CLoadPartyInfoAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 16:17:15 +00:00
ragnarok-clanker
2d55a137fc Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is
Batch #10269 by ragnarok-clanker: forced by an admin (2 lower score(s), 6 changed function(s)); checked with 102 compiled unit(s), including every includer of Source/Script/LuaScript.h.
2026-11-03 14:40:29 +00:00
ragnarok-clanker
70f3e36c88 Maintenance: [forced, user-approved] Family G19: remove WindowOrdering, WindowDropDown, WindowMouseHit and the dead WindowMouseCaptur
Batch #10231 by ragnarok-clanker: forced by an admin (5 lower score(s), 39 changed function(s)); checked with 495 compiled unit(s), including every includer of Source/Client/Mode/ModeTooltip.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Lists/UIDropDownBox.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
Deletes: Source/UI/Window/WindowOrdering.h
2026-11-03 10:07:55 +00:00
ragnarok-clanker
33611655e5 Maintenance: [forced, user-approved] Family G17 (coordinator round-5 fixes). (1) ShortcutVisibility.h only held inline UIWindowMgr::S
Batch #10224 by ragnarok-clanker: forced by an admin (0 lower score(s), 2 changed function(s)); checked with 22 compiled unit(s), including every includer of Source/UI/Window/UIWindowMgr.inl, Source/UI/Shortcuts/ShortcutVisibility.h.
Deletes: Source/UI/Shortcuts/ShortcutVisibility.h
2026-11-03 09:09:57 +00:00
ragnarok-clanker
85f98ef6ab Maintenance: [forced, user-approved] Family G16: remove ClientMessenger (reference view over g_session.m_partyMembers +0x17DC / m_fri
Batch #10222 by ragnarok-clanker: forced by an admin (7 lower score(s), 45 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Messenger/ClientMessenger.h.
2026-11-03 01:04:03 +00:00
ragnarok-clanker
8b3ba20b56 Maintenance: [forced, user-approved] Family G9: remove the adventurer-agency bundle family: AgencyRequestContext, StopRecruitingConte
Batch #10208 by ragnarok-clanker: forced by an admin (10 lower score(s), 42 changed function(s)); checked with 119 compiled unit(s), including every includer of Source/Client/ModeBaseEvents.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Configuration/ServiceConfiguration.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/Party/LoadPartyInfoAsyncWork.h, Source/Contents/Party/PartyJoinResult.h, Source/Contents/Party/RegisterPartyAsyncWork.h, Source/Contents/Party/StopRecruitingAsyncWork.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIApplyForPartyWnd.h, Source/UI/Party/UIPartyInfoWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/Contents/Party/AgencyRequestContext.h.
Deletes: Source/Contents/Party/AgencyRequestContext.h
2026-11-02 22:46:30 +00:00
ragnarok-clanker
2360db3c37 Maintenance: [forced, user-approved] Family G3: delete reference-bundle types that have no user anywhere in Source (no includer, no i
Batch #10195 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 11 compiled unit(s), including every includer of Source/Render/DX7/DeviceOwnerDX7.h, Source/Client/ClientOptions.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/SkinInfo.h, Source/Contents/World/WorldActors.h, Source/Render/Textures/ClientTextureSources.h, Source/UI/Chat/ChatNotifications.h, Source/UI/MiniPartyManager.h.
Deletes: Source/Client/ClientOptions.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/SkinInfo.h, Source/Contents/World/WorldActors.h, Source/Render/Textures/ClientTextureSources.h, Source/UI/Chat/ChatNotifications.h, Source/UI/MiniPartyManager.h
2026-11-02 21:20:38 +00:00
ragnarok-clanker
d6bc9836d7 Maintenance: [forced, admin decision] Collapse the WindowManagerWindows adapter into UIWindowMgr, stage 1 of 2 (project decision: por
Batch #10019 by ragnarok-clanker: forced by an admin (23 lower score(s), 187 changed function(s)); checked with 447 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Mode/ModeDragState.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemCache.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/Party/AgencyRequestContext.h, Source/Contents/Party/ChangePartyMasterAsyncWork.h, Source/Contents/Party/LoadMyPartyAsyncWork.h, Source/Contents/Party/LoadPartyInfoAsyncWork.h, Source/Contents/Party/LoadPartyListAsyncWork.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/Party/RegisterPartyAsyncWork.h, Source/Contents/Party/StopRecruitingAsyncWork.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Chat/ChatSuggestions.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Lists/UIListBox.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/UIBasicCtrl.h, Source/UI/UIStaticItem.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/WindowManagerWindows.h, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
2026-11-02 14:09:20 +00:00
ragnarok-clanker
4fd6cd3ad7 Maintenance: Resubmission of batch 9115 rebased onto main (it conflicted with 9108's CommonObject.cpp change, which it already contai
Batch #9132 by ragnarok-clanker: forced by an admin (2 lower score(s), 13 changed function(s)); checked with 22 compiled unit(s), including every includer of Source/Contents/ForbiddenWords.h, Source/Contents/Party/PartyInvitation.h, Source/File/CommonObject.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIPetInfoWnd.h.
2026-11-01 02:10:48 +00:00
ragnarok-clanker
cd97dfd62a Decompile 6 functions in Source/UI/Cooldowns/CooldownState.cpp, Source/UI/Cooldowns/CooldownState.h, ...
Batch #3674 by youko: 0 byte-identical, 6 confirmed by peer review.

- fn_12503 CFlyingShipRouteInfo::CFlyingShipRouteInfo: logic confirmed by peer review
- fn_12505 HotkeyInfo::HotkeyInfo: logic confirmed by peer review
- fn_12507 FlyingShipRouteEntry::FlyingShipRouteEntry: logic confirmed by peer review
- fn_12508 PartyBookingEntry::PartyBookingEntry: logic confirmed by peer review
- fn_12510 UIBattleMsgOptionWnd::UIBattleMsgOptionWnd: logic confirmed by peer review
- fn_12513 UIHotKeyWnd::UIHotKeyWnd: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 01:19:21 +00:00
ragnarok-clanker
84ddf6299e Decompile fn_12502 (CooldownState::CooldownState)
Batch #3933 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_12502 CooldownState::CooldownState: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UIHotKeyWnd.cpp, Source/UI/Window/UIBattleMsgOptionWnd.cpp, Source/Contents/FlyingShipRouteInfo.cpp
2026-10-30 00:07:58 +00:00
ragnarok-clanker
94cfc65317 Decompile 8 functions in Source/Contents/Party/PartyBookingMgr.cpp, Source/Contents/Party/PartyBookingMgr.h, ...
Batch #3181 by eAthena: 0 byte-identical, 8 confirmed by peer review.

- fn_18432 PartyBookingMgr::PartyBookingMgr: logic confirmed by peer review
- fn_18442 PartyBookingMgr::FlushPending: logic confirmed by peer review
- fn_18444 PartyBookingMgr::Remove: logic confirmed by peer review
- fn_18446 PartyBookingMgr::EraseEntry: logic confirmed by peer review
- fn_18447 PartyBookingMgr::MakeEntry: logic confirmed by peer review
- fn_18449 PartyBookingMgr::AddEntries: logic confirmed by peer review
- fn_18451 PartyBookingMgr::SetFilter: logic confirmed by peer review
- fn_18452 PartyBookingMgr::SetJobs: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, superintelligence
Reviewed-by: ragnarok-clanker
2026-10-29 21:50:34 +00:00
ragnarok-clanker
b85cc9c7b4 Decompile 3 functions in Source/UI/Window/UISeekPartyListWnd.cpp, Source/UI/Window/UISeekPartyListWnd.h, ...
Batch #3206 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_12815 UISeekPartyListWnd::NotifyNewAd: logic confirmed by peer review
- fn_12825 UISeekPartyListWnd::MatchesFilter: logic confirmed by peer review
- fn_18448 PartyBookingMgr::OnAdvertisement: logic confirmed by peer review

Peer-reviewed-by: meitogi, alisonrag, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UISeekPartyListWnd.cpp
2026-10-29 21:49:06 +00:00
ragnarok-clanker
303eb3b37b Decompile 2 functions in Source/Contents/Party/PartyBookingMgr.cpp, Source/Contents/Party/PartyBookingMgr.h, ...
Batch #3182 by eAthena: 2 byte-identical, 0 confirmed by peer review.

- fn_18443 PartyBookingMgr::Clear: byte-identical
- fn_18450 PartyBookingMgr::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Party/PartyBookingMgr.cpp
2026-10-29 20:45:05 +00:00