Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
Batch #14829 by secret: 0 byte-identical, 1 confirmed by peer review.
- fn_17818 ReadClientInfo: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, codeplay, raiken, Stingor
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #14920 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_17817 InitializeServiceConfiguration: logic confirmed by peer review
Peer-reviewed-by: Tanke, codeplay, Stingor
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #14824 by secret: 0 byte-identical, 1 confirmed by peer review.
- fn_06317 CGameSettingsMgr::LoadSettings: logic confirmed by peer review
Peer-reviewed-by: kyoshi, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #14832 by secret: 1 byte-identical, 0 confirmed by peer review.
- fn_17811 InitializeLanguage: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #14772 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_06352 ApplyServiceOptionFlags: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #14710 by Yommy: 0 byte-identical, 3 confirmed by peer review.
- fn_17807 GetLicenceText: logic confirmed by peer review
- fn_17808 InitializeServiceStrings: logic confirmed by peer review
- fn_17818 ReadClientInfo: logic confirmed by peer review
Peer-reviewed-by: secret, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #14709 by secret: 0 byte-identical, 2 confirmed by peer review.
- fn_06322 CGameSettingsMgr::ResetToDefaults: logic confirmed by peer review (already on main)
- fn_06323 CGameSettingsMgr::ToggleOption: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #14666 by secret: 0 byte-identical, 1 confirmed by peer review.
- fn_06313 CGameSettingsMgr::RunFunction: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #14661 by secret: 0 byte-identical, 1 confirmed by peer review.
- fn_06312 CGameSettingsMgr::SetOption: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #14397 by superintelligence: 0 byte-identical, 1 confirmed by peer review.
- fn_06323 CGameSettingsMgr::ToggleOption: logic confirmed by peer review
Peer-reviewed-by: Yommy, secret, aDw, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #13993 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_06324 SetOption: logic confirmed by peer review
Peer-reviewed-by: Yommy, KWDev, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #13623 by SapitoSucio: 0 byte-identical, 3 confirmed by peer review.
- fn_17808 InitializeServiceStrings: logic confirmed by peer review
- fn_17811 InitializeLanguage: logic confirmed by peer review
- fn_17818 ReadClientInfo: logic confirmed by peer review
Peer-reviewed-by: eAthena, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #13427 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_06351 SendConfigServiceOption: logic confirmed by peer review
Peer-reviewed-by: eAthena, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #13345 by ragnarok-clanker: forced by an admin (0 lower score(s), 13 changed function(s)); checked with 96 compiled unit(s), including every includer of Source/Client/Application/ClientInfo.h, Source/Contents/Configuration/ServiceConfiguration.h.
Adds to the build: Source/Client/Application/ClientInfo.cpp
Batch #12714 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_06315 CGameSettingsMgr::FindOption: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12614 by Yommy: 0 byte-identical, 15 confirmed by peer review.
- fn_06318 ServiceOptions::Get: logic confirmed by peer review
- fn_06320 CGameSettingsMgr::ApplyScriptOption: logic confirmed by peer review
- fn_06325 ServiceOptions::Set: logic confirmed by peer review
- fn_06352 ApplyServiceOptionFlags: logic confirmed by peer review (already on main)
- fn_06353 ApplyServiceOption: logic confirmed by peer review (already on main)
- fn_06355 ApplyServiceOptionXmasWeather: logic confirmed by peer review (already on main)
- fn_06356 ApplyServiceOptionJitterScale: logic confirmed by peer review (already on main)
- fn_06357 ApplyServiceOptionMapFog: logic confirmed by peer review (already on main)
- fn_06358 ApplyServiceOptionWithNotice: logic confirmed by peer review (already on main)
- fn_06360 ApplyServiceOptionActorRefresh: logic confirmed by peer review (already on main)
- fn_06362 ApplyServiceOptionItemWnd: logic confirmed by peer review (already on main)
- fn_06363 ApplyServiceOptionWeatherFlag: logic confirmed by peer review (already on main)
- fn_06366 ApplyServiceOptionSessionFlag: logic confirmed by peer review (already on main)
- fn_06367 ApplyServiceOptionCursorClip: logic confirmed by peer review (already on main)
- fn_06371 ApplyServiceOptionWindow159: logic confirmed by peer review (already on main)
Peer-reviewed-by: KWDev, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12598 by Yommy: 1 byte-identical, 0 confirmed by peer review.
- fn_17330 Singleton<CGameSettingsMgr>::GetInstance: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #12527 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_24219 CSession::SendClientOption: logic confirmed by peer review
Peer-reviewed-by: Yommy, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12281 by cremane: 3 byte-identical, 0 confirmed by peer review.
- fn_23918 CSession::WriteOptionGuid: byte-identical
- fn_23919 CSession::WriteOptionInteger: byte-identical
- fn_23920 CSession::WriteOptionString: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10843 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.
- fn_45506 DeviceOwnerDX9::CaptureBackBuffer: byte-identical (annotation added to existing code)
- fn_45507 DeviceOwnerDX9::RestoreBackBuffer: byte-identical (annotation added to existing code)
- fn_45508 ReleaseApplicationCursor: logic confirmed by peer review
- fn_06367 ApplyServiceOptionCursorClip: logic confirmed by peer review
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10800 by kyoshi: 0 byte-identical, 2 confirmed by peer review.
- fn_06312 CGameSettingsMgr::sub_6C0C40: logic confirmed by peer review (already on main)
- fn_06322 CGameSettingsMgr::ResetToDefaults: logic confirmed by peer review (already on main)
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10396 by ragnarok-clanker: no function's compiled code changes; checked with 190 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h.
Merged directly by the admin, bypassing peer review, because part of the
original function was overwritten by the client's protector and can never
match. Task 16009 is marked done on purpose; do not resubmit it.
- Jump table 0xAD29E4: modes 0/1 go to 0xAD1E58, now "jmp 0x027AB0FE" into
an empty protector stub. Bytes 0xAD1E58..0xAD237D are garbage.
- The rest of case 0/1 survives from 0xAD237E (g_serviceFlag07 = 29,
strstr(g_launchServerName, "QmSakray"), key/address pair, StringFormat
into g_serviceAddress, then the admin/monster-job tail); ported as is.
- Live WinDbg run (servertype=primary): 0xAD1C90 is never called; the
protector loader in .data6 (sub_3DE8027) replaces it at runtime.
- Based on attempt 57915 (batch 10359), with g_session.unknown_58FA replaced
by g_launchServerName (same address, 0x1737F32). Key/string decryption
verified against the binary. td check --includers: no errors.
Batch #10367 by ragnarok-clanker: no function's compiled code changes; checked with 507 compiled unit(s), including every includer of Source/UI/Edit/UIEditCtrl.h, Source/UI/Window/UIWindowMgr.h.
Batch #10323 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_24372 sub_E5C430: logic confirmed by peer review
Peer-reviewed-by: tester, System4z, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10269 by ragnarok-clanker: forced by an admin (2 lower score(s), 6 changed function(s)); checked with 102 compiled unit(s), including every includer of Source/Script/LuaScript.h.
Batch #10223 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 0 compiled unit(s), including every includer of Source/Contents/Configuration/ScriptOptions.h.
Deletes: Source/Contents/Configuration/ScriptOptions.h
Batch #10221 by ragnarok-clanker: forced by an admin (3 lower score(s), 7 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Configuration/GraphicsConfiguration.h.
Deletes: Source/Contents/Configuration/GraphicsConfiguration.h
Batch #10183 by ragnarok-clanker: forced by an admin (6 lower score(s), 50 changed function(s)); checked with 115 compiled unit(s), including every includer of Source/Client/Input/InputCharset.h, Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/UI/Chat/ChatNotifications.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Text/TextWrapping.h, Source/Client/Input/ImeInput.h.
Deletes: Source/Client/Input/ImeInput.h
Batch #10067 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_06359 ShowHelpMessages: logic confirmed by peer review
Peer-reviewed-by: Qwenkler3.8, cremane, doczeira, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #9986 by ragnarok-clanker: no function's compiled code changes; checked with 177 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h.
Batch #9818 by akreao: 0 byte-identical, 1 confirmed by peer review.
- fn_06317 CGameSettingsMgr::LoadSettings: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #9377 by secret: 0 byte-identical, 3 confirmed by peer review.
- fn_12107 UIChooseWarpWnd::Slot44: logic confirmed by peer review
- fn_12110 UIExchangeWnd::Slot44: logic confirmed by peer review
- fn_12117 UISayDialogWnd::Slot44: logic confirmed by peer review
Peer-reviewed-by: gordaoprogramas, Montyla, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #9151 by KWDev: 0 byte-identical, 1 confirmed by peer review.
- fn_17811 InitializeLanguage: logic confirmed by peer review
Peer-reviewed-by: youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
