Commit graph

30 commits

Author SHA1 Message Date
ragnarok-clanker
c932ad6499 Maintenance: Resubmission of 15134 without the 12 struct/type renames (their new names changed mangled symbols in 17 functions). Rena
Batch #15141 by ragnarok-clanker: no function's compiled code changes; checked with 537 compiled unit(s), including every includer of Source/Client/Input/LanguageTC.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/EnchantMgr.h, Source/Contents/GuildInfo.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TableMng.h, Source/Contents/World/SkyBox.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl.
2026-11-09 12:21:09 +00:00
ragnarok-clanker
bd947f545e Decompile 10 functions in Source/Client/Mode/GameModeNotices.cpp, Source/Client/Session.cpp, ...
Batch #14954 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_21601 ReceiveShortcutPage: byte-identical
- fn_22072 CGameMode::ReceiveRouletteInfo: byte-identical
- fn_23361 CSession::FindUnknown0708: byte-identical
- fn_23362 CSession::FindUnknown0700: byte-identical
- fn_21014 CRenderObject::DrawPulseOutline: byte-identical
- fn_07839 C3dAttr::HeightBounds: byte-identical
- fn_23342 CSession::RemoveItem1750: byte-identical
- fn_10077 RouletteMgr::Update: byte-identical
- fn_09079 CSimpleStringMgr::GetString: byte-identical
- fn_17703 WorldSpatialTree::RefreshBounds: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-08 23:56:15 +00:00
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 13:56:42 +00:00
ragnarok-clanker
858265cc69 Maintenance: Second pass: name remaining numeric switch case labels (identifier-only; no code change). ~3,500 more labels across 150
Batch #14936 by ragnarok-clanker: no function's compiled code changes; checked with 158 compiled unit(s), including every includer of Source/Client/Mode/GameModeEnums.h, Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Contents/Actors/PetEnums.h, Source/Contents/Combat/CombatTypes.h, Source/Contents/Configuration/ServiceEnums.h, Source/Contents/Effects/EffectPrimId.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemId.h, Source/Contents/Items/ItemType.h, Source/Network/Packets/ModeResultEnums.h, Source/Network/Packets/NoticeEnums.h, Source/Network/Packets/PacketId.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 12:37:46 +00:00
ragnarok-clanker
720df40253 Confirm fn_06571 (ITEM_INFO::operator<)
Batch #14836 by kyoshi: 0 byte-identical, 1 confirmed by peer review.

- fn_06571 ITEM_INFO::operator<: logic confirmed by peer review (already on main)

Peer-reviewed-by: ragnarok-clanker, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 19:09:48 +00:00
ragnarok-clanker
86569e4a86 Decompile fn_06561 (ITEM_INFO::ITEM_INFO)
Batch #14427 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_06561 ITEM_INFO::ITEM_INFO: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-07 08:55:39 +00:00
ragnarok-clanker
e8b2f375ed Decompile 10 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Items/ItemInfo.cpp, ...
Batch #13444 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_23807 CSession::GetPetFood: byte-identical
- fn_23813 CSession::GetPetJobByEggItem: byte-identical
- fn_23816 CSession::GetPetString: byte-identical
- fn_20077 CRagEffect::LexDivina: byte-identical
- fn_06573 ITEM_INFO::Assign: byte-identical
- fn_07702 UIMessengerGroupWnd::DropMember: byte-identical
- fn_10118 UIRPData::~UIRPData: byte-identical
- fn_08276 CPlayerSkillBundle::RemoveExtra: byte-identical
- fn_08129 CRuneSystemMgr::GetGradeFailValue: byte-identical
- fn_02432 CSurfaceDX9::Resize: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 17:00:22 +00:00
ragnarok-clanker
f2a8186947 Decompile 2 functions in Source/Contents/Items/ItemInfo.cpp
Batch #12980 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_23386 LookupClientItem: logic confirmed by peer review
- fn_23584 CSession::HasRequiredItems: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 14:28:15 +00:00
ragnarok-clanker
34c2c70dbc Decompile fn_06569 (ITEM_INFO::operator=)
Batch #12740 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_06569 ITEM_INFO::operator=: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 00:21:50 +00:00
ragnarok-clanker
c0cf5af14f Decompile 2 functions in Source/Contents/Items/ItemInfo.cpp
Batch #12523 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_23584 CSession::HasRequiredItems: logic confirmed by peer review
- fn_23591 CSession::HasItemId: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, KWDev, Toshiro, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:50:07 +00:00
ragnarok-clanker
7e8d6a3ac8 Decompile fn_23387 (LookupClientItemByIdentity)
Batch #12413 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_23387 LookupClientItemByIdentity: logic confirmed by peer review

Peer-reviewed-by: KWDev, Toshiro, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 14:49:31 +00:00
ragnarok-clanker
8056824bb4 Decompile 3 functions in Source/Contents/Items/ItemInfo.cpp
Batch #12228 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_06612 ITEM_INFO::Deserialize: logic confirmed by peer review
- fn_06614 LoadItemIntegerTable: logic confirmed by peer review
- fn_23386 LookupClientItem: logic confirmed by peer review

Peer-reviewed-by: KWDev, Tanke, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:25:50 +00:00
ragnarok-clanker
169dd26477 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp
Batch #11955 by Yommy: 1 byte-identical, 3 confirmed by peer review.

- fn_06569 ITEM_INFO::operator=: logic confirmed by peer review
- fn_06573 ITEM_INFO::Assign: logic confirmed by peer review
- fn_06610 ITEM_INFO::SetItemId: byte-identical
- fn_24230 ReadItemArray: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, kyoshi, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 05:44:24 +00:00
ragnarok-clanker
b26c03276d Decompile 2 functions in Source/Contents/ClientItemLists.cpp, Source/Contents/Items/ItemInfo.cpp
Batch #10753 by kyoshi: 0 byte-identical, 2 confirmed by peer review.

- fn_23342 CSession::RemoveItem1750: logic confirmed by peer review
- fn_23348 CSession::RemoveItem1720: logic confirmed by peer review

Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 17:10:39 +00:00
ragnarok-clanker
3001775a62 Decompile fn_06614 (LoadItemIntegerTable)
Batch #6888 by Landruca: 0 byte-identical, 1 confirmed by peer review.

- fn_06614 LoadItemIntegerTable: logic confirmed by peer review

Peer-reviewed-by: eAthena, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 02:12:32 +00:00
ragnarok-clanker
05be22bdcf Decompile 22 functions in Source/Client/Session.h, Source/Contents/Actors/GroundScope.cpp, ...
Batch #4990 by youko: 3 byte-identical, 19 confirmed by peer review.

- fn_24228 ReadMessengerMembers: logic confirmed by peer review
- fn_24229 ReadItemList: logic confirmed by peer review
- fn_24230 ReadItemArray: logic confirmed by peer review
- fn_24232 CSession::SetUnknown5BC0: logic confirmed by peer review
- fn_24236 MessengerMember::Deserialize: logic confirmed by peer review
- fn_24247 ClientItemLists::SetItems1750: logic confirmed by peer review
- fn_24249 AppendBytes: logic confirmed by peer review
- fn_24258 CMsgEffect::~CMsgEffect: logic confirmed by peer review
- fn_24259 CSkill::~CSkill: logic confirmed by peer review
- fn_24267 CGroundScope::SkillScopeType: logic confirmed by peer review
- fn_24268 CSkill::GetTrapModelName: logic confirmed by peer review
- fn_24269 CSkill::ReleaseModel: logic confirmed by peer review
- fn_24270 CMsgEffect::UsesMsgEffect: logic confirmed by peer review
- fn_24275 CGraffiSkill::ReleaseTexture: byte-identical
- fn_24277 CArrowEffect::Reset: logic confirmed by peer review
- fn_24278 CEffectMaker::Reset: byte-identical
- fn_24279 CGraffiSkill::BuildTexture: logic confirmed by peer review
- fn_24280 CArrowEffect::OnProcess: logic confirmed by peer review
- fn_24281 CDummyEffectLauncher::OnProcess: logic confirmed by peer review
- fn_24282 CEffectMaker::OnProcess: logic confirmed by peer review
- fn_24283 CGraffiSkill::OnProcess: byte-identical
- fn_24285 CMandraAttackEffect::OnProcess: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Actors/GraffiSkill.cpp, Source/Contents/Effects/ArrowEffect.cpp, Source/Contents/Effects/DummyEffectLauncher.cpp, Source/Contents/Effects/MandraAttackEffect.cpp, Source/Contents/Effects/MsgEffect.cpp
2026-10-30 06:43:59 +00:00
ragnarok-clanker
9d42b95e16 Decompile 3 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #3508 by youko: 0 byte-identical, 3 confirmed by peer review.

- fn_06599 IsItemCard: logic confirmed by peer review
- fn_06611 ITEM_INFO::SetOption: logic confirmed by peer review
- fn_06613 ITEM_INFO::SetCard: logic confirmed by peer review

Peer-reviewed-by: meitogi, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:45:23 +00:00
ragnarok-clanker
9bf2a922a8 Decompile fn_06612 (ITEM_INFO::Deserialize)
Batch #3330 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06612 ITEM_INFO::Deserialize: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:27:15 +00:00
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
a591f8908d Decompile 6 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1876 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_19844 EffectParticle::PrimThrowItem: logic confirmed by peer review (annotation added to existing code)
- fn_19822 EffectParticle::PrimPeong: logic confirmed by peer review (annotation added to existing code)
- fn_19810 EffectParticle::PrimGI3: logic confirmed by peer review (annotation added to existing code)
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review (already on main)
- fn_04106 ItemInfo::GetItemId: logic confirmed by peer review (annotation added to existing code)
- fn_12589 ShortcutDrop::Drop: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-28 23:10:29 +00:00
ragnarok-clanker
81e812ea39 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1869 by ragnarok-clanker: 3 byte-identical, 0 confirmed by peer review.

- fn_19971 EffectParticle::PrimWaterFall: byte-identical
- fn_21090 CGameActor::ProcessBodyState: byte-identical
- fn_12629 UIShortCutWnd::Slot03: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-10-28 23:05:45 +00:00
ragnarok-clanker
018dee6278 Decompile 15 functions in Source/Client/Session.h, Source/Client/Replay.cpp, ...
Batch #1712 by ragnarok-clanker: 0 byte-identical, 15 confirmed by peer review.

- fn_06570 ItemInfo::AssignBasic: logic confirmed by peer review
- fn_06607 SearchItemIds: logic confirmed by peer review
- fn_06608 MatchItemName: logic confirmed by peer review
- fn_06582 FindMetalProcessItems: logic confirmed by peer review
- fn_06590 ItemInfo::Serialize: logic confirmed by peer review
- fn_06544 FindItemCardName: logic confirmed by peer review
- fn_23291 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23297 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23584 CSession::HasRequiredItems: logic confirmed by peer review
- fn_23588 CSession::IsSlotItemIdentity: logic confirmed by peer review
- fn_23589 CSession::HasInventoryItem: logic confirmed by peer review
- fn_23591 CSession::HasItemId: logic confirmed by peer review
- fn_23592 CSession::HasItemCount: logic confirmed by peer review
- fn_23582 IsScreenShakeActive: logic confirmed by peer review
- fn_23908 CSession::SetPlayerNameKey: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:47:17 +00:00
ragnarok-clanker
8125ad1ce1 Decompile fn_06623 (BuildReplayTaggedRecord)
Batch #1714 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06623 BuildReplayTaggedRecord: logic confirmed by peer review (annotation added to existing code)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:43:04 +00:00
ragnarok-clanker
79c8823d57 Decompile fn_06602 (IsNumericText)
Batch #1373 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_06602 IsNumericText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:05:19 +00:00
ragnarok-clanker
dc2307a00e Decompile 3 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h
Batch #1368 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_06601 ItemInfo::IsForgeMaterial: logic confirmed by peer review
- fn_06604 ItemInfo::IsElementalStone: logic confirmed by peer review
- fn_06605 ItemInfo::IsAboveItemId600: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:44:10 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 10:35:18 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard)
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:19:34 +00:00
ragnarok-clanker
82a645387c Decompile 3 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h
Batch #1209 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_06571 ItemInfo::operator<: logic confirmed by peer review
- fn_06609 ItemInfo::SetName: logic confirmed by peer review
- fn_06610 ItemInfo::SetItemId: logic confirmed by peer review

Peer-reviewed-by: Kisuka, eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:09:14 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
Renamed from Source/Contents/ItemInfo.cpp (Browse further)