Batch #10562 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_19761 CEffectPrim::CEffectPrim: logic confirmed by peer review
Peer-reviewed-by: Yommy, Lumen, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11228 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_13807 UINewSkillListWnd::VisibleSkill: logic confirmed by peer review (already on main)
- fn_13813 UINewSkillListWnd::IsSkillArea: logic confirmed by peer review (already on main)
Peer-reviewed-by: kyoshi, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11227 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_01847 BitmapPixels::UploadTexture: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Yommy, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11226 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_13807 UINewSkillListWnd::VisibleSkill: logic confirmed by peer review
- fn_13813 UINewSkillListWnd::IsSkillArea: logic confirmed by peer review
Peer-reviewed-by: kyoshi, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11222 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_18385 PacketLengths::Register: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10638 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_08073 C3dWorldRes::Load: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11218 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_11353 UIComboBoxEx2::Paint: logic confirmed by peer review (already on main)
Peer-reviewed-by: ragnarok-clanker, Yommy, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11217 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_11513 UIListBoxEx::Refresh: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Yommy, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10793 by StrawberrysherbetIX: 0 byte-identical, 2 confirmed by peer review.
- fn_21832 CGameMode::ReceiveEquipItemList: logic confirmed by peer review (already on main)
- fn_24247 CSession::SetItems1750: logic confirmed by peer review (already on main)
Peer-reviewed-by: SapitoSucio, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10839 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_23638 CSession::SetHotkeyDescription: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10832 by dori: 1 byte-identical, 0 confirmed by peer review.
- fn_45511 CUIEquipmentPropertiesWnd::OnClickClose: byte-identical (annotation added to existing code)
Peer-reviewed-by: SapitoSucio, cremane, StrawberrysherbetIX
Merged automatically: every function is byte-identical to the original.
Batch #10928 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_22272 CLoginMode::GetMaxCharacterSlot: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11209 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_22309 CLoginMode::PollNetworkStatus: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10865 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_10490 CCreateLineInfo::ParseLink: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11206 by dori: 0 byte-identical, 5 confirmed by peer review.
- fn_11743 UIMakeCharWnd::Slot15: logic confirmed by peer review
- fn_11814 UIReplayRECControlWnd::SendMsg: logic confirmed by peer review
- fn_11815 UISelectReplayDataWnd::SendMsg: logic confirmed by peer review
- fn_11816 UISelectServerWnd::SendMsg: logic confirmed by peer review
- fn_11804 UILoginOTPWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10973 by dori: 1 byte-identical, 0 confirmed by peer review.
- fn_13561 UIMiniMapWnd::ResetCursor: byte-identical
Peer-reviewed-by: Yommy, cremane, StrawberrysherbetIX
Merged automatically: every function is byte-identical to the original.
Batch #10876 by cremane: 1 byte-identical, 1 confirmed by peer review.
- fn_10328 UIShowInfoWnd::ResetCheckBoxes: logic confirmed by peer review
- fn_10357 UIStylingShopButton::Slot28: byte-identical
Peer-reviewed-by: Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10812 by StrawberrysherbetIX: 0 byte-identical, 2 confirmed by peer review.
- fn_10315 UIStylingShopWnd::RefreshFavoriteButton: logic confirmed by peer review (already on main)
- fn_10368 UIAccessoryShowCase::SendMsg: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11032 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_17412 BrowserAddressEditProc: byte-identical
Peer-reviewed-by: Yommy, kyoshi, StrawberrysherbetIX
Merged automatically: every function is byte-identical to the original.
Batch #11200 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_12883 UIGuild_Storage_Log::FillRows: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Toshiro, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10877 by StrawberrysherbetIX: 0 byte-identical, 3 confirmed by peer review.
- fn_03478 CAccountLinkedUserDataSaveAsyncWork::CAccountLinkedUserDataSaveAsyncWork: logic confirmed by peer review
- fn_03480 CAccountLinkedUserDataSaveAsyncWork::Bind: logic confirmed by peer review
- fn_03483 CAccountLinkedUserDataSaveAsyncWork::Execute: logic confirmed by peer review (already on main)
Peer-reviewed-by: SapitoSucio, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11197 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_09598 UINewSelectCharWnd::sub_7D9310: logic confirmed by peer review (already on main)
Peer-reviewed-by: ragnarok-clanker, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11192 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_10554 UIBarterItemPurchaseWnd::Paint: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
CRC32, FileSignatureVerifier, GGHash, MD5 and Hash/MD5 are the objects at 0x401000-0x403960, built by an older compiler: 0 of 152 functions there use an ebp frame and all 21 /GS cookies use the esp form, with /EHs-style FuncInfo. Shape 10 is shape 0 without /Oy- and with /EHsc. Dry run on the server compilers: 40 functions, mean 48.3% -> 60.2%, 27 up, 3 down (fn_00144 0.53 -> 0.25, fn_00116, fn_00117 by < 0.011), exact unchanged.
Batch #10808 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_18112 PakRegistry::Read: logic confirmed by peer review (already on main)
Peer-reviewed-by: Toshiro, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Main is clean (07897c8b): every FUNCTION line has its address right
above it. offsetAnnotations makes the submission gate keep it that way.
CODING_RULES section 2: OFFSET goes on the line directly above each
FUNCTION line, never without one, with no blank line in the block;
several IDs on one body only for template instances.
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
Batch #11181 by StrawberrysherbetIX: 1 byte-identical, 0 confirmed by peer review.
- fn_10937 UIEditCtrl::Background: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10976 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_13772 UIScrollWnd::~UIScrollWnd: logic confirmed by peer review (already on main)
Peer-reviewed-by: Toshiro, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11177 by StrawberrysherbetIX: 2 byte-identical, 0 confirmed by peer review.
- fn_23891 CSession::IsSuperNovice2Job: byte-identical
- fn_23892 CSession::IsSuperNoviceJob: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #11176 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_08123 RuneSetData::CountActiveSlots: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #11145 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_02758 ContainsText: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10706 by dori: 0 byte-identical, 3 confirmed by peer review.
- fn_04822 GPakEx::SecureByteBuffer::~SecureByteBuffer: logic confirmed by peer review
- fn_04823 GPakEx::BlockCipher::~BlockCipher: logic confirmed by peer review
- fn_04825 GPakEx::BlockCipher::ScalarDeletingDestructor: logic confirmed by peer review
Peer-reviewed-by: SapitoSucio, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11170 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_17178 UIWindowMgr::LoadUIRectInfo: logic confirmed by peer review
Peer-reviewed-by: Tanke, Toshiro, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11169 by kyoshi: 0 byte-identical, 3 confirmed by peer review.
- fn_09236 UIAchTab::Slot27: logic confirmed by peer review (already on main)
- fn_09246 UIAchTab::SendMsg: logic confirmed by peer review (already on main)
- fn_09253 UIAchievementWnd::SelectTab: logic confirmed by peer review (already on main)
Peer-reviewed-by: Toshiro, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11168 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_03961 CCURLPostHander::WriteResponse: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #11167 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_17681 WorldSpatialTree::ReadBounds: logic confirmed by peer review
Peer-reviewed-by: kyoshi, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11165 by dori: 0 byte-identical, 2 confirmed by peer review.
- fn_04194 UILapineUpgradeBoxWnd::Slot10: logic confirmed by peer review
- fn_04209 UILapineUpgradeBox_IngredientInfoWnd::Slot28: logic confirmed by peer review
Peer-reviewed-by: kyoshi, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11164 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_10277 C3DCooRendering::SetWindowImage: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10985 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_05566 L_AddPerfectEnchant: logic confirmed by peer review (already on main)
Peer-reviewed-by: cremane, raiken, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11161 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_01993 DeviceStateDX9::Begin: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10951 by kyoshi: 0 byte-identical, 2 confirmed by peer review.
- fn_02260 ApplyDepthAlpha: logic confirmed by peer review (already on main)
- fn_02261 ApplyDepthAlpha: logic confirmed by peer review (already on main)
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10720 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_23579 IsNavigationActive: logic confirmed by peer review
- fn_23909 CSession::InsertPair: logic confirmed by peer review
Peer-reviewed-by: Toshiro, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11154 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_09650 UICheckAttendanceWnd_Banner::CreateButtons: logic confirmed by peer review
Peer-reviewed-by: kyoshi, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11027 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_14482 CUIGameItem::Slot28: logic confirmed by peer review
Peer-reviewed-by: kyoshi, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10869 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_03885 UIChangeMaterialWnd_List::Slot28: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11106 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_10917 UIEmblemWnd::SendMsg: byte-identical
Merged automatically: every function is byte-identical to the original.
