clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
677 commits 1 branch 0 tags 7.8 MiB
Commit graph

27 commits

Author SHA1 Message Date
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
833db84d60 Decompile fn_23772 (CSession::CountProhibitionLog) 
Batch #2037 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23772 CSession::CountProhibitionLog: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 09:55:21 +00:00
ragnarok-clanker
a748c78604 Decompile 3 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h, ... 
Batch #1940 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_23761 ShortcutBindings::ClearAdditionalSkills: logic confirmed by peer review
- fn_23768 CharacterConfigSave::SkillLevel: logic confirmed by peer review
- fn_23778 CSession::FindGameActor: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy
Reviewed-by: ragnarok-clanker
 2026-10-29 00:11:41 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ... 
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:49:51 +00:00
ragnarok-clanker
4739b61323 Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h 
Batch #1828 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_23763 CSession::DeleteProhibitionLog: logic confirmed by peer review
- fn_23771 CSession::DecodePlayerName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:48:17 +00:00
ragnarok-clanker
f07e52ffeb 🔥 refactor(effects): removed unused header includes 2026-10-28 23:14:51 +01:00
ragnarok-clanker
41b839b378 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-28 23:14:46 +01:00
ragnarok-clanker
4c22f54ad0 🔥 refactor(effects): removed unused header includes 2026-10-28 23:13:11 +01:00
ragnarok-clanker
5a44997d9c Decompile 22 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1769 by Yommy: 0 byte-identical, 22 confirmed by peer review.

- fn_08327 CEfstAction_ChangeSize::Slot01: logic confirmed by peer review
- fn_08328 CEfstAction_ChangeSize::Slot02: logic confirmed by peer review
- fn_08331 CEfstAction_GenderChange::Slot02: logic confirmed by peer review
- fn_08334 CEfstAction_ShowEffect::Slot02: logic confirmed by peer review
- fn_08335 CSkillAction_RA_UNLIMIT::Slot08: logic confirmed by peer review
- fn_08339 CEfstAction_UNLIMIT::Slot02: logic confirmed by peer review
- fn_08346 CEfstAction_SHADOW_WEAPON::Slot03: logic confirmed by peer review
- fn_08347 CEfstAction_SHADOW_WEAPON::Slot04: logic confirmed by peer review
- fn_08359 CEfstAction_DANCING_KNIFE::Slot02: logic confirmed by peer review
- fn_08366 CEfstAction_SHADOW_EXCEED::Slot01: logic confirmed by peer review
- fn_08367 CEfstAction_SHADOW_EXCEED::Slot02: logic confirmed by peer review
- fn_08368 CEfstAction_SHADOW_EXCEED::Slot03: logic confirmed by peer review
- fn_08369 CEfstAction_SHADOW_EXCEED::Slot04: logic confirmed by peer review
- fn_08404 CSkillActionMgr::ActionSlot01: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_08406 CSkillActionMgr::EfstSlot03: logic confirmed by peer review
- fn_08407 CSkillActionMgr::EfstSlot04: logic confirmed by peer review
- fn_08408 CSkillActionMgr::ActionSlot14: logic confirmed by peer review
- fn_08409 CSkillActionMgr::ActionSlot02: logic confirmed by peer review
- fn_08410 CSkillActionMgr::ActionSlot03: logic confirmed by peer review
- fn_08411 CSkillActionMgr::ActionSlot04: logic confirmed by peer review
- fn_08412 CSkillActionMgr::HasEfstAction: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:12:43 +00:00
ragnarok-clanker
be749d87c8 Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1771 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_08371 CSkillAction_ABC_CHASING_BREAK::Slot07: byte-identical
- fn_08375 CSkillAction_ABC_CHASING_SHOT::Slot07: byte-identical
- fn_08385 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot03: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 22:12:16 +00:00
ragnarok-clanker
eba26963c9 Add SkillId enum and name SkillInfo skill helpers 
SkillId.h: the full SKID table (1929 entries) from skillinfoz/skillid.lua. SkillInfo.cpp: every numeric skill ID replaced by its SkillId name; Sub773A00/Sub773CB0/Sub773CD0/Sub7745B0/CSkillActionMgr::Sub77B4A0 renamed IsOptionalSelfTargetSkill/HidesUseFailureMessage/IsSupportSkill/ShowsCastEffect/CSkillActionMgr::IsSupportAction from their call sites; CSkillInfo::operator= copies scalars by assignment instead of memcpy. Compiled code unchanged (all includers checked).
 2026-10-28 22:19:15 +01:00
ragnarok-clanker
21ea249664 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1707 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_08322 Sub773CD0: logic confirmed by peer review
- fn_08413 CSkillActionMgr::Sub77B4A0: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:39:14 +00:00
ragnarok-clanker
b677bdbc59 Decompile 3 functions in Source/Client/Session.cpp, Source/Client/Session.h, ... 
Batch #1704 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_24179 CSession::IsDoramJob: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review
- fn_19754 EquipmentResourceMgr::GetBodyRacePrefix: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 20:33:49 +00:00
ragnarok-clanker
a13f7d9125 Decompile fn_08285 (IsIndexedSkill) 
Batch #1690 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_08285 IsIndexedSkill: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:21:09 +00:00
ragnarok-clanker
9aea62bd9b Decompile 47 functions in Source/Client/ClientOptions.cpp, Source/Client/Session.h, ... 
Batch #1675 by ragnarok-clanker: 2 byte-identical, 45 confirmed by peer review.

- fn_10839 UIButton::Slot25: logic confirmed by peer review
- fn_10852 UIButton::Slot31: logic confirmed by peer review
- fn_10868 UIButton::Slot27: logic confirmed by peer review
- fn_10930 UIStaticBitmap::SetBitmap: logic confirmed by peer review
- fn_10931 UIBitmapButton::SetBitmap: logic confirmed by peer review
- fn_11320 UIComboBoxEx2::Slot15: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review
- fn_11381 UIScrollBar::Paint: logic confirmed by peer review
- fn_11383 UIScrollBar_Navi::Paint: logic confirmed by peer review
- fn_11425 UIScrollBar::Slot25: logic confirmed by peer review
- fn_11440 UIScrollBar::Slot31: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review
- fn_11468 UIScrollBar::Slot27: logic confirmed by peer review
- fn_11471 UITextButton::Slot27: logic confirmed by peer review
- fn_11494 UITextButton::Slot33: logic confirmed by peer review
- fn_11779 UIFrameWnd::Slot25: logic confirmed by peer review
- fn_11781 UIFrameWnd::Slot31: logic confirmed by peer review
- fn_11786 UIFrameWnd::Slot27: logic confirmed by peer review
- fn_12610 CSession::GetOption: logic confirmed by peer review
- fn_12689 ActivateShortcut: logic confirmed by peer review
- fn_12711 ShortcutTooltip::Hover: logic confirmed by peer review
- fn_12724 ShortcutDetails::Open: logic confirmed by peer review (already on main)
- fn_12760 UIShortCutWnd::SendMsg: logic confirmed by peer review
- fn_17144 UIWindowMgr::RemoveOrder: logic confirmed by peer review
- fn_17158 UIWindowMgr::Capture: byte-identical
- fn_17180 UIWindowMgr::BringToFront: logic confirmed by peer review
- fn_17192 UIWindowMgr::IsOrderFixed: logic confirmed by peer review
- fn_17232 UIWindowMgr::ReleaseCapture: byte-identical
- fn_17255 UIWindowMgr::SetCapture: logic confirmed by peer review
- fn_20382 CConnection::CConnection: logic confirmed by peer review
- fn_20383 CRagConnection::CRagConnection: logic confirmed by peer review
- fn_20384 CConnection::~CConnection: logic confirmed by peer review (already on main)
- fn_20389 CConnection::Connect: logic confirmed by peer review
- fn_20390 CConnection::Close: logic confirmed by peer review
- fn_20409 GetRagConnection: logic confirmed by peer review
- fn_21406 AutomaticSkills::Complete: logic confirmed by peer review
- fn_03927 CCharacterLinkedUserDataMgr::CompleteLoad: logic confirmed by peer review
- fn_03933 CCharacterLinkedUserDataMgr::Save: logic confirmed by peer review
- fn_03937 CSession::SetOption: logic confirmed by peer review
- fn_11073 UIScrollBar::UIScrollBar: logic confirmed by peer review
- fn_11102 UIComboBoxEx2::~UIComboBoxEx2: logic confirmed by peer review (already on main)
- fn_09150 AutomaticSkills::DisableAll: logic confirmed by peer review
- fn_09153 AutomaticSkills::Use: logic confirmed by peer review
- fn_10689 UIBitmapButton::~UIBitmapButton: logic confirmed by peer review (already on main)
- fn_10795 UIBitmapButton::Paint: logic confirmed by peer review
- fn_10817 UIStaticBitmap::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:01:00 +00:00
ragnarok-clanker
4f0d60a4a7 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #1595 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_08320 Sub773A00: logic confirmed by peer review
- fn_08324 Sub7745B0: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-28 19:42:33 +00:00
ragnarok-clanker
16b72c624f Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Contents/Skills/ClientSkills.h, ... 
Batch #1471 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23753 CSession::ResetItems2B50: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 15:32:17 +00:00
ragnarok-clanker
c8d7550973 Decompile fn_08321 (Sub773CB0) 
Batch #1342 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_08321 Sub773CB0: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-28 11:00:58 +00:00
ragnarok-clanker
d766d07a84 Decompile fn_08319 (Sub7739F0) 
Batch #1224 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_08319 Sub7739F0: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 21:41:40 +00:00
ragnarok-clanker
5ea6f2488e Decompile 19 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h 
Batch #1178 by eAthena: 0 byte-identical, 19 confirmed by peer review.

- fn_23741 CSession::UpdateHomunSkill: logic confirmed by peer review
- fn_23742 CSession::UpdateMercSkill: logic confirmed by peer review
- fn_23743 CSession::AddUnknownId: logic confirmed by peer review
- fn_23747 CSession::AddStackedItem: logic confirmed by peer review
- fn_23748 CSession::AddItemToFreeSlot: logic confirmed by peer review
- fn_23752 CSession::IsListedId: logic confirmed by peer review
- fn_23760 CSession::EraseUnknownKey: logic confirmed by peer review
- fn_23764 CSession::FindUnknown0784: logic confirmed by peer review
- fn_23765 CSession::FindUnknown078C: logic confirmed by peer review
- fn_23766 CSession::FindRecord6144: logic confirmed by peer review
- fn_23769 CSession::GetBeginEffectId: logic confirmed by peer review
- fn_23773 CSession::GetItem2B50: logic confirmed by peer review
- fn_23775 CSession::SplitDate: logic confirmed by peer review
- fn_23776 CSession::GetDefaultOptionValue: logic confirmed by peer review
- fn_23777 CSession::FindUnknown0778: logic confirmed by peer review
- fn_23779 CSession::AdditionalSkillAt: logic confirmed by peer review
- fn_23781 CSession::HomunSkillAt: logic confirmed by peer review
- fn_23902 CSession::NotifyHomunSkillWindows: logic confirmed by peer review
- fn_23903 CSession::NotifyMercSkillWindows: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 21:06:59 +00:00
ragnarok-clanker
ab4477de24 Decompile 7 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h 
Batch #1179 by eAthena: 7 byte-identical, 0 confirmed by peer review.

- fn_23754 CSession::ClearItemQuantities: byte-identical
- fn_23755 CSession::ResetItems3500: byte-identical
- fn_23756 CSession::ClearSlots06EB: byte-identical
- fn_23757 CSession::ClearShortcutSlots: byte-identical
- fn_23758 CSession::ClearSecondaryShortcutSlots: byte-identical
- fn_23759 CSession::ClearUnknown0420: byte-identical
- fn_23774 CSession::CountItems5C68: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 20:58:12 +00:00
ragnarok-clanker
9ac3d05245 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Contents headers (part 2: Items, Models, Movies, Skills, 
Batch #1063 by ragnarok-clanker: no function's compiled code changes; checked with 62 compiled unit(s), including every includer of Source/Contents/Items/ItemNaming.h, Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelRendering.h, Source/Contents/Models/ModelSpatial.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/Movies/BinkMovies.h, Source/Contents/PlayerNameDictionary.h, Source/Contents/Skills/AutomaticSkills.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/WorldModelLoading.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldRayQuery.h.
 2026-10-27 13:52:05 +00:00
ragnarok-clanker
779dd40d2e 🛠️ refactor(source): annotated inlined functions and removed unused include 2026-10-27 10:01:19 +01:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections 
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
 2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems 
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
 2026-10-25 07:42:41 +00:00