ragnarok-clanker
d7862ef5c4
Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ...
...
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.
- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review
Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:49:51 +00:00
ragnarok-clanker
f07e52ffeb
🔥 refactor(effects): removed unused header includes
2026-10-28 23:14:51 +01:00
ragnarok-clanker
41b839b378
Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp
2026-10-28 23:14:46 +01:00
ragnarok-clanker
4c22f54ad0
🔥 refactor(effects): removed unused header includes
2026-10-28 23:13:11 +01:00
ragnarok-clanker
5a44997d9c
Decompile 22 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h
...
Batch #1769 by Yommy: 0 byte-identical, 22 confirmed by peer review.
- fn_08327 CEfstAction_ChangeSize::Slot01: logic confirmed by peer review
- fn_08328 CEfstAction_ChangeSize::Slot02: logic confirmed by peer review
- fn_08331 CEfstAction_GenderChange::Slot02: logic confirmed by peer review
- fn_08334 CEfstAction_ShowEffect::Slot02: logic confirmed by peer review
- fn_08335 CSkillAction_RA_UNLIMIT::Slot08: logic confirmed by peer review
- fn_08339 CEfstAction_UNLIMIT::Slot02: logic confirmed by peer review
- fn_08346 CEfstAction_SHADOW_WEAPON::Slot03: logic confirmed by peer review
- fn_08347 CEfstAction_SHADOW_WEAPON::Slot04: logic confirmed by peer review
- fn_08359 CEfstAction_DANCING_KNIFE::Slot02: logic confirmed by peer review
- fn_08366 CEfstAction_SHADOW_EXCEED::Slot01: logic confirmed by peer review
- fn_08367 CEfstAction_SHADOW_EXCEED::Slot02: logic confirmed by peer review
- fn_08368 CEfstAction_SHADOW_EXCEED::Slot03: logic confirmed by peer review
- fn_08369 CEfstAction_SHADOW_EXCEED::Slot04: logic confirmed by peer review
- fn_08404 CSkillActionMgr::ActionSlot01: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_08406 CSkillActionMgr::EfstSlot03: logic confirmed by peer review
- fn_08407 CSkillActionMgr::EfstSlot04: logic confirmed by peer review
- fn_08408 CSkillActionMgr::ActionSlot14: logic confirmed by peer review
- fn_08409 CSkillActionMgr::ActionSlot02: logic confirmed by peer review
- fn_08410 CSkillActionMgr::ActionSlot03: logic confirmed by peer review
- fn_08411 CSkillActionMgr::ActionSlot04: logic confirmed by peer review
- fn_08412 CSkillActionMgr::HasEfstAction: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-28 22:12:43 +00:00
ragnarok-clanker
be749d87c8
Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h
...
Batch #1771 by Yommy: 3 byte-identical, 0 confirmed by peer review.
- fn_08371 CSkillAction_ABC_CHASING_BREAK::Slot07: byte-identical
- fn_08375 CSkillAction_ABC_CHASING_SHOT::Slot07: byte-identical
- fn_08385 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot03: byte-identical
Merged automatically: every function is byte-identical to the original.
2026-10-28 22:12:16 +00:00
ragnarok-clanker
eba26963c9
Add SkillId enum and name SkillInfo skill helpers
...
SkillId.h: the full SKID table (1929 entries) from skillinfoz/skillid.lua. SkillInfo.cpp: every numeric skill ID replaced by its SkillId name; Sub773A00/Sub773CB0/Sub773CD0/Sub7745B0/CSkillActionMgr::Sub77B4A0 renamed IsOptionalSelfTargetSkill/HidesUseFailureMessage/IsSupportSkill/ShowsCastEffect/CSkillActionMgr::IsSupportAction from their call sites; CSkillInfo::operator= copies scalars by assignment instead of memcpy. Compiled code unchanged (all includers checked).
2026-10-28 22:19:15 +01:00
ragnarok-clanker
21ea249664
Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h
...
Batch #1707 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.
- fn_08322 Sub773CD0: logic confirmed by peer review
- fn_08413 CSkillActionMgr::Sub77B4A0: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-28 20:39:14 +00:00
ragnarok-clanker
4f0d60a4a7
Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp
...
Batch #1595 by eAthena: 0 byte-identical, 2 confirmed by peer review.
- fn_08320 Sub773A00: logic confirmed by peer review
- fn_08324 Sub7745B0: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
2026-10-28 19:42:33 +00:00
ragnarok-clanker
c8d7550973
Decompile fn_08321 (Sub773CB0)
...
Batch #1342 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_08321 Sub773CB0: logic confirmed by peer review
Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-28 11:00:58 +00:00
ragnarok-clanker
d766d07a84
Decompile fn_08319 (Sub7739F0)
...
Batch #1224 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.
- fn_08319 Sub7739F0: byte-identical
Merged automatically: every function is byte-identical to the original.
2026-10-27 21:41:40 +00:00
ragnarok-clanker
a47d20f8be
Reconstruct readable C++ and organize cohesive source subsystems
...
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.
Previous head: 35d2a8cb36
2026-10-25 07:42:41 +00:00
