clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
742 commits 1 branch 0 tags 9 MiB
Commit graph

21 commits

Author SHA1 Message Date
ragnarok-clanker
46d4abaff3 Decompile 2 functions in Source/Contents/Sound/SoundMaker.cpp 
Batch #2167 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_22400 CHalluNPC::OnProcess: logic confirmed by peer review
- fn_22402 CHalluPC::OnProcess: logic confirmed by peer review

Peer-reviewed-by: ntrl
Reviewed-by: ragnarok-clanker
 2026-10-29 15:06:11 +00:00
ragnarok-clanker
bc2b7572e1 Decompile 2 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Actors/Pc.h 
Batch #2157 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_22429 CPc::Slot59: logic confirmed by peer review
- fn_22430 CPc::Slot57: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 14:44:33 +00:00
ragnarok-clanker
cd47fe84d3 Rename CGameObject virtuals to DHXJ names across the actor hierarchy: Update->OnProcess, SendObjectMessage->SendMsg, Draw->Render, Direction->Get8Dir, SetScreenBounds->SetRenderInfo, SetScreenPosition->SetTlvert, SetAnimation->SetAction. Pure rename, codegen unchanged (314/314 functions identical with includers). 2026-10-29 14:01:33 +01:00
ragnarok-clanker
dc2f3a8f88 Align method names with DHXJ (call-graph matches): CEffectPrim::Prim3DParticle/Prim3DParticleNoMaster/Prim3DParticleOrbit, matrix::AppendScale/AppendXRotation/AppendZRotation/AppendTranslate/MakeYRotation/MakeZRotation, CRenderObject::CalcDist (2 overloads). Pure rename, codegen unchanged (504/504 functions identical with includers). 2026-10-29 13:12:37 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
5b51184749 Decompile 20 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h, ... 
Batch #2111 by ragnarok-clanker: 0 byte-identical, 20 confirmed by peer review.

- fn_21042 CGameActor::GetEffectiveJob: logic confirmed by peer review
- fn_03042 CGameActor::Slot62: logic confirmed by peer review
- fn_03046 CGameActor::GetExtent: logic confirmed by peer review
- fn_03048 CGameActor::Slot45: logic confirmed by peer review
- fn_03054 CGameActor::Slot48: logic confirmed by peer review
- fn_03062 CGameActor::Slot47: logic confirmed by peer review
- fn_21040 CGameActor::Slot55: logic confirmed by peer review
- fn_21048 CGameActor::Slot51: logic confirmed by peer review
- fn_21052 CGameActor::Slot53: logic confirmed by peer review
- fn_21135 CGameActor::Slot49: logic confirmed by peer review
- fn_23576 CSession::IsNpcJob: logic confirmed by peer review
- fn_23792 CSession::GetPairValue: logic confirmed by peer review
- fn_23872 CSession::IsGuardianJob: logic confirmed by peer review
- fn_23887 CSession::IsPlayerJobId: logic confirmed by peer review
- fn_22615 CGrannyPc::Slot40: logic confirmed by peer review
- fn_22616 CPc::Slot40: logic confirmed by peer review
- fn_22621 CGrannyPc::Slot41: logic confirmed by peer review
- fn_22622 CPc::Slot41: logic confirmed by peer review
- fn_22625 CPc::Slot47: logic confirmed by peer review
- fn_22383 CPc::Slot35: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 10:59:31 +00:00
ragnarok-clanker
7f8b1faa57 Decompile 18 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h, ... 
Batch #2112 by ragnarok-clanker: 18 byte-identical, 0 confirmed by peer review.

- fn_03043 CGameActor::Slot46: byte-identical
- fn_03044 CGameActor::Slot13: byte-identical
- fn_03045 CGameActor::Slot50: byte-identical
- fn_03047 CGameActor::Slot58: byte-identical
- fn_03049 CGameActor::Slot56: byte-identical
- fn_03050 CGameActor::Slot42: byte-identical
- fn_03051 CGameActor::Slot35: byte-identical
- fn_03057 CGameActor::Slot40: byte-identical
- fn_03059 CGameActor::Slot59: byte-identical
- fn_03060 CGameActor::Slot57: byte-identical
- fn_03061 CGameActor::Slot41: byte-identical
- fn_03068 CGameActor::Slot60: byte-identical
- fn_03071 CGameActor::Slot43: byte-identical
- fn_22636 CPc::Slot60: byte-identical
- fn_22378 CPc::Slot46: byte-identical
- fn_22380 CPc::Slot58: byte-identical
- fn_22381 CPc::Slot56: byte-identical
- fn_22382 CPc::Slot42: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 10:36:51 +00:00
ragnarok-clanker
3a6bebae77 Decompile 7 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/Player.cpp, ... 
Batch #2092 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_21037 CGameActor::Slot37: logic confirmed by peer review
- fn_21074 CGameActor::Slot38: logic confirmed by peer review
- fn_21199 CGameActor::Slot39: logic confirmed by peer review
- fn_22619 CGrannyPc::Slot39: logic confirmed by peer review
- fn_22620 CPc::Slot39: logic confirmed by peer review
- fn_22354 CCorpse::CCorpse: logic confirmed by peer review
- fn_21301 CGameMode::SpawnCorpse: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 10:04:49 +00:00
ragnarok-clanker
e4be8f4190 Decompile 18 functions in Source/Client/Application/UnhandledExceptionHandler.cpp, Source/Client/Session.h, ... 
Batch #2077 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_04709 TopLevelExceptionFilter: logic confirmed by peer review (already on main)
- fn_08004 C3dGrannyModelRes::PlayAnimation: logic confirmed by peer review
- fn_09315 UIRequestJoinPartyWnd::SendMsg: logic confirmed by peer review
- fn_19761 EffectParticle::EffectParticle: logic confirmed by peer review
- fn_19768 EffectParticle::InitializeRecords: logic confirmed by peer review
- fn_20007 AttachedEffect::AttachedEffect: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20991 CRenderObject::CRenderObject: logic confirmed by peer review
- fn_21069 ?CreatePartyEffect@?A0xba063134@@YAPAUAttachedEffect@@AAUEffectActor@@AAUPartyEffectMode@@@Z: logic confirmed by peer review
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review
- fn_23396 CSession::GetJobName: logic confirmed by peer review
- fn_23495 CSession::InitJobNameTable: logic confirmed by peer review
- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23791 CSession::GetMonsterTalkText: logic confirmed by peer review
- fn_20987 EffectActor::EffectActor: logic confirmed by peer review
- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review
- fn_24251 CEffectMaker::CEffectMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 09:48:08 +00:00
ragnarok-clanker
ce2aab5af8 Decompile 4 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Actors/EffectActors.h 
Batch #1976 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_22397 CBlurPC::Update: logic confirmed by peer review
- fn_22401 CHalluPC2::Update: logic confirmed by peer review
- fn_22410 CCorpse::Draw: logic confirmed by peer review
- fn_22415 CHalluPlant::Draw: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Reviewed-by: ragnarok-clanker
 2026-10-29 08:58:05 +00:00
ragnarok-clanker
97cf23ebda Decompile 4 functions in Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/RenderObjectState.cpp, ... 
Batch #1949 by ragnarok-clanker: 1 byte-identical, 3 confirmed by peer review.

- fn_21086 RenderObjectState::Reset: logic confirmed by peer review
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_20088 UpdatePartyEffect: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 00:03:44 +00:00
ragnarok-clanker
81e812ea39 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ... 
Batch #1869 by ragnarok-clanker: 3 byte-identical, 0 confirmed by peer review.

- fn_19971 EffectParticle::PrimWaterFall: byte-identical
- fn_21090 CGameActor::ProcessBodyState: byte-identical
- fn_12629 UIShortCutWnd::Slot03: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
 2026-10-28 23:05:45 +00:00
ragnarok-clanker
2e808aaa74 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ... 
Batch #1853 by ragnarok-clanker: 1 byte-identical, 2 confirmed by peer review.

- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:53:38 +00:00
ragnarok-clanker
41858e4aff Maintenance: Remove the annotations of fn_22365/67/73/75 now that their tasks are skipped as compiler generated (batch 1498): each is 
Batch #1502 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s).
 2026-10-28 17:09:55 +00:00
ragnarok-clanker
d58f8f5ac1 Decompile 2 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Sound/SoundMaker.h 
Batch #1494 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_22406 CSoundMaker::Update: logic confirmed by peer review
- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 17:03:51 +00:00
ragnarok-clanker
edab01cdc4 Decompile 7 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Actors/GameActor.h, ... 
Batch #1420 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_22364 CNpc::~CNpc: logic confirmed by peer review
- fn_22379 CPc::GetExtent: logic confirmed by peer review
- fn_22419 CBlurPC::SendObjectMessage: logic confirmed by peer review
- fn_22422 CHalluNPC::SendObjectMessage: logic confirmed by peer review
- fn_22423 CHalluPC2::SendObjectMessage: logic confirmed by peer review
- fn_22424 CHalluPC::SendObjectMessage: logic confirmed by peer review
- fn_22425 CHalluPlant::SendObjectMessage: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 12:41:21 +00:00
ragnarok-clanker
fd4e979ab4 Decompile 2 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Actors/GameActor.h, ... 
Batch #1421 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_22403 CHalluPlant::Update: byte-identical
- fn_22411 CGndRiser::Draw: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 12:40:42 +00:00
ragnarok-clanker
b722d4e36d Decompile 8 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Actors/EffectActors.h 
Batch #1131 by eAthena: 0 byte-identical, 8 confirmed by peer review.

- fn_22365 CBlowEffect::`scalar deleting destructor': logic confirmed by peer review
- fn_22367 CCorpse::`scalar deleting destructor': logic confirmed by peer review
- fn_22373 CMasterChaser::`scalar deleting destructor': logic confirmed by peer review
- fn_22375 CNumEffect::`scalar deleting destructor': logic confirmed by peer review
- fn_22405 CNumEffect::Update: logic confirmed by peer review
- fn_22418 CBlowEffect::SendObjectMessage: logic confirmed by peer review
- fn_22420 CCorpse::SendObjectMessage: logic confirmed by peer review
- fn_22427 CNumEffect::SendObjectMessage: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-27 21:05:10 +00:00
ragnarok-clanker
7d9b244fb1 Decompile 3 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Sound/SoundMaker.h 
Batch #1017 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review
- fn_22406 CSoundMaker::Update: logic confirmed by peer review
- fn_22428 CSoundMaker::SendObjectMessage: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 10:04:43 +00:00
ragnarok-clanker
a996ad893b Decompile fn_22417 (CSoundMaker::Draw) 
Batch #1018 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_22417 CSoundMaker::Draw: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Sound/SoundMaker.cpp
 2026-10-27 09:30:10 +00:00