Commit graph

261 commits

Author SHA1 Message Date
ragnarok-clanker
edd5a4a066 Decompile fn_17678 (WorldScene::FindActorInCell)
Batch #1912 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17678 WorldScene::FindActorInCell: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 23:39:00 +00:00
ragnarok-clanker
2ae8a409c7 Decompile fn_23818 (FormatMonsterSpeech)
Batch #1903 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23818 FormatMonsterSpeech: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/MonsterSpeech.cpp
2026-10-28 23:28:03 +00:00
ragnarok-clanker
ef13e565dd Decompile 2 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h, ...
Batch #1897 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23644 CSession::LoadNavigationScripts: logic confirmed by peer review
- fn_23645 CSession::LoadRobeAlpha: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:27:26 +00:00
ragnarok-clanker
5056537cdf Decompile fn_05174 (CGuildMgr::GetEmblemFilename)
Batch #1892 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_05174 CGuildMgr::GetEmblemFilename: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/GuildEmblemLookup.cpp
2026-10-28 23:26:42 +00:00
ragnarok-clanker
ac2249cef5 Decompile fn_24284 (CGroundScope::Update)
Batch #1905 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_24284 CGroundScope::Update: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/Actors/GroundScope.cpp
2026-10-28 23:26:33 +00:00
ragnarok-clanker
3b3e844b6b Decompile fn_21110 (CGameActor::ApplyPendingUnknown0408)
Batch #1899 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21110 CGameActor::ApplyPendingUnknown0408: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 23:23:02 +00:00
ragnarok-clanker
20a2647c7a Decompile fn_21269 (CGameMode::SubcellPosition)
Batch #1886 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21269 CGameMode::SubcellPosition: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:17:28 +00:00
ragnarok-clanker
ec71daa13b Decompile fn_23815 (CSession::GetPetTalkText)
Batch #1885 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_23815 CSession::GetPetTalkText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:15:39 +00:00
ragnarok-clanker
260999b6d1 Decompile 2 functions in Source/Contents/TipOfTheDay.cpp, Source/Contents/TipOfTheDay.h
Batch #1882 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18078 CTipOfTheDay::GetTip: logic confirmed by peer review
- fn_18079 CTipOfTheDay::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:12:49 +00:00
ragnarok-clanker
5167f6ba82 Decompile 2 functions in Source/Contents/SkinInfo.cpp, Source/Contents/SkinCatalog.cpp, ...
Batch #1877 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_09691 CSkinMgr::Select: logic confirmed by peer review
- fn_09689 CSkinMgr::Refresh: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SkinCatalog.cpp
2026-10-28 23:12:35 +00:00
ragnarok-clanker
3898d6613a Decompile fn_12400 (CTipOfTheDay::Size)
Batch #1884 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_12400 CTipOfTheDay::Size: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/TipOfTheDay.cpp
2026-10-28 23:12:18 +00:00
ragnarok-clanker
a591f8908d Decompile 6 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1876 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_19844 EffectParticle::PrimThrowItem: logic confirmed by peer review (annotation added to existing code)
- fn_19822 EffectParticle::PrimPeong: logic confirmed by peer review (annotation added to existing code)
- fn_19810 EffectParticle::PrimGI3: logic confirmed by peer review (annotation added to existing code)
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review (already on main)
- fn_04106 ItemInfo::GetItemId: logic confirmed by peer review (annotation added to existing code)
- fn_12589 ShortcutDrop::Drop: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-28 23:10:29 +00:00
ragnarok-clanker
3950b1196e Decompile fn_10103 (SpriteDrawingPolicy::OffsetLayerDepth)
Batch #1871 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_10103 SpriteDrawingPolicy::OffsetLayerDepth: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SpriteLayerDepth.cpp
2026-10-28 23:09:15 +00:00
ragnarok-clanker
5c0eb3d28b Decompile 2 functions in Source/Contents/ActorNameRequests.cpp, Source/Contents/ActorNameCard.h, ...
Batch #1864 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_03504 CActorNameCardHolder::ProcessRequests: logic confirmed by peer review
- fn_03419 CCommonObject::LoadCsv: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:09:00 +00:00
ragnarok-clanker
81e812ea39 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1869 by ragnarok-clanker: 3 byte-identical, 0 confirmed by peer review.

- fn_19971 EffectParticle::PrimWaterFall: byte-identical
- fn_21090 CGameActor::ProcessBodyState: byte-identical
- fn_12629 UIShortCutWnd::Slot03: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-10-28 23:05:45 +00:00
ragnarok-clanker
8836dc5137 Decompile 3 functions in Source/Contents/EquipmentResources.cpp, Source/Contents/EquipmentResourceMgr.h, ...
Batch #1858 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_19746 EquipmentResourceMgr::GetAccessoryResourceName: logic confirmed by peer review
- fn_23357 CSession::GetAccessoryActName: logic confirmed by peer review
- fn_23358 CSession::GetAccessorySprName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:00:12 +00:00
ragnarok-clanker
8a9e5752b5 Decompile 2 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h
Batch #1855 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_21090 CGameActor::ProcessBodyState: byte-identical
- fn_08455 CGameActor::GetShield: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 22:54:17 +00:00
ragnarok-clanker
2e808aaa74 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1853 by ragnarok-clanker: 1 byte-identical, 2 confirmed by peer review.

- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:53:38 +00:00
ragnarok-clanker
6f1a245675 Decompile 7 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ...
Batch #1846 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_19830 EffectParticle::PrimSMA: logic confirmed by peer review (annotation added to existing code)
- fn_19790 EffectParticle::PrimBottom2: logic confirmed by peer review (already on main)
- fn_19791 EffectParticle::PrimBottom: logic confirmed by peer review (already on main)
- fn_02021 CreateTrigonometricTable: logic confirmed by peer review (already on main)
- fn_02023 ClientCosine: logic confirmed by peer review (already on main)
- fn_02025 ClientSine: logic confirmed by peer review (already on main)
- fn_19818 EffectParticle::PrimLineLink: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:52:17 +00:00
ragnarok-clanker
ef21913c3f Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Client/Session.h, ...
Batch #1842 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23837 CSession::GetWeaponActName: logic confirmed by peer review
- fn_23838 CSession::GetWeaponEffectActName: logic confirmed by peer review
- fn_23839 CSession::GetWeaponEffectSprName: logic confirmed by peer review
- fn_23840 CSession::GetWeaponSprName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:51:51 +00:00
ragnarok-clanker
f05827650a Decompile 2 functions in Source/Contents/ClientState.cpp, Source/Contents/ClientState.h, ...
Batch #1835 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_24222 CSession::SetHomunculusAutoFeed: logic confirmed by peer review
- fn_24223 CSession::SetPetAutoFeed: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:51:20 +00:00
ragnarok-clanker
75bc9ea504 Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1845 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05654 EquipmentProperties::CEquipmentPropertiesMgr::GetInstance: logic confirmed by peer review
- fn_05622 EquipmentProperties::CEquipment::CallOnStartEquip: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:50:33 +00:00
ragnarok-clanker
e4e285180f Decompile fn_19610 (CNavigationManager::SavedTargetText)
Batch #1844 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19610 CNavigationManager::SavedTargetText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:50:17 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ...
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:49:51 +00:00
ragnarok-clanker
5776a19924 Decompile fn_05236 (CAdventureGuideMgr::GetEntryList)
Batch #1838 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_05236 CAdventureGuideMgr::GetEntryList: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:49:35 +00:00
ragnarok-clanker
4739b61323 Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h
Batch #1828 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_23763 CSession::DeleteProhibitionLog: logic confirmed by peer review
- fn_23771 CSession::DecodePlayerName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:48:17 +00:00
ragnarok-clanker
716701c6ab Decompile fn_18985 (CEffect::RetireIfInactive)
Batch #1827 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_18985 CEffect::RetireIfInactive: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:43:36 +00:00
ragnarok-clanker
a8ff0839ca Decompile 12 functions in Source/Contents/Actors/Player.cpp, Source/Contents/Actors/Pc.h, ...
Batch #1819 by Yommy: 0 byte-identical, 12 confirmed by peer review.

- fn_22606 CGrannyPc::SetAnimation: logic confirmed by peer review
- fn_22611 CGrannyPc::PlayMotion: logic confirmed by peer review
- fn_22612 CPc::Slot34: logic confirmed by peer review
- fn_22626 CGrannyPc::Slot26: logic confirmed by peer review
- fn_22628 CGrannyPc::Slot27: logic confirmed by peer review
- fn_22630 CGrannyPc::Slot25: logic confirmed by peer review
- fn_22632 CGrannyPc::Slot20: logic confirmed by peer review
- fn_22637 CGrannyPc::Slot22: logic confirmed by peer review
- fn_22639 CGrannyPc::Slot21: logic confirmed by peer review
- fn_22648 CGrannyPc::Slot23: logic confirmed by peer review
- fn_22662 CPlayer::AngleToDirection: logic confirmed by peer review
- fn_22663 CPlayer::IsSpecialState: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:39:36 +00:00
ragnarok-clanker
16fade7361 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1792 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_19796 EffectParticle::PrimChemical3: logic confirmed by peer review
- fn_19824 EffectParticle::PrimPoison: logic confirmed by peer review
- fn_19813 EffectParticle::PrimGuard: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:39:29 +00:00
ragnarok-clanker
2d264e43ba Decompile 2 functions in Source/Contents/HeadResources.cpp
Batch #1806 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23393 CSession::GetDisplayJob: logic confirmed by peer review
- fn_23336 CSession::NormalizeHead: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:39:25 +00:00
ragnarok-clanker
b01dd18bf1 Decompile fn_22646 (CGrannyPc::Slot24)
Batch #1820 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_22646 CGrannyPc::Slot24: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Actors/Player.cpp
2026-10-28 22:39:23 +00:00
ragnarok-clanker
6d568f53db Decompile 6 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/EffectLists.h, ...
Batch #1818 by Yommy: 0 byte-identical, 6 confirmed by peer review.

- fn_18772 EffectLists::RetireActor: logic confirmed by peer review
- fn_18777 EffectLists::Retire: logic confirmed by peer review
- fn_18778 EffectLists::Retire: logic confirmed by peer review
- fn_18779 EffectLists::Retire: logic confirmed by peer review
- fn_18780 EffectLists::Clear: logic confirmed by peer review
- fn_18781 EffectLists::Release: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:37:37 +00:00
ragnarok-clanker
e4647a1535 Decompile fn_19598 (CNavigationManager::RequestRoute)
Batch #1781 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19598 CNavigationManager::RequestRoute: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:37:25 +00:00
ragnarok-clanker
720a876789 Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1813 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05612 EquipmentProperties::CEquipment::`scalar deleting destructor': logic confirmed by peer review
- fn_05624 EquipmentProperties::CEquipment::GetValue: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:37:12 +00:00
ragnarok-clanker
97e174c6b0 Decompile 4 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1817 by Yommy: 4 byte-identical, 0 confirmed by peer review.

- fn_05628 EquipmentProperties::CEquipment::GetId: byte-identical
- fn_05633 EquipmentProperties::CEquipment::GetProperties: byte-identical
- fn_05638 EquipmentProperties::CEquipment::Clear: byte-identical
- fn_05642 EquipmentProperties::CEquipment::IsPretend: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 22:37:01 +00:00
ragnarok-clanker
805cf67f82 Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1793 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19800 EffectParticle::PrimEffectTexture2: logic confirmed by peer review
- fn_19802 EffectParticle::PrimEffectTexture_Ani: logic confirmed by peer review
- fn_19805 EffectParticle::PrimFirstAid: logic confirmed by peer review
- fn_19816 EffectParticle::PrimIntimidate: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:21:46 +00:00
ragnarok-clanker
eb96e386eb Decompile 15 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h
Batch #1782 by Yommy: 0 byte-identical, 15 confirmed by peer review.

- fn_19438 CNaviInfo::AddNpc: logic confirmed by peer review
- fn_19439 CNaviInfo::AddLink: logic confirmed by peer review
- fn_19440 CNaviInfo::AddMob: logic confirmed by peer review
- fn_19441 CNavi_Link::AddLinkedLink: logic confirmed by peer review
- fn_19442 CNavi_Link::AddLink: logic confirmed by peer review
- fn_19443 CNavi_Object::AddLink: logic confirmed by peer review
- fn_19445 CNavi_Link::LinksBegin: logic confirmed by peer review
- fn_19446 CNavi_Object::LinksBegin: logic confirmed by peer review
- fn_19447 CNavi_Link::FindLinkAt: logic confirmed by peer review
- fn_19448 CNavi_Object::FindLinkAt: logic confirmed by peer review
- fn_19449 CNavi_Link::FindLinkTo: logic confirmed by peer review
- fn_19450 CNavi_Object::FindLinkTo: logic confirmed by peer review
- fn_19454 CNavi_Link::EraseLink: logic confirmed by peer review
- fn_19455 CNavi_Object::EraseLink: logic confirmed by peer review
- fn_19491 CNavi_Link::GetLinkedCell: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:19:30 +00:00
ragnarok-clanker
73e944dded Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h
Batch #1789 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19795 EffectParticle::PrimChemical2: logic confirmed by peer review
- fn_19797 EffectParticle::PrimChemical: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:19:15 +00:00
ragnarok-clanker
94783060d2 Decompile fn_09481 (UICashEmotionPiece::Set)
Batch #1775 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_09481 UICashEmotionPiece::Set: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:18:52 +00:00
ragnarok-clanker
64ad35e4c0 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-28 23:14:53 +01:00
ragnarok-clanker
f07e52ffeb 🔥 refactor(effects): removed unused header includes 2026-10-28 23:14:51 +01:00
ragnarok-clanker
41b839b378 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-28 23:14:46 +01:00
ragnarok-clanker
40dade2c0b Decompile 4 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h
Batch #1783 by Yommy: 4 byte-identical, 0 confirmed by peer review.

- fn_19451 CNavi_Link::ClearLinkedLinks: byte-identical
- fn_19452 CNavi_Link::ClearLinks: byte-identical
- fn_19453 CNavi_Object::ClearLinks: byte-identical
- fn_19490 CNavi_Link::GetLinkedName: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 22:14:12 +00:00
ragnarok-clanker
4c22f54ad0 🔥 refactor(effects): removed unused header includes 2026-10-28 23:13:11 +01:00
ragnarok-clanker
5a44997d9c Decompile 22 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h
Batch #1769 by Yommy: 0 byte-identical, 22 confirmed by peer review.

- fn_08327 CEfstAction_ChangeSize::Slot01: logic confirmed by peer review
- fn_08328 CEfstAction_ChangeSize::Slot02: logic confirmed by peer review
- fn_08331 CEfstAction_GenderChange::Slot02: logic confirmed by peer review
- fn_08334 CEfstAction_ShowEffect::Slot02: logic confirmed by peer review
- fn_08335 CSkillAction_RA_UNLIMIT::Slot08: logic confirmed by peer review
- fn_08339 CEfstAction_UNLIMIT::Slot02: logic confirmed by peer review
- fn_08346 CEfstAction_SHADOW_WEAPON::Slot03: logic confirmed by peer review
- fn_08347 CEfstAction_SHADOW_WEAPON::Slot04: logic confirmed by peer review
- fn_08359 CEfstAction_DANCING_KNIFE::Slot02: logic confirmed by peer review
- fn_08366 CEfstAction_SHADOW_EXCEED::Slot01: logic confirmed by peer review
- fn_08367 CEfstAction_SHADOW_EXCEED::Slot02: logic confirmed by peer review
- fn_08368 CEfstAction_SHADOW_EXCEED::Slot03: logic confirmed by peer review
- fn_08369 CEfstAction_SHADOW_EXCEED::Slot04: logic confirmed by peer review
- fn_08404 CSkillActionMgr::ActionSlot01: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_08406 CSkillActionMgr::EfstSlot03: logic confirmed by peer review
- fn_08407 CSkillActionMgr::EfstSlot04: logic confirmed by peer review
- fn_08408 CSkillActionMgr::ActionSlot14: logic confirmed by peer review
- fn_08409 CSkillActionMgr::ActionSlot02: logic confirmed by peer review
- fn_08410 CSkillActionMgr::ActionSlot03: logic confirmed by peer review
- fn_08411 CSkillActionMgr::ActionSlot04: logic confirmed by peer review
- fn_08412 CSkillActionMgr::HasEfstAction: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:12:43 +00:00
ragnarok-clanker
43198220b9 Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h
Batch #1770 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19792 EffectParticle::PrimBottomOut: logic confirmed by peer review
- fn_19793 EffectParticle::PrimBubbleDrop: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:12:29 +00:00
ragnarok-clanker
be749d87c8 Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h
Batch #1771 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_08371 CSkillAction_ABC_CHASING_BREAK::Slot07: byte-identical
- fn_08375 CSkillAction_ABC_CHASING_SHOT::Slot07: byte-identical
- fn_08385 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot03: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 22:12:16 +00:00
ragnarok-clanker
996f026515 Decompile 8 functions in Source/Contents/CashEmotionMgr.cpp, Source/Contents/CashEmotionMgr.h, ...
Batch #1766 by Yommy: 0 byte-identical, 8 confirmed by peer review.

- fn_02972 CCashEmotionMgr::SetOwnedPack: logic confirmed by peer review
- fn_09428 UICashEmotionMiniWnd::Select: logic confirmed by peer review
- fn_09429 UICashEmotionMiniWnd::Previous: logic confirmed by peer review
- fn_09431 UICashEmotionMiniWnd::Slot15: logic confirmed by peer review
- fn_09432 UICashEmotionMiniWnd::Paint: logic confirmed by peer review
- fn_09433 UICashEmotionMiniWnd::Next: logic confirmed by peer review
- fn_09434 UICashEmotionMiniWnd::SetIndex: logic confirmed by peer review
- fn_09435 UICashEmotionMiniWnd::SendMsg: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:10:56 +00:00
ragnarok-clanker
e6834bc146 Decompile fn_09430 (UICashEmotionMiniWnd::Refresh)
Batch #1767 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_09430 UICashEmotionMiniWnd::Refresh: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:10:32 +00:00
ragnarok-clanker
25dd065dbd Decompile 8 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrimitiveState.cpp, ...
Batch #1765 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.

- fn_19791 EffectParticle::PrimBottom: logic confirmed by peer review
- fn_19765 EffectPrimitiveState::GetColorOverride: logic confirmed by peer review
- fn_19779 EffectParticle::UpdateHit6: logic confirmed by peer review
- fn_19785 MoveEffectPrimitive: logic confirmed by peer review
- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_19866 RenderEffectPrimitive15: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:09:53 +00:00