Batch #12242 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_06853 CAMachineEffect::Slot03: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12243 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_19996 CEffectPrim::RenderTwinGlowSquares: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12369 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_21647 CGameMode::ReceiveItem1738AddOptions: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12367 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_19990 CEffectPrim::RenderTrailingArc: logic confirmed by peer review
Peer-reviewed-by: KWDev, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12332 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_23797 HotkeyCount: logic confirmed by peer review
Peer-reviewed-by: KWDev, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
TableMng.cpp redeclared a partial, mismatched YExcel API (CompoundDocument
instead of YCompoundFiles::CompoundFile, SetIntegerAlt/SetWStringAlt instead
of BasicExcelCell::Set(int)/Set(const wchar_t*), non-const getters, int
GetTotalRows/GetTotalCols, New(size_t)), so nothing could define it. The
YExcel span was already skipped as runtime_library code.
- ThirdParty/BasicExcel: Yap Chun Wei's public-domain BasicExcel 1.14.
Matches the binary: sizeof(CompoundFile)=0x330, workbook_ at 0x330,
worksheets_ at 0x488, yesheets_ at 0x494, BasicExcelCell 0x28, Workbook()
BOF constants 0x50600/0x7CD19A0/0xC0C9/0x306. Local changes:
- BasicExcel gains unknown_04A0[0x108]: all four operator new calls in
the original allocate 0x5A8, no code reads the tail.
- the default constructor is defined by TableMng.cpp (fn_20498).
- operator<<(wchar_t*) keeps its pre-C++20 overload explicitly.
- TableMng.cpp includes the real header; scores of its 13 functions are
unchanged (td check).
- data/compile.json: shape 4 gets -I ThirdParty/BasicExcel; the library is
shape 11 (shape 8 without the jsoncpp defines/include).
Batch #12329 by unna: 0 byte-identical, 2 confirmed by peer review.
- fn_04294 CReputeMgr::sub_60DC70: logic confirmed by peer review
- fn_04295 CReputeMgr::sub_60E090: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12322 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12321 by cremane: 0 byte-identical, 3 confirmed by peer review.
- fn_19746 EquipmentResourceMgr::GetAccessoryResourceName: logic confirmed by peer review
- fn_19747 EquipmentResourceMgr::GetNamedAccessoryResourceName: logic confirmed by peer review
- fn_19748 EquipmentResourceMgr::GetBodyPalName: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11997 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_18865 CSpriteParticle::sub_B40F30: logic confirmed by peer review
Peer-reviewed-by: SapitoSucio, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12309 by Yommy: 0 byte-identical, 5 confirmed by peer review.
- fn_22571 CPc::GetEquipActionNames: logic confirmed by peer review
- fn_22578 CPc::GetEquipSpriteNames: logic confirmed by peer review
- fn_22613 CGrannyPc::Slot31: logic confirmed by peer review
- fn_22614 CPc::Slot31: logic confirmed by peer review
- fn_22619 CGrannyPc::Slot39: logic confirmed by peer review
Peer-reviewed-by: cremane, codeplay, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12233 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_22569 CPc::ApplyLayerEffects: logic confirmed by peer review
Peer-reviewed-by: Yommy, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12308 by Yommy: 0 byte-identical, 2 confirmed by peer review.
- fn_22601 CGrannyPc::SendMsg: logic confirmed by peer review
- fn_22643 CPc::Slot15: logic confirmed by peer review (already on main)
Peer-reviewed-by: KWDev, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12305 by Yommy: 0 byte-identical, 6 confirmed by peer review.
- fn_13832 ?SplitTitle@?A0xd165b6a5@@YAXPBDAAV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@H@Z: logic confirmed by peer review
- fn_09122 CTipBoxMgr::AddParagraph: logic confirmed by peer review
- fn_09125 CTipBoxMgr::SelectRandomTip: logic confirmed by peer review
- fn_09128 CTipBoxMgr::Sub7ACF50: logic confirmed by peer review
- fn_09129 CTipBoxMgr::RegisterLuaFunctions: logic confirmed by peer review
- fn_09146 sub_7AEC00: logic confirmed by peer review
Peer-reviewed-by: KWDev, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12301 by eAthena: 2 byte-identical, 0 confirmed by peer review.
- fn_18370 FindMessageId: byte-identical
- fn_18372 InsertMessageRow: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #12293 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_19221 CStormKickEffect::Close: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12292 by cremane: 2 byte-identical, 0 confirmed by peer review.
- fn_19272 CEffectMemoryMgr::Init: byte-identical
- fn_19273 CreateEffectMemoryMgr: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12286 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_18891 CGlassWall::Close: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12281 by cremane: 3 byte-identical, 0 confirmed by peer review.
- fn_23918 CSession::WriteOptionGuid: byte-identical
- fn_23919 CSession::WriteOptionInteger: byte-identical
- fn_23920 CSession::WriteOptionString: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12274 by cremane: 2 byte-identical, 0 confirmed by peer review.
- fn_18877 CCellRangeEffect::Close: byte-identical
- fn_18881 CCellRangeEffect::Slot04: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12268 by SapitoSucio: 0 byte-identical, 2 confirmed by peer review.
- fn_19882 CEffectPrim::RenderColorPaper: logic confirmed by peer review
- fn_19906 CEffectPrim::RenderGrid: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11963 by Yommy: 0 byte-identical, 2 confirmed by peer review.
- fn_23738 CSession::UpdateRecord6144: logic confirmed by peer review (already on main)
- fn_23775 CSession::SplitDate: logic confirmed by peer review
Peer-reviewed-by: SapitoSucio, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12258 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_06850 CAMachineEffect::Close: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #12257 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_19776 CEffectPrim::Prim3DCircle: logic confirmed by peer review
Peer-reviewed-by: KWDev, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12256 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_24235 CSession::SetShowRankingSchedule: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, KWDev, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12248 by Yommy: 0 byte-identical, 4 confirmed by peer review.
- fn_07161 CSvgSpiritEffect::Slot03: logic confirmed by peer review
- fn_07174 CCurseOfCubeEffect::SpawnStart: logic confirmed by peer review
- fn_07183 CWarningPlaneEffect::AddPlane: logic confirmed by peer review
- fn_07193 CCylinderEffect::Slot01: logic confirmed by peer review
Peer-reviewed-by: KWDev, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12215 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_18950 CMapChainEffect::Slot07: logic confirmed by peer review
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12211 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_19872 CEffectPrim::RenderBlind: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11838 by Yommy: 0 byte-identical, 2 confirmed by peer review.
- fn_19037 GetHatEffectOffsetY: logic confirmed by peer review
- fn_19049 CEZ2STRScreenEffect::Slot24: logic confirmed by peer review
Peer-reviewed-by: Tanke, cremane, raiken
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12202 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_20135 CRagEffect::WhiteYellowRings: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12176 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_19925 CEffectPrim::RenderTeiRect: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12239 by eAthena: 1 byte-identical, 2 confirmed by peer review.
- fn_06544 FindItemCardName: byte-identical
- fn_06584 ITEM_INFO::Star: logic confirmed by peer review
- fn_06594 ItemUnidentifiedName: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12238 by Yommy: 0 byte-identical, 3 confirmed by peer review.
- fn_01721 SampleLegacyPosition: logic confirmed by peer review
- fn_01722 SampleModelPosition: logic confirmed by peer review
- fn_01723 SampleLegacyRotation: logic confirmed by peer review
Peer-reviewed-by: KWDev, Toshiro, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12167 by Toshiro: 0 byte-identical, 1 confirmed by peer review.
- fn_19893 CEffectPrim::RenderOrbitIcons: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12142 by SapitoSucio: 0 byte-identical, 4 confirmed by peer review.
- fn_19884 CEffectPrim::RenderTeiFacingSlots: logic confirmed by peer review
- fn_19903 CEffectPrim::RenderGroundBubbles: logic confirmed by peer review
- fn_19919 CEffectPrim::RenderSoulParticle: logic confirmed by peer review
- fn_19923 CEffectPrim::RenderTeiRect: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12141 by SapitoSucio: 0 byte-identical, 3 confirmed by peer review.
- fn_19976 CEffectPrim::RenderSegmentSprites: logic confirmed by peer review
- fn_19980 CEffectPrim::RenderTwinFacingSquares: logic confirmed by peer review
- fn_19981 CEffectPrim::RenderPillarSquares: logic confirmed by peer review
Peer-reviewed-by: Yommy, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12140 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_19979 CEffectPrim::RenderJitterQuads: logic confirmed by peer review
Peer-reviewed-by: Yommy, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12022 by SapitoSucio: 0 byte-identical, 2 confirmed by peer review.
- fn_03937 CSession::SetOption: logic confirmed by peer review
- fn_12610 CSession::GetOption: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12228 by Yommy: 0 byte-identical, 3 confirmed by peer review.
- fn_06612 ITEM_INFO::Deserialize: logic confirmed by peer review
- fn_06614 LoadItemIntegerTable: logic confirmed by peer review
- fn_23386 LookupClientItem: logic confirmed by peer review
Peer-reviewed-by: KWDev, Tanke, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12226 by Yommy: 0 byte-identical, 3 confirmed by peer review.
- fn_08136 CRuneSystemMgr::GetGradeValue: logic confirmed by peer review
- fn_08146 CRuneSystemMgr::LoadScripts: logic confirmed by peer review
- fn_08152 CRuneSystemMgr::SendRequest: logic confirmed by peer review
Peer-reviewed-by: KWDev, Toshiro, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11870 by Yommy: 0 byte-identical, 4 confirmed by peer review.
- fn_02936 CCashEmotionMgr::ClearCommands: logic confirmed by peer review
- fn_02943 CCashEmotionMgr::GetPackName: logic confirmed by peer review
- fn_09412 UICashEmotionListWnd::ShowPack: logic confirmed by peer review
- fn_09430 UICashEmotionMiniWnd::Refresh: logic confirmed by peer review
Peer-reviewed-by: KWDev, SapitoSucio, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12137 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_19862 CEffectPrim::RenderPyramid: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12136 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_19864 CEffectPrim::RenderSphere: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12209 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_23300 CSession::GetEquipSlots: logic confirmed by peer review
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12189 by Yommy: 0 byte-identical, 4 confirmed by peer review.
- fn_19853 CEffectPrim::RenderSizedSquare: logic confirmed by peer review
- fn_19874 CEffectPrim::RenderLayeredGlow: logic confirmed by peer review
- fn_19892 CEffectPrim::RenderSphereCage: logic confirmed by peer review
- fn_19929 CEffectPrim::RenderFacingQuads: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, KWDev, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11948 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_19420 FindNaviObjectByName: logic confirmed by peer review
Peer-reviewed-by: KWDev, SapitoSucio, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #12166 by Yommy: 0 byte-identical, 3 confirmed by peer review.
- fn_03692 CLoadPartyInfoAsyncWork::CLoadPartyInfoAsyncWork: logic confirmed by peer review
- fn_03694 CLoadPartyInfoAsyncWork::Bind: logic confirmed by peer review
- fn_03697 CLoadPartyInfoAsyncWork::Execute: logic confirmed by peer review
Peer-reviewed-by: KWDev, SapitoSucio, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
