Commit graph

48 commits

Author SHA1 Message Date
ragnarok-clanker
63b1377599 Decompile 5 functions in Source/Client/ReplayPacketRecorder.h, Source/Contents/Emblems/EmblemUpload.h, ...
Batch #1488 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18386 PacketLengths::IsRecorded: logic confirmed by peer review
- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18388 PacketLengths::Lookup: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
- fn_18171 ResourceFailures::Report: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 16:45:10 +00:00
ragnarok-clanker
865d8a45e2 Decompile fn_07750 (CActRes::Load)
Batch #1483 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_07750 CActRes::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 16:23:38 +00:00
ragnarok-clanker
ca5b834cf3 Decompile 3 functions in Source/Resource/Audio/WaveResource.cpp, Source/Resource/Audio/WaveResource.h
Batch #1228 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_08066 CWave::Create: logic confirmed by peer review
- fn_08067 CWave::Load: logic confirmed by peer review
- fn_08070 CWave::CWave: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 16:09:55 +00:00
ragnarok-clanker
565716ba36 Decompile 2 functions in Source/Resource/ResourceMgr.cpp, Source/Resource/ResourceMgr.h
Batch #1480 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18175 ResourceMgr::Load: logic confirmed by peer review
- fn_18176 ResourceMgr::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 15:47:54 +00:00
ragnarok-clanker
73cc345898 Decompile 7 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ...
Batch #1447 by Yommy: 0 byte-identical, 7 confirmed by peer review.

- fn_03435 CMapSkyMgr::LoadData: logic confirmed by peer review
- fn_23794 CSession::GetAccessoryName: logic confirmed by peer review
- fn_17667 WorldActors::Lookup: logic confirmed by peer review
- fn_17698 WorldObjects::SendObjectMessage: logic confirmed by peer review
- fn_17865 CPathFinder::~CPathFinder: logic confirmed by peer review
- fn_18334 LuaScript::TableField: logic confirmed by peer review
- fn_07925 CImfRes::Load: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
2026-10-28 13:18:31 +00:00
ragnarok-clanker
f61f0747fa Decompile 2 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ...
Batch #1449 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_17872 CPathFinder::Height: byte-identical
- fn_17873 CPathFinder::Width: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/MapSkyMgr.cpp, Source/Contents/EquipmentResources.cpp, Source/Contents/Pathfinding.cpp, Source/Resource/ImfResource.cpp
2026-10-28 12:59:53 +00:00
ragnarok-clanker
cdc3c895f1 Decompile 2 functions in Source/Resource/ResourceMgr.cpp, Source/Resource/ResourceMgr.h
Batch #1385 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_18209 ResourceMgr::Instance: logic confirmed by peer review
- fn_18189 ResourceMgr::UnloadAll: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:08:03 +00:00
ragnarok-clanker
96acca76c3 Decompile fn_02010 (ModelFace::~ModelFace)
Batch #1356 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02010 ModelFace::~ModelFace: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 11:42:53 +00:00
ragnarok-clanker
b8287f9827 Decompile 5 functions in Source/Resource/XmlParsing.cpp, Source/Resource/XmlNode.h
Batch #1247 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_18298 XmlNode::Text: logic confirmed by peer review
- fn_18299 XmlNode::DecodeEntity: logic confirmed by peer review
- fn_18300 XmlDocument::TerminateName: logic confirmed by peer review
- fn_18301 XmlDocument::ParseElements: logic confirmed by peer review
- fn_18302 XmlDocument::Parse: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/XmlParsing.cpp
2026-10-27 23:23:01 +00:00
ragnarok-clanker
79455b041b Decompile 4 functions in Source/Resource/RmaResource.cpp, Source/Resource/RmaResource.h
Batch #1246 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_07753 CRmaRes::Create: logic confirmed by peer review
- fn_07754 CRmaRes::Load: logic confirmed by peer review
- fn_07755 CRmaRes::Unload: logic confirmed by peer review
- fn_07778 CRmaRes::`scalar deleting destructor': logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/RmaResource.cpp
2026-10-27 23:22:54 +00:00
ragnarok-clanker
6d4d89a9cc Decompile fn_09154 (BinkMovie::BinkMovie)
Batch #1219 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_09154 BinkMovie::BinkMovie: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 21:18:48 +00:00
ragnarok-clanker
61943206fb Decompile fn_08054 (CSprRes::Load)
Batch #1201 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_08054 CSprRes::Load: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:08:39 +00:00
ragnarok-clanker
347b99c15d Decompile 4 functions in Source/Resource/World/WorldResource.cpp, Source/Resource/World/WorldResource.h, ...
Batch #1130 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_08071 C3dWorldRes::Create: logic confirmed by peer review
- fn_08073 C3dWorldRes::Load: logic confirmed by peer review
- fn_08076 C3dWorldRes::C3dWorldRes: logic confirmed by peer review
- fn_17681 WorldSpatialTree::ReadBounds: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:07:47 +00:00
ragnarok-clanker
d8177fe68b Decompile 2 functions in Source/Resource/World/GroundResource.cpp, Source/Resource/World/GroundResource.h
Batch #1185 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_07909 GroundLegacyLightmap::Decode: logic confirmed by peer review (annotation added to existing code)
- fn_07910 CGndRes::Lightmap: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-27 21:07:31 +00:00
ragnarok-clanker
aa8d6d2427 Decompile 8 functions in Source/Resource/GifResource.cpp, Source/Resource/GifResource.h, ...
Batch #1132 by eAthena: 0 byte-identical, 8 confirmed by peer review.

- fn_07852 CGifRes::Create: logic confirmed by peer review
- fn_07853 CGifRes::Load: logic confirmed by peer review
- fn_07854 CGifRes::Decode: logic confirmed by peer review
- fn_07855 CGifRes::Unload: logic confirmed by peer review
- fn_07856 CGifRes::Slot02: logic confirmed by peer review
- fn_07857 CGifRes::IsTransient: logic confirmed by peer review
- fn_07865 CGifRes::CreateBlank: logic confirmed by peer review
- fn_07870 CGifRes::DecodeGif: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/GifResource.cpp
2026-10-27 21:05:50 +00:00
ragnarok-clanker
e44193df72 Decompile fn_07911 (CGndRes::Parse)
Batch #1189 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_07911 CGndRes::Parse: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-27 21:01:13 +00:00
ragnarok-clanker
c5a61bd331 Decompile fn_07994 (AnimatedModelFrame::~AnimatedModelFrame)
Batch #1151 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_07994 AnimatedModelFrame::~AnimatedModelFrame: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:34:49 +00:00
ragnarok-clanker
2dda6bce1d Decompile 4 functions in Source/Resource/EZeffectResource.h, Source/Resource/EZeffectResource.cpp
Batch #1088 by ragnarok-clanker: 1 byte-identical, 3 confirmed by peer review.

- fn_07889 CEZeffectRes::Create: logic confirmed by peer review
- fn_07890 CEZeffectRes::Load: logic confirmed by peer review
- fn_07891 CEZeffectRes::Unload: byte-identical
- fn_07893 CEZeffectRes::CEZeffectRes: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 16:36:30 +00:00
ragnarok-clanker
787f0dd3ea Decompile 8 functions in Source/Resource/World/GroundResource.cpp, Source/Resource/World/GroundResource.h, ...
Batch #1084 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.

- fn_07899 CGndRes::Create: logic confirmed by peer review
- fn_07900 CGndRes::Load: logic confirmed by peer review
- fn_07906 CGndRes::CGndRes: logic confirmed by peer review
- fn_07911 CGndRes::Parse: logic confirmed by peer review
- fn_07912 CGndRes::ReadWater: logic confirmed by peer review
- fn_07828 C3dAttr::Create: logic confirmed by peer review
- fn_07829 C3dAttr::Load: logic confirmed by peer review
- fn_07833 C3dAttr::C3dAttr: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 16:35:37 +00:00
ragnarok-clanker
eb3e3b8b08 Decompile 11 functions in Source/Contents/Models/ModelLighting.cpp, Source/Contents/Models/ModelNode.cpp, ...
Batch #1082 by ragnarok-clanker: 0 byte-identical, 11 confirmed by peer review.

- fn_02007 ModelMesh::ModelMesh: logic confirmed by peer review
- fn_02009 ModelMesh::~ModelMesh: logic confirmed by peer review
- fn_02011 ModelMesh::CalculateNormals: logic confirmed by peer review
- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review
- fn_07997 AnimatedModelRecord::~AnimatedModelRecord: logic confirmed by peer review
- fn_08023 C3dAnimModelRes::Unload: logic confirmed by peer review
- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review
- fn_17514 C3dNode::AccumulateBounds: logic confirmed by peer review
- fn_17515 C3dNode::SampleGroundColors: logic confirmed by peer review
- fn_17521 C3dNode::Prepare: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 16:31:29 +00:00
ragnarok-clanker
5ec8920fd4 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Resource headers
Batch #1067 by ragnarok-clanker: no function's compiled code changes; checked with 83 compiled unit(s), including every includer of Source/Resource/Audio/WaveResource.h, Source/Resource/BinkRuntime.h, Source/Resource/Bitmap/BitmapResource.h, Source/Resource/Bitmap/IJL15Runtime.h, Source/Resource/Models/ModelResource.h, Source/Resource/Resource.h, Source/Resource/ResourceAliases.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/WorldResource.h.
2026-10-27 14:00:13 +00:00
ragnarok-clanker
823aeda193 Decompile 2 functions in Source/Resource/Sprites/ActionResource.cpp, Source/Resource/Sprites/ActionResource.h
Batch #1042 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_07787 CActRes::Frame: logic confirmed by peer review
- fn_07788 CActRes::FrameCount: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 11:01:42 +00:00
ragnarok-clanker
f3ceb09e9d Merge commit '6c40a36577' 2026-10-27 10:06:35 +00:00
ragnarok-clanker
d22c6b96a6 Decompile 5 functions in Source/Resource/Bitmap/BitmapImage.cpp, Source/Resource/Bitmap/BitmapImage.h, ...
Batch #1026 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_07866 BitmapImage::CreateAuxiliary: logic confirmed by peer review
- fn_07867 BitmapImage::Pixel: logic confirmed by peer review
- fn_07874 BitmapImage::ClearAuxiliary: logic confirmed by peer review
- fn_09684 SkinPaletteColor: logic confirmed by peer review
- fn_09685 SkinPaletteChannels: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/SkinPalette.cpp
2026-10-27 10:04:56 +00:00
ragnarok-clanker
07d2f8441c 📝 docs(headers): added inlined comments to method definitions 2026-10-27 10:46:28 +01:00
ragnarok-clanker
e331e03f4c 📝 docs(headers): annotated inlined methods 2026-10-27 10:43:00 +01:00
ragnarok-clanker
ff15df90ad 📝 docs(annotations): marked inlined functions across modules 2026-10-27 10:42:13 +01:00
ragnarok-clanker
3dbd276311 📚 docs(inlining): marked inlined functions across modules 2026-10-27 10:21:57 +01:00
ragnarok-clanker
add868efe7 ♻️ refactor(source): removed unused includes and add INLINE comments 2026-10-27 10:09:10 +01:00
ragnarok-clanker
779dd40d2e 🛠️ refactor(source): annotated inlined functions and removed unused include 2026-10-27 10:01:19 +01:00
ragnarok-clanker
279b86f980 Merge branch 'main' of http://forgejo:3000/clank/rodecomp 2026-10-27 08:58:12 +00:00
ragnarok-clanker
c2b4547ea0 Decompile 2 functions in Source/Resource/ResourceAliases.cpp, Source/Resource/ResourceAliases.h, ...
Batch #1004 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18179 ResourceAliases::ResolveMapName: logic confirmed by peer review
- fn_18187 ResourceAliases::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 08:52:33 +00:00
ragnarok-clanker
b574abe09d Decompile 4 functions in Source/Resource/PaletteResource.cpp, Source/Resource/PaletteResource.h, ...
Batch #989 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_08039 CPaletteRes::Create: logic confirmed by peer review
- fn_08040 CPaletteRes::Load: logic confirmed by peer review
- fn_02597 CFile::Open: logic confirmed by peer review
- fn_01124 CFile::~CFile: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-27 08:51:32 +00:00
ragnarok-clanker
9bacaba47a Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-27 09:47:29 +01:00
ragnarok-clanker
b1b73cc318 🛠️ refactor(strings): converted hex-escaped Korean strings to UTF-8 literals 2026-10-27 09:47:02 +01:00
ragnarok-clanker
5aafb686cc 🛠️ refactor(strings): wrote CP949 Korean literals as UTF-8 Hangul with /source-charset:utf-8 /execution-charset:.949 2026-10-27 09:42:20 +01:00
ragnarok-clanker
b63782e6f5 Merge branch 'main' of http://forgejo:3000/clank/rodecomp 2026-10-27 08:39:28 +00:00
ragnarok-clanker
c3bce5ee83 Decompile fn_08041 (CPaletteRes::Unload)
Batch #991 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_08041 CPaletteRes::Unload: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Resource/PaletteResource.cpp
2026-10-27 08:32:45 +00:00
ragnarok-clanker
181f099344 ✨ feat(Resource): added MSGSTRINGID enum definitions 2026-10-27 09:17:49 +01:00
ragnarok-clanker
220df4d318 Decompile 12 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/ModelResource.h, ...
Batch #959 by ragnarok-clanker: 0 byte-identical, 12 confirmed by peer review.

- fn_07948 C3dModelRes::Unload: logic confirmed by peer review (already on main)
- fn_07949 C3dModelResV1::Create: logic confirmed by peer review (already on main)
- fn_07982 C3dModelRes::C3dModelRes: logic confirmed by peer review (already on main)
- fn_07995 C3dModelRes::~C3dModelRes: logic confirmed by peer review (already on main)
- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review
- fn_08012 C3dModelRes::FindNode: logic confirmed by peer review (already on main)
- fn_07985 ModelNode::ModelNode: logic confirmed by peer review
- fn_07950 C3dModelResV1::Load: logic confirmed by peer review (already on main)
- fn_07983 C3dModelResV1::C3dModelResV1: logic confirmed by peer review (already on main)
- fn_07984 C3dModelResV2::C3dModelResV2: logic confirmed by peer review (already on main)
- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 08:05:28 +00:00
ragnarok-clanker
f517a81de5 Decompile fn_07979 (C3dAnimModelRes::C3dAnimModelRes)
Batch #958 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_07979 C3dAnimModelRes::C3dAnimModelRes: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 00:02:54 +00:00
ragnarok-clanker
14197ed459 Decompile 7 functions in Source/Resource/XmlNode.cpp, Source/Resource/XmlNode.h
Batch #844 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_18291 XmlNode::XmlNode: logic confirmed by peer review
- fn_18292 XmlNode::`scalar deleting destructor': logic confirmed by peer review
- fn_18293 XmlNode::AppendSibling: logic confirmed by peer review
- fn_18294 XmlDocument::Reset: logic confirmed by peer review
- fn_18295 XmlNode::Clear: logic confirmed by peer review
- fn_18296 XmlNode::FindChild: logic confirmed by peer review
- fn_18297 XmlNode::FindSibling: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/XmlNode.cpp
2026-10-26 22:51:22 +00:00
ragnarok-clanker
2bd93fdbc7 Decompile fn_07868 (DecodeGifLzw)
Batch #843 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_07868 DecodeGifLzw: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/GifLzw.cpp
2026-10-26 22:51:20 +00:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
ragnarok-clanker
9822c2fdf5 Decompile fn_18183 (CRes::AddRef)
Batch #125 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_18183 CRes::AddRef: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-24 18:10:11 +00:00
ragnarok-clanker
d456e8f64a Initial rodecomp source snapshot 2026-10-24 00:35:19 +00:00