clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
431 commits 1 branch 0 tags 7.2 MiB
Commit graph

170 commits

Author SHA1 Message Date
ragnarok-clanker
6ebe295226 Decompile fn_23814 (CSession::GetPetTalkName) 
Batch #1621 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23814 CSession::GetPetTalkName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetTalkNames.cpp
 2026-10-28 19:45:23 +00:00
ragnarok-clanker
58b744ad2f Decompile 2 functions in Source/Contents/BodyResources.cpp, Source/Contents/RobeResources.cpp, ... 
Batch #1617 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_19754 EquipmentResourceMgr::GetBodyRacePrefix: logic confirmed by peer review
- fn_19756 EquipmentResourceMgr::GetRobeSprName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/BodyResources.cpp, Source/Contents/RobeResources.cpp
 2026-10-28 19:44:56 +00:00
ragnarok-clanker
856429f9dc Decompile fn_10102 (SpriteDrawingPolicy::ProjectCell) 
Batch #1615 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_10102 SpriteDrawingPolicy::ProjectCell: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Render/SpriteGeometry.cpp
 2026-10-28 19:44:43 +00:00
ragnarok-clanker
9e88189238 Decompile fn_19766 (CalculateVectorAngle) 
Batch #1612 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19766 CalculateVectorAngle: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:44:33 +00:00
ragnarok-clanker
499d5b8558 Decompile 2 functions in Source/Contents/MonsterResources.cpp, Source/Client/Session.h 
Batch #1608 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23790 CSession::GetMonsterSprName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/MonsterResources.cpp
 2026-10-28 19:44:03 +00:00
ragnarok-clanker
c3fe24e020 Decompile 2 functions in Source/Contents/ActorMovementRoute.cpp, Source/Contents/Actors/GameActor.h, ... 
Batch #1601 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_19317 Replay::DelayScale: logic confirmed by peer review
- fn_21028 CGameActor::FindRoute: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ActorMovementRoute.cpp
 2026-10-28 19:42:58 +00:00
ragnarok-clanker
0e94db9d83 Decompile fn_01730 (ModelKeyList3::Read) 
Batch #1597 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_01730 ModelKeyList3::Read: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-28 19:42:35 +00:00
ragnarok-clanker
4f0d60a4a7 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp 
Batch #1595 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_08320 Sub773A00: logic confirmed by peer review
- fn_08324 Sub7745B0: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-28 19:42:33 +00:00
ragnarok-clanker
838c0044d2 Decompile 70 functions in Source/Client/Browser/BrowserFactory.cpp, Source/Contents/Emblems/EmblemUpload.cpp, ... 
Batch #1665 by ragnarok-clanker: 0 byte-identical, 70 confirmed by peer review.

- fn_10904 UIEditCtrl::UpdateLinks: logic confirmed by peer review
- fn_10905 EditViewport::Synchronize: logic confirmed by peer review
- fn_10950 UIBalloonText::SetText: logic confirmed by peer review
- fn_11216 ItemLinkDisplay::Convert: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review (already on main)
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review (already on main)
- fn_11366 UIListBox::Paint: logic confirmed by peer review
- fn_11367 UIListBoxEx::Paint: logic confirmed by peer review
- fn_11392 UITextButton::Paint: logic confirmed by peer review
- fn_11394 UITextViewer::Paint: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review (already on main)
- fn_11471 UITextButton::Slot27: logic confirmed by peer review (already on main)
- fn_11494 UITextButton::Slot33: logic confirmed by peer review (already on main)
- fn_11562 UITextViewer::SendMsg: logic confirmed by peer review (already on main)
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review (already on main)
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review (already on main)
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review (already on main)
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review (already on main)
- fn_12680 ShortcutPainting::Paint: logic confirmed by peer review
- fn_13829 WrapPlainText: logic confirmed by peer review
- fn_13833 WrapRichText: logic confirmed by peer review
- fn_16941 UIWindow::DrawAmount: logic confirmed by peer review
- fn_16971 UIWindow::TextHeight: logic confirmed by peer review
- fn_16972 UIWindow::VerticalTextHeight: logic confirmed by peer review
- fn_16973 UIWindow::TextSize: logic confirmed by peer review
- fn_16974 UIWindow::VerticalTextSize: logic confirmed by peer review
- fn_16975 UIWindow::TextWidth: logic confirmed by peer review
- fn_16993 WrapPixelText: logic confirmed by peer review
- fn_17007 FitText: logic confirmed by peer review
- fn_17009 UIWindow::DrawTextAt: logic confirmed by peer review
- fn_17013 DrawOutlinedColoredText: logic confirmed by peer review
- fn_17014 DrawStyledColoredText: logic confirmed by peer review
- fn_17015 DrawColoredText: logic confirmed by peer review
- fn_17016 DrawOutlinedText: logic confirmed by peer review
- fn_17136 BrowserFactory::Create: logic confirmed by peer review
- fn_18376 LookupMessage: logic confirmed by peer review
- fn_01934 TextContext::TextContext: logic confirmed by peer review
- fn_01957 TextContext::Marker: logic confirmed by peer review
- fn_01961 TextContext::Measure: logic confirmed by peer review
- fn_01966 TextContext::SetFont: logic confirmed by peer review
- fn_01970 TextContext::DrawPair: logic confirmed by peer review
- fn_01971 TextContext::Draw: logic confirmed by peer review
- fn_01983 TextContext::MeasurePart: logic confirmed by peer review
- fn_01984 TextContext::DrawPart: logic confirmed by peer review
- fn_21788 ReceivePartyJoinResult: logic confirmed by peer review
- fn_24191 EmotionHotkeys::LoadDefaults: logic confirmed by peer review
- fn_03664 CAdventurerAgencyMgr::CompletePartyInfo: logic confirmed by peer review
- fn_03666 CAdventurerAgencyMgr::CompleteRegistration: logic confirmed by peer review
- fn_03668 CAdventurerAgencyMgr::CompleteStopRecruiting: logic confirmed by peer review
- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
- fn_04239 CMCStoreInfoBackup::CompleteSave: logic confirmed by peer review
- fn_04262 CPlayerNameDictionary::Lookup: logic confirmed by peer review
- fn_06581 ItemNaming::DisplayName: logic confirmed by peer review (already on main)
- fn_06583 ItemNamingContext::Element: logic confirmed by peer review (already on main)
- fn_06584 ItemNamingContext::Star: logic confirmed by peer review (already on main)
- fn_06585 ItemNaming::Creator: logic confirmed by peer review (already on main)
- fn_06586 ItemNamingContext::Apprentice: logic confirmed by peer review (already on main)
- fn_06587 ItemNaming::Suffixes: logic confirmed by peer review (already on main)
- fn_06588 ItemNaming::Prefixes: logic confirmed by peer review (already on main)
- fn_09299 UIApplyForPartyWnd::Slot15: logic confirmed by peer review
- fn_09300 UIRegisterPartyWnd::Slot15: logic confirmed by peer review
- fn_09301 UIRequestJoinPartyWnd::Slot15: logic confirmed by peer review
- fn_09303 UIApplyForPartyWnd::Paint: logic confirmed by peer review
- fn_09304 UIPartyInfoWnd::Paint: logic confirmed by peer review
- fn_10748 UIEditCtrl::RemoveInvalidLink: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review (already on main)
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review (already on main)
- fn_10794 UIBasicButton::Paint: logic confirmed by peer review
- fn_10799 UIBmpTextButton::Paint: logic confirmed by peer review
- fn_10823 UITransBalloonText::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:35:29 +00:00
ragnarok-clanker
23f296ca38 Decompile fn_17689 (WorldScene::ClearActorCells) 
Batch #1640 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_17689 WorldScene::ClearActorCells: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 19:16:57 +00:00
ragnarok-clanker
9dbf24ec67 Decompile 2 functions in Source/Contents/Ground/GroundDecals.cpp, Source/Contents/Ground/GroundGeometry.h 
Batch #1631 by eAthena: 2 byte-identical, 0 confirmed by peer review.

- fn_17588 GroundGeometry::Slot14: byte-identical
- fn_17603 GroundGeometry::Slot16: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 19:16:42 +00:00
ragnarok-clanker
f464cd3f17 Decompile 41 functions in Source/Client/Input/InputCharset.cpp, Source/Client/Input/InputCharset.h, ... 
Batch #1607 by ragnarok-clanker: 0 byte-identical, 41 confirmed by peer review.

- fn_11718 DrawItemIconById: logic confirmed by peer review
- fn_11719 DrawItemSlotBackground: logic confirmed by peer review
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review
- fn_12085 UIWindow::DrawPanelBackground: logic confirmed by peer review
- fn_12086 UIWindow::DrawPanelBackgroundAt: logic confirmed by peer review
- fn_12088 UIWindow::DrawButtonBar: logic confirmed by peer review
- fn_12089 UIWindow::DrawButtonBarAt: logic confirmed by peer review
- fn_12098 UIWindow::DrawTitleBar: logic confirmed by peer review
- fn_12099 UIWindow::DrawTitleBarAt: logic confirmed by peer review
- fn_12120 UIWindow::LoadStyledBitmap: logic confirmed by peer review
- fn_12219 UIDisconnectedServerMsgWnd::Paint: logic confirmed by peer review
- fn_12233 UINoticeConfirmWnd::Paint: logic confirmed by peer review
- fn_12245 UIQuitWnd::Paint: logic confirmed by peer review
- fn_12246 UIRestartWnd::Paint: logic confirmed by peer review
- fn_12258 UIWaitWnd::Paint: logic confirmed by peer review
- fn_14470 CUIFrameWnd::RefreshSkinColors: logic confirmed by peer review
- fn_14471 CUIFrameWnd::Paint: logic confirmed by peer review
- fn_14472 CUIFrameWnd::SetSkinColors: logic confirmed by peer review
- fn_14635 CUIControl::LoadBitmapResource: logic confirmed by peer review
- fn_17781 InputCharset::Prefix: logic confirmed by peer review
- fn_17788 InputCharset::ServiceName: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_18378 Resolve: logic confirmed by peer review
- fn_02111 RendererDX7Operations::SaveLogo: logic confirmed by peer review
- fn_09446 UICashEmotionPack::Paint: logic confirmed by peer review
- fn_09453 UICashEmotionPack::SetSaleBadge: logic confirmed by peer review
- fn_09483 UICashEmotionPiece::Paint: logic confirmed by peer review
- fn_45445 CSkinMgr::CSkinMgr: logic confirmed by peer review
- fn_09681 CSkinMgr::~CSkinMgr: logic confirmed by peer review
- fn_09683 CSkinMgr::Prepare: logic confirmed by peer review
- fn_09684 SkinPaletteColor: logic confirmed by peer review
- fn_09685 SkinPaletteChannels: logic confirmed by peer review
- fn_09686 CSkinMgr::Name: logic confirmed by peer review
- fn_09687 CSkinMgr::Prefix: logic confirmed by peer review
- fn_09688 CSkinMgr::Name: logic confirmed by peer review
- fn_09690 CSkinMgr::Selected: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SkinMgr.cpp
 2026-10-28 19:13:07 +00:00
ragnarok-clanker
c1cb6a6f33 Decompile fn_17578 (GroundGeometry::Slot12) 
Batch #1589 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_17578 GroundGeometry::Slot12: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 19:10:58 +00:00
ragnarok-clanker
7dc26e0b3f Decompile fn_22583 (IsIgnoredRidingState) 
Batch #1587 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_22583 IsIgnoredRidingState: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SpriteRidingPolicy.cpp
 2026-10-28 19:10:44 +00:00
ragnarok-clanker
b496a618dc Decompile 2 functions in Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp, ... 
Batch #1582 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23486 CSession::GetRobeAlpha: logic confirmed by peer review
- fn_24176 CSession::IsTopLayerRobe: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp
 2026-10-28 19:10:37 +00:00
ragnarok-clanker
6ffc82d2d0 Decompile fn_24251 (CEffectMaker::CEffectMaker) 
Batch #1563 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_24251 CEffectMaker::CEffectMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/Effects/EffectMaker.cpp
 2026-10-28 19:10:23 +00:00
ragnarok-clanker
b65df98bb0 Decompile fn_04759 (CSoundMgr::Unused) 
Batch #1574 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_04759 CSoundMgr::Unused: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 19:00:16 +00:00
ragnarok-clanker
9312817430 Maintenance: Define two globals that main reads but never defines. g_applicationDirectory (gl_24584, 0x173AD78, char[0x80]) has one w 
Batch #1570 by ragnarok-clanker: no function's compiled code changes; checked with 5 compiled unit(s), including every includer of Source/Client/Application/Launcher.h, Source/Client/Input/InputCharset.h.
 2026-10-28 18:59:30 +00:00
ragnarok-clanker
a182e716f4 Decompile fn_05179 (CGuildMgr::UpdateEmblemRequests) 
Batch #1561 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_05179 CGuildMgr::UpdateEmblemRequests: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 18:57:54 +00:00
ragnarok-clanker
8163309a36 Decompile 2 functions in Source/Contents/Actors/GameObject.cpp, Source/Contents/Actors/RenderObject.h 
Batch #1557 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_21108 CRenderObject::SetActionSpeed: logic confirmed by peer review
- fn_21102 CRenderObject::Draw: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 18:54:18 +00:00
ragnarok-clanker
5b8f2cfb1f Decompile 12 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ... 
Batch #1554 by ragnarok-clanker: 0 byte-identical, 12 confirmed by peer review.

- fn_21278 CGameMode::WorldCell: logic confirmed by peer review (already on main)
- fn_19599 CNavigationManager::LoadStates: logic confirmed by peer review (annotation added to existing code)
- fn_19394 CNaviData::ResetLinkDepths: logic confirmed by peer review (annotation added to existing code)
- fn_19390 CNaviData::FindRoute: logic confirmed by peer review (annotation added to existing code)
- fn_19508 CNavi_Link::SetDepth: logic confirmed by peer review (annotation added to existing code)
- fn_19456 CNavi_Link::LinkedEnd: logic confirmed by peer review (annotation added to existing code)
- fn_19444 CNavi_Link::LinkedBegin: logic confirmed by peer review (annotation added to existing code)
- fn_19466 CNaviInfo::LinksBegin: logic confirmed by peer review (annotation added to existing code)
- fn_19467 CNaviInfo::LinksEnd: logic confirmed by peer review (annotation added to existing code)
- fn_19509 CNaviInfo::SetVisited: logic confirmed by peer review (annotation added to existing code)
- fn_19581 CNavigationManager::PlayerCell: logic confirmed by peer review (annotation added to existing code)
- fn_21282 CGameMode::PlayerCell: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
 2026-10-28 18:50:46 +00:00
ragnarok-clanker
7a9ea8ab29 Decompile fn_17691 (WorldScene::Clear) 
Batch #1549 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17691 WorldScene::Clear: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-28 18:50:15 +00:00
ragnarok-clanker
4cf3413524 Decompile 4 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ... 
Batch #1556 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_19489 CNavi_Link::GetLinkedInfo: byte-identical
- fn_19481 CNaviInfo::IsVisited: byte-identical
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/NavigationDestinations.cpp, Source/Contents/NavigationGraph.cpp, Source/Contents/WorldNavigation.cpp
 2026-10-28 18:48:31 +00:00
ragnarok-clanker
9541f2ff09 Decompile 4 functions in Source/Contents/TerrainPathSearch.cpp, Source/Contents/TerrainPathSearch.h 
Batch #1547 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_17868 CPathFinder::FindPath: logic confirmed by peer review
- fn_17875 CPathFinder::FindOrCreateNode: logic confirmed by peer review
- fn_17882 CPathFinder::AddNeighbor: logic confirmed by peer review
- fn_17884 CPathFinder::Clear: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 18:20:56 +00:00
ragnarok-clanker
4c1960b206 Decompile 14 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h, ... 
Batch #1540 by ragnarok-clanker: 0 byte-identical, 14 confirmed by peer review.

- fn_19436 CNavi_Link::`scalar deleting destructor': logic confirmed by peer review
- fn_19483 CNavi_Link::GetCell: logic confirmed by peer review
- fn_19497 CNavi_Link::GetInfo: logic confirmed by peer review
- fn_19387 CNaviData::SetDestination: logic confirmed by peer review
- fn_19638 CNavigationManager::UpdateGround: logic confirmed by peer review
- fn_19364 CNaviData::CNaviData: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review
- fn_19429 CNaviInfo::~CNaviInfo: logic confirmed by peer review
- fn_19551 CNavigationManager::CNavigationManager: logic confirmed by peer review
- fn_19574 CNavigationManager::ClearRouteNodes: logic confirmed by peer review
- fn_19575 CNavigationManager::ClearNodePaths: logic confirmed by peer review
- fn_19593 CNavigationManager::Reset: logic confirmed by peer review
- fn_45448 CNavigationManager::~CNavigationManager: logic confirmed by peer review
- fn_45452 CNavigationManager::GetLinkedPlayerInfo: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 17:40:11 +00:00
ragnarok-clanker
dfadb24ce5 Decompile 5 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h, ... 
Batch #1541 by ragnarok-clanker: 5 byte-identical, 0 confirmed by peer review.

- fn_19473 CNavi_Link::GetTitle: byte-identical
- fn_19475 CNavi_Link::GetName: byte-identical
- fn_19487 CNavi_Link::GetIndex: byte-identical
- fn_19492 CNavi_Link::GetType: byte-identical
- fn_19494 CNavi_Link::GetId: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/NavigationLink.cpp
 2026-10-28 17:38:51 +00:00
ragnarok-clanker
7472beae2d Decompile 3 functions in Source/Contents/TipBoxTitles.cpp, Source/Contents/TipBoxTitles.h 
Batch #1499 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_09133 CTipBoxMgr::Search: logic confirmed by peer review (annotation added to existing code)
- fn_09134 CTipBoxMgr::SelectTip: logic confirmed by peer review (annotation added to existing code)
- fn_09118 TipBoxEntry::TipBoxEntry: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-28 17:27:02 +00:00
ragnarok-clanker
84b010ff82 Decompile fn_04058 (CUserHotkeyMgr::TabAt) 
Batch #1537 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_04058 CUserHotkeyMgr::TabAt: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 17:22:25 +00:00
ragnarok-clanker
3c5e940a6d Decompile 31 functions in Source/Contents/NavigationManager.h, Source/Contents/NavigationRequest.cpp, ... 
Batch #1503 by ragnarok-clanker: 12 byte-identical, 19 confirmed by peer review.

- fn_19461 CNavi_Object::GetFlag: logic confirmed by peer review
- fn_19474 CNavi_Object::GetTitle: byte-identical
- fn_19476 CNaviInfo::GetTitle: byte-identical
- fn_19477 CNavi_Object::GetName: byte-identical
- fn_19484 CNavi_Object::GetCell: logic confirmed by peer review
- fn_19485 CNaviInfo::GetName: byte-identical
- fn_19488 CNavi_Object::GetIndex: byte-identical
- fn_19493 CNavi_Object::GetType: byte-identical
- fn_19495 CNavi_Object::GetId: byte-identical
- fn_19498 CNavi_Object::GetInfo: byte-identical
- fn_19376 CNavigationManager::FindObject: logic confirmed by peer review
- fn_19378 CNaviData::GetCell: logic confirmed by peer review
- fn_19380 CNaviData::GetInfo: byte-identical
- fn_19430 CNavi_Object::~CNavi_Object: logic confirmed by peer review
- fn_19434 CNaviInfo::HasName: logic confirmed by peer review
- fn_19604 CNavigationManager::SelectedNodeText: logic confirmed by peer review
- fn_19605 CNavigationManager::SubDestinationText: logic confirmed by peer review
- fn_19606 CNavigationManager::DestinationText: logic confirmed by peer review
- fn_19607 CNavigationManager::DestinationTitle: logic confirmed by peer review
- fn_19613 CNavigationManager::LoadSettings: logic confirmed by peer review
- fn_19618 CNavigationManager::FitToSquare: logic confirmed by peer review
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19588 CNavigationManager::GetCurrentTarget: logic confirmed by peer review
- fn_19589 CNavigationManager::GetCurrentTargetName: logic confirmed by peer review
- fn_19590 CNavigationManager::GetSavedTarget: logic confirmed by peer review
- fn_19591 CNavigationManager::GetDestinationInfo: byte-identical
- fn_19592 CNavigationManager::GetDestinationCell: logic confirmed by peer review
- fn_19594 CNavigationManager::ClearData: logic confirmed by peer review
- fn_19596 CNavigationManager::IsCurrentTarget: logic confirmed by peer review
- fn_19597 CNavigationManager::GetCurrentTargetType: byte-identical
- fn_19635 CNavigationManager::SaveCurrentTarget: byte-identical

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/NavigationRequest.cpp
 2026-10-28 17:20:17 +00:00
ragnarok-clanker
9607e27ae2 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-28 18:12:18 +01:00
ragnarok-clanker
7a679497ea 📚 docs(RagEffectState): corrected field offset comments 2026-10-28 18:12:16 +01:00
ragnarok-clanker
41858e4aff Maintenance: Remove the annotations of fn_22365/67/73/75 now that their tasks are skipped as compiler generated (batch 1498): each is 
Batch #1502 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s).
 2026-10-28 17:09:55 +00:00
ragnarok-clanker
ed210d3dfb Decompile 2 functions in Source/Contents/TipBoxTitles.cpp, Source/Contents/TipBoxTitles.h 
Batch #1501 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_09131 CTipBoxMgr::HasImages: byte-identical
- fn_09132 CTipBoxMgr::HasSearchResults: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 17:09:25 +00:00
ragnarok-clanker
d58f8f5ac1 Decompile 2 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Sound/SoundMaker.h 
Batch #1494 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_22406 CSoundMaker::Update: logic confirmed by peer review
- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 17:03:51 +00:00
ragnarok-clanker
07e0e8c45c 📚 docs(RagEffectState): corrected field offset comments 2026-10-28 17:59:04 +01:00
ragnarok-clanker
50d48d14dc 🔥 refactor(effects): removed unused header includes 2026-10-28 17:54:10 +01:00
ragnarok-clanker
63b1377599 Decompile 5 functions in Source/Client/ReplayPacketRecorder.h, Source/Contents/Emblems/EmblemUpload.h, ... 
Batch #1488 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18386 PacketLengths::IsRecorded: logic confirmed by peer review
- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18388 PacketLengths::Lookup: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
- fn_18171 ResourceFailures::Report: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 16:45:10 +00:00
ragnarok-clanker
6c9430e9a1 🔥 refactor(effects): removed unused header includes 2026-10-28 17:41:29 +01:00
ragnarok-clanker
e4be41defa Maintenance: Replace numeric case labels in SelectRagEffectResource with RagEffectID EF_* enumerators from EffectTypes.h; each value 
Batch #1485 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s).
 2026-10-28 16:29:31 +00:00
ragnarok-clanker
3863fe6f3c Decompile 6 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Contents/Jobs/JobInheritance.h, ... 
Batch #1478 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_23898 GetDualWieldWeaponType: logic confirmed by peer review
- fn_23583 IsJobWeaponAllowed: logic confirmed by peer review
- fn_23836 GetJobTitleString: logic confirmed by peer review
- fn_23909 CSession::InsertPair: logic confirmed by peer review
- fn_23911 CSession::SetHotkeyEntry: logic confirmed by peer review
- fn_23912 CSession::SetFlag: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 15:38:29 +00:00
ragnarok-clanker
9d7fe49b7e Decompile 10 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h 
Batch #1466 by ragnarok-clanker: 0 byte-identical, 10 confirmed by peer review.

- fn_23639 CSession::AddItemSlot: logic confirmed by peer review
- fn_23640 CSession::GetShop: logic confirmed by peer review
- fn_23641 CSession::SetShopFlag: logic confirmed by peer review
- fn_23642 CSession::SetShopItem: logic confirmed by peer review
- fn_23643 CSession::AddShopName: logic confirmed by peer review
- fn_23646 CSession::SetUnknown8134: logic confirmed by peer review
- fn_23647 CSession::ClearUnknown1710: logic confirmed by peer review
- fn_23648 CSession::ClearUnknown1740: logic confirmed by peer review
- fn_23649 CSession::ClearUnknown1738: logic confirmed by peer review
- fn_23650 CSession::SyncServerTime: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 15:38:10 +00:00
ragnarok-clanker
3b469b8970 Decompile fn_21015 (CRenderObject::JitterBounds) 
Batch #1460 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21015 CRenderObject::JitterBounds: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 15:37:50 +00:00
ragnarok-clanker
16b72c624f Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Contents/Skills/ClientSkills.h, ... 
Batch #1471 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23753 CSession::ResetItems2B50: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 15:32:17 +00:00
ragnarok-clanker
447fa8b9f6 Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Contents/Jobs/JobInheritance.h, ... 
Batch #1470 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23590 IsVisibleJob: logic confirmed by peer review
- fn_23841 GetWeaponViewValue: logic confirmed by peer review
- fn_23906 ResetHotkeySlots: logic confirmed by peer review
- fn_23910 CSession::SetPairValue: logic confirmed by peer review

Peer-reviewed-by: Kisuka, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 14:13:00 +00:00
ragnarok-clanker
c351db5d57 Decompile 4 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h 
Batch #1467 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23466 CSession::GetServerTime: logic confirmed by peer review
- fn_23605 CSession::AddPingSample: logic confirmed by peer review
- fn_23637 CSession::SetServerTime: logic confirmed by peer review
- fn_23638 CSession::SetHotkeyDescription: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/ClientTiming.cpp
 2026-10-28 14:02:41 +00:00
ragnarok-clanker
b9474e7c82 Decompile fn_23379 (CSession::HomunSkillLevel) 
Batch #1465 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23379 CSession::HomunSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 13:55:33 +00:00
ragnarok-clanker
17def7f7e4 Decompile fn_04340 (CRenderObject::GetInstant) 
Batch #1458 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_04340 CRenderObject::GetInstant: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 13:29:33 +00:00
ragnarok-clanker
73cc345898 Decompile 7 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ... 
Batch #1447 by Yommy: 0 byte-identical, 7 confirmed by peer review.

- fn_03435 CMapSkyMgr::LoadData: logic confirmed by peer review
- fn_23794 CSession::GetAccessoryName: logic confirmed by peer review
- fn_17667 WorldActors::Lookup: logic confirmed by peer review
- fn_17698 WorldObjects::SendObjectMessage: logic confirmed by peer review
- fn_17865 CPathFinder::~CPathFinder: logic confirmed by peer review
- fn_18334 LuaScript::TableField: logic confirmed by peer review
- fn_07925 CImfRes::Load: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-28 13:18:31 +00:00
ragnarok-clanker
a0aa87c8b2 Decompile 2 functions in Source/Contents/EffectResourceSwitcher.cpp, Source/Contents/Effects/Effect.h 
Batch #1444 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_03085 CEffect::Slot11: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-28 13:15:24 +00:00
ragnarok-clanker
f0f09ed3c6 Decompile 7 functions in Source/Contents/CashEmotionMgr.cpp, Source/Contents/CashEmotionMgr.h, ... 
Batch #1437 by Yommy: 0 byte-identical, 7 confirmed by peer review.

- fn_09439 UICashEmotionPack::~UICashEmotionPack: logic confirmed by peer review
- fn_09446 UICashEmotionPack::Paint: logic confirmed by peer review
- fn_09450 UICashEmotionPack::Slot19: logic confirmed by peer review
- fn_09451 UICashEmotionPack::Slot35: logic confirmed by peer review
- fn_09452 UICashEmotionPack::SendMsg: logic confirmed by peer review
- fn_09453 UICashEmotionPack::SetSaleBadge: logic confirmed by peer review
- fn_09454 UICashEmotionPack::SetTitle: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 13:15:15 +00:00