Commit graph

26 commits

Author SHA1 Message Date
ragnarok-clanker
0d3aba1c52 Decompile 9 functions in Source/Client/Mode/GameModeNames.cpp, Source/Client/Mode/CGameMode.h, ...
Batch #2124 by ragnarok-clanker: 0 byte-identical, 9 confirmed by peer review.

- fn_21263 CGameMode::FindUnknown01AC: logic confirmed by peer review
- fn_21264 CGameMode::ActorName: logic confirmed by peer review
- fn_21265 CGameMode::ActorNameColor: logic confirmed by peer review
- fn_21266 CGameMode::LookupNameCard: logic confirmed by peer review
- fn_21272 CGameMode::DragItemName: logic confirmed by peer review
- fn_21273 CGameMode::AppendGuildEmblem: logic confirmed by peer review
- fn_17814 IsMonsterJob: logic confirmed by peer review
- fn_23368 CSession::GetItem17F0: logic confirmed by peer review
- fn_24184 CSession::IsAllyActor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 12:57:42 +00:00
ragnarok-clanker
dcc654e1d6 Decompile 2 functions in Source/Client/Mode/ModeLifetime.cpp, Source/Contents/Configuration/ServiceConfiguration.cpp, ...
Batch #2128 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17819 SetServiceFlags: logic confirmed by peer review
- fn_17822 CMode::`scalar deleting destructor': logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/Mode/ModeLifetime.cpp
2026-10-29 12:55:03 +00:00
ragnarok-clanker
b5682471b4 Decompile 3 functions in Source/Client/Mode/GameModeNames.cpp, Source/Client/Mode/CGameMode.h, ...
Batch #2125 by ragnarok-clanker: 3 byte-identical, 0 confirmed by peer review.

- fn_21267 CSession::Text8104: byte-identical
- fn_21268 CSession::Text80EC: byte-identical
- fn_17813 MonsterJobColor: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Client/Mode/GameModeNames.cpp
2026-10-29 12:17:07 +00:00
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
3f11ad6407 Decompile fn_21245 (CGameMode::CanFindPath)
Batch #2107 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21245 CGameMode::CanFindPath: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:27:21 +00:00
ragnarok-clanker
3a6bebae77 Decompile 7 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/Player.cpp, ...
Batch #2092 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_21037 CGameActor::Slot37: logic confirmed by peer review
- fn_21074 CGameActor::Slot38: logic confirmed by peer review
- fn_21199 CGameActor::Slot39: logic confirmed by peer review
- fn_22619 CGrannyPc::Slot39: logic confirmed by peer review
- fn_22620 CPc::Slot39: logic confirmed by peer review
- fn_22354 CCorpse::CCorpse: logic confirmed by peer review
- fn_21301 CGameMode::SpawnCorpse: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:04:49 +00:00
ragnarok-clanker
2d34af20fc Decompile fn_17824 (CMode::DrawCursor)
Batch #1970 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17824 CMode::DrawCursor: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/ModeCursorDrawing.cpp
2026-10-29 09:01:52 +00:00
ragnarok-clanker
86b21d5ec7 Decompile fn_17848 (CMode::TakeScreenshot)
Batch #1895 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_17848 CMode::TakeScreenshot: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:22:44 +00:00
ragnarok-clanker
20a2647c7a Decompile fn_21269 (CGameMode::SubcellPosition)
Batch #1886 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21269 CGameMode::SubcellPosition: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:17:28 +00:00
ragnarok-clanker
0cffe990b0 Decompile fn_17832 (CWorld::ActiveLoginMode)
Batch #1890 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_17832 CWorld::ActiveLoginMode: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 23:15:57 +00:00
ragnarok-clanker
ff83912b6b Decompile 9 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Session.h, ...
Batch #1711 by ragnarok-clanker: 0 byte-identical, 9 confirmed by peer review.

- fn_23304 SessionMessengerContext::UpdateRandomStats: logic confirmed by peer review
- fn_05603 EquipmentPropertyStore::EquipmentPropertyStore: logic confirmed by peer review
- fn_05771 EquipmentPropertyStore::Clear: logic confirmed by peer review
- fn_05740 EquipmentPropertyStore::~EquipmentPropertyStore: logic confirmed by peer review
- fn_05807 EquipmentPropertyGroup::~EquipmentPropertyGroup: logic confirmed by peer review
- fn_06013 EquipmentProperties::CEquipmentPropertiesMgr::CEquipmentPropertiesMgr: logic confirmed by peer review
- fn_06170 EquipmentProperties::CEquipmentPropertiesMgr::Clear: logic confirmed by peer review
- fn_17276 UIWindowMgr::NotifyItemWindows: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:41:46 +00:00
ragnarok-clanker
faae91cc6d Decompile fn_17826 (CMode::DrawTexture)
Batch #1600 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17826 CMode::DrawTexture: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:49:26 +00:00
ragnarok-clanker
4f48baf914 Decompile 2 functions in Source/Client/ModeTransitions.cpp, Source/Client/Mode/ActiveGameMode.h
Batch #1610 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17845 CWorld::Quit: logic confirmed by peer review
- fn_17851 CWorld::Switch: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/ModeTransitions.cpp
2026-10-28 19:44:21 +00:00
ragnarok-clanker
1ebead0e33 Decompile fn_21632 (CGameMode::ReceiveActorNameAll)
Batch #1591 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21632 CGameMode::ReceiveActorNameAll: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Network/ActorNamePacket.cpp
2026-10-28 19:42:41 +00:00
ragnarok-clanker
4cf3413524 Decompile 4 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ...
Batch #1556 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_19489 CNavi_Link::GetLinkedInfo: byte-identical
- fn_19481 CNaviInfo::IsVisited: byte-identical
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/NavigationDestinations.cpp, Source/Contents/NavigationGraph.cpp, Source/Contents/WorldNavigation.cpp
2026-10-28 18:48:31 +00:00
ragnarok-clanker
26ff979bde Decompile 3 functions in Source/UI/Window/UIWindow.cpp, Source/Client/Mode/CGameMode.h, ...
Batch #1400 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_03560 UIWindow::Slot44: logic confirmed by peer review
- fn_03565 CGameMode::MapName: logic confirmed by peer review
- fn_03568 UINavigationV4Wnd::IsListShown: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:35:57 +00:00
ragnarok-clanker
097ad1eee0 Maintenance: Add data-only CGameMode and CView layout headers (no methods; worker versions declared 6-7 methods with no definitions).
Batch #1320 by ragnarok-clanker: no function's compiled code changes; checked with 0 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Contents/Camera/Camera.h.
2026-10-28 09:47:03 +00:00
ragnarok-clanker
967adbbc52 Decompile 2 functions in Source/Client/Mode/ActiveGameMode.cpp
Batch #1293 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_17836 CMode::End: byte-identical
- fn_17837 CMode::Initialize: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 06:32:11 +00:00
ragnarok-clanker
48e41cae16 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Client headers (Browser, Input, Mode)
Batch #1059 by ragnarok-clanker: no function's compiled code changes; checked with 21 compiled unit(s), including every includer of Source/Client/Browser/WebBrowser.h, Source/Client/Browser/WebEventReceiver.h, Source/Client/Input/Mouse.h, Source/Client/Input/TraditionalKeyInput.h, Source/Client/Mode/ModeCursor.h.
2026-10-27 13:42:38 +00:00
ragnarok-clanker
fbdc231444 Decompile 5 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1048 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_17219 UIWindowMgr::Schedule: logic confirmed by peer review
- fn_17235 UIWindowMgr::DismissTransient: logic confirmed by peer review
- fn_17237 UIWindowMgr::Destroy: logic confirmed by peer review
- fn_17833 ModeTooltip::Clear: logic confirmed by peer review
- fn_17843 ModeTooltip::Expire: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-27 12:07:15 +00:00
ragnarok-clanker
d73c3c1296 Decompile 5 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1025 by ragnarok-clanker: 5 byte-identical, 0 confirmed by peer review.

- fn_17831 CWorld::ActiveGameMode: byte-identical
- fn_19302 ReplaySection::ReplaySection: byte-identical (already on main)
- fn_19306 ReplaySection::~ReplaySection: byte-identical (already on main)
- fn_17835 CMode::Slot7: byte-identical
- fn_17838 CMode::Slot5: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 09:38:13 +00:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00
ragnarok-clanker
f575258340 Maintenance: Define every global once in its owner unit; session members replace member globals
Batch #906 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Client/Session.h, Source/Client/Registry.h, Source/Client/Application/LaunchInfo.h, Source/Client/Application/Launcher.h, Source/Client/Mode/ActiveGameMode.h, Source/Render/DeviceSelection.h.
Adds to the build: Source/Client/Session.cpp, Source/Client/Registry.cpp, Source/Client/Application/LaunchInfo.cpp, Source/Render/DeviceSelection.cpp
2026-10-26 18:34:25 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00