clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
782 commits 1 branch 0 tags 15 MiB
Commit graph

69 commits

Author SHA1 Message Date
ragnarok-clanker
87bb32cef8 Decompile 48 functions in Source/Client/ModeFade.cpp, Source/Client/ModeFade.h, ... 
Batch #2457 by ragnarok-clanker: 0 byte-identical, 48 confirmed by peer review.

- fn_00152 TextureCache::TextureCache: logic confirmed by peer review
- fn_01952 DrawAlphaRectangle: logic confirmed by peer review
- fn_01953 DrawBlendedRectangle: logic confirmed by peer review
- fn_01954 DrawTexturedRectangle: logic confirmed by peer review
- fn_01955 DrawTextureRegion: logic confirmed by peer review
- fn_02237 CRendererDX9::SaveLogo: logic confirmed by peer review
- fn_02353 CRenderSystemDX9::CRenderSystemDX9: logic confirmed by peer review
- fn_02447 TextureCache::~TextureCache: logic confirmed by peer review (already on main)
- fn_02449 TextureCache::Upload: logic confirmed by peer review
- fn_02451 TextureCache::Clear: logic confirmed by peer review (already on main)
- fn_02452 TextureCache::Remove: logic confirmed by peer review (already on main)
- fn_02453 TextureCache::Default: logic confirmed by peer review
- fn_02454 TextureCache::Load: logic confirmed by peer review (already on main)
- fn_02455 TextureCache::Create: logic confirmed by peer review
- fn_02456 TextureCache::Reload: logic confirmed by peer review
- fn_02457 TextureCache::ClearUnused: logic confirmed by peer review
- fn_07897 EZeffectClip::Texture: logic confirmed by peer review
- fn_07898 EZeffectClip::Texture: logic confirmed by peer review
- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review
- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review
- fn_08010 C3dGrannyModelRes::CreateTexture: logic confirmed by peer review
- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review
- fn_09166 BinkMovies::Update: logic confirmed by peer review
- fn_10122 UIRPData::DrawNamed: logic confirmed by peer review
- fn_12091 UIWhisperWnd::Slot43: logic confirmed by peer review
- fn_17556 GroundGeometry::Build: logic confirmed by peer review
- fn_17565 GroundGeometry::BuildLightmaps: logic confirmed by peer review
- fn_17581 GroundWaterState::Update: logic confirmed by peer review
- fn_17587 GroundGeometry::DrawGrid: logic confirmed by peer review
- fn_17599 GroundWaterState::Import: logic confirmed by peer review
- fn_17842 ModeFade::Draw: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_20019 CRagEffect::Blessing: logic confirmed by peer review
- fn_20023 CRagEffect::Bottom: logic confirmed by peer review
- fn_20024 CRagEffect::BowlingBash: logic confirmed by peer review
- fn_20025 CRagEffect::CartRevolution: logic confirmed by peer review
- fn_20042 CRagEffect::Entry: logic confirmed by peer review
- fn_20054 CRagEffect::FrostDiver: logic confirmed by peer review
- fn_20058 CRagEffect::GrimTooth: logic confirmed by peer review
- fn_20066 CRagEffect::Hit4: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20105 CRagEffect::SonicBlowHit: logic confirmed by peer review
- fn_20109 CRagEffect::SprayPond: logic confirmed by peer review
- fn_20124 CRagEffect::Yufitel: logic confirmed by peer review
- fn_20132 CRagEffect::AirTexture: logic confirmed by peer review
- fn_20133 CRagEffect::AttackEnergy2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 18:23:21 +00:00
ragnarok-clanker
b03935e409 Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h, ... 
Batch #2139 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_20075 CRagEffect::InitEZ2STRFrame: logic confirmed by peer review
- fn_20095 CRagEffect::ProcessEZ2STR: logic confirmed by peer review
- fn_20326 CRagEffect::ShieldCharge: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 14:38:19 +00:00
ragnarok-clanker
dc2f3a8f88 Align method names with DHXJ (call-graph matches): CEffectPrim::Prim3DParticle/Prim3DParticleNoMaster/Prim3DParticleOrbit, matrix::AppendScale/AppendXRotation/AppendZRotation/AppendTranslate/MakeYRotation/MakeZRotation, CRenderObject::CalcDist (2 overloads). Pure rename, codegen unchanged (504/504 functions identical with includers). 2026-10-29 13:12:37 +01:00
ragnarok-clanker
e9b98b8c69 Rename AffineMatrix -> matrix (DHXJ); clashes with variables named matrix use the elaborated form 'struct matrix'. Pure rename, codegen unchanged (383/383 functions identical with includers). 2026-10-29 12:33:14 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
e4be8f4190 Decompile 18 functions in Source/Client/Application/UnhandledExceptionHandler.cpp, Source/Client/Session.h, ... 
Batch #2077 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_04709 TopLevelExceptionFilter: logic confirmed by peer review (already on main)
- fn_08004 C3dGrannyModelRes::PlayAnimation: logic confirmed by peer review
- fn_09315 UIRequestJoinPartyWnd::SendMsg: logic confirmed by peer review
- fn_19761 EffectParticle::EffectParticle: logic confirmed by peer review
- fn_19768 EffectParticle::InitializeRecords: logic confirmed by peer review
- fn_20007 AttachedEffect::AttachedEffect: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20991 CRenderObject::CRenderObject: logic confirmed by peer review
- fn_21069 ?CreatePartyEffect@?A0xba063134@@YAPAUAttachedEffect@@AAUEffectActor@@AAUPartyEffectMode@@@Z: logic confirmed by peer review
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review
- fn_23396 CSession::GetJobName: logic confirmed by peer review
- fn_23495 CSession::InitJobNameTable: logic confirmed by peer review
- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23791 CSession::GetMonsterTalkText: logic confirmed by peer review
- fn_20987 EffectActor::EffectActor: logic confirmed by peer review
- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review
- fn_24251 CEffectMaker::CEffectMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 09:48:08 +00:00
ragnarok-clanker
755f1d6eb6 Decompile fn_08019 (GrannyAnimationLibrary::ReadAnimationFile) 
Batch #1983 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_08019 GrannyAnimationLibrary::ReadAnimationFile: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-29 08:58:27 +00:00
ragnarok-clanker
c14ddddccf Decompile fn_18175 (ResourceMgr::Load) 
Batch #1900 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_18175 ResourceMgr::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 23:26:18 +00:00
ragnarok-clanker
95a451f8e5 Decompile 2 functions in Source/Resource/Models/AnimatedModelResource.cpp, Source/Resource/Models/GrannyModelResource.h 
Batch #1888 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_07961 C3dGrannyModelRes::Create: logic confirmed by peer review
- fn_07963 C3dGrannyModelRes::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 23:17:16 +00:00
ragnarok-clanker
b68718f749 Decompile 5 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/ModelResource.h, ... 
Batch #1850 by Yommy: 2 byte-identical, 3 confirmed by peer review.

- fn_08014 C3dModelRes::ForEachRootName: logic confirmed by peer review
- fn_08015 C3dGrannyModelRes::GetTriangleCount: logic confirmed by peer review
- fn_08016 C3dGrannyModelRes::GetRigidVertices: logic confirmed by peer review
- fn_08017 GrannyAnimationLibrary::Initialize: byte-identical
- fn_08018 C3dModelRes::Load: byte-identical

Reviewed-by: ragnarok-clanker
 2026-10-28 22:53:13 +00:00
ragnarok-clanker
968a6dcdfc Decompile fn_18191 (ResourceMgr::ClearExpired) 
Batch #1832 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18191 ResourceMgr::ClearExpired: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 22:45:59 +00:00
ragnarok-clanker
97293fce11 Decompile 3 functions in Source/Resource/EmblemResource.cpp, Source/Resource/EmblemResource.h, ... 
Batch #1823 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_07880 CEmblemRes::Create: logic confirmed by peer review
- fn_07881 CEmblemRes::Load: logic confirmed by peer review
- fn_07885 CEmblemRes::MissingFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:43:54 +00:00
ragnarok-clanker
903f26c3f2 Decompile 3 functions in Source/Resource/EmblemResource.cpp, Source/Resource/EmblemResource.h, ... 
Batch #1826 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_07882 CEmblemRes::Unload: byte-identical
- fn_07883 CEmblemRes::Slot02: byte-identical
- fn_07884 CEmblemRes::IsTransient: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Resource/EmblemResource.cpp
 2026-10-28 22:42:32 +00:00
ragnarok-clanker
731d1b60ce Decompile 4 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/ModelResource.h, ... 
Batch #1726 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_08004 C3dGrannyModelRes::PlayAnimation: logic confirmed by peer review
- fn_08005 GrannyAnimationLibrary::Load: logic confirmed by peer review
- fn_08007 AnimatedModelNode::Shade: logic confirmed by peer review
- fn_08008 C3dGrannyModelRes::ProjectBounds: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 21:43:00 +00:00
ragnarok-clanker
7a88edb84c Decompile fn_23848 (CSession::LoadXmlTables) 
Batch #1684 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23848 CSession::LoadXmlTables: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientXmlTables.cpp
 2026-10-28 20:23:55 +00:00
ragnarok-clanker
e45536a0bf Decompile 4 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/GrannyModelResource.h 
Batch #1691 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_08006 C3dGrannyModelRes::RebindMeshes: logic confirmed by peer review
- fn_08009 C3dGrannyModelRes::InstantiateModel: logic confirmed by peer review
- fn_08010 C3dGrannyModelRes::CreateTexture: logic confirmed by peer review
- fn_08011 C3dGrannyModelRes::FreeControl: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:21:13 +00:00
ragnarok-clanker
916347b79a Decompile fn_18182 (ResourceMgr::Exists) 
Batch #1614 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_18182 ResourceMgr::Exists: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/ResourcePresence.cpp
 2026-10-28 19:50:12 +00:00
ragnarok-clanker
f464cd3f17 Decompile 41 functions in Source/Client/Input/InputCharset.cpp, Source/Client/Input/InputCharset.h, ... 
Batch #1607 by ragnarok-clanker: 0 byte-identical, 41 confirmed by peer review.

- fn_11718 DrawItemIconById: logic confirmed by peer review
- fn_11719 DrawItemSlotBackground: logic confirmed by peer review
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review
- fn_12085 UIWindow::DrawPanelBackground: logic confirmed by peer review
- fn_12086 UIWindow::DrawPanelBackgroundAt: logic confirmed by peer review
- fn_12088 UIWindow::DrawButtonBar: logic confirmed by peer review
- fn_12089 UIWindow::DrawButtonBarAt: logic confirmed by peer review
- fn_12098 UIWindow::DrawTitleBar: logic confirmed by peer review
- fn_12099 UIWindow::DrawTitleBarAt: logic confirmed by peer review
- fn_12120 UIWindow::LoadStyledBitmap: logic confirmed by peer review
- fn_12219 UIDisconnectedServerMsgWnd::Paint: logic confirmed by peer review
- fn_12233 UINoticeConfirmWnd::Paint: logic confirmed by peer review
- fn_12245 UIQuitWnd::Paint: logic confirmed by peer review
- fn_12246 UIRestartWnd::Paint: logic confirmed by peer review
- fn_12258 UIWaitWnd::Paint: logic confirmed by peer review
- fn_14470 CUIFrameWnd::RefreshSkinColors: logic confirmed by peer review
- fn_14471 CUIFrameWnd::Paint: logic confirmed by peer review
- fn_14472 CUIFrameWnd::SetSkinColors: logic confirmed by peer review
- fn_14635 CUIControl::LoadBitmapResource: logic confirmed by peer review
- fn_17781 InputCharset::Prefix: logic confirmed by peer review
- fn_17788 InputCharset::ServiceName: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_18378 Resolve: logic confirmed by peer review
- fn_02111 RendererDX7Operations::SaveLogo: logic confirmed by peer review
- fn_09446 UICashEmotionPack::Paint: logic confirmed by peer review
- fn_09453 UICashEmotionPack::SetSaleBadge: logic confirmed by peer review
- fn_09483 UICashEmotionPiece::Paint: logic confirmed by peer review
- fn_45445 CSkinMgr::CSkinMgr: logic confirmed by peer review
- fn_09681 CSkinMgr::~CSkinMgr: logic confirmed by peer review
- fn_09683 CSkinMgr::Prepare: logic confirmed by peer review
- fn_09684 SkinPaletteColor: logic confirmed by peer review
- fn_09685 SkinPaletteChannels: logic confirmed by peer review
- fn_09686 CSkinMgr::Name: logic confirmed by peer review
- fn_09687 CSkinMgr::Prefix: logic confirmed by peer review
- fn_09688 CSkinMgr::Name: logic confirmed by peer review
- fn_09690 CSkinMgr::Selected: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SkinMgr.cpp
 2026-10-28 19:13:07 +00:00
ragnarok-clanker
9162deb256 Decompile fn_07938 (CImfRes::GetLayer) 
Batch #1560 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_07938 CImfRes::GetLayer: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/ImfLayerIndex.cpp
 2026-10-28 19:10:16 +00:00
ragnarok-clanker
f0050dbf61 Decompile 3 functions in Source/Resource/Models/ModelResourceV2.cpp, Source/Resource/Models/ModelResource.h 
Batch #1548 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 18:21:44 +00:00
ragnarok-clanker
63b1377599 Decompile 5 functions in Source/Client/ReplayPacketRecorder.h, Source/Contents/Emblems/EmblemUpload.h, ... 
Batch #1488 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18386 PacketLengths::IsRecorded: logic confirmed by peer review
- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18388 PacketLengths::Lookup: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
- fn_18171 ResourceFailures::Report: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 16:45:10 +00:00
ragnarok-clanker
865d8a45e2 Decompile fn_07750 (CActRes::Load) 
Batch #1483 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_07750 CActRes::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 16:23:38 +00:00
ragnarok-clanker
ca5b834cf3 Decompile 3 functions in Source/Resource/Audio/WaveResource.cpp, Source/Resource/Audio/WaveResource.h 
Batch #1228 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_08066 CWave::Create: logic confirmed by peer review
- fn_08067 CWave::Load: logic confirmed by peer review
- fn_08070 CWave::CWave: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 16:09:55 +00:00
ragnarok-clanker
565716ba36 Decompile 2 functions in Source/Resource/ResourceMgr.cpp, Source/Resource/ResourceMgr.h 
Batch #1480 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18175 ResourceMgr::Load: logic confirmed by peer review
- fn_18176 ResourceMgr::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 15:47:54 +00:00
ragnarok-clanker
73cc345898 Decompile 7 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ... 
Batch #1447 by Yommy: 0 byte-identical, 7 confirmed by peer review.

- fn_03435 CMapSkyMgr::LoadData: logic confirmed by peer review
- fn_23794 CSession::GetAccessoryName: logic confirmed by peer review
- fn_17667 WorldActors::Lookup: logic confirmed by peer review
- fn_17698 WorldObjects::SendObjectMessage: logic confirmed by peer review
- fn_17865 CPathFinder::~CPathFinder: logic confirmed by peer review
- fn_18334 LuaScript::TableField: logic confirmed by peer review
- fn_07925 CImfRes::Load: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-28 13:18:31 +00:00
ragnarok-clanker
f61f0747fa Decompile 2 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ... 
Batch #1449 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_17872 CPathFinder::Height: byte-identical
- fn_17873 CPathFinder::Width: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/MapSkyMgr.cpp, Source/Contents/EquipmentResources.cpp, Source/Contents/Pathfinding.cpp, Source/Resource/ImfResource.cpp
 2026-10-28 12:59:53 +00:00
ragnarok-clanker
cdc3c895f1 Decompile 2 functions in Source/Resource/ResourceMgr.cpp, Source/Resource/ResourceMgr.h 
Batch #1385 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_18209 ResourceMgr::Instance: logic confirmed by peer review
- fn_18189 ResourceMgr::UnloadAll: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 12:08:03 +00:00
ragnarok-clanker
96acca76c3 Decompile fn_02010 (ModelFace::~ModelFace) 
Batch #1356 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02010 ModelFace::~ModelFace: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 11:42:53 +00:00
ragnarok-clanker
b8287f9827 Decompile 5 functions in Source/Resource/XmlParsing.cpp, Source/Resource/XmlNode.h 
Batch #1247 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_18298 XmlNode::Text: logic confirmed by peer review
- fn_18299 XmlNode::DecodeEntity: logic confirmed by peer review
- fn_18300 XmlDocument::TerminateName: logic confirmed by peer review
- fn_18301 XmlDocument::ParseElements: logic confirmed by peer review
- fn_18302 XmlDocument::Parse: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/XmlParsing.cpp
 2026-10-27 23:23:01 +00:00
ragnarok-clanker
79455b041b Decompile 4 functions in Source/Resource/RmaResource.cpp, Source/Resource/RmaResource.h 
Batch #1246 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_07753 CRmaRes::Create: logic confirmed by peer review
- fn_07754 CRmaRes::Load: logic confirmed by peer review
- fn_07755 CRmaRes::Unload: logic confirmed by peer review
- fn_07778 CRmaRes::`scalar deleting destructor': logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/RmaResource.cpp
 2026-10-27 23:22:54 +00:00
ragnarok-clanker
6d4d89a9cc Decompile fn_09154 (BinkMovie::BinkMovie) 
Batch #1219 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_09154 BinkMovie::BinkMovie: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 21:18:48 +00:00
ragnarok-clanker
61943206fb Decompile fn_08054 (CSprRes::Load) 
Batch #1201 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_08054 CSprRes::Load: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-27 21:08:39 +00:00
ragnarok-clanker
347b99c15d Decompile 4 functions in Source/Resource/World/WorldResource.cpp, Source/Resource/World/WorldResource.h, ... 
Batch #1130 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_08071 C3dWorldRes::Create: logic confirmed by peer review
- fn_08073 C3dWorldRes::Load: logic confirmed by peer review
- fn_08076 C3dWorldRes::C3dWorldRes: logic confirmed by peer review
- fn_17681 WorldSpatialTree::ReadBounds: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-27 21:07:47 +00:00
ragnarok-clanker
d8177fe68b Decompile 2 functions in Source/Resource/World/GroundResource.cpp, Source/Resource/World/GroundResource.h 
Batch #1185 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_07909 GroundLegacyLightmap::Decode: logic confirmed by peer review (annotation added to existing code)
- fn_07910 CGndRes::Lightmap: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-27 21:07:31 +00:00
ragnarok-clanker
aa8d6d2427 Decompile 8 functions in Source/Resource/GifResource.cpp, Source/Resource/GifResource.h, ... 
Batch #1132 by eAthena: 0 byte-identical, 8 confirmed by peer review.

- fn_07852 CGifRes::Create: logic confirmed by peer review
- fn_07853 CGifRes::Load: logic confirmed by peer review
- fn_07854 CGifRes::Decode: logic confirmed by peer review
- fn_07855 CGifRes::Unload: logic confirmed by peer review
- fn_07856 CGifRes::Slot02: logic confirmed by peer review
- fn_07857 CGifRes::IsTransient: logic confirmed by peer review
- fn_07865 CGifRes::CreateBlank: logic confirmed by peer review
- fn_07870 CGifRes::DecodeGif: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/GifResource.cpp
 2026-10-27 21:05:50 +00:00
ragnarok-clanker
e44193df72 Decompile fn_07911 (CGndRes::Parse) 
Batch #1189 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_07911 CGndRes::Parse: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-27 21:01:13 +00:00
ragnarok-clanker
c5a61bd331 Decompile fn_07994 (AnimatedModelFrame::~AnimatedModelFrame) 
Batch #1151 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_07994 AnimatedModelFrame::~AnimatedModelFrame: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 20:34:49 +00:00
ragnarok-clanker
2dda6bce1d Decompile 4 functions in Source/Resource/EZeffectResource.h, Source/Resource/EZeffectResource.cpp 
Batch #1088 by ragnarok-clanker: 1 byte-identical, 3 confirmed by peer review.

- fn_07889 CEZeffectRes::Create: logic confirmed by peer review
- fn_07890 CEZeffectRes::Load: logic confirmed by peer review
- fn_07891 CEZeffectRes::Unload: byte-identical
- fn_07893 CEZeffectRes::CEZeffectRes: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 16:36:30 +00:00
ragnarok-clanker
787f0dd3ea Decompile 8 functions in Source/Resource/World/GroundResource.cpp, Source/Resource/World/GroundResource.h, ... 
Batch #1084 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.

- fn_07899 CGndRes::Create: logic confirmed by peer review
- fn_07900 CGndRes::Load: logic confirmed by peer review
- fn_07906 CGndRes::CGndRes: logic confirmed by peer review
- fn_07911 CGndRes::Parse: logic confirmed by peer review
- fn_07912 CGndRes::ReadWater: logic confirmed by peer review
- fn_07828 C3dAttr::Create: logic confirmed by peer review
- fn_07829 C3dAttr::Load: logic confirmed by peer review
- fn_07833 C3dAttr::C3dAttr: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 16:35:37 +00:00
ragnarok-clanker
eb3e3b8b08 Decompile 11 functions in Source/Contents/Models/ModelLighting.cpp, Source/Contents/Models/ModelNode.cpp, ... 
Batch #1082 by ragnarok-clanker: 0 byte-identical, 11 confirmed by peer review.

- fn_02007 ModelMesh::ModelMesh: logic confirmed by peer review
- fn_02009 ModelMesh::~ModelMesh: logic confirmed by peer review
- fn_02011 ModelMesh::CalculateNormals: logic confirmed by peer review
- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review
- fn_07997 AnimatedModelRecord::~AnimatedModelRecord: logic confirmed by peer review
- fn_08023 C3dAnimModelRes::Unload: logic confirmed by peer review
- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review
- fn_17514 C3dNode::AccumulateBounds: logic confirmed by peer review
- fn_17515 C3dNode::SampleGroundColors: logic confirmed by peer review
- fn_17521 C3dNode::Prepare: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 16:31:29 +00:00
ragnarok-clanker
5ec8920fd4 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Resource headers 
Batch #1067 by ragnarok-clanker: no function's compiled code changes; checked with 83 compiled unit(s), including every includer of Source/Resource/Audio/WaveResource.h, Source/Resource/BinkRuntime.h, Source/Resource/Bitmap/BitmapResource.h, Source/Resource/Bitmap/IJL15Runtime.h, Source/Resource/Models/ModelResource.h, Source/Resource/Resource.h, Source/Resource/ResourceAliases.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/WorldResource.h.
 2026-10-27 14:00:13 +00:00
ragnarok-clanker
823aeda193 Decompile 2 functions in Source/Resource/Sprites/ActionResource.cpp, Source/Resource/Sprites/ActionResource.h 
Batch #1042 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_07787 CActRes::Frame: logic confirmed by peer review
- fn_07788 CActRes::FrameCount: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 11:01:42 +00:00
ragnarok-clanker
f3ceb09e9d Merge commit '6c40a36577' 2026-10-27 10:06:35 +00:00
ragnarok-clanker
d22c6b96a6 Decompile 5 functions in Source/Resource/Bitmap/BitmapImage.cpp, Source/Resource/Bitmap/BitmapImage.h, ... 
Batch #1026 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_07866 BitmapImage::CreateAuxiliary: logic confirmed by peer review
- fn_07867 BitmapImage::Pixel: logic confirmed by peer review
- fn_07874 BitmapImage::ClearAuxiliary: logic confirmed by peer review
- fn_09684 SkinPaletteColor: logic confirmed by peer review
- fn_09685 SkinPaletteChannels: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/SkinPalette.cpp
 2026-10-27 10:04:56 +00:00
ragnarok-clanker
07d2f8441c 📝 docs(headers): added inlined comments to method definitions 2026-10-27 10:46:28 +01:00
ragnarok-clanker
e331e03f4c 📝 docs(headers): annotated inlined methods 2026-10-27 10:43:00 +01:00
ragnarok-clanker
ff15df90ad 📝 docs(annotations): marked inlined functions across modules 2026-10-27 10:42:13 +01:00
ragnarok-clanker
3dbd276311 📚 docs(inlining): marked inlined functions across modules 2026-10-27 10:21:57 +01:00
ragnarok-clanker
add868efe7 ♻️ refactor(source): removed unused includes and add INLINE comments 2026-10-27 10:09:10 +01:00