Commit graph

63 commits

Author SHA1 Message Date
ragnarok-clanker
9cbb5257ed Maintenance: Resubmission of 15183 over main 662db5ca. PacketId: switch to the official packet names (names.txt, 1689 entries). 194 e
Batch #15189 by ragnarok-clanker: no function's compiled code changes; checked with 58 compiled unit(s), including every includer of Source/Network/Packets/PacketId.h, Source/Network/Packets/ShortcutPacket.h.
2026-11-09 12:56:29 +00:00
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
521b52384c Maintenance: Replace LookupMessage(<integer>) with the existing MSGSTRINGID constant of the same value (3596 sites, 162 files; each v
Batch #14938 by ragnarok-clanker: no function's compiled code changes; checked with 162 compiled unit(s).
2026-11-08 14:19:01 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 13:56:42 +00:00
ragnarok-clanker
e2d1de3f92 Decompile fn_06317 (CGameSettingsMgr::LoadSettings)
Batch #14824 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_06317 CGameSettingsMgr::LoadSettings: logic confirmed by peer review

Peer-reviewed-by: kyoshi, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 19:07:39 +00:00
ragnarok-clanker
48a326c099 Decompile fn_06352 (ApplyServiceOptionFlags)
Batch #14772 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06352 ApplyServiceOptionFlags: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 17:59:07 +00:00
ragnarok-clanker
140bd9ea19 Decompile 2 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #14709 by secret: 0 byte-identical, 2 confirmed by peer review.

- fn_06322 CGameSettingsMgr::ResetToDefaults: logic confirmed by peer review (already on main)
- fn_06323 CGameSettingsMgr::ToggleOption: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 15:35:54 +00:00
ragnarok-clanker
599505cb52 Decompile fn_06313 (CGameSettingsMgr::RunFunction)
Batch #14666 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_06313 CGameSettingsMgr::RunFunction: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 13:22:36 +00:00
ragnarok-clanker
6fdd9155b6 Decompile fn_06312 (CGameSettingsMgr::SetOption)
Batch #14661 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_06312 CGameSettingsMgr::SetOption: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 13:08:14 +00:00
ragnarok-clanker
9a122dfd1e Decompile 20 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #14471 by SapitoSucio: 0 byte-identical, 20 confirmed by peer review.

- fn_06351 SendConfigServiceOption: logic confirmed by peer review
- fn_06353 ApplyServiceOption: logic confirmed by peer review
- fn_06355 ApplyServiceOptionXmasWeather: logic confirmed by peer review
- fn_06356 ApplyServiceOptionJitterScale: logic confirmed by peer review
- fn_06357 ApplyServiceOptionMapFog: logic confirmed by peer review
- fn_06358 ApplyServiceOptionWithNotice: logic confirmed by peer review
- fn_06360 ApplyServiceOptionActorRefresh: logic confirmed by peer review
- fn_06362 ApplyServiceOptionItemWnd: logic confirmed by peer review
- fn_06363 ApplyServiceOptionWeatherFlag: logic confirmed by peer review
- fn_06366 ApplyServiceOptionSessionFlag: logic confirmed by peer review
- fn_06367 ApplyServiceOptionCursorClip: logic confirmed by peer review
- fn_06369 ApplyServiceOptionAskOnDisable: logic confirmed by peer review (already on main)
- fn_06371 ApplyServiceOptionWindow159: logic confirmed by peer review
- fn_06375 ApplyServiceOptionWindow190: logic confirmed by peer review
- fn_06376 ApplyServiceOptionWindow267: logic confirmed by peer review
- fn_06377 ApplyServiceOptionWindows189: logic confirmed by peer review
- fn_06378 ApplyServiceOptionNotifyWindow: logic confirmed by peer review
- fn_06379 ApplyServiceOptionWindow268: logic confirmed by peer review
- fn_06380 ApplyServiceOptionHideWindow: logic confirmed by peer review
- fn_06384 ApplyServiceOptionAndSnap: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 10:22:29 +00:00
ragnarok-clanker
bfdc0eb315 Decompile fn_06323 (CGameSettingsMgr::ToggleOption)
Batch #14397 by superintelligence: 0 byte-identical, 1 confirmed by peer review.

- fn_06323 CGameSettingsMgr::ToggleOption: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, aDw, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 08:23:56 +00:00
ragnarok-clanker
2f05afd829 Decompile fn_06324 (SetOption)
Batch #13993 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_06324 SetOption: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 04:10:23 +00:00
ragnarok-clanker
a88c398a80 Decompile fn_06351 (SendConfigServiceOption)
Batch #13427 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06351 SendConfigServiceOption: logic confirmed by peer review

Peer-reviewed-by: eAthena, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 19:55:07 +00:00
ragnarok-clanker
be12661f53 Decompile 4 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #13428 by SapitoSucio: 4 byte-identical, 0 confirmed by peer review.

- fn_06368 SendServiceOptionPacket: byte-identical
- fn_06381 EnableWhisperBlock: byte-identical
- fn_06382 DisableWhisperBlock: byte-identical
- fn_06383 SendWhisperBlockPacket: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 16:45:06 +00:00
ragnarok-clanker
f8d3e8622d Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
2026-11-06 16:30:12 +00:00
ragnarok-clanker
fec919b88e Maintenance: Link-completeness fixes so the whole client links into one executable (all units in data/compile.json plus exe-only thir
Batch #13186 by ragnarok-clanker: forced by an admin (40 lower score(s), 206 changed function(s)); checked with 620 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h, Source/Client/Timer.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/ServiceOptions.h, Source/Contents/Skills/SkillTreeScript.h, Source/Render/DX9/D3DX9Runtime.h, Source/Resource/GifResource.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Cooldowns/CooldownOwner.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIReputeWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/EncryptedName.h.
2026-11-06 10:56:48 +00:00
ragnarok-clanker
fbc78b9901 Decompile fn_06315 (CGameSettingsMgr::FindOption)
Batch #12714 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_06315 CGameSettingsMgr::FindOption: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 00:08:48 +00:00
ragnarok-clanker
3f186b1f46 Decompile 15 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #12614 by Yommy: 0 byte-identical, 15 confirmed by peer review.

- fn_06318 ServiceOptions::Get: logic confirmed by peer review
- fn_06320 CGameSettingsMgr::ApplyScriptOption: logic confirmed by peer review
- fn_06325 ServiceOptions::Set: logic confirmed by peer review
- fn_06352 ApplyServiceOptionFlags: logic confirmed by peer review (already on main)
- fn_06353 ApplyServiceOption: logic confirmed by peer review (already on main)
- fn_06355 ApplyServiceOptionXmasWeather: logic confirmed by peer review (already on main)
- fn_06356 ApplyServiceOptionJitterScale: logic confirmed by peer review (already on main)
- fn_06357 ApplyServiceOptionMapFog: logic confirmed by peer review (already on main)
- fn_06358 ApplyServiceOptionWithNotice: logic confirmed by peer review (already on main)
- fn_06360 ApplyServiceOptionActorRefresh: logic confirmed by peer review (already on main)
- fn_06362 ApplyServiceOptionItemWnd: logic confirmed by peer review (already on main)
- fn_06363 ApplyServiceOptionWeatherFlag: logic confirmed by peer review (already on main)
- fn_06366 ApplyServiceOptionSessionFlag: logic confirmed by peer review (already on main)
- fn_06367 ApplyServiceOptionCursorClip: logic confirmed by peer review (already on main)
- fn_06371 ApplyServiceOptionWindow159: logic confirmed by peer review (already on main)

Peer-reviewed-by: KWDev, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 22:48:27 +00:00
ragnarok-clanker
355aed43d2 Confirm fn_17330 (Singleton<CGameSettingsMgr>::GetInstance)
Batch #12598 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_17330 Singleton<CGameSettingsMgr>::GetInstance: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-05 22:30:40 +00:00
ragnarok-clanker
0cca901c29 Decompile fn_24219 (CSession::SendClientOption)
Batch #12527 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_24219 CSession::SendClientOption: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:53:43 +00:00
ragnarok-clanker
68c8d0dc48 Decompile 4 functions in Source/Render/DX9/BackBufferDX9.cpp, Source/Render/DX9/RendererDX9.cpp, ...
Batch #10843 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_45506 DeviceOwnerDX9::CaptureBackBuffer: byte-identical (annotation added to existing code)
- fn_45507 DeviceOwnerDX9::RestoreBackBuffer: byte-identical (annotation added to existing code)
- fn_45508 ReleaseApplicationCursor: logic confirmed by peer review
- fn_06367 ApplyServiceOptionCursorClip: logic confirmed by peer review

Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 18:23:10 +00:00
ragnarok-clanker
ff13022223 Confirm 2 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #10800 by kyoshi: 0 byte-identical, 2 confirmed by peer review.

- fn_06312 CGameSettingsMgr::sub_6C0C40: logic confirmed by peer review (already on main)
- fn_06322 CGameSettingsMgr::ResetToDefaults: logic confirmed by peer review (already on main)

Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 17:29:50 +00:00
ragnarok-clanker
1a162f0f4b Maintenance: Fold alias global gl_25097 g_saleOpenWindow (0x1457854) into its evidenced owner member g_windowMgr.unknown_01D4. 0x1457
Batch #10396 by ragnarok-clanker: no function's compiled code changes; checked with 190 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h.
2026-11-03 21:50:07 +00:00
ragnarok-clanker
aa90ea3c33 Maintenance: Fold two alias globals into their evidenced owner members. 0x14576A4 (gl_24635 g_inputSuggestionsEnabled) and 0x14576A6
Batch #10367 by ragnarok-clanker: no function's compiled code changes; checked with 507 compiled unit(s), including every includer of Source/UI/Edit/UIEditCtrl.h, Source/UI/Window/UIWindowMgr.h.
2026-11-03 21:15:45 +00:00
ragnarok-clanker
ab4ef21fb8 Maintenance: [forced, user-approved] Family V5: remove invented helper types that exist only to call real methods under old sub_ name
Batch #10281 by ragnarok-clanker: forced by an admin (1 lower score(s), 10 changed function(s)); checked with 6 compiled unit(s).
2026-11-03 16:16:57 +00:00
ragnarok-clanker
2d55a137fc Maintenance: [forced, user-approved] Family V1: remove the invented global g_luaScript and the session-as-script casts. 0x1738010 is
Batch #10269 by ragnarok-clanker: forced by an admin (2 lower score(s), 6 changed function(s)); checked with 102 compiled unit(s), including every includer of Source/Script/LuaScript.h.
2026-11-03 14:40:29 +00:00
ragnarok-clanker
8a04248e21 Maintenance: [forced, user-approved] Family G22: remove StoreBackupData, ItemTagRetirement/ItemTagRemoval, SoundMgrContext, JobInheri
Batch #10242 by ragnarok-clanker: forced by an admin (7 lower score(s), 33 changed function(s)); checked with 260 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Jobs/JobInheritance.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/Store/MCStoreInfoBackup.h, Source/UI/Edit/ItemTagRetirement.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Shortcuts/ShortcutPainting.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/Contents/Configuration/OptionWriter.h, Source/Contents/Store/StoreBackupData.h.
Deletes: Source/Contents/Configuration/OptionWriter.h, Source/Contents/Store/StoreBackupData.h
2026-11-03 11:44:08 +00:00
ragnarok-clanker
2b755e795a Maintenance: [forced, user-approved] Family F6 (closes family F): delete the four headers left empty or orphaned by F1-F5. WindowDial
Batch #10239 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 494 compiled unit(s), including every includer of Source/UI/GameSettings/GameSettingsUI.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowDialogs.h, Source/Client/Mode/ModeTooltip.h, Source/Client/Mode/ModeCursor.h, Source/UI/Window/WindowRegistration.h.
Deletes: Source/UI/Window/WindowDialogs.h, Source/Client/Mode/ModeTooltip.h, Source/Client/Mode/ModeCursor.h, Source/UI/Window/WindowRegistration.h
2026-11-03 11:10:29 +00:00
ragnarok-clanker
14a432d922 Maintenance: [forced, user-approved] Family F3: remove WindowDialogs, WindowResponseRecorder, UIMessageBoxContext, UIEntryQueueContex
Batch #10232 by ragnarok-clanker: forced by an admin (22 lower score(s), 263 changed function(s)); checked with 562 compiled unit(s), including every includer of Source/Client/Mode/CLoginMode.h, Source/Client/ReplayPacketRecorder.h, Source/Client/Session.h, Source/Contents/NavigationManager.h, Source/UI/Acceptance/UIJoinPartyAcceptWnd.h, Source/UI/EntryQueue/UIEntryQueueWnd.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UIPayConfirmWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIShowWarpWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowDialogs.h.
2026-11-03 10:23:36 +00:00
ragnarok-clanker
e757db50e0 Maintenance: [forced, user-approved] Family G15: remove ScriptOptions (reference view over g_session.m_hotkeyScript) and the unused G
Batch #10221 by ragnarok-clanker: forced by an admin (3 lower score(s), 7 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Configuration/GraphicsConfiguration.h.
Deletes: Source/Contents/Configuration/GraphicsConfiguration.h
2026-11-03 00:44:20 +00:00
ragnarok-clanker
6822c4abbf Decompile fn_06359 (ShowHelpMessages)
Batch #10067 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_06359 ShowHelpMessages: logic confirmed by peer review

Peer-reviewed-by: Qwenkler3.8, cremane, doczeira, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-02 15:07:25 +00:00
ragnarok-clanker
d6bc9836d7 Maintenance: [forced, admin decision] Collapse the WindowManagerWindows adapter into UIWindowMgr, stage 1 of 2 (project decision: por
Batch #10019 by ragnarok-clanker: forced by an admin (23 lower score(s), 187 changed function(s)); checked with 447 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Mode/ModeDragState.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemCache.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/Party/AgencyRequestContext.h, Source/Contents/Party/ChangePartyMasterAsyncWork.h, Source/Contents/Party/LoadMyPartyAsyncWork.h, Source/Contents/Party/LoadPartyInfoAsyncWork.h, Source/Contents/Party/LoadPartyListAsyncWork.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/Party/RegisterPartyAsyncWork.h, Source/Contents/Party/StopRecruitingAsyncWork.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Chat/ChatSuggestions.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Lists/UIListBox.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/UIBasicCtrl.h, Source/UI/UIStaticItem.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/WindowManagerWindows.h, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
2026-11-02 14:09:20 +00:00
ragnarok-clanker
38d679d82f Decompile fn_06361 (CGameSettingsMgr::Init_Func)
Batch #10005 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06361 CGameSettingsMgr::Init_Func: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-11-02 13:19:44 +00:00
ragnarok-clanker
bd9abfbc56 Maintenance: CGameMode layout, remaining members after maintenance 00792cfe (replaces returned batch 9955, rebased on current main).
Batch #9986 by ragnarok-clanker: no function's compiled code changes; checked with 177 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h.
2026-11-02 12:44:07 +00:00
ragnarok-clanker
66d43b7d12 Decompile fn_06317 (CGameSettingsMgr::LoadSettings)
Batch #9818 by akreao: 0 byte-identical, 1 confirmed by peer review.

- fn_06317 CGameSettingsMgr::LoadSettings: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-02 01:02:20 +00:00
ragnarok-clanker
97cd41807e Decompile fn_06362 (ApplyServiceOptionItemWnd)
Batch #8871 by Romain: 0 byte-identical, 1 confirmed by peer review.

- fn_06362 ApplyServiceOptionItemWnd: logic confirmed by peer review

Peer-reviewed-by: Montyla, pedrao, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 22:07:18 +00:00
ragnarok-clanker
f1ffb5c8db Decompile fn_06362 (ApplyServiceOptionItemWnd)
Batch #8850 by KWDev: 0 byte-identical, 1 confirmed by peer review.

- fn_06362 ApplyServiceOptionItemWnd: logic confirmed by peer review

Peer-reviewed-by: Montyla, pedrao, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 22:01:06 +00:00
ragnarok-clanker
ba1fe23c29 Decompile fn_23651 (CSession::SaveOptionInfo)
Batch #8238 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23651 CSession::SaveOptionInfo: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, Romain, vinnyamancio, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 17:06:58 +00:00
ragnarok-clanker
8552c60086 Decompile fn_23604 (CSession::LoadOptionInfo)
Batch #8272 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23604 CSession::LoadOptionInfo: logic confirmed by peer review

Peer-reviewed-by: Yommy, System4z, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 16:00:20 +00:00
ragnarok-clanker
d971cb7a98 Decompile 2 functions in Source/Contents/ClientTiming.cpp, Source/Client/Replay.cpp, ...
Batch #7250 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_24203 CSession::BuildReservedReplayRecords: logic confirmed by peer review
- fn_06365 ShowPlayerLocation: logic confirmed by peer review

Peer-reviewed-by: meitogi, alisonrag, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 05:21:19 +00:00
ragnarok-clanker
158c77e1fe Decompile fn_19329 (Replay::CachePacket)
Batch #7224 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19329 Replay::CachePacket: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 05:01:50 +00:00
ragnarok-clanker
dfdd4fbf2f Decompile 6 functions in Source/Contents/Configuration/ServiceOptions.cpp, Source/Contents/Effects/MonsterSkillEffects.cpp, ...
Batch #7031 by Lumen: 2 byte-identical, 4 confirmed by peer review.

- fn_45463 RequestModeAction48: logic confirmed by peer review
- fn_45464 RequestModeAction61: logic confirmed by peer review
- fn_45465 NotifyGameModeOptionFirst: logic confirmed by peer review
- fn_45462 RequestPlayerAction31: logic confirmed by peer review
- fn_07176 CCurseOfCubeEffect::Restart: byte-identical
- fn_07177 CCurseOfCubeEffect::Slot01: byte-identical

Peer-reviewed-by: ragnarok-clanker, alisonrag, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 03:22:35 +00:00
ragnarok-clanker
437cdd7344 Decompile fn_45461 (GreetFriends)
Batch #6559 by System4z: 0 byte-identical, 1 confirmed by peer review.

- fn_45461 GreetFriends: logic confirmed by peer review

Peer-reviewed-by: eAthena, gordaoprogramas, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:19:13 +00:00
ragnarok-clanker
04edb6b31b Decompile fn_06356 (ApplyServiceOptionJitterScale)
Batch #6331 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_06356 ApplyServiceOptionJitterScale: logic confirmed by peer review

Peer-reviewed-by: alisonrag, superintelligence, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 22:03:45 +00:00
ragnarok-clanker
f67d21742e Confirm 4 functions in Source/Contents/Configuration/ServiceOptions.cpp
Batch #5800 by Yommy: 0 byte-identical, 4 confirmed by peer review.

- fn_06355 ApplyServiceOptionXmasWeather: logic confirmed by peer review (already on main)
- fn_06358 ApplyServiceOptionWithNotice: logic confirmed by peer review (already on main)
- fn_06360 ApplyServiceOptionActorRefresh: logic confirmed by peer review (already on main)
- fn_06377 ApplyServiceOptionWindows189: logic confirmed by peer review (already on main)

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 15:49:11 +00:00
ragnarok-clanker
eff783d8ce Decompile fn_06357 (ApplyServiceOptionMapFog)
Batch #5583 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06357 ApplyServiceOptionMapFog: logic confirmed by peer review

Peer-reviewed-by: willerthal, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:38:00 +00:00
ragnarok-clanker
953c0fdb28 Decompile fn_06371 (ApplyServiceOptionWindow159)
Batch #5561 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06371 ApplyServiceOptionWindow159: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:17:48 +00:00
ragnarok-clanker
5f99fe86ef Decompile fn_06364 (ApplyServiceOptionWindow27)
Batch #5538 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06364 ApplyServiceOptionWindow27: logic confirmed by peer review

Peer-reviewed-by: willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 12:56:26 +00:00
ragnarok-clanker
c18238d97f Decompile fn_06322 (CGameSettingsMgr::ResetToDefaults)
Batch #5369 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_06322 CGameSettingsMgr::ResetToDefaults: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 10:47:00 +00:00
ragnarok-clanker
79db1039a2 Decompile fn_06363 (ApplyServiceOptionWeatherFlag)
Batch #5202 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_06363 ApplyServiceOptionWeatherFlag: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, meitogi, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:54:10 +00:00