clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
764 commits 1 branch 0 tags 28 MiB
Commit graph

98 commits

Author SHA1 Message Date
ragnarok-clanker
43bae14f66 Decompile fn_19958 (CEffectPrim::PrimTrailShift) 
Batch #2632 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19958 CEffectPrim::PrimTrailShift: logic confirmed by peer review

Peer-reviewed-by: meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 18:10:36 +00:00
ragnarok-clanker
faeb281905 Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2618 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19950 CEffectPrim::PrimFrameScroll: logic confirmed by peer review
- fn_19962 CEffectPrim::PrimFramePhase: logic confirmed by peer review

Peer-reviewed-by: youko
Reviewed-by: ragnarok-clanker
 2026-10-29 18:09:08 +00:00
ragnarok-clanker
19065ff9be Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2543 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19798 CEffectPrim::PrimBobbing: logic confirmed by peer review
- fn_19936 CEffectPrim::PrimTwinSpin: logic confirmed by peer review
- fn_19948 CEffectPrim::PrimFlashFade: logic confirmed by peer review
- fn_19968 CEffectPrim::PrimFadeAlpha: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 17:51:30 +00:00
ragnarok-clanker
c43208818d Decompile 4 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/EffectResourceSwitcher.cpp, ... 
Batch #2534 by meitogi: 0 byte-identical, 4 confirmed by peer review.

- fn_08337 CEfstAction_UNLIMIT::Slot00: logic confirmed by peer review
- fn_08372 CSkillAction_ABC_CHASING_BREAK::Slot11: logic confirmed by peer review
- fn_08377 CSkillAction_ABC_CHASING_SHOT::Slot11: logic confirmed by peer review
- fn_03082 EffectResourceSwitcher::RetireEffects: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 17:47:45 +00:00
ragnarok-clanker
35a3946332 Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2537 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19943 CEffectPrim::PrimTextureSpin: logic confirmed by peer review
- fn_19951 CEffectPrim::PrimScrollTexture: logic confirmed by peer review
- fn_19953 CEffectPrim::PrimFrameFade: logic confirmed by peer review
- fn_19969 CEffectPrim::PrimRiseFollow: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 17:47:29 +00:00
ragnarok-clanker
7bbe61ba40 Decompile 9 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2518 by ragnarok-clanker: 0 byte-identical, 9 confirmed by peer review.

- fn_19853 CEffectPrim::RenderSizedSquare: logic confirmed by peer review
- fn_19886 CEffectPrim::RenderLightningArc: logic confirmed by peer review
- fn_19868 CEffectPrim::RenderHaloLayers: logic confirmed by peer review
- fn_19860 CEffectPrim::RenderArcBand: logic confirmed by peer review
- fn_19903 CEffectPrim::RenderGroundBubbles: logic confirmed by peer review
- fn_19862 CEffectPrim::RenderPyramid: logic confirmed by peer review
- fn_19892 CEffectPrim::RenderSphereCage: logic confirmed by peer review
- fn_19859 CEffectPrim::RenderCrossPlanes: logic confirmed by peer review
- fn_19874 CEffectPrim::RenderLayeredGlow: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, willerthal, bigodeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 17:27:02 +00:00
ragnarok-clanker
3d5e9e9956 Decompile 6 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2514 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_19881 CEffectPrim::RenderBladeTrail: logic confirmed by peer review
- fn_19871 CEffectPrim::RenderFanBeam: logic confirmed by peer review
- fn_19921 CEffectPrim::RenderStackedRings: logic confirmed by peer review
- fn_19885 CEffectPrim::RenderLightningTube: logic confirmed by peer review
- fn_19898 CEffectPrim::RenderOrbitSquare: logic confirmed by peer review
- fn_19877 CEffectPrim::RenderGroundBar: logic confirmed by peer review

Peer-reviewed-by: meitogi, gordaoprogramas, willerthal, alisonrag, bigodeira, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 17:24:54 +00:00
ragnarok-clanker
00d92e9fb1 Decompile fn_19880 (CEffectPrim::RenderFieldPanel) 
Batch #2504 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19880 CEffectPrim::RenderFieldPanel: logic confirmed by peer review

Peer-reviewed-by: bigodeira
Reviewed-by: ragnarok-clanker
 2026-10-29 17:22:45 +00:00
ragnarok-clanker
0d45c7276f Decompile fn_19858 (CEffectPrim::RenderRecordRings) 
Batch #2491 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19858 CEffectPrim::RenderRecordRings: logic confirmed by peer review

Peer-reviewed-by: bigodeira
Reviewed-by: ragnarok-clanker
 2026-10-29 17:22:27 +00:00
ragnarok-clanker
f4188c2c0f Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2480 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19899 CEffectPrim::RenderGlowDisc: logic confirmed by peer review
- fn_19887 CEffectPrim::RenderSpiralBlades: logic confirmed by peer review
- fn_19863 CEffectPrim::RenderRecordQuads: logic confirmed by peer review
- fn_19901 CEffectPrim::RenderTube: logic confirmed by peer review

Peer-reviewed-by: alisonrag, gordaoprogramas, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 16:55:48 +00:00
ragnarok-clanker
7ae37f7150 Decompile fn_19879 (CEffectPrim::RenderColorPanel) 
Batch #2462 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19879 CEffectPrim::RenderColorPanel: logic confirmed by peer review

Peer-reviewed-by: alisonrag, gordaoprogramas, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 16:54:37 +00:00
ragnarok-clanker
2e5ca78dda Decompile fn_19851 (CEffectPrim::Render2DDiamond) 
Batch #2456 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19851 CEffectPrim::Render2DDiamond: logic confirmed by peer review

Peer-reviewed-by: alisonrag, gordaoprogramas, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 16:54:23 +00:00
ragnarok-clanker
42b144a2b0 Decompile fn_19907 (CEffectPrim::RenderTrailSquares) 
Batch #2453 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19907 CEffectPrim::RenderTrailSquares: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 16:15:52 +00:00
ragnarok-clanker
9c6bccc775 Decompile fn_19912 (CEffectPrim::RenderSMA3) 
Batch #2444 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19912 CEffectPrim::RenderSMA3: logic confirmed by peer review

Peer-reviewed-by: alisonrag
Reviewed-by: ragnarok-clanker
 2026-10-29 16:15:03 +00:00
ragnarok-clanker
e6c22457a6 Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h 
Batch #2449 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_20025 CRagEffect::CartRevolution: logic confirmed by peer review
- fn_20024 CRagEffect::BowlingBash: logic confirmed by peer review
- fn_20105 CRagEffect::SonicBlowHit: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas
Reviewed-by: ragnarok-clanker
 2026-10-29 16:14:48 +00:00
ragnarok-clanker
71c56041c1 Decompile fn_19922 (CEffectPrim::RenderRotatedPlate) 
Batch #2442 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19922 CEffectPrim::RenderRotatedPlate: logic confirmed by peer review

Peer-reviewed-by: alisonrag, gordaoprogramas
Reviewed-by: ragnarok-clanker
 2026-10-29 16:14:28 +00:00
ragnarok-clanker
bc0f96ee8b Decompile fn_20055 (CRagEffect::GetDuration) 
Batch #2447 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_20055 CRagEffect::GetDuration: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 16:03:32 +00:00
ragnarok-clanker
7413b83b11 Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2439 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19850 CEffectPrim::Render2DCircle: logic confirmed by peer review
- fn_19855 CEffectPrim::Render3DCasting2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 15:57:50 +00:00
ragnarok-clanker
c1df67e2eb Decompile 8 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2440 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.

- fn_19856 CEffectPrim::Render3DCasting: logic confirmed by peer review
- fn_19857 CEffectPrim::Render3DCasting_LowPolygon: logic confirmed by peer review
- fn_19869 CEffectPrim::RenderAttackEnergy2: logic confirmed by peer review
- fn_19872 CEffectPrim::RenderBlind: logic confirmed by peer review
- fn_19878 CEffectPrim::RenderChemical: logic confirmed by peer review
- fn_19882 CEffectPrim::RenderColorPaper: logic confirmed by peer review
- fn_19883 CEffectPrim::RenderDoubleGumGang: logic confirmed by peer review
- fn_19890 CEffectPrim::RenderGrandCross2: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 15:57:27 +00:00
ragnarok-clanker
fb006bc003 Decompile 4 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h 
Batch #2431 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_20133 CRagEffect::AttackEnergy2: logic confirmed by peer review
- fn_20077 CRagEffect::LexDivina: logic confirmed by peer review
- fn_20096 CRagEffect::RemoveTrap: logic confirmed by peer review
- fn_20108 CRagEffect::Sphere: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 15:56:49 +00:00
ragnarok-clanker
347c72405a EffectPrimitiveState: split unknown_0258[4] into DHXJ chPoint/chVal1/chVal2/chVal3 (std::vector<float> each). Pure rename, codegen unchanged. 2026-10-29 16:53:57 +01:00
ragnarok-clanker
a267c1f2ee Decompile fn_19873 (CEffectPrim::RenderColorPlane) 
Batch #2424 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19873 CEffectPrim::RenderColorPlane: logic confirmed by peer review

Peer-reviewed-by: alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 15:49:47 +00:00
ragnarok-clanker
90c2a35550 Decompile 7 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2376 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_19900 CEffectPrim::RenderBeam: logic confirmed by peer review
- fn_19870 CEffectPrim::RenderCone: logic confirmed by peer review
- fn_19904 CEffectPrim::RenderPeong: logic confirmed by peer review
- fn_19876 CEffectPrim::RenderFloorRect: logic confirmed by peer review
- fn_19913 CEffectPrim::RenderRotatedRing: logic confirmed by peer review
- fn_19917 CEffectPrim::RenderFloorSquare: logic confirmed by peer review
- fn_19914 CEffectPrim::RenderFloorSquare2: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 15:48:02 +00:00
ragnarok-clanker
5a9265428f Decompile fn_20241 (CRagEffect::Fireworks) 
Batch #2202 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_20241 CRagEffect::Fireworks: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 15:46:38 +00:00
ragnarok-clanker
6dcd49bd31 Decompile fn_19889 (CEffectPrim::RenderRipple) 
Batch #2288 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19889 CEffectPrim::RenderRipple: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 15:46:16 +00:00
ragnarok-clanker
d27fba9a13 Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2361 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19867 CEffectPrim::RenderRing: logic confirmed by peer review
- fn_19888 CEffectPrim::RenderPentagon: logic confirmed by peer review

Peer-reviewed-by: alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 15:45:44 +00:00
ragnarok-clanker
a9e6d911e4 Decompile fn_19906 (CEffectPrim::RenderGrid) 
Batch #2191 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19906 CEffectPrim::RenderGrid: logic confirmed by peer review

Peer-reviewed-by: ntrl
Reviewed-by: ragnarok-clanker
 2026-10-29 15:30:01 +00:00
ragnarok-clanker
648d92414a Decompile 8 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h 
Batch #2193 by ragnarok-clanker: 8 byte-identical, 0 confirmed by peer review.

- fn_20034 CRagEffect::ProcessEZ2STRC10830: byte-identical
- fn_20049 CRagEffect::ProcessEZ2STRC153A0: byte-identical
- fn_20112 CRagEffect::ProcessEZ2STRC3CC40: byte-identical
- fn_20123 CRagEffect::ProcessEZ2STRC3FE00: byte-identical
- fn_20267 CRagEffect::ProcessEZ2STRC65300: byte-identical
- fn_20051 CRagEffect::ProcessEZ2STRC15990: byte-identical
- fn_20052 CRagEffect::ProcessEZ2STRC159D0: byte-identical
- fn_20326 CRagEffect::ShieldCharge: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 15:21:28 +00:00
ragnarok-clanker
9c689705b7 Decompile fn_19875 (CEffectPrim::RenderHalfSphere2) 
Batch #2186 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19875 CEffectPrim::RenderHalfSphere2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 15:18:13 +00:00
ragnarok-clanker
2a3e04dac8 RagEffectState: name CRagEffect members after DHXJ (param[4], longitude, latitude, tlvertX/Y/Z, defZ, isDirection, type, level, flag, count, stateCnt, duration, deltaPos/deltaPos2/deltaPos3, primList, objSeg). tlvert/longitude become floats (were uint32 written through bit_cast). Codegen unchanged except Hit4 (59.2->60.4%) and ProcessEZ2STR (58.6->59.0%), both from dropping the bit_cast stores; 120/122 identical with includers. 2026-10-29 16:00:58 +01:00
ragnarok-clanker
bdd9736af4 EffectPrimitiveState: name 84 CEffectPrim members after DHXJ (layout matches DHXJ member order with 12-byte std::vector and one extra 2026 dword at 0x1D8): stateCnt, duration, pattern, count, renderFlag, numSegment, speed/accel, gravSpeed/gravAccel, longitude/latitude/roll, size, alpha*, lati*/long*/roll* speeds and accels, radius*, width*/height*, orgPos, deltaPos/deltaPos2/deltaPos3, segPos, rotAxis, transform/rotTransform, etc. Pure rename, codegen unchanged (221/221 functions with includers). 2026-10-29 15:58:02 +01:00
ragnarok-clanker
ddb1d0aeac Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h 
Batch #2156 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_20016 CRagEffect::Aspersio: logic confirmed by peer review
- fn_20019 CRagEffect::Blessing: logic confirmed by peer review
- fn_20023 CRagEffect::Bottom: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 14:44:24 +00:00
ragnarok-clanker
0aa64c3622 Decompile 15 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2150 by ragnarok-clanker: 0 byte-identical, 15 confirmed by peer review.

- fn_19894 CEffectPrim::RenderHalfSphere: logic confirmed by peer review
- fn_19895 CEffectPrim::RenderHermode: logic confirmed by peer review
- fn_19896 CEffectPrim::RenderHitLine3: logic confirmed by peer review
- fn_19897 CEffectPrim::RenderHitLine: logic confirmed by peer review
- fn_19902 CEffectPrim::RenderMagnum2: logic confirmed by peer review
- fn_19905 CEffectPrim::RenderPeongUp: logic confirmed by peer review
- fn_19908 CEffectPrim::RenderRainbow: logic confirmed by peer review
- fn_19909 CEffectPrim::RenderRectUp2: logic confirmed by peer review
- fn_19910 CEffectPrim::RenderRectUp: logic confirmed by peer review
- fn_19911 CEffectPrim::RenderSMA2: logic confirmed by peer review
- fn_19915 CEffectPrim::RenderSaintWing: logic confirmed by peer review
- fn_19916 CEffectPrim::RenderSlash1: logic confirmed by peer review
- fn_19918 CEffectPrim::RenderSoulLink: logic confirmed by peer review
- fn_19919 CEffectPrim::RenderSoulParticle: logic confirmed by peer review
- fn_19920 CEffectPrim::RenderSphereWind: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 14:39:20 +00:00
ragnarok-clanker
b03935e409 Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h, ... 
Batch #2139 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_20075 CRagEffect::InitEZ2STRFrame: logic confirmed by peer review
- fn_20095 CRagEffect::ProcessEZ2STR: logic confirmed by peer review
- fn_20326 CRagEffect::ShieldCharge: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 14:38:19 +00:00
ragnarok-clanker
31422085a7 Decompile fn_03111 (CEffect::Slot22) 
Batch #2149 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_03111 CEffect::Slot22: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 14:34:08 +00:00
ragnarok-clanker
05882a0341 Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrimitiveMotion.cpp, ... 
Batch #2137 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19923 CEffectPrim::RenderTeiRect: logic confirmed by peer review
- fn_19924 CEffectPrim::RenderTeiRect: logic confirmed by peer review
- fn_19925 CEffectPrim::RenderTeiRect: logic confirmed by peer review
- fn_19933 TransformVert: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 14:19:13 +00:00
ragnarok-clanker
1353b13bac Decompile 13 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h, ... 
Batch #2136 by ragnarok-clanker: 0 byte-identical, 13 confirmed by peer review.

- fn_20040 CRagEffect::BloodDrain: logic confirmed by peer review
- fn_20046 CRagEffect::FireBall: logic confirmed by peer review
- fn_20054 CRagEffect::FrostDiver: logic confirmed by peer review
- fn_20058 CRagEffect::GrimTooth: logic confirmed by peer review
- fn_20066 CRagEffect::Hit4: logic confirmed by peer review
- fn_20106 CRagEffect::SoulStrike: logic confirmed by peer review
- fn_20107 CRagEffect::SpearBmr: logic confirmed by peer review
- fn_20109 CRagEffect::SprayPond: logic confirmed by peer review
- fn_20120 CRagEffect::WaterBall2: logic confirmed by peer review
- fn_20124 CRagEffect::Yufitel: logic confirmed by peer review
- fn_20132 CRagEffect::AirTexture: logic confirmed by peer review
- fn_20181 CRagEffect::EnergyDrain2: logic confirmed by peer review
- fn_21029 CGameObject::Get8Dir2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 14:02:25 +00:00
ragnarok-clanker
1682799c2c Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2132 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19845 CEffectPrim::PrimTwilight: logic confirmed by peer review
- fn_19847 CEffectPrim::PrimWind: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 14:02:10 +00:00
ragnarok-clanker
dd5161a8f7 Decompile 18 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrim.h 
Batch #2133 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_19787 CEffectPrim::PrimAcidDemon: logic confirmed by peer review
- fn_19788 CEffectPrim::PrimAsuraCasting: logic confirmed by peer review
- fn_19803 CEffectPrim::PrimElectric2: logic confirmed by peer review
- fn_19806 CEffectPrim::PrimFlowerCast: logic confirmed by peer review
- fn_19807 CEffectPrim::PrimForest: logic confirmed by peer review
- fn_19819 CEffectPrim::PrimMapParticle: logic confirmed by peer review
- fn_19820 CEffectPrim::PrimParticleSpread: logic confirmed by peer review
- fn_19821 CEffectPrim::PrimParticleUp: logic confirmed by peer review
- fn_19823 CEffectPrim::PrimPeongUp: logic confirmed by peer review
- fn_19825 CEffectPrim::PrimPokJuk: logic confirmed by peer review
- fn_19832 CEffectPrim::PrimSTIN4: logic confirmed by peer review
- fn_19833 CEffectPrim::PrimSaintWing: logic confirmed by peer review
- fn_19837 CEffectPrim::PrimSoulParticle: logic confirmed by peer review
- fn_19838 CEffectPrim::PrimSphereWind2: logic confirmed by peer review
- fn_19932 CEffectPrim::Tei_TowardScreen: logic confirmed by peer review
- fn_19938 CEffectPrim::PrimGI4: logic confirmed by peer review
- fn_19940 CEffectPrim::PrimGI1: logic confirmed by peer review
- fn_19946 CEffectPrim::PrimCHOOKGI: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 13:17:02 +00:00
ragnarok-clanker
f8ee6dec15 Decompile 3 functions in Source/Contents/Effects/PartyMemberEffects.cpp, Source/Contents/Effects/EffectPrimitiveMotion.cpp, ... 
Batch #2131 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_19841 CEffectPrim::PrimTanji2: logic confirmed by peer review
- fn_19786 CEffectPrim::Prim3DTextureNoMaster: logic confirmed by peer review
- fn_21069 EffectActor::LaunchEffect: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 12:59:44 +00:00
ragnarok-clanker
d98cf6bf1e Decompile 5 functions in Source/Contents/Effects/Effect.cpp, Source/Contents/Effects/EffectForceRender.cpp, ... 
Batch #2130 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18986 CEffect::Slot33: logic confirmed by peer review
- fn_18989 CEffect::UpdateVisibility: logic confirmed by peer review
- fn_18990 CEffect::Slot29: logic confirmed by peer review
- fn_23884 CSession::IsPartyMember: logic confirmed by peer review
- fn_24185 CSession::IsPvpMap: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/Effects/EffectForceRender.cpp, Source/Client/SessionParty.cpp
 2026-10-29 12:59:22 +00:00
ragnarok-clanker
bc7be6e928 Rename ConnectionBuffer -> CPacketQueue (DHXJ; methods GetData/GetSize/Init/InsertData/PeekData/RemoveData; file -> PacketQueue.{h,cpp}), CConnection::SetBlock, CEffectPrim::Prim3DParticleGravity. Pure rename, codegen unchanged (109/109 functions, byte-identical). 2026-10-29 13:22:00 +01:00
ragnarok-clanker
dc2f3a8f88 Align method names with DHXJ (call-graph matches): CEffectPrim::Prim3DParticle/Prim3DParticleNoMaster/Prim3DParticleOrbit, matrix::AppendScale/AppendXRotation/AppendZRotation/AppendTranslate/MakeYRotation/MakeZRotation, CRenderObject::CalcDist (2 overloads). Pure rename, codegen unchanged (504/504 functions identical with includers). 2026-10-29 13:12:37 +01:00
ragnarok-clanker
e9b98b8c69 Rename AffineMatrix -> matrix (DHXJ); clashes with variables named matrix use the elaborated form 'struct matrix'. Pure rename, codegen unchanged (383/383 functions identical with includers). 2026-10-29 12:33:14 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
7f3b43c8ef Rename AttachedEffect -> CRagEffect (DHXJ), AttachedEffect.{h,cpp} -> RagEffect.{h,cpp}. Pure rename, codegen unchanged (129/129 functions identical with includers). 2026-10-29 12:19:20 +01:00
ragnarok-clanker
7555e0220d Rename EffectParticle -> CEffectPrim (DHXJ), EffectParticle.{h,cpp} -> EffectPrim.{h,cpp}. Pure rename, codegen unchanged (50/50 functions identical with includers). 2026-10-29 12:15:56 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
76ac1d4c92 Decompile 3 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/Effect.cpp, ... 
Batch #2114 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_18774 EffectLists::Spawn: logic confirmed by peer review
- fn_18991 CEffect::SetActor: logic confirmed by peer review
- fn_18992 CEffect::SetSourceActor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 10:47:33 +00:00
ragnarok-clanker
59d0e54c9e Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h 
Batch #2102 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19817 EffectParticle::PrimKouenka: logic confirmed by peer review
- fn_19834 EffectParticle::PrimSakura: logic confirmed by peer review
- fn_19836 EffectParticle::PrimShieldBoomerang: logic confirmed by peer review
- fn_19843 EffectParticle::PrimTeiHit2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 10:24:08 +00:00