Commit graph

352 commits

Author SHA1 Message Date
ragnarok-clanker
10143c7796 Decompile fn_22330 (ClampTargetAttackRange)
Batch #2196 by alisonrag: 0 byte-identical, 1 confirmed by peer review.

- fn_22330 ClampTargetAttackRange: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 15:29:19 +00:00
ragnarok-clanker
648d92414a Decompile 8 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h
Batch #2193 by ragnarok-clanker: 8 byte-identical, 0 confirmed by peer review.

- fn_20034 CRagEffect::ProcessEZ2STRC10830: byte-identical
- fn_20049 CRagEffect::ProcessEZ2STRC153A0: byte-identical
- fn_20112 CRagEffect::ProcessEZ2STRC3CC40: byte-identical
- fn_20123 CRagEffect::ProcessEZ2STRC3FE00: byte-identical
- fn_20267 CRagEffect::ProcessEZ2STRC65300: byte-identical
- fn_20051 CRagEffect::ProcessEZ2STRC15990: byte-identical
- fn_20052 CRagEffect::ProcessEZ2STRC159D0: byte-identical
- fn_20326 CRagEffect::ShieldCharge: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 15:21:28 +00:00
ragnarok-clanker
ecf0296f5f Decompile fn_04256 (CPlayerNameDictionary::`scalar deleting destructor')
Batch #2189 by ntrl: 0 byte-identical, 1 confirmed by peer review.

- fn_04256 CPlayerNameDictionary::`scalar deleting destructor': logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 15:18:55 +00:00
ragnarok-clanker
42755f9540 Decompile fn_21039 (CGameActor::ActionBase)
Batch #2188 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21039 CGameActor::ActionBase: logic confirmed by peer review

Peer-reviewed-by: ntrl, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 15:18:49 +00:00
ragnarok-clanker
9c689705b7 Decompile fn_19875 (CEffectPrim::RenderHalfSphere2)
Batch #2186 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19875 CEffectPrim::RenderHalfSphere2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 15:18:13 +00:00
ragnarok-clanker
2dadd7c772 Decompile fn_21038 (CRenderObject::ScaleByFadePulse)
Batch #2180 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21038 CRenderObject::ScaleByFadePulse: logic confirmed by peer review

Peer-reviewed-by: ntrl, alisonrag
Reviewed-by: ragnarok-clanker
2026-10-29 15:16:54 +00:00
ragnarok-clanker
6f0fe82fc4 Decompile fn_21161 (CRenderObject::UpdateTlvertex)
Batch #2181 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21161 CRenderObject::UpdateTlvertex: logic confirmed by peer review

Peer-reviewed-by: ntrl
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 15:10:20 +00:00
ragnarok-clanker
7f900459b1 Decompile fn_21129 (CGameActor::SetUnknown03C4)
Batch #2170 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21129 CGameActor::SetUnknown03C4: logic confirmed by peer review

Peer-reviewed-by: ntrl
Reviewed-by: ragnarok-clanker
2026-10-29 15:06:31 +00:00
ragnarok-clanker
46d4abaff3 Decompile 2 functions in Source/Contents/Sound/SoundMaker.cpp
Batch #2167 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_22400 CHalluNPC::OnProcess: logic confirmed by peer review
- fn_22402 CHalluPC::OnProcess: logic confirmed by peer review

Peer-reviewed-by: ntrl
Reviewed-by: ragnarok-clanker
2026-10-29 15:06:11 +00:00
ragnarok-clanker
2a3e04dac8 RagEffectState: name CRagEffect members after DHXJ (param[4], longitude, latitude, tlvertX/Y/Z, defZ, isDirection, type, level, flag, count, stateCnt, duration, deltaPos/deltaPos2/deltaPos3, primList, objSeg). tlvert/longitude become floats (were uint32 written through bit_cast). Codegen unchanged except Hit4 (59.2->60.4%) and ProcessEZ2STR (58.6->59.0%), both from dropping the bit_cast stores; 120/122 identical with includers. 2026-10-29 16:00:58 +01:00
ragnarok-clanker
bdd9736af4 EffectPrimitiveState: name 84 CEffectPrim members after DHXJ (layout matches DHXJ member order with 12-byte std::vector and one extra 2026 dword at 0x1D8): stateCnt, duration, pattern, count, renderFlag, numSegment, speed/accel, gravSpeed/gravAccel, longitude/latitude/roll, size, alpha*, lati*/long*/roll* speeds and accels, radius*, width*/height*, orgPos, deltaPos/deltaPos2/deltaPos3, segPos, rotAxis, transform/rotTransform, etc. Pure rename, codegen unchanged (221/221 functions with includers). 2026-10-29 15:58:02 +01:00
ragnarok-clanker
19feaf8184 Decompile 3 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h
Batch #2162 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_21155 CGameActor::SetUnknown008C: logic confirmed by peer review
- fn_21157 CGameActor::SetUnknown0404: logic confirmed by peer review
- fn_21159 CGameActor::Slot17: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:46:06 +00:00
ragnarok-clanker
382be11765 Decompile fn_21044 (CGameActor::GetUnknown0404Job)
Batch #2163 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_21044 CGameActor::GetUnknown0404Job: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 14:45:35 +00:00
ragnarok-clanker
dd4a3970bf Decompile fn_22644 (CGrannyPc::Slot28)
Batch #2158 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_22644 CGrannyPc::Slot28: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:44:43 +00:00
ragnarok-clanker
bc2b7572e1 Decompile 2 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Actors/Pc.h
Batch #2157 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_22429 CPc::Slot59: logic confirmed by peer review
- fn_22430 CPc::Slot57: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:44:33 +00:00
ragnarok-clanker
ddb1d0aeac Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h
Batch #2156 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_20016 CRagEffect::Aspersio: logic confirmed by peer review
- fn_20019 CRagEffect::Blessing: logic confirmed by peer review
- fn_20023 CRagEffect::Bottom: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:44:24 +00:00
ragnarok-clanker
e91dea0947 Decompile 10 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h, ...
Batch #2152 by ragnarok-clanker: 10 byte-identical, 0 confirmed by peer review.

- fn_03067 CGameActor::Slot19: byte-identical
- fn_03066 CGameActor::Slot20: byte-identical
- fn_03063 CGameActor::Slot26: byte-identical
- fn_03064 CGameActor::Slot27: byte-identical
- fn_03056 CGameActor::Slot31: byte-identical
- fn_03055 CGameActor::Slot34: byte-identical
- fn_03069 CNpc::Slot22: byte-identical
- fn_03065 CNpc::Slot25: byte-identical
- fn_03058 CNpc::Slot30: byte-identical
- fn_03070 CCharacterNpc::Slot21: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 14:39:30 +00:00
ragnarok-clanker
0aa64c3622 Decompile 15 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrim.h
Batch #2150 by ragnarok-clanker: 0 byte-identical, 15 confirmed by peer review.

- fn_19894 CEffectPrim::RenderHalfSphere: logic confirmed by peer review
- fn_19895 CEffectPrim::RenderHermode: logic confirmed by peer review
- fn_19896 CEffectPrim::RenderHitLine3: logic confirmed by peer review
- fn_19897 CEffectPrim::RenderHitLine: logic confirmed by peer review
- fn_19902 CEffectPrim::RenderMagnum2: logic confirmed by peer review
- fn_19905 CEffectPrim::RenderPeongUp: logic confirmed by peer review
- fn_19908 CEffectPrim::RenderRainbow: logic confirmed by peer review
- fn_19909 CEffectPrim::RenderRectUp2: logic confirmed by peer review
- fn_19910 CEffectPrim::RenderRectUp: logic confirmed by peer review
- fn_19911 CEffectPrim::RenderSMA2: logic confirmed by peer review
- fn_19915 CEffectPrim::RenderSaintWing: logic confirmed by peer review
- fn_19916 CEffectPrim::RenderSlash1: logic confirmed by peer review
- fn_19918 CEffectPrim::RenderSoulLink: logic confirmed by peer review
- fn_19919 CEffectPrim::RenderSoulParticle: logic confirmed by peer review
- fn_19920 CEffectPrim::RenderSphereWind: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:39:20 +00:00
ragnarok-clanker
f8ea163c84 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/EffectResourceSwitcher.cpp, ...
Batch #2148 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_08329 CEfstAction_GenderChange::Slot00: logic confirmed by peer review
- fn_08330 CEfstAction_GenderChange::Slot01: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:38:37 +00:00
ragnarok-clanker
b03935e409 Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h, ...
Batch #2139 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_20075 CRagEffect::InitEZ2STRFrame: logic confirmed by peer review
- fn_20095 CRagEffect::ProcessEZ2STR: logic confirmed by peer review
- fn_20326 CRagEffect::ShieldCharge: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:38:19 +00:00
ragnarok-clanker
31422085a7 Decompile fn_03111 (CEffect::Slot22)
Batch #2149 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_03111 CEffect::Slot22: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 14:34:08 +00:00
ragnarok-clanker
16cf1dce90 Decompile 29 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/EffectResourceSwitcher.cpp, ...
Batch #2141 by ragnarok-clanker: 0 byte-identical, 29 confirmed by peer review.

- fn_08336 CSkillAction_RA_UNLIMIT::Slot11: logic confirmed by peer review
- fn_08340 CSkillAction_AG_ENERGY_CONVERSION::Slot08: logic confirmed by peer review
- fn_08342 CSkillAction_CD_DIVINUS_FLOS::Slot08: logic confirmed by peer review
- fn_08343 CSkillAction_CD_DIVINUS_FLOS::Slot11: logic confirmed by peer review
- fn_08345 CSkillAction_SHC_ENCHANTING_SHADOW::Slot08: logic confirmed by peer review
- fn_08349 CSkillAction_SHC_IMPACT_CRATER::Slot11: logic confirmed by peer review
- fn_08350 CSkillAction_SHC_IMPACT_CRATER::Slot16: logic confirmed by peer review
- fn_08352 CSkillAction_SHC_CROSS_SLASH::Slot11: logic confirmed by peer review
- fn_08353 CSkillAction_SHC_CROSS_SLASH::Slot16: logic confirmed by peer review
- fn_08355 CSkillAction_SHC_DANCING_KNIFE::Slot08: logic confirmed by peer review
- fn_08356 CSkillAction_SHC_DANCING_KNIFE::Slot16: logic confirmed by peer review
- fn_08363 CSkillAction_SHC_SHADOW_EXCEED::Slot08: logic confirmed by peer review
- fn_08373 CSkillAction_ABC_CHASING_BREAK::Slot16: logic confirmed by peer review
- fn_08376 CSkillAction_ABC_CHASING_SHOT::Slot08: logic confirmed by peer review
- fn_08378 CSkillAction_ABC_CHASING_SHOT::Slot15: logic confirmed by peer review
- fn_08379 CSkillAction_ABC_CHASING_SHOT::Slot16: logic confirmed by peer review
- fn_08381 CSkillAction_ABC_HIT_AND_SLIDING::Slot16: logic confirmed by peer review
- fn_08382 CSkillAction_ABC_ABYSS_FLAME::Slot08: logic confirmed by peer review
- fn_08383 CSkillAction_ABC_ABYSS_FLAME::Slot11: logic confirmed by peer review
- fn_08384 CSkillAction_ABC_ABYSS_FLAME::Slot16: logic confirmed by peer review
- fn_08386 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot11: logic confirmed by peer review
- fn_08387 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot16: logic confirmed by peer review
- fn_08388 CSkillAction_EM_PSYCHIC_STREAM::Slot08: logic confirmed by peer review
- fn_08389 CSkillAction_EM_PSYCHIC_STREAM::Slot11: logic confirmed by peer review
- fn_08390 CSkillAction_EM_PSYCHIC_STREAM::Slot16: logic confirmed by peer review
- fn_08392 CSkillAction_IQ_BLAZING_FLAME_BLAST::Slot08: logic confirmed by peer review
- fn_08394 CSkillAction_IQ_BLAZING_FLAME_BLAST::Slot16: logic confirmed by peer review
- fn_08344 CSkillAction_CD_DIVINUS_FLOS::Slot16: logic confirmed by peer review
- fn_06989 CEZ2STREffectMgr::EffectId: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 14:22:12 +00:00
ragnarok-clanker
05882a0341 Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrimitiveMotion.cpp, ...
Batch #2137 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19923 CEffectPrim::RenderTeiRect: logic confirmed by peer review
- fn_19924 CEffectPrim::RenderTeiRect: logic confirmed by peer review
- fn_19925 CEffectPrim::RenderTeiRect: logic confirmed by peer review
- fn_19933 TransformVert: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:19:13 +00:00
ragnarok-clanker
1353b13bac Decompile 13 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h, ...
Batch #2136 by ragnarok-clanker: 0 byte-identical, 13 confirmed by peer review.

- fn_20040 CRagEffect::BloodDrain: logic confirmed by peer review
- fn_20046 CRagEffect::FireBall: logic confirmed by peer review
- fn_20054 CRagEffect::FrostDiver: logic confirmed by peer review
- fn_20058 CRagEffect::GrimTooth: logic confirmed by peer review
- fn_20066 CRagEffect::Hit4: logic confirmed by peer review
- fn_20106 CRagEffect::SoulStrike: logic confirmed by peer review
- fn_20107 CRagEffect::SpearBmr: logic confirmed by peer review
- fn_20109 CRagEffect::SprayPond: logic confirmed by peer review
- fn_20120 CRagEffect::WaterBall2: logic confirmed by peer review
- fn_20124 CRagEffect::Yufitel: logic confirmed by peer review
- fn_20132 CRagEffect::AirTexture: logic confirmed by peer review
- fn_20181 CRagEffect::EnergyDrain2: logic confirmed by peer review
- fn_21029 CGameObject::Get8Dir2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:02:25 +00:00
ragnarok-clanker
1682799c2c Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrim.h
Batch #2132 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19845 CEffectPrim::PrimTwilight: logic confirmed by peer review
- fn_19847 CEffectPrim::PrimWind: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:02:10 +00:00
ragnarok-clanker
dd5161a8f7 Decompile 18 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrim.h
Batch #2133 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_19787 CEffectPrim::PrimAcidDemon: logic confirmed by peer review
- fn_19788 CEffectPrim::PrimAsuraCasting: logic confirmed by peer review
- fn_19803 CEffectPrim::PrimElectric2: logic confirmed by peer review
- fn_19806 CEffectPrim::PrimFlowerCast: logic confirmed by peer review
- fn_19807 CEffectPrim::PrimForest: logic confirmed by peer review
- fn_19819 CEffectPrim::PrimMapParticle: logic confirmed by peer review
- fn_19820 CEffectPrim::PrimParticleSpread: logic confirmed by peer review
- fn_19821 CEffectPrim::PrimParticleUp: logic confirmed by peer review
- fn_19823 CEffectPrim::PrimPeongUp: logic confirmed by peer review
- fn_19825 CEffectPrim::PrimPokJuk: logic confirmed by peer review
- fn_19832 CEffectPrim::PrimSTIN4: logic confirmed by peer review
- fn_19833 CEffectPrim::PrimSaintWing: logic confirmed by peer review
- fn_19837 CEffectPrim::PrimSoulParticle: logic confirmed by peer review
- fn_19838 CEffectPrim::PrimSphereWind2: logic confirmed by peer review
- fn_19932 CEffectPrim::Tei_TowardScreen: logic confirmed by peer review
- fn_19938 CEffectPrim::PrimGI4: logic confirmed by peer review
- fn_19940 CEffectPrim::PrimGI1: logic confirmed by peer review
- fn_19946 CEffectPrim::PrimCHOOKGI: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 13:17:02 +00:00
ragnarok-clanker
cd47fe84d3 Rename CGameObject virtuals to DHXJ names across the actor hierarchy: Update->OnProcess, SendObjectMessage->SendMsg, Draw->Render, Direction->Get8Dir, SetScreenBounds->SetRenderInfo, SetScreenPosition->SetTlvert, SetAnimation->SetAction. Pure rename, codegen unchanged (314/314 functions identical with includers). 2026-10-29 14:01:33 +01:00
ragnarok-clanker
f8ee6dec15 Decompile 3 functions in Source/Contents/Effects/PartyMemberEffects.cpp, Source/Contents/Effects/EffectPrimitiveMotion.cpp, ...
Batch #2131 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_19841 CEffectPrim::PrimTanji2: logic confirmed by peer review
- fn_19786 CEffectPrim::Prim3DTextureNoMaster: logic confirmed by peer review
- fn_21069 EffectActor::LaunchEffect: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 12:59:44 +00:00
ragnarok-clanker
d98cf6bf1e Decompile 5 functions in Source/Contents/Effects/Effect.cpp, Source/Contents/Effects/EffectForceRender.cpp, ...
Batch #2130 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18986 CEffect::Slot33: logic confirmed by peer review
- fn_18989 CEffect::UpdateVisibility: logic confirmed by peer review
- fn_18990 CEffect::Slot29: logic confirmed by peer review
- fn_23884 CSession::IsPartyMember: logic confirmed by peer review
- fn_24185 CSession::IsPvpMap: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/Effects/EffectForceRender.cpp, Source/Client/SessionParty.cpp
2026-10-29 12:59:22 +00:00
ragnarok-clanker
1e370c70a8 Decompile 6 functions in Source/Contents/Skills/SkillActionInfo.cpp, Source/Client/Session.h, ...
Batch #2126 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_23824 CSession::GetRobeActName: logic confirmed by peer review
- fn_23825 CSession::GetRobeSprName: logic confirmed by peer review
- fn_23827 CSession::GetRobeName: logic confirmed by peer review
- fn_23828 CSession::GetItemDescription40: logic confirmed by peer review
- fn_23829 CSession::GetUnknown0420: logic confirmed by peer review
- fn_23830 CSession::GetSkillActionInfo: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/Skills/SkillActionInfo.cpp
2026-10-29 12:58:19 +00:00
ragnarok-clanker
dcc654e1d6 Decompile 2 functions in Source/Client/Mode/ModeLifetime.cpp, Source/Contents/Configuration/ServiceConfiguration.cpp, ...
Batch #2128 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17819 SetServiceFlags: logic confirmed by peer review
- fn_17822 CMode::`scalar deleting destructor': logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/Mode/ModeLifetime.cpp
2026-10-29 12:55:03 +00:00
ragnarok-clanker
7db74ec953 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp
Batch #2121 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_08326 CEfstAction_ChangeSize::Slot00: logic confirmed by peer review
- fn_08364 CSkillAction_SHC_SHADOW_EXCEED::Slot11: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 12:54:53 +00:00
ragnarok-clanker
bc7be6e928 Rename ConnectionBuffer -> CPacketQueue (DHXJ; methods GetData/GetSize/Init/InsertData/PeekData/RemoveData; file -> PacketQueue.{h,cpp}), CConnection::SetBlock, CEffectPrim::Prim3DParticleGravity. Pure rename, codegen unchanged (109/109 functions, byte-identical). 2026-10-29 13:22:00 +01:00
ragnarok-clanker
dc2f3a8f88 Align method names with DHXJ (call-graph matches): CEffectPrim::Prim3DParticle/Prim3DParticleNoMaster/Prim3DParticleOrbit, matrix::AppendScale/AppendXRotation/AppendZRotation/AppendTranslate/MakeYRotation/MakeZRotation, CRenderObject::CalcDist (2 overloads). Pure rename, codegen unchanged (504/504 functions identical with includers). 2026-10-29 13:12:37 +01:00
ragnarok-clanker
e9b98b8c69 Rename AffineMatrix -> matrix (DHXJ); clashes with variables named matrix use the elaborated form 'struct matrix'. Pure rename, codegen unchanged (383/383 functions identical with includers). 2026-10-29 12:33:14 +01:00
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
591a7db26b Rename pathfinding types to DHXJ: MovementOpenList -> CPriorityQueue, MovementPathNodeCompare -> NodeTotalGreater, MovementPathNode -> PathNode, MovementRoutePoint -> PathCell. Pure rename, codegen unchanged. 2026-10-29 12:23:51 +01:00
ragnarok-clanker
7f3b43c8ef Rename AttachedEffect -> CRagEffect (DHXJ), AttachedEffect.{h,cpp} -> RagEffect.{h,cpp}. Pure rename, codegen unchanged (129/129 functions identical with includers). 2026-10-29 12:19:20 +01:00
ragnarok-clanker
7555e0220d Rename EffectParticle -> CEffectPrim (DHXJ), EffectParticle.{h,cpp} -> EffectPrim.{h,cpp}. Pure rename, codegen unchanged (50/50 functions identical with includers). 2026-10-29 12:15:56 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
5b51184749 Decompile 20 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h, ...
Batch #2111 by ragnarok-clanker: 0 byte-identical, 20 confirmed by peer review.

- fn_21042 CGameActor::GetEffectiveJob: logic confirmed by peer review
- fn_03042 CGameActor::Slot62: logic confirmed by peer review
- fn_03046 CGameActor::GetExtent: logic confirmed by peer review
- fn_03048 CGameActor::Slot45: logic confirmed by peer review
- fn_03054 CGameActor::Slot48: logic confirmed by peer review
- fn_03062 CGameActor::Slot47: logic confirmed by peer review
- fn_21040 CGameActor::Slot55: logic confirmed by peer review
- fn_21048 CGameActor::Slot51: logic confirmed by peer review
- fn_21052 CGameActor::Slot53: logic confirmed by peer review
- fn_21135 CGameActor::Slot49: logic confirmed by peer review
- fn_23576 CSession::IsNpcJob: logic confirmed by peer review
- fn_23792 CSession::GetPairValue: logic confirmed by peer review
- fn_23872 CSession::IsGuardianJob: logic confirmed by peer review
- fn_23887 CSession::IsPlayerJobId: logic confirmed by peer review
- fn_22615 CGrannyPc::Slot40: logic confirmed by peer review
- fn_22616 CPc::Slot40: logic confirmed by peer review
- fn_22621 CGrannyPc::Slot41: logic confirmed by peer review
- fn_22622 CPc::Slot41: logic confirmed by peer review
- fn_22625 CPc::Slot47: logic confirmed by peer review
- fn_22383 CPc::Slot35: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:59:31 +00:00
ragnarok-clanker
7cbe10620b Decompile 22 functions in Source/Contents/Actors/ActorStateFlags.cpp, Source/Contents/Actors/ActorStateFlags.h
Batch #2118 by ragnarok-clanker: 0 byte-identical, 22 confirmed by peer review.

- fn_23525 StateFlag01Changed: logic confirmed by peer review
- fn_23527 StateFlag05Changed: logic confirmed by peer review
- fn_23529 StateFlag23Changed: logic confirmed by peer review
- fn_23531 StateFlag24Changed: logic confirmed by peer review
- fn_23533 StateFlag25Changed: logic confirmed by peer review
- fn_23535 StateFlag26Changed: logic confirmed by peer review
- fn_23537 StateFlag19Changed: logic confirmed by peer review
- fn_23538 StateFlag14: logic confirmed by peer review
- fn_23540 StateFlag02: logic confirmed by peer review
- fn_23541 StateFlag02Changed: logic confirmed by peer review
- fn_23542 StateFlag22: logic confirmed by peer review
- fn_23544 StateFlagsClear: logic confirmed by peer review
- fn_23546 StateFlag11: logic confirmed by peer review
- fn_23547 StateFlag20: logic confirmed by peer review
- fn_23548 StateFlag20Changed: logic confirmed by peer review
- fn_23549 StateFlag13: logic confirmed by peer review
- fn_23550 StateFlag13Changed: logic confirmed by peer review
- fn_23552 StateFlag00: logic confirmed by peer review
- fn_23553 StateFlag00Changed: logic confirmed by peer review
- fn_23554 StateFlag06: logic confirmed by peer review
- fn_23555 StateFlag06Changed: logic confirmed by peer review
- fn_23557 StateFlag15Changed: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:58:34 +00:00
ragnarok-clanker
76ac1d4c92 Decompile 3 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/Effect.cpp, ...
Batch #2114 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_18774 EffectLists::Spawn: logic confirmed by peer review
- fn_18991 CEffect::SetActor: logic confirmed by peer review
- fn_18992 CEffect::SetSourceActor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:47:33 +00:00
ragnarok-clanker
7f8b1faa57 Decompile 18 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h, ...
Batch #2112 by ragnarok-clanker: 18 byte-identical, 0 confirmed by peer review.

- fn_03043 CGameActor::Slot46: byte-identical
- fn_03044 CGameActor::Slot13: byte-identical
- fn_03045 CGameActor::Slot50: byte-identical
- fn_03047 CGameActor::Slot58: byte-identical
- fn_03049 CGameActor::Slot56: byte-identical
- fn_03050 CGameActor::Slot42: byte-identical
- fn_03051 CGameActor::Slot35: byte-identical
- fn_03057 CGameActor::Slot40: byte-identical
- fn_03059 CGameActor::Slot59: byte-identical
- fn_03060 CGameActor::Slot57: byte-identical
- fn_03061 CGameActor::Slot41: byte-identical
- fn_03068 CGameActor::Slot60: byte-identical
- fn_03071 CGameActor::Slot43: byte-identical
- fn_22636 CPc::Slot60: byte-identical
- fn_22378 CPc::Slot46: byte-identical
- fn_22380 CPc::Slot58: byte-identical
- fn_22381 CPc::Slot56: byte-identical
- fn_22382 CPc::Slot42: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 10:36:51 +00:00
ragnarok-clanker
a94250ec62 Confirm 3 functions in Source/Contents/ClientTiming.cpp, Source/Contents/NavigationManager.h
Batch #2110 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_19424 CNaviInfo::CNaviInfo: logic confirmed by peer review (already on main)
- fn_19425 CNavi_Object::CNavi_Object: logic confirmed by peer review (already on main)
- fn_19426 CNavi_Object::CNavi_Object: logic confirmed by peer review (already on main)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 10:35:34 +00:00
ragnarok-clanker
3f11ad6407 Decompile fn_21245 (CGameMode::CanFindPath)
Batch #2107 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21245 CGameMode::CanFindPath: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:27:21 +00:00
ragnarok-clanker
df6f74535d Decompile 14 functions in Source/Contents/Actors/ActorStateFlags.cpp, Source/Contents/Actors/ActorStateFlags.h
Batch #2106 by ragnarok-clanker: 0 byte-identical, 14 confirmed by peer review.

- fn_23524 StateFlag01: logic confirmed by peer review
- fn_23526 StateFlag05: logic confirmed by peer review
- fn_23528 StateFlag23: logic confirmed by peer review
- fn_23530 StateFlag24: logic confirmed by peer review
- fn_23532 StateFlag25: logic confirmed by peer review
- fn_23534 StateFlag26: logic confirmed by peer review
- fn_23536 StateFlag19: logic confirmed by peer review
- fn_23539 StateFlag27: logic confirmed by peer review
- fn_23543 StateFlag12: logic confirmed by peer review
- fn_23545 StateFlag28: logic confirmed by peer review
- fn_23551 StateFlag16: logic confirmed by peer review
- fn_23556 StateFlag15: logic confirmed by peer review
- fn_23558 StateFlag18: logic confirmed by peer review
- fn_23559 StateFlag21: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/Actors/ActorStateFlags.cpp
2026-10-29 10:27:11 +00:00
ragnarok-clanker
d15190c45f Decompile fn_21041 (CGameObject::GetDir)
Batch #2105 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21041 CGameObject::GetDir: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:24:11 +00:00
ragnarok-clanker
cae73af75b Decompile 2 functions in Source/Contents/TerrainPathSearch.cpp, Source/Contents/TerrainPathSearch.h
Batch #2104 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17882 CPathFinder::AddNeighbor: logic confirmed by peer review
- fn_17883 MovementOpenList::Push: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:24:08 +00:00