Commit graph

35 commits

Author SHA1 Message Date
ragnarok-clanker
05882a0341 Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveRendering.cpp, Source/Contents/Effects/EffectPrimitiveMotion.cpp, ...
Batch #2137 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19923 CEffectPrim::RenderTeiRect: logic confirmed by peer review
- fn_19924 CEffectPrim::RenderTeiRect: logic confirmed by peer review
- fn_19925 CEffectPrim::RenderTeiRect: logic confirmed by peer review
- fn_19933 TransformVert: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:19:13 +00:00
ragnarok-clanker
1682799c2c Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrim.h
Batch #2132 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19845 CEffectPrim::PrimTwilight: logic confirmed by peer review
- fn_19847 CEffectPrim::PrimWind: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:02:10 +00:00
ragnarok-clanker
dd5161a8f7 Decompile 18 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrim.h
Batch #2133 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_19787 CEffectPrim::PrimAcidDemon: logic confirmed by peer review
- fn_19788 CEffectPrim::PrimAsuraCasting: logic confirmed by peer review
- fn_19803 CEffectPrim::PrimElectric2: logic confirmed by peer review
- fn_19806 CEffectPrim::PrimFlowerCast: logic confirmed by peer review
- fn_19807 CEffectPrim::PrimForest: logic confirmed by peer review
- fn_19819 CEffectPrim::PrimMapParticle: logic confirmed by peer review
- fn_19820 CEffectPrim::PrimParticleSpread: logic confirmed by peer review
- fn_19821 CEffectPrim::PrimParticleUp: logic confirmed by peer review
- fn_19823 CEffectPrim::PrimPeongUp: logic confirmed by peer review
- fn_19825 CEffectPrim::PrimPokJuk: logic confirmed by peer review
- fn_19832 CEffectPrim::PrimSTIN4: logic confirmed by peer review
- fn_19833 CEffectPrim::PrimSaintWing: logic confirmed by peer review
- fn_19837 CEffectPrim::PrimSoulParticle: logic confirmed by peer review
- fn_19838 CEffectPrim::PrimSphereWind2: logic confirmed by peer review
- fn_19932 CEffectPrim::Tei_TowardScreen: logic confirmed by peer review
- fn_19938 CEffectPrim::PrimGI4: logic confirmed by peer review
- fn_19940 CEffectPrim::PrimGI1: logic confirmed by peer review
- fn_19946 CEffectPrim::PrimCHOOKGI: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 13:17:02 +00:00
ragnarok-clanker
f8ee6dec15 Decompile 3 functions in Source/Contents/Effects/PartyMemberEffects.cpp, Source/Contents/Effects/EffectPrimitiveMotion.cpp, ...
Batch #2131 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_19841 CEffectPrim::PrimTanji2: logic confirmed by peer review
- fn_19786 CEffectPrim::Prim3DTextureNoMaster: logic confirmed by peer review
- fn_21069 EffectActor::LaunchEffect: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 12:59:44 +00:00
ragnarok-clanker
bc7be6e928 Rename ConnectionBuffer -> CPacketQueue (DHXJ; methods GetData/GetSize/Init/InsertData/PeekData/RemoveData; file -> PacketQueue.{h,cpp}), CConnection::SetBlock, CEffectPrim::Prim3DParticleGravity. Pure rename, codegen unchanged (109/109 functions, byte-identical). 2026-10-29 13:22:00 +01:00
ragnarok-clanker
dc2f3a8f88 Align method names with DHXJ (call-graph matches): CEffectPrim::Prim3DParticle/Prim3DParticleNoMaster/Prim3DParticleOrbit, matrix::AppendScale/AppendXRotation/AppendZRotation/AppendTranslate/MakeYRotation/MakeZRotation, CRenderObject::CalcDist (2 overloads). Pure rename, codegen unchanged (504/504 functions identical with includers). 2026-10-29 13:12:37 +01:00
ragnarok-clanker
e9b98b8c69 Rename AffineMatrix -> matrix (DHXJ); clashes with variables named matrix use the elaborated form 'struct matrix'. Pure rename, codegen unchanged (383/383 functions identical with includers). 2026-10-29 12:33:14 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
7f3b43c8ef Rename AttachedEffect -> CRagEffect (DHXJ), AttachedEffect.{h,cpp} -> RagEffect.{h,cpp}. Pure rename, codegen unchanged (129/129 functions identical with includers). 2026-10-29 12:19:20 +01:00
ragnarok-clanker
7555e0220d Rename EffectParticle -> CEffectPrim (DHXJ), EffectParticle.{h,cpp} -> EffectPrim.{h,cpp}. Pure rename, codegen unchanged (50/50 functions identical with includers). 2026-10-29 12:15:56 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
59d0e54c9e Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h
Batch #2102 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19817 EffectParticle::PrimKouenka: logic confirmed by peer review
- fn_19834 EffectParticle::PrimSakura: logic confirmed by peer review
- fn_19836 EffectParticle::PrimShieldBoomerang: logic confirmed by peer review
- fn_19843 EffectParticle::PrimTeiHit2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:24:08 +00:00
ragnarok-clanker
bf726cdbc4 Decompile fn_19811 (EffectParticle::PrimGhost)
Batch #2096 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19811 EffectParticle::PrimGhost: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:11:32 +00:00
ragnarok-clanker
32b2067c80 Decompile fn_19783 (EffectParticle::UpdateWarp)
Batch #2091 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19783 EffectParticle::UpdateWarp: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 09:59:37 +00:00
ragnarok-clanker
b2252fa1ab Decompile fn_19944 (EffectParticle::FollowMasterAndTickSlots2)
Batch #1991 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19944 EffectParticle::FollowMasterAndTickSlots2: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-29 08:59:05 +00:00
ragnarok-clanker
b7fce8bdd9 Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h
Batch #1992 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_19966 EffectParticle::FollowMasterAndAdvance: byte-identical
- fn_19952 EffectParticle::FollowMasterAndTickSlots: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 00:59:59 +00:00
ragnarok-clanker
97cf23ebda Decompile 4 functions in Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/RenderObjectState.cpp, ...
Batch #1949 by ragnarok-clanker: 1 byte-identical, 3 confirmed by peer review.

- fn_21086 RenderObjectState::Reset: logic confirmed by peer review
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_20088 UpdatePartyEffect: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 00:03:44 +00:00
ragnarok-clanker
a591f8908d Decompile 6 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1876 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_19844 EffectParticle::PrimThrowItem: logic confirmed by peer review (annotation added to existing code)
- fn_19822 EffectParticle::PrimPeong: logic confirmed by peer review (annotation added to existing code)
- fn_19810 EffectParticle::PrimGI3: logic confirmed by peer review (annotation added to existing code)
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review (already on main)
- fn_04106 ItemInfo::GetItemId: logic confirmed by peer review (annotation added to existing code)
- fn_12589 ShortcutDrop::Drop: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-28 23:10:29 +00:00
ragnarok-clanker
81e812ea39 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1869 by ragnarok-clanker: 3 byte-identical, 0 confirmed by peer review.

- fn_19971 EffectParticle::PrimWaterFall: byte-identical
- fn_21090 CGameActor::ProcessBodyState: byte-identical
- fn_12629 UIShortCutWnd::Slot03: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-10-28 23:05:45 +00:00
ragnarok-clanker
2e808aaa74 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1853 by ragnarok-clanker: 1 byte-identical, 2 confirmed by peer review.

- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:53:38 +00:00
ragnarok-clanker
6f1a245675 Decompile 7 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ...
Batch #1846 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_19830 EffectParticle::PrimSMA: logic confirmed by peer review (annotation added to existing code)
- fn_19790 EffectParticle::PrimBottom2: logic confirmed by peer review (already on main)
- fn_19791 EffectParticle::PrimBottom: logic confirmed by peer review (already on main)
- fn_02021 CreateTrigonometricTable: logic confirmed by peer review (already on main)
- fn_02023 ClientCosine: logic confirmed by peer review (already on main)
- fn_02025 ClientSine: logic confirmed by peer review (already on main)
- fn_19818 EffectParticle::PrimLineLink: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:52:17 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ...
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:49:51 +00:00
ragnarok-clanker
16fade7361 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1792 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_19796 EffectParticle::PrimChemical3: logic confirmed by peer review
- fn_19824 EffectParticle::PrimPoison: logic confirmed by peer review
- fn_19813 EffectParticle::PrimGuard: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:39:29 +00:00
ragnarok-clanker
805cf67f82 Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
Batch #1793 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19800 EffectParticle::PrimEffectTexture2: logic confirmed by peer review
- fn_19802 EffectParticle::PrimEffectTexture_Ani: logic confirmed by peer review
- fn_19805 EffectParticle::PrimFirstAid: logic confirmed by peer review
- fn_19816 EffectParticle::PrimIntimidate: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:21:46 +00:00
ragnarok-clanker
73e944dded Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h
Batch #1789 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19795 EffectParticle::PrimChemical2: logic confirmed by peer review
- fn_19797 EffectParticle::PrimChemical: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:19:15 +00:00
ragnarok-clanker
43198220b9 Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h
Batch #1770 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19792 EffectParticle::PrimBottomOut: logic confirmed by peer review
- fn_19793 EffectParticle::PrimBubbleDrop: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:12:29 +00:00
ragnarok-clanker
25dd065dbd Decompile 8 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrimitiveState.cpp, ...
Batch #1765 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.

- fn_19791 EffectParticle::PrimBottom: logic confirmed by peer review
- fn_19765 EffectPrimitiveState::GetColorOverride: logic confirmed by peer review
- fn_19779 EffectParticle::UpdateHit6: logic confirmed by peer review
- fn_19785 MoveEffectPrimitive: logic confirmed by peer review
- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_19866 RenderEffectPrimitive15: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:09:53 +00:00
ragnarok-clanker
fbb9a30daa Decompile fn_19790 (EffectParticle::PrimBottom2)
Batch #1732 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19790 EffectParticle::PrimBottom2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 21:47:19 +00:00
ragnarok-clanker
d9a92a8e3b Decompile fn_19780 (EffectParticle::UpdateCoin)
Batch #1626 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19780 EffectParticle::UpdateCoin: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:46:05 +00:00
ragnarok-clanker
6c9430e9a1 🔥 refactor(effects): removed unused header includes 2026-10-28 17:41:29 +01:00
ragnarok-clanker
819b017c80 Decompile fn_19783 (EffectParticle::UpdateWarp)
Batch #1424 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19783 EffectParticle::UpdateWarp: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:44:52 +00:00
ragnarok-clanker
e79c5afc99 Decompile 8 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrimitiveState.h, ...
Batch #1425 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.

- fn_19772 EffectParticle::UpdateFireWall: logic confirmed by peer review
- fn_19775 EffectParticle::UpdateStoneCurse: logic confirmed by peer review
- fn_19776 EffectParticle::UpdateBeginSpell: logic confirmed by peer review
- fn_19779 EffectParticle::UpdateHit6: logic confirmed by peer review
- fn_19781 EffectParticle::UpdateDetoxication: logic confirmed by peer review
- fn_19782 EffectParticle::UpdateExit: logic confirmed by peer review
- fn_19764 EffectParticle::AdvanceFrame: logic confirmed by peer review
- fn_19931 EffectParticle::UpdateRecords: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 12:43:08 +00:00
ragnarok-clanker
c6cc9dc69e Decompile 6 functions in Source/Contents/Effects/EffectPrimitiveState.cpp, Source/Contents/Effects/EffectPrimitiveState.h, ...
Batch #1199 by eAthena: 0 byte-identical, 6 confirmed by peer review.

- fn_19765 EffectPrimitiveState::GetColorOverride: logic confirmed by peer review
- fn_19773 ShrinkEffectPrimitiveSlots: logic confirmed by peer review
- fn_19774 PulseEffectPrimitiveSlots: logic confirmed by peer review
- fn_19777 SpinEffectPrimitive: logic confirmed by peer review
- fn_19778 RollEffectPrimitive: logic confirmed by peer review
- fn_19784 AdvanceEffectPrimitive: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 21:09:20 +00:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
Renamed from Source/Contents/EffectPrimitiveMotion.cpp (Browse further)