Commit graph

53 commits

Author SHA1 Message Date
ragnarok-clanker
30cdd441a1 Maintenance: [forced, admin decision] Resubmission of returned batch 10026 rebased on c246e79d: also renames the CMode+0x10 write in
Batch #10033 by ragnarok-clanker: forced by an admin (0 lower score(s), 6 changed function(s)); checked with 479 compiled unit(s), including every includer of Source/Client/Application/ApplicationMessages.h, Source/Client/Application/Launcher.h, Source/Client/Mode/CMode.h, Source/Client/ModeFade.h, Source/UI/Window/UIWindowMgr.h.
2026-11-02 14:34:46 +00:00
ragnarok-clanker
694f37b1a5 Decompile fn_21329 (CGameMode::ProcessGroundClick)
Batch #9998 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_21329 CGameMode::ProcessGroundClick: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, cremane
Reviewed-by: ragnarok-clanker
2026-11-02 13:53:27 +00:00
ragnarok-clanker
b538c3a695 Maintenance: Consolidate the guild state into its real owner. The original has one GuildInfo object at 0x16D4400 (static ctor 0x4A887
Batch #10011 by ragnarok-clanker: forced by an admin (8 lower score(s), 43 changed function(s)); checked with 137 compiled unit(s), including every includer of Source/Contents/Actors/RenderObject.h, Source/Contents/GuildInfo.h, Source/Contents/GuildMgr.h.
2026-11-02 13:42:03 +00:00
ragnarok-clanker
d7052cd046 Decompile fn_17930 (CView::Render)
Batch #9548 by Lumen: 0 byte-identical, 1 confirmed by peer review.

- fn_17930 CView::Render: logic confirmed by peer review

Peer-reviewed-by: secret, meitogi, gordaoprogramas, superintelligence, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 16:03:55 +00:00
ragnarok-clanker
31b3875300 Decompile 3 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #9503 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_22301 CLoginMode::Slot5: logic confirmed by peer review
- fn_22305 CLoginMode::Update: logic confirmed by peer review
- fn_17684 CWorld::InitWorld: logic confirmed by peer review

Peer-reviewed-by: secret, superintelligence, KWDev, seumadruga, ragnarok-clanker, gordaoprogramas, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 14:37:01 +00:00
ragnarok-clanker
1a4662a41f Decompile fn_17684 (CWorld::InitWorld)
Batch #9400 by Lumen: 0 byte-identical, 1 confirmed by peer review.

- fn_17684 CWorld::InitWorld: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 12:48:30 +00:00
ragnarok-clanker
79dd2432b8 Decompile fn_21297 (CGameMode::UpdateNameBalloon)
Batch #9252 by KWDev: 0 byte-identical, 1 confirmed by peer review.

- fn_21297 CGameMode::UpdateNameBalloon: logic confirmed by peer review

Peer-reviewed-by: secret, superintelligence, seumadruga
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 06:03:19 +00:00
ragnarok-clanker
ce937281ca Decompile 2 functions in Source/Contents/World/WorldProximity.cpp
Batch #9214 by secret: 0 byte-identical, 2 confirmed by peer review.

- fn_17699 CWorld::AddPcPos: logic confirmed by peer review
- fn_17678 CWorld::FindActorInCell: logic confirmed by peer review

Peer-reviewed-by: superintelligence, KWDev, seumadruga
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 05:04:54 +00:00
ragnarok-clanker
7b4740adbf Decompile fn_17688 (CWorld::OnProcess)
Batch #8505 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_17688 CWorld::OnProcess: logic confirmed by peer review

Peer-reviewed-by: eAthena, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 18:34:47 +00:00
ragnarok-clanker
da85cd2f6d Decompile fn_17682 (CWorld::LoadMapEffects)
Batch #8482 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_17682 CWorld::LoadMapEffects: logic confirmed by peer review

Peer-reviewed-by: KWDev, Romain, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/World/WorldEffects.cpp
2026-10-31 18:20:17 +00:00
ragnarok-clanker
e111a16b63 Decompile fn_21307 (CGameMode::OpenActorMenu)
Batch #8359 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21307 CGameMode::OpenActorMenu: logic confirmed by peer review

Peer-reviewed-by: eAthena, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 17:04:15 +00:00
ragnarok-clanker
7a697a7e52 Decompile fn_17650 (WorldRayQuery::WorldRayQuery)
Batch #8258 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_17650 WorldRayQuery::WorldRayQuery: logic confirmed by peer review

Peer-reviewed-by: eAthena, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 15:43:37 +00:00
ragnarok-clanker
918b893022 Decompile 2 functions in Source/Contents/World/WorldActors.cpp, Source/Contents/World/World.h, ...
Batch #8203 by pedrao: 0 byte-identical, 2 confirmed by peer review.

- fn_17672 CWorld::CreatePlayer: logic confirmed by peer review
- fn_02352 CreateTextureDX9: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 15:11:25 +00:00
ragnarok-clanker
cee583cb0d Decompile fn_21299 (CGameMode::SpawnArrowEffect64)
Batch #8125 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21299 CGameMode::SpawnArrowEffect64: logic confirmed by peer review

Peer-reviewed-by: Yommy, Snow, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 14:18:36 +00:00
ragnarok-clanker
ae7cb57b3f Decompile 2 functions in Source/Contents/World/WorldProximity.cpp
Batch #7544 by Toshiro: 0 byte-identical, 2 confirmed by peer review.

- fn_17686 CWorld::PcApproachToPlayer: logic confirmed by peer review
- fn_17687 CWorld::PlayerMove: logic confirmed by peer review

Peer-reviewed-by: eAthena, secret
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 10:22:36 +00:00
ragnarok-clanker
6a59abb0b5 Decompile 2 functions in Source/Contents/World/WorldObjects.cpp, Source/Contents/World/World.h, ...
Batch #7549 by eAthena: 1 byte-identical, 1 confirmed by peer review.

- fn_17690 CWorld::RemoveItem: logic confirmed by peer review
- fn_21300 CGameMode::UnusedArrowStub: byte-identical

Peer-reviewed-by: Yommy, Snow, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 10:15:52 +00:00
ragnarok-clanker
95101552fb Decompile fn_17685 (CWorld::OnExitFrame)
Batch #7520 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17685 CWorld::OnExitFrame: logic confirmed by peer review

Peer-reviewed-by: secret, Romain, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 09:49:38 +00:00
ragnarok-clanker
da7f6e7d93 Decompile 2 functions in Source/Contents/World/WorldObjects.cpp, Source/Client/Mode/CGameMode.h
Batch #7115 by aDw: 0 byte-identical, 2 confirmed by peer review.

- fn_21298 CGameMode::SpawnArrowEffect: logic confirmed by peer review
- fn_21299 CGameMode::SpawnArrowEffect64: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, gordaoprogramas, Lumen, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:28:45 +00:00
ragnarok-clanker
d85d5d2575 Decompile fn_21309 (CGameMode::SpawnMsgEffect)
Batch #6958 by superintelligence: 0 byte-identical, 1 confirmed by peer review.

- fn_21309 CGameMode::SpawnMsgEffect: logic confirmed by peer review

Peer-reviewed-by: eAthena, KWDev, Landruca
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 03:12:01 +00:00
ragnarok-clanker
14145e50fe Decompile fn_21308 (CGameMode::SpawnDamageMsgEffect)
Batch #6972 by superintelligence: 0 byte-identical, 1 confirmed by peer review.

- fn_21308 CGameMode::SpawnDamageMsgEffect: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag, Landruca
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 02:55:34 +00:00
ragnarok-clanker
938387b643 Decompile 2 functions in Source/Contents/World/WorldProximity.cpp, Source/Contents/World/World.h
Batch #6874 by pedrao: 0 byte-identical, 2 confirmed by peer review.

- fn_17700 CWorld::AddPcPosFromCell: logic confirmed by peer review
- fn_17701 CWorld::AddPcPosUnindexed: logic confirmed by peer review

Peer-reviewed-by: alisonrag, superintelligence, Snow, ragnarok-clanker, Yommy, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:58:38 +00:00
ragnarok-clanker
be64b7dc52 Decompile fn_17677 (CWorld::IsExistGuildMasterNearby)
Batch #6669 by kyoshi: 0 byte-identical, 1 confirmed by peer review.

- fn_17677 CWorld::IsExistGuildMasterNearby: logic confirmed by peer review

Peer-reviewed-by: eAthena, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:34:10 +00:00
ragnarok-clanker
0852a6339a Decompile 2 functions in Source/Contents/World/WorldProximity.cpp
Batch #5999 by superintelligence: 0 byte-identical, 2 confirmed by peer review.

- fn_17719 WorldProximityGuildMasterCallback::Invoke: logic confirmed by peer review
- fn_17720 WorldProximityRangeCallback::Invoke: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 18:23:15 +00:00
ragnarok-clanker
afeed6b258 Decompile 3 functions in Source/Contents/World/WorldObjects.cpp, Source/Contents/World/WorldProximity.cpp, ...
Batch #5981 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_17679 CWorld::IsGuildMaster: logic confirmed by peer review
- fn_17693 CWorld::RemoveGroundItem: logic confirmed by peer review
- fn_17697 CWorld::RemoveSkill: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, superintelligence, SapitoSucio, tayoba, Snow, Yommy, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 18:23:06 +00:00
ragnarok-clanker
ffaaa50169 Decompile 2 functions in Source/Contents/World/WorldProximity.cpp
Batch #6016 by superintelligence: 2 byte-identical, 0 confirmed by peer review.

- fn_17717 WorldProximityRejectA: byte-identical
- fn_17718 WorldProximityRejectB: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-30 18:21:36 +00:00
ragnarok-clanker
74c0f03188 Decompile 2 functions in Source/Contents/World/WorldProximity.cpp, Source/Contents/World/World.h
Batch #5744 by willerthal: 0 byte-identical, 2 confirmed by peer review.

- fn_17695 CWorld::RemovePcPos: logic confirmed by peer review
- fn_17696 CWorld::RemovePcPosForMove: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, SapitoSucio, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 17:41:47 +00:00
ragnarok-clanker
77c4face37 Decompile 6 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h, ...
Batch #5750 by willerthal: 0 byte-identical, 6 confirmed by peer review.

- fn_21023 CGameActor::ClearUnknown0188: logic confirmed by peer review
- fn_21075 CGameActor::RefreshGuildEmblemWindow: logic confirmed by peer review
- fn_21165 CGameActor::NotifyCellMove: logic confirmed by peer review
- fn_21177 C3dGrannyGameActor::SpawnCorpseActor: logic confirmed by peer review
- fn_21158 CGameActor::sub_CC40D0: logic confirmed by peer review
- fn_21178 C3dGrannyGameActor::OnProcess: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Snow, SapitoSucio, Yommy, tayoba, Millenium, Qwenkler3.8
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 15:46:20 +00:00
ragnarok-clanker
1a0c1375ed Decompile 5 functions in Source/Contents/World/WorldObjects.cpp, Source/Contents/Actors/RenderObject.cpp, ...
Batch #5424 by Yommy: 0 byte-identical, 5 confirmed by peer review.

- fn_21302 CGameMode::ShowGuildEmblem: logic confirmed by peer review
- fn_21303 CGameMode::SpawnCashEmotion: logic confirmed by peer review
- fn_21304 CGameMode::ApplyMapFog: logic confirmed by peer review
- fn_21305 CGameMode::SpawnGrannyCorpse: logic confirmed by peer review
- fn_21306 CGameMode::SpawnMandraAttack: logic confirmed by peer review

Peer-reviewed-by: willerthal, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 12:52:28 +00:00
ragnarok-clanker
57c72ab3ba Decompile 5 functions in Source/Contents/World/SkyBox.cpp, Source/Contents/World/SkyBox.h
Batch #5455 by Yommy: 0 byte-identical, 5 confirmed by peer review.

- fn_08044 CLensFlare::CLensFlare: logic confirmed by peer review (annotation added to existing code)
- fn_08045 CSkyCube::CSkyCube: logic confirmed by peer review (annotation added to existing code)
- fn_08050 CLensFlare::Init: logic confirmed by peer review (annotation added to existing code)
- fn_08051 CLensFlare::Update: logic confirmed by peer review (annotation added to existing code)
- fn_08052 CLensFlare::Render: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: ragnarok-clanker, willerthal, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 12:14:40 +00:00
ragnarok-clanker
8ff80e6385 Decompile 4 functions in Source/Contents/World/SkyBox.cpp, Source/Contents/World/SkyBox.h
Batch #5460 by Yommy: 4 byte-identical, 0 confirmed by peer review.

- fn_08046 FlareElement::FlareElement: byte-identical
- fn_08047 SkyBoxVertex::SkyBoxVertex: byte-identical
- fn_08048 SkyBoxVertex::~SkyBoxVertex: byte-identical
- fn_08049 CSkyBox::~CSkyBox: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/World/SkyBox.cpp
2026-10-30 11:55:02 +00:00
ragnarok-clanker
1aba73a5d5 Decompile fn_21296 (CGameMode::LaunchTargetEffect)
Batch #5314 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21296 CGameMode::LaunchTargetEffect: logic confirmed by peer review

Peer-reviewed-by: meitogi, alisonrag, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 10:45:18 +00:00
ragnarok-clanker
95ef79d546 Decompile 2 functions in Source/Contents/World/WorldObjects.cpp, Source/Contents/World/World.h, ...
Batch #4425 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17669 CWorld::GetItemByAID: logic confirmed by peer review
- fn_17670 CWorld::GetActorByGID: logic confirmed by peer review

Peer-reviewed-by: willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 03:00:41 +00:00
ragnarok-clanker
87bb32cef8 Decompile 48 functions in Source/Client/ModeFade.cpp, Source/Client/ModeFade.h, ...
Batch #2457 by ragnarok-clanker: 0 byte-identical, 48 confirmed by peer review.

- fn_00152 TextureCache::TextureCache: logic confirmed by peer review
- fn_01952 DrawAlphaRectangle: logic confirmed by peer review
- fn_01953 DrawBlendedRectangle: logic confirmed by peer review
- fn_01954 DrawTexturedRectangle: logic confirmed by peer review
- fn_01955 DrawTextureRegion: logic confirmed by peer review
- fn_02237 CRendererDX9::SaveLogo: logic confirmed by peer review
- fn_02353 CRenderSystemDX9::CRenderSystemDX9: logic confirmed by peer review
- fn_02447 TextureCache::~TextureCache: logic confirmed by peer review (already on main)
- fn_02449 TextureCache::Upload: logic confirmed by peer review
- fn_02451 TextureCache::Clear: logic confirmed by peer review (already on main)
- fn_02452 TextureCache::Remove: logic confirmed by peer review (already on main)
- fn_02453 TextureCache::Default: logic confirmed by peer review
- fn_02454 TextureCache::Load: logic confirmed by peer review (already on main)
- fn_02455 TextureCache::Create: logic confirmed by peer review
- fn_02456 TextureCache::Reload: logic confirmed by peer review
- fn_02457 TextureCache::ClearUnused: logic confirmed by peer review
- fn_07897 EZeffectClip::Texture: logic confirmed by peer review
- fn_07898 EZeffectClip::Texture: logic confirmed by peer review
- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review
- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review
- fn_08010 C3dGrannyModelRes::CreateTexture: logic confirmed by peer review
- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review
- fn_09166 BinkMovies::Update: logic confirmed by peer review
- fn_10122 UIRPData::DrawNamed: logic confirmed by peer review
- fn_12091 UIWhisperWnd::Slot43: logic confirmed by peer review
- fn_17556 GroundGeometry::Build: logic confirmed by peer review
- fn_17565 GroundGeometry::BuildLightmaps: logic confirmed by peer review
- fn_17581 GroundWaterState::Update: logic confirmed by peer review
- fn_17587 GroundGeometry::DrawGrid: logic confirmed by peer review
- fn_17599 GroundWaterState::Import: logic confirmed by peer review
- fn_17842 ModeFade::Draw: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_20019 CRagEffect::Blessing: logic confirmed by peer review
- fn_20023 CRagEffect::Bottom: logic confirmed by peer review
- fn_20024 CRagEffect::BowlingBash: logic confirmed by peer review
- fn_20025 CRagEffect::CartRevolution: logic confirmed by peer review
- fn_20042 CRagEffect::Entry: logic confirmed by peer review
- fn_20054 CRagEffect::FrostDiver: logic confirmed by peer review
- fn_20058 CRagEffect::GrimTooth: logic confirmed by peer review
- fn_20066 CRagEffect::Hit4: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20105 CRagEffect::SonicBlowHit: logic confirmed by peer review
- fn_20109 CRagEffect::SprayPond: logic confirmed by peer review
- fn_20124 CRagEffect::Yufitel: logic confirmed by peer review
- fn_20132 CRagEffect::AirTexture: logic confirmed by peer review
- fn_20133 CRagEffect::AttackEnergy2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 18:23:21 +00:00
ragnarok-clanker
cd47fe84d3 Rename CGameObject virtuals to DHXJ names across the actor hierarchy: Update->OnProcess, SendObjectMessage->SendMsg, Draw->Render, Direction->Get8Dir, SetScreenBounds->SetRenderInfo, SetScreenPosition->SetTlvert, SetAnimation->SetAction. Pure rename, codegen unchanged (314/314 functions identical with includers). 2026-10-29 14:01:33 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
3956caf9e3 Decompile 2 functions in Source/Contents/Effects/Effect.cpp, Source/Contents/World/WorldObjects.cpp, ...
Batch #2099 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18807 FindRenderObject: logic confirmed by peer review
- fn_17671 WorldScene::GetSkillByAID: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:12:19 +00:00
ragnarok-clanker
8c95ae6c7e Decompile fn_18987 (CEffect::Slot06)
Batch #2100 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_18987 CEffect::Slot06: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 10:09:26 +00:00
ragnarok-clanker
3a6bebae77 Decompile 7 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/Player.cpp, ...
Batch #2092 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_21037 CGameActor::Slot37: logic confirmed by peer review
- fn_21074 CGameActor::Slot38: logic confirmed by peer review
- fn_21199 CGameActor::Slot39: logic confirmed by peer review
- fn_22619 CGrannyPc::Slot39: logic confirmed by peer review
- fn_22620 CPc::Slot39: logic confirmed by peer review
- fn_22354 CCorpse::CCorpse: logic confirmed by peer review
- fn_21301 CGameMode::SpawnCorpse: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:04:49 +00:00
ragnarok-clanker
edd5a4a066 Decompile fn_17678 (WorldScene::FindActorInCell)
Batch #1912 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17678 WorldScene::FindActorInCell: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 23:39:00 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ...
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:49:51 +00:00
ragnarok-clanker
23f296ca38 Decompile fn_17689 (WorldScene::ClearActorCells)
Batch #1640 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_17689 WorldScene::ClearActorCells: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 19:16:57 +00:00
ragnarok-clanker
7a9ea8ab29 Decompile fn_17691 (WorldScene::Clear)
Batch #1549 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17691 WorldScene::Clear: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-28 18:50:15 +00:00
ragnarok-clanker
63b1377599 Decompile 5 functions in Source/Client/ReplayPacketRecorder.h, Source/Contents/Emblems/EmblemUpload.h, ...
Batch #1488 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18386 PacketLengths::IsRecorded: logic confirmed by peer review
- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18388 PacketLengths::Lookup: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
- fn_18171 ResourceFailures::Report: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 16:45:10 +00:00
ragnarok-clanker
73cc345898 Decompile 7 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ...
Batch #1447 by Yommy: 0 byte-identical, 7 confirmed by peer review.

- fn_03435 CMapSkyMgr::LoadData: logic confirmed by peer review
- fn_23794 CSession::GetAccessoryName: logic confirmed by peer review
- fn_17667 WorldActors::Lookup: logic confirmed by peer review
- fn_17698 WorldObjects::SendObjectMessage: logic confirmed by peer review
- fn_17865 CPathFinder::~CPathFinder: logic confirmed by peer review
- fn_18334 LuaScript::TableField: logic confirmed by peer review
- fn_07925 CImfRes::Load: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
2026-10-28 13:18:31 +00:00
ragnarok-clanker
f61f0747fa Decompile 2 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ...
Batch #1449 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_17872 CPathFinder::Height: byte-identical
- fn_17873 CPathFinder::Width: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/MapSkyMgr.cpp, Source/Contents/EquipmentResources.cpp, Source/Contents/Pathfinding.cpp, Source/Resource/ImfResource.cpp
2026-10-28 12:59:53 +00:00
ragnarok-clanker
347b99c15d Decompile 4 functions in Source/Resource/World/WorldResource.cpp, Source/Resource/World/WorldResource.h, ...
Batch #1130 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_08071 C3dWorldRes::Create: logic confirmed by peer review
- fn_08073 C3dWorldRes::Load: logic confirmed by peer review
- fn_08076 C3dWorldRes::C3dWorldRes: logic confirmed by peer review
- fn_17681 WorldSpatialTree::ReadBounds: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:07:47 +00:00
ragnarok-clanker
9ac3d05245 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Contents headers (part 2: Items, Models, Movies, Skills,
Batch #1063 by ragnarok-clanker: no function's compiled code changes; checked with 62 compiled unit(s), including every includer of Source/Contents/Items/ItemNaming.h, Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelRendering.h, Source/Contents/Models/ModelSpatial.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/Movies/BinkMovies.h, Source/Contents/PlayerNameDictionary.h, Source/Contents/Skills/AutomaticSkills.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/WorldModelLoading.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldRayQuery.h.
2026-10-27 13:52:05 +00:00
ragnarok-clanker
3dbd276311 📚 docs(inlining): marked inlined functions across modules 2026-10-27 10:21:57 +01:00
ragnarok-clanker
4d9d775cc8 Decompile 3 functions in Source/Contents/World/WorldSpatialTree.cpp, Source/Contents/World/WorldSpatialTree.h, ...
Batch #995 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_17651 WorldScene::WorldScene: logic confirmed by peer review
- fn_17654 WorldScene::~WorldScene: logic confirmed by peer review
- fn_17704 WorldSpatialTree::RefreshModelBounds: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 08:51:12 +00:00