Commit graph

22 commits

Author SHA1 Message Date
ragnarok-clanker
b7aeb72531 Decompile fn_04342 (CRagEffect::SetStateDuration)
Batch #3900 by sherollyner: 0 byte-identical, 1 confirmed by peer review.

- fn_04342 CRagEffect::SetStateDuration: logic confirmed by peer review

Peer-reviewed-by: Yommy, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:18:43 +00:00
ragnarok-clanker
ca88198020 Decompile fn_04338 (?GetDuration@CRollingCutterRagEffect@?A0xc62a2aae@@UAEHXZ)
Batch #3902 by sherollyner: 1 byte-identical, 0 confirmed by peer review.

- fn_04338 ?GetDuration@CRollingCutterRagEffect@?A0xc62a2aae@@UAEHXZ: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 23:54:47 +00:00
ragnarok-clanker
b73184a998 Maintenance: CODING_RULES cleanup of RagEffect.cpp, no code change (all 124 functions compile identically before/after): wrap 13 line
Batch #3565 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s).
2026-10-29 22:36:41 +00:00
ragnarok-clanker
c26095ec64 Decompile fn_20228 (CRagEffect::TexturedOrbitDust)
Batch #3415 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_20228 CRagEffect::TexturedOrbitDust: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:29:22 +00:00
ragnarok-clanker
162db43713 Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h
Batch #3219 by Lumen: 0 byte-identical, 3 confirmed by peer review.

- fn_20186 CRagEffect::FirstAid: logic confirmed by peer review
- fn_20191 CRagEffect::GRANDCROSS2: logic confirmed by peer review
- fn_20223 CRagEffect::Magnum2: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 20:59:11 +00:00
ragnarok-clanker
0fe3003bbb Decompile fn_20144 (CRagEffect::SaintWing)
Batch #3216 by Lumen: 0 byte-identical, 1 confirmed by peer review.

- fn_20144 CRagEffect::SaintWing: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 20:58:47 +00:00
ragnarok-clanker
e81ecd8904 Decompile 10 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h
Batch #2845 by Lumen: 0 byte-identical, 10 confirmed by peer review.

- fn_20193 CRagEffect::GROUNDSAMPLE: logic confirmed by peer review
- fn_20157 CRagEffect::CALLZONE: logic confirmed by peer review
- fn_20212 CRagEffect::JobLvUp50_2: logic confirmed by peer review
- fn_20252 CRagEffect::RunStop: logic confirmed by peer review
- fn_20256 CRagEffect::SMA: logic confirmed by peer review
- fn_20211 CRagEffect::JobLvUp50: logic confirmed by peer review
- fn_20229 CRagEffect::Map_Pika: logic confirmed by peer review
- fn_20233 CRagEffect::POISON: logic confirmed by peer review
- fn_20248 CRagEffect::Rainbow: logic confirmed by peer review
- fn_20138 CRagEffect::BLIND: logic confirmed by peer review

Peer-reviewed-by: willerthal, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:43:18 +00:00
ragnarok-clanker
1819290973 Decompile fn_20258 (CRagEffect::TexturedSlashLevel)
Batch #2816 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_20258 CRagEffect::TexturedSlashLevel: logic confirmed by peer review

Peer-reviewed-by: meitogi, youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:18:26 +00:00
ragnarok-clanker
578a4287c5 Decompile fn_20092 (CRagEffect::PotionPillar)
Batch #2748 by Lumen: 0 byte-identical, 1 confirmed by peer review.

- fn_20092 CRagEffect::PotionPillar: logic confirmed by peer review

Peer-reviewed-by: youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 18:41:23 +00:00
ragnarok-clanker
6805fb3b26 Decompile 4 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h
Batch #2689 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_20043 CRagEffect::Exit: logic confirmed by peer review
- fn_20118 CRagEffect::Warp: logic confirmed by peer review
- fn_20092 CRagEffect::PotionPillar: logic confirmed by peer review
- fn_20094 CRagEffect::Potion_Berserk: logic confirmed by peer review

Peer-reviewed-by: youko
Reviewed-by: ragnarok-clanker
2026-10-29 18:28:40 +00:00
ragnarok-clanker
87bb32cef8 Decompile 48 functions in Source/Client/ModeFade.cpp, Source/Client/ModeFade.h, ...
Batch #2457 by ragnarok-clanker: 0 byte-identical, 48 confirmed by peer review.

- fn_00152 TextureCache::TextureCache: logic confirmed by peer review
- fn_01952 DrawAlphaRectangle: logic confirmed by peer review
- fn_01953 DrawBlendedRectangle: logic confirmed by peer review
- fn_01954 DrawTexturedRectangle: logic confirmed by peer review
- fn_01955 DrawTextureRegion: logic confirmed by peer review
- fn_02237 CRendererDX9::SaveLogo: logic confirmed by peer review
- fn_02353 CRenderSystemDX9::CRenderSystemDX9: logic confirmed by peer review
- fn_02447 TextureCache::~TextureCache: logic confirmed by peer review (already on main)
- fn_02449 TextureCache::Upload: logic confirmed by peer review
- fn_02451 TextureCache::Clear: logic confirmed by peer review (already on main)
- fn_02452 TextureCache::Remove: logic confirmed by peer review (already on main)
- fn_02453 TextureCache::Default: logic confirmed by peer review
- fn_02454 TextureCache::Load: logic confirmed by peer review (already on main)
- fn_02455 TextureCache::Create: logic confirmed by peer review
- fn_02456 TextureCache::Reload: logic confirmed by peer review
- fn_02457 TextureCache::ClearUnused: logic confirmed by peer review
- fn_07897 EZeffectClip::Texture: logic confirmed by peer review
- fn_07898 EZeffectClip::Texture: logic confirmed by peer review
- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review
- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review
- fn_08010 C3dGrannyModelRes::CreateTexture: logic confirmed by peer review
- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review
- fn_09166 BinkMovies::Update: logic confirmed by peer review
- fn_10122 UIRPData::DrawNamed: logic confirmed by peer review
- fn_12091 UIWhisperWnd::Slot43: logic confirmed by peer review
- fn_17556 GroundGeometry::Build: logic confirmed by peer review
- fn_17565 GroundGeometry::BuildLightmaps: logic confirmed by peer review
- fn_17581 GroundWaterState::Update: logic confirmed by peer review
- fn_17587 GroundGeometry::DrawGrid: logic confirmed by peer review
- fn_17599 GroundWaterState::Import: logic confirmed by peer review
- fn_17842 ModeFade::Draw: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_20019 CRagEffect::Blessing: logic confirmed by peer review
- fn_20023 CRagEffect::Bottom: logic confirmed by peer review
- fn_20024 CRagEffect::BowlingBash: logic confirmed by peer review
- fn_20025 CRagEffect::CartRevolution: logic confirmed by peer review
- fn_20042 CRagEffect::Entry: logic confirmed by peer review
- fn_20054 CRagEffect::FrostDiver: logic confirmed by peer review
- fn_20058 CRagEffect::GrimTooth: logic confirmed by peer review
- fn_20066 CRagEffect::Hit4: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20105 CRagEffect::SonicBlowHit: logic confirmed by peer review
- fn_20109 CRagEffect::SprayPond: logic confirmed by peer review
- fn_20124 CRagEffect::Yufitel: logic confirmed by peer review
- fn_20132 CRagEffect::AirTexture: logic confirmed by peer review
- fn_20133 CRagEffect::AttackEnergy2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 18:23:21 +00:00
ragnarok-clanker
e6c22457a6 Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h
Batch #2449 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_20025 CRagEffect::CartRevolution: logic confirmed by peer review
- fn_20024 CRagEffect::BowlingBash: logic confirmed by peer review
- fn_20105 CRagEffect::SonicBlowHit: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas
Reviewed-by: ragnarok-clanker
2026-10-29 16:14:48 +00:00
ragnarok-clanker
bc0f96ee8b Decompile fn_20055 (CRagEffect::GetDuration)
Batch #2447 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_20055 CRagEffect::GetDuration: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 16:03:32 +00:00
ragnarok-clanker
fb006bc003 Decompile 4 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h
Batch #2431 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_20133 CRagEffect::AttackEnergy2: logic confirmed by peer review
- fn_20077 CRagEffect::LexDivina: logic confirmed by peer review
- fn_20096 CRagEffect::RemoveTrap: logic confirmed by peer review
- fn_20108 CRagEffect::Sphere: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 15:56:49 +00:00
ragnarok-clanker
5a9265428f Decompile fn_20241 (CRagEffect::Fireworks)
Batch #2202 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_20241 CRagEffect::Fireworks: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 15:46:38 +00:00
ragnarok-clanker
648d92414a Decompile 8 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h
Batch #2193 by ragnarok-clanker: 8 byte-identical, 0 confirmed by peer review.

- fn_20034 CRagEffect::ProcessEZ2STRC10830: byte-identical
- fn_20049 CRagEffect::ProcessEZ2STRC153A0: byte-identical
- fn_20112 CRagEffect::ProcessEZ2STRC3CC40: byte-identical
- fn_20123 CRagEffect::ProcessEZ2STRC3FE00: byte-identical
- fn_20267 CRagEffect::ProcessEZ2STRC65300: byte-identical
- fn_20051 CRagEffect::ProcessEZ2STRC15990: byte-identical
- fn_20052 CRagEffect::ProcessEZ2STRC159D0: byte-identical
- fn_20326 CRagEffect::ShieldCharge: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 15:21:28 +00:00
ragnarok-clanker
2a3e04dac8 RagEffectState: name CRagEffect members after DHXJ (param[4], longitude, latitude, tlvertX/Y/Z, defZ, isDirection, type, level, flag, count, stateCnt, duration, deltaPos/deltaPos2/deltaPos3, primList, objSeg). tlvert/longitude become floats (were uint32 written through bit_cast). Codegen unchanged except Hit4 (59.2->60.4%) and ProcessEZ2STR (58.6->59.0%), both from dropping the bit_cast stores; 120/122 identical with includers. 2026-10-29 16:00:58 +01:00
ragnarok-clanker
bdd9736af4 EffectPrimitiveState: name 84 CEffectPrim members after DHXJ (layout matches DHXJ member order with 12-byte std::vector and one extra 2026 dword at 0x1D8): stateCnt, duration, pattern, count, renderFlag, numSegment, speed/accel, gravSpeed/gravAccel, longitude/latitude/roll, size, alpha*, lati*/long*/roll* speeds and accels, radius*, width*/height*, orgPos, deltaPos/deltaPos2/deltaPos3, segPos, rotAxis, transform/rotTransform, etc. Pure rename, codegen unchanged (221/221 functions with includers). 2026-10-29 15:58:02 +01:00
ragnarok-clanker
ddb1d0aeac Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h
Batch #2156 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_20016 CRagEffect::Aspersio: logic confirmed by peer review
- fn_20019 CRagEffect::Blessing: logic confirmed by peer review
- fn_20023 CRagEffect::Bottom: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:44:24 +00:00
ragnarok-clanker
b03935e409 Decompile 3 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h, ...
Batch #2139 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_20075 CRagEffect::InitEZ2STRFrame: logic confirmed by peer review
- fn_20095 CRagEffect::ProcessEZ2STR: logic confirmed by peer review
- fn_20326 CRagEffect::ShieldCharge: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:38:19 +00:00
ragnarok-clanker
1353b13bac Decompile 13 functions in Source/Contents/Effects/RagEffect.cpp, Source/Contents/Effects/RagEffect.h, ...
Batch #2136 by ragnarok-clanker: 0 byte-identical, 13 confirmed by peer review.

- fn_20040 CRagEffect::BloodDrain: logic confirmed by peer review
- fn_20046 CRagEffect::FireBall: logic confirmed by peer review
- fn_20054 CRagEffect::FrostDiver: logic confirmed by peer review
- fn_20058 CRagEffect::GrimTooth: logic confirmed by peer review
- fn_20066 CRagEffect::Hit4: logic confirmed by peer review
- fn_20106 CRagEffect::SoulStrike: logic confirmed by peer review
- fn_20107 CRagEffect::SpearBmr: logic confirmed by peer review
- fn_20109 CRagEffect::SprayPond: logic confirmed by peer review
- fn_20120 CRagEffect::WaterBall2: logic confirmed by peer review
- fn_20124 CRagEffect::Yufitel: logic confirmed by peer review
- fn_20132 CRagEffect::AirTexture: logic confirmed by peer review
- fn_20181 CRagEffect::EnergyDrain2: logic confirmed by peer review
- fn_21029 CGameObject::Get8Dir2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:02:25 +00:00
ragnarok-clanker
7f3b43c8ef Rename AttachedEffect -> CRagEffect (DHXJ), AttachedEffect.{h,cpp} -> RagEffect.{h,cpp}. Pure rename, codegen unchanged (129/129 functions identical with includers). 2026-10-29 12:19:20 +01:00
Renamed from Source/Contents/Effects/AttachedEffect.cpp (Browse further)