Commit graph

1,064 commits

Author SHA1 Message Date
ragnarok-clanker
0d6efeaf09 Maintenance: C7 (replaces 18431/18498/18559). Actor SendMsg takes (CGameObject* sender, std::int64_t message, std::int64_t b..g). Aud
Batch #18562 by ragnarok-clanker: forced by an admin (31 lower score(s), 132 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GameObject.h, Source/Contents/Actors/GndRiser.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/MousePointer.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObject.h, Source/Contents/Actors/Skill.h, Source/Contents/Effects/Core/DummyEffectLauncher.h, Source/Contents/Effects/Core/EffectActor.h, Source/Contents/Effects/Core/EffectMaker.h, Source/Contents/Effects/Core/MsgEffect.h, Source/Contents/Effects/Skills/ArrowEffect.h, Source/Contents/Effects/Skills/MandraAttackEffect.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/GraffiSkill.h, Source/Contents/Sound/SoundMaker.h.
2026-11-12 16:09:04 +00:00
ragnarok-clanker
81c97ebe42 Maintenance: Crash fix (replaces 18525/18545): UIWindow::DrawAuxiliary/DrawAuxiliaryScaled/DrawBitmapScaled (fn_16940/fn_16939/fn_169
Batch #18558 by ragnarok-clanker: forced by an admin (1 lower score(s), 14 changed function(s)); checked with 415 compiled unit(s), including every includer of Source/UI/Window/UIWindow.h, Source/UI/CashShop/UIPayConfirmWnd.h.
2026-11-12 16:01:41 +00:00
ragnarok-clanker
7a3f23c281 Decompile fn_17238 (UIWindowMgr::DrawWindows)
Batch #18546 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17238 UIWindowMgr::DrawWindows: logic confirmed by peer review

Peer-reviewed-by: alisonrag, kyoshi, bibinir
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-12 15:44:54 +00:00
ragnarok-clanker
96de096f68 Decompile fn_17208 (UIWindowMgr::CreateLayoutWindow)
Batch #18149 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17208 UIWindowMgr::CreateLayoutWindow: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, kyoshi, bibinir
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-12 15:30:44 +00:00
ragnarok-clanker
8d70f61abd Decompile fn_17127 (UIWindowMgr::RefreshFrameSkins)
Batch #18277 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17127 UIWindowMgr::RefreshFrameSkins: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, cremane, bibinir
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-12 14:00:28 +00:00
ragnarok-clanker
89a874690f Maintenance: Move mid-file forward declarations out of .cpp files into owning headers: CUIListBoxEx explicit-specialization declarati
Batch #18338 by ragnarok-clanker: no function's compiled code changes; checked with 433 compiled unit(s), including every includer of Source/Client/Application/ApplicationWindow.h, Source/Client/Mode/CGameMode.h, Source/Client/Session/Session.h, Source/Contents/Configuration/ServiceOptions.h, Source/Contents/Map/MapSkyMgr.h, Source/Contents/Messenger/ClientMessenger.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Sound/SoundConfiguration.h, Source/Render/DX7/RenderSystemDX7.h, Source/Render/Device/DisplayMode.h, Source/Resource/Json/JsonCppLoader.h, Source/Security/NProtectGameGuardMgr.h, Source/UI/Cooldowns/CooldownOwner.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/SelectPackageItemBox/SelectPackageItemBox.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/Text/TextWrapping.h, Source/Contents/Actors/Resources/BodyResources.h, Source/Resource/Json/JsonCppLoaderExternal.h, Source/Resource/Json/JsonCppLoaderParsing.h, Source/Security/NProtectGameMon.h.
2026-11-12 13:39:07 +00:00
ragnarok-clanker
b505fa1491 Maintenance: B4/C4: GetBodyImfName (fn_23381) and GetBodyActionResourceName (fn_23394) are CSession members: both end in ret 0x14 and
Batch #18317 by ragnarok-clanker: forced by an admin (7 lower score(s), 18 changed function(s)); checked with 288 compiled unit(s), including every includer of Source/Client/Session/Session.h, Source/Contents/Actors/Pc.h, Source/Contents/Sprites/SpriteRidingOffset.h.
2026-11-12 13:08:01 +00:00
ragnarok-clanker
7a7b3af63f Decompile fn_17199 (CUIRegisterMgr::IsRegistered)
Batch #18273 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_17199 CUIRegisterMgr::IsRegistered: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-12 12:25:04 +00:00
ragnarok-clanker
9af357fd13 Confirm fn_17215 (UIWindowMgr::UpdateFrameWindows)
Batch #18272 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_17215 UIWindowMgr::UpdateFrameWindows: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-12 12:23:58 +00:00
ragnarok-clanker
da97b80236 Maintenance: C9: the bitmap decoders and pixel helpers are CBitmapRes members in the original (they call Unload through the vtable at
Batch #18237 by ragnarok-clanker: forced by an admin (1 lower score(s), 14 changed function(s)); checked with 437 compiled unit(s), including every includer of Source/Resource/Bitmap/BitmapImage.h, Source/Resource/Bitmap/BitmapResource.h, Source/UI/Window/UIWindow.h.
2026-11-12 11:59:34 +00:00
ragnarok-clanker
aa749e13a4 Decompile fn_03583 (UIPrivateAirplaneWnd::OnCreate)
Batch #18158 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_03583 UIPrivateAirplaneWnd::OnCreate: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, bibinir
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-12 11:36:10 +00:00
ragnarok-clanker
38f040504e Maintenance: B4': DrawColoredText/DrawStyledColoredText/DrawOutlinedText/DrawOutlinedColoredText are UIWindow thiscall members in the
Batch #18182 by ragnarok-clanker: forced by an admin (6 lower score(s), 45 changed function(s)); checked with 415 compiled unit(s), including every includer of Source/UI/Text/ColoredText.h, Source/UI/Window/UIWindow.h.
2026-11-12 11:23:37 +00:00
ragnarok-clanker
c6dbc7b158 Decompile fn_12092 (UIEquipWnd::DrawDamageSkinPage)
Batch #18212 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_12092 UIEquipWnd::DrawDamageSkinPage: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, bibinir
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-12 11:00:16 +00:00
ragnarok-clanker
445f31a212 Maintenance: Signature fixes from the original: (C12) CRendererDX9::DrawDepthQueue takes (bool sort, vector& queue): original tests t
Batch #18147 by ragnarok-clanker: forced by an admin (7 lower score(s), 20 changed function(s)); checked with 122 compiled unit(s), including every includer of Source/Render/DX9/RendererDX9.h, Source/Render/DeviceContext/DCBitmap.h, Source/Render/DeviceContext/DCSurface.h, Source/Render/DeviceContext/DeviceContext.h.
2026-11-12 10:11:34 +00:00
ragnarok-clanker
5cad8ec14f Decompile fn_11779 (UIFrameWnd::OnLBtnDown)
Batch #18138 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_11779 UIFrameWnd::OnLBtnDown: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-12 10:01:56 +00:00
ragnarok-clanker
f545883c1a Decompile fn_17178 (UIWindowMgr::LoadUIRectInfo)
Batch #18120 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_17178 UIWindowMgr::LoadUIRectInfo: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-12 09:47:30 +00:00
ragnarok-clanker
9dc1aca0c7 Confirm fn_10908 (UIBitmapTab::SendMsg)
Batch #17827 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_10908 UIBitmapTab::SendMsg: logic confirmed by peer review (already on main)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-12 04:13:14 +00:00
ragnarok-clanker
31f4a72928 Confirm fn_14695 (CUITabButton::SetSelected)
Batch #17759 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_14695 CUITabButton::SetSelected: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-12 03:17:07 +00:00
ragnarok-clanker
6a3ec90f3f Decompile fn_14511 (CUITextViewer::AddLine)
Batch #17687 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_14511 CUITextViewer::AddLine: logic confirmed by peer review

Peer-reviewed-by: Yommy, cremane, bibinir
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-12 02:22:23 +00:00
ragnarok-clanker
69019e828a Decompile 8 functions in Source/Client/Mode/GameModePackets.cpp, Source/Client/Mode/GameMode.cpp, ...
Batch #17585 by KWDev: 8 byte-identical, 0 confirmed by peer review.

- fn_21866 CGameMode::ReceiveGuildBanList: byte-identical
- fn_21881 CGameMode::ReceiveGuildMemberList2: byte-identical
- fn_21970 CGameMode::ReceiveActorStatusValue: byte-identical
- fn_21424 CGameMode::SendNpcInputText: byte-identical
- fn_08344 CSkillAction_CD_DIVINUS_FLOS::OnSkillDamage: byte-identical
- fn_08362 CSkillAction_SHC_SHADOW_STAB::OnSkillDamage: byte-identical
- fn_14635 CUIControl::LoadBitmapResource: byte-identical
- fn_12720 UIShortCutWnd::OnProcess: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-12 01:02:04 +00:00
ragnarok-clanker
48f0d2ebbe Decompile fn_17244 (UIWindowMgr::SaveReplayWindows)
Batch #17458 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17244 UIWindowMgr::SaveReplayWindows: logic confirmed by peer review

Peer-reviewed-by: Yommy, cremane, bibinir
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 23:15:42 +00:00
ragnarok-clanker
a4f6285db0 Decompile 3 functions in Source/UI/Window/UIWindowMgr.cpp
Batch #17459 by eAthena: 2 byte-identical, 1 confirmed by peer review.

- fn_17122 UIWindowMgr::AddWhisperName: logic confirmed by peer review
- fn_17242 UIWindowMgr::SaveReplaySettings: byte-identical (already on main)
- fn_17243 UIWindowMgr::SaveReplayReserved: byte-identical (already on main)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 22:59:35 +00:00
ragnarok-clanker
9b8dbb21de Decompile 6 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindow.cpp, ...
Batch #17363 by eAthena: 0 byte-identical, 6 confirmed by peer review.

- fn_16944 UIWindow::FlushPrimitives: logic confirmed by peer review
- fn_20963 CooldownDrawing::SubmitNormal: logic confirmed by peer review
- fn_17238 UIWindowMgr::DrawWindows: logic confirmed by peer review
- fn_17223 UIWindowMgr::ProcessKeyDown: logic confirmed by peer review
- fn_17233 UIWindowMgr::Shutdown: logic confirmed by peer review
- fn_17234 UIWindowMgr::ClearMapWindows: logic confirmed by peer review

Peer-reviewed-by: alisonrag, SapitoSucio, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 22:07:32 +00:00
ragnarok-clanker
516a5dd68a Decompile 2 functions in Source/UI/Window/UIControl.cpp
Batch #17300 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_14686 CUITab::SelectPage: logic confirmed by peer review
- fn_14687 CUITab::SelectIndex: logic confirmed by peer review

Peer-reviewed-by: alisonrag, cremane, bibinir
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 21:46:48 +00:00
ragnarok-clanker
33c09d6fb3 Decompile fn_14565 (CUITextButton::OnMouseHover)
Batch #17301 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_14565 CUITextButton::OnMouseHover: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-11 20:42:29 +00:00
ragnarok-clanker
ba683b3b8d Maintenance: Linkage preludes, part 2 (resubmit of 17276): the 17 units whose explicit-template declarations name game types. Their e
Batch #17281 by ragnarok-clanker: no function's compiled code changes; checked with 17 compiled unit(s), including every includer of Source/Linkage/Source/Client/Browser/BrowserFactory.cpp.h, Source/Linkage/Source/Client/Browser/BrowserRegistry.cpp.h, Source/Linkage/Source/Client/Session/Session.cpp.h, Source/Linkage/Source/Contents/Actors/ActorNameCache.cpp.h, Source/Linkage/Source/Contents/Actors/ActorNameDirectory.cpp.h, Source/Linkage/Source/Contents/Actors/ActorNameRequests.cpp.h, Source/Linkage/Source/Contents/Actors/RenderObject.cpp.h, Source/Linkage/Source/Contents/AdventureGuide/AdventureGuideMgr.cpp.h, Source/Linkage/Source/Contents/Async/AsyncWorkRecycleObjectPoolMgr.cpp.h, Source/Linkage/Source/Contents/Items/ClientItemLists.cpp.h, Source/Linkage/Source/Contents/Messenger/ClientMessenger.cpp.h, Source/Linkage/Source/Contents/Skills/PlayerSkillBundle.cpp.h, Source/Linkage/Source/UI/AdventureGuide/UIAdventureGuide.cpp.h, Source/Linkage/Source/UI/Quest/UIRenewQuestUI.cpp.h, Source/Linkage/Source/UI/Quest/UIRenewQuestWnd.cpp.h, Source/Linkage/Source/UI/Window/UIWindowMgr.cpp.h, Source/Linkage/Source/UI/Window/WindowMgrState.cpp.h.
2026-11-11 20:19:09 +00:00
ragnarok-clanker
d7c1911fa6 Maintenance: Move explicit-template linkage declarations out of the game source. 105 units' extern template lines (and the std tree a
Batch #17237 by ragnarok-clanker: no function's compiled code changes; checked with 105 compiled unit(s), including every includer of Source/Linkage/Source/Client/Mode/LoginMode.cpp.h, Source/Linkage/Source/Client/Session/SessionAchievements.cpp.h, Source/Linkage/Source/Client/Session/SessionPredicates.cpp.h, Source/Linkage/Source/Client/Session/SessionState.cpp.h, Source/Linkage/Source/Contents/Achievement/AchievementMgr.cpp.h, Source/Linkage/Source/Contents/Actors/ActorPickNode.cpp.h, Source/Linkage/Source/Contents/Actors/MercenaryAI.cpp.h, Source/Linkage/Source/Contents/Actors/Resources/RobeResources.cpp.h, Source/Linkage/Source/Contents/CashEmotion/CashEmotionMgr.cpp.h, Source/Linkage/Source/Contents/Effects/EffectResourceSwitcher.cpp.h, Source/Linkage/Source/Contents/Effects/Particles/AnimatedEmitterEffect.cpp.h, Source/Linkage/Source/Contents/Effects/Particles/Particle.cpp.h, Source/Linkage/Source/Contents/Effects/Skills/MonsterSkillEffects.cpp.h, Source/Linkage/Source/Contents/Emblems/EmblemCache.cpp.h, Source/Linkage/Source/Contents/Emblems/EmblemDataDownloadAsyncWork.cpp.h, Source/Linkage/Source/Contents/Emblems/EmblemDataMgr.cpp.h, Source/Linkage/Source/Contents/Emblems/EmblemDataUploadAsyncWork.cpp.h, Source/Linkage/Source/Contents/Emblems/GuildEmblemLookup.cpp.h, Source/Linkage/Source/Contents/Hotkeys/EmotionHotkeys.cpp.h, Source/Linkage/Source/Contents/Items/ItemInfo.cpp.h, Source/Linkage/Source/Contents/Items/ItemNaming.cpp.h, Source/Linkage/Source/Contents/Map/PrivateAirplaneMgr.cpp.h, Source/Linkage/Source/Contents/Map/TownInfoMgr.cpp.h, Source/Linkage/Source/Contents/Messenger/MessengerMember.cpp.h, Source/Linkage/Source/Contents/Messenger/WhisperBlockMgr.cpp.h, Source/Linkage/Source/Contents/Models/ModelLighting.cpp.h, Source/Linkage/Source/Contents/Movies/BinkMovies.cpp.h, Source/Linkage/Source/Contents/Navigation/NavigationDestinations.cpp.h, Source/Linkage/Source/Contents/Navigation/NavigationRequest.cpp.h, Source/Linkage/Source/Contents/Navigation/NavigationRoute.cpp.h, Source/Linkage/Source/Contents/Party/AgencyRequests.cpp.h, Source/Linkage/Source/Contents/Party/LoadPartyInfoAsyncWork.cpp.h, Source/Linkage/Source/Contents/Party/LoadPartyListAsyncWork.cpp.h, Source/Linkage/Source/Contents/Party/RegisterPartyAsyncWork.cpp.h, Source/Linkage/Source/Contents/Repute/ReputeMgr.cpp.h, Source/Linkage/Source/Contents/Sound/SoundMgr.cpp.h, Source/Linkage/Source/Contents/Store/MCStoreInfoBackup.cpp.h, Source/Linkage/Source/Contents/Store/MCStoreInfoBackupAsyncWork.cpp.h, Source/Linkage/Source/Contents/Time/ClientTiming.cpp.h, Source/Linkage/Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.cpp.h, Source/Linkage/Source/Contents/UserData/AccountLinkedUserDataMgr.cpp.h, Source/Linkage/Source/Contents/UserData/AccountLinkedUserDataSaveAsyncWork.cpp.h, Source/Linkage/Source/Contents/UserData/CharacterConfigSave.cpp.h, Source/Linkage/Source/Contents/UserData/CharacterLinkedUserDataLoadAsyncWork.cpp.h, Source/Linkage/Source/Contents/UserData/CharacterLinkedUserDataSaveAsyncWork.cpp.h, Source/Linkage/Source/File/DirectoryRemoval.cpp.h, Source/Linkage/Source/Network/NIPAddr.cpp.h, Source/Linkage/Source/Network/Packets/ActorNamePacket.cpp.h, Source/Linkage/Source/Render/Device/RenderBackends.cpp.h, Source/Linkage/Source/Render/Primitives/ScreenLine.cpp.h, Source/Linkage/Source/Render/Text/EmbedFont.cpp.h, Source/Linkage/Source/Resource/Models/RmaResource.cpp.h, Source/Linkage/Source/Resource/ResourceFailures.cpp.h, Source/Linkage/Source/Script/LuaScript.cpp.h, Source/Linkage/Source/Security/NProtectGameGuardMgr.cpp.h, Source/Linkage/Source/UI/Acceptance/UIExchangeAcceptWnd.cpp.h, Source/Linkage/Source/UI/Achievement/UIAchWnd.cpp.h, Source/Linkage/Source/UI/Buttons/UINaviLinkButton.cpp.h, Source/Linkage/Source/UI/CashShop/UICashShopWnd.cpp.h, Source/Linkage/Source/UI/Chat/UIChatRoomTitle.cpp.h, Source/Linkage/Source/UI/Dialogs/UIMessageBox.cpp.h, Source/Linkage/Source/UI/Dialogs/UINoteWnd.cpp.h, Source/Linkage/Source/UI/Edit/UIEditCtrl3.cpp.h, Source/Linkage/Source/UI/Enchant/UIEnchantUI.cpp.h, Source/Linkage/Source/UI/EntryQueue/UIEntryQueueWnd.cpp.h, Source/Linkage/Source/UI/Events/UICheckAttendanceWnd.cpp.h, Source/Linkage/Source/UI/GameSettings/GameSettingsUI.cpp.h, Source/Linkage/Source/UI/GameSettings/UIHotkeyGuideWnd.cpp.h, Source/Linkage/Source/UI/Gauges/UIBarGraph.cpp.h, Source/Linkage/Source/UI/Guild/UIGuildHelperWnd.cpp.h, Source/Linkage/Source/UI/Items/UIEquipmentPropertiesWnd.cpp.h, Source/Linkage/Source/UI/Items/UIItemReformWnd.cpp.h, Source/Linkage/Source/UI/Items/UIItemStoreComboBox.cpp.h, Source/Linkage/Source/UI/Items/UILapineBoxWnd.cpp.h, Source/Linkage/Source/UI/Items/UIMakeTargetProcessWnd.cpp.h, Source/Linkage/Source/UI/Items/UIMerchantItemLogWnd.cpp.h, Source/Linkage/Source/UI/Items/UISwapEquipmentWnd.cpp.h, Source/Linkage/Source/UI/Lists/UIChatHisBox.cpp.h, Source/Linkage/Source/UI/Lists/UIComboBoxDefWnd.cpp.h, Source/Linkage/Source/UI/Login/UIPasswordWnd.cpp.h, Source/Linkage/Source/UI/Macro/UIMacroDetectorWnd.cpp.h, Source/Linkage/Source/UI/Navigation/NavigationLink.cpp.h, Source/Linkage/Source/UI/Party/UIApplyForPartyWnd.cpp.h, Source/Linkage/Source/UI/Party/UIRegisterPartyWnd.cpp.h, Source/Linkage/Source/UI/Party/UISeekPartyMBWnd.cpp.h, Source/Linkage/Source/UI/Quest/UIRecommendedQuestInfo.cpp.h, Source/Linkage/Source/UI/Repute/UIReputeWnd.cpp.h, Source/Linkage/Source/UI/Rodex/UIRodexComposeWnd.cpp.h, Source/Linkage/Source/UI/RuneSystem/UIRuneSystemWnd.cpp.h, Source/Linkage/Source/UI/Shop/UIMerchantShopTitle.cpp.h, Source/Linkage/Source/UI/Shortcuts/UIShortCutWnd.cpp.h, Source/Linkage/Source/UI/Skill/UIGraffiStrboxWnd.cpp.h, Source/Linkage/Source/UI/SkillDelayInfo/UISkillDelayInfo.cpp.h, Source/Linkage/Source/UI/Status/UIBasicInfoWnd.cpp.h, Source/Linkage/Source/UI/Text/ColoredText.cpp.h, Source/Linkage/Source/UI/Text/ItemLinkDisplay.cpp.h, Source/Linkage/Source/UI/Text/TextMarkup.cpp.h, Source/Linkage/Source/UI/Text/UITagTextViewer.cpp.h, Source/Linkage/Source/UI/Text/UITextViewer.cpp.h, Source/Linkage/Source/UI/Window/UIFrameWnd.cpp.h, Source/Linkage/Source/UI/Window/UIWindow.cpp.h, Source/Linkage/Source/UI/Window/UIWindowFactory.cpp.h, Source/Linkage/Source/UI/Window/WindowRegistration.cpp.h, Source/Linkage/Source/UI/Window/WindowRetirement.cpp.h, Source/Linkage/Source/Utility/Threading/NThread.cpp.h.
2026-11-11 16:21:46 +00:00
ragnarok-clanker
55d37a7071 Maintenance: Forced resubmit of 17189, rebased on 7ea84b3b3 (main had added 25 more copies of the same lines, now converted too). Sha
Batch #17225 by ragnarok-clanker: forced by an admin (0 lower score(s), 1 changed function(s)); checked with 75 compiled unit(s), including every includer of Source/Utility/StdIntVectorCopy.h, Source/Utility/StdStringConcat.h, Source/Utility/StdStringCopy.h, Source/Utility/StdStringInsert.h, Source/Utility/StdStringMoveAssign.h, Source/Utility/StdStringVectorDestroy.h, Source/Utility/StdTraitsEqual.h, Source/Utility/StdTraitsFind.h, Source/Utility/StdWindowListEmplace.h.
2026-11-11 15:11:07 +00:00
ragnarok-clanker
7ea84b3b37 Confirm 5 functions in Source/Contents/Actors/ActorPickNode.cpp, Source/Contents/Emblems/EmblemDataUploadAsyncWork.cpp, ...
Batch #17208 by eAthena: 4 byte-identical, 1 confirmed by peer review.

- fn_03631 UINavigationV4Wnd::LoadRoute: byte-identical (already on main)
- fn_10693 UIEditCtrl3::~UIEditCtrl3: byte-identical (already on main)
- fn_10715 UIEditCtrl3::`scalar deleting destructor': byte-identical (already on main)
- fn_16930 UIWindow::CreateItemTagButton: logic confirmed by peer review (already on main)
- fn_21631 CGameMode::ReceivePlayerNameUpdate: byte-identical (already on main)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 14:52:37 +00:00
ragnarok-clanker
79dbba9406 Decompile 4 functions in Source/UI/Window/UIWindow.cpp
Batch #17107 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_16931 UIWindow::Update: logic confirmed by peer review
- fn_17023 UIWindow::DrawFormattedText: logic confirmed by peer review
- fn_16976 UIWindow::FormattedTextWidth: logic confirmed by peer review
- fn_03636 UINavigationV4Wnd::InsertNavigationLink: logic confirmed by peer review

Peer-reviewed-by: alisonrag, Toshiro, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 14:01:31 +00:00
ragnarok-clanker
092f50b745 Decompile 2 functions in Source/Client/Browser/BrowserRegistry.cpp, Source/Client/Browser/BrowserCreation.cpp, ...
Batch #17077 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17138 UIWindowMgr::EnsureSpecialBrowser: logic confirmed by peer review (already on main)
- fn_17413 CWebBrowser::Create: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 13:45:58 +00:00
ragnarok-clanker
62bb9eddd8 Decompile fn_17218 (UIWindowMgr::ShowWaitDBSaveWindow)
Batch #16919 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17218 UIWindowMgr::ShowWaitDBSaveWindow: logic confirmed by peer review

Peer-reviewed-by: Yommy, Toshiro, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 13:37:37 +00:00
ragnarok-clanker
fca27cc545 Decompile 18 functions in Source/UI/Window/UIControl.h, Source/UI/Window/UIControl.cpp, ...
Batch #17060 by eAthena: 12 byte-identical, 6 confirmed by peer review.

- fn_14418 CUIDropDownBox::HasOwnerChild: byte-identical
- fn_45427 CUIDropDownBox::~CUIDropDownBox: byte-identical (already on main)
- fn_14773 CUIListBoxEx<EnchantUI::CUIEnchantItem,EnchantUI::CEnchantItemData>::~CUIListBoxEx<EnchantUI::CUIEnchantItem,EnchantUI::CEnchantItemData>: byte-identical (already on main)
- fn_14774 CUIListBoxEx<EnchantUI::CUITargetItem,ITEM_INFO>::~CUIListBoxEx<EnchantUI::CUITargetItem,ITEM_INFO>: byte-identical (already on main)
- fn_15026 CUIListBoxEx<EquipmentPropertiesWnd::CUIItemEquipmentPropertiesLine,std::basic_string<char,std::char_traits<char>,std::allocator<char> > >::~CUIListBoxEx<EquipmentPropertiesWnd::CUIItemEquipmentPropertiesLine,std::basic_string<char,std::char_traits<char>,std::allocator<char> > >: byte-identical (already on main)
- fn_15181 CUIListBoxEx<ExchangeUI::CUIItem,ExchangeUI::CItemData>::~CUIListBoxEx<ExchangeUI::CUIItem,ExchangeUI::CItemData>: logic confirmed by peer review (already on main)
- fn_15348 CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderAdapter>::~CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderAdapter>: logic confirmed by peer review (already on main)
- fn_15349 CUIListBoxEx<GameSettingsUI::CUIComboItem,DisplayMode>::~CUIListBoxEx<GameSettingsUI::CUIComboItem,DisplayMode>: logic confirmed by peer review (already on main)
- fn_15350 CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderBackend>::~CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderBackend>: logic confirmed by peer review (already on main)
- fn_15351 CUIListBoxEx<GameSettingsUI::CUIComboItem,std::basic_string<char,std::char_traits<char>,std::allocator<char> > >::~CUIListBoxEx<GameSettingsUI::CUIComboItem,std::basic_string<char,std::char_traits<char>,std::allocator<char> > >: byte-identical (already on main)
- fn_15352 CUIListBoxEx<GameSettingsUI::CUIOptionItem,TALKTYPE>::~CUIListBoxEx<GameSettingsUI::CUIOptionItem,TALKTYPE>: byte-identical (already on main)
- fn_16109 CUIListBoxEx<ProbabilityTable::CUIItem,ProbabilityTable::CItemData>::~CUIListBoxEx<ProbabilityTable::CUIItem,ProbabilityTable::CItemData>: byte-identical (already on main)
- fn_16218 CUIListBoxEx<OngoingQuestInfo::CUIRewardItem,OngoingQuestInfo::CRewardItemData>::~CUIListBoxEx<OngoingQuestInfo::CUIRewardItem,OngoingQuestInfo::CRewardItemData>: byte-identical (already on main)
- fn_16368 CUIListBoxEx<RenewQuestUI::CUIQuestItem,unsigned long>::~CUIListBoxEx<RenewQuestUI::CUIQuestItem,unsigned long>: byte-identical (already on main)
- fn_16648 CUIListBoxEx<SelectPackageItemBox::CUIItemInfo,ITEM_INFO>::~CUIListBoxEx<SelectPackageItemBox::CUIItemInfo,ITEM_INFO>: logic confirmed by peer review (already on main)
- fn_16649 CUIListBoxEx<SelectPackageItemBox::CUITabInfo,SelectPackageItemBox::CTabInfoData>::~CUIListBoxEx<SelectPackageItemBox::CUITabInfo,SelectPackageItemBox::CTabInfoData>: logic confirmed by peer review (already on main)
- fn_16800 CUIListBoxEx<SkillDelayInfo::CUIDelayItem,SkillDelayInfo::CDelayItemData>::~CUIListBoxEx<SkillDelayInfo::CUIDelayItem,SkillDelayInfo::CDelayItemData>: byte-identical (already on main)
- fn_16877 SkillDelayInfo::CUITime::`scalar deleting destructor': byte-identical (already on main)

Peer-reviewed-by: Yommy, Toshiro, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 13:29:14 +00:00
ragnarok-clanker
e3d10246b8 Decompile fn_16918 (RunWindowAction)
Batch #16894 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_16918 RunWindowAction: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 13:12:38 +00:00
ragnarok-clanker
8dafe9aa8a Decompile 2 functions in Source/UI/Window/UIWindow.cpp
Batch #16645 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_16977 UIWindow::FitDisplayText: logic confirmed by peer review
- fn_03626 UINavigationV4Wnd::SendMsg: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 13:12:11 +00:00
ragnarok-clanker
dfa456d091 Decompile fn_04314 (UIReputeWnd::Paint)
Batch #17054 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_04314 UIReputeWnd::Paint: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 13:04:28 +00:00
ragnarok-clanker
40b3896339 Decompile 2 functions in Source/UI/Window/UIWindow.cpp
Batch #17033 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_03628 UIPrivateAirplaneWnd::SendMsg: logic confirmed by peer review
- fn_16931 UIWindow::Update: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 12:56:32 +00:00
ragnarok-clanker
a78ce8f5f6 Decompile 2 functions in Source/UI/Window/UIControl.cpp
Batch #16841 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_14411 CUICheckBox::Paint: logic confirmed by peer review
- fn_14665 CUIStaticImage::Paint: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 12:53:00 +00:00
ragnarok-clanker
7b5f29a7ef Decompile 10 functions in Source/UI/GameSettings/UIHotKeyWnd.cpp, Source/UI/Items/UIMerchantItemLogWnd.cpp, ...
Batch #16976 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_12740 UIHotKeyWnd::SaveHotkeys: byte-identical
- fn_13575 UIMerchantItemLogWnd::OnCreate: byte-identical
- fn_13578 UIMerchantItemLogWnd::OnProcess: byte-identical
- fn_09912 UIRefining_Notice::Paint: byte-identical
- fn_11504 UIWindow::WrapLinkText: byte-identical
- fn_09228 UIAchListWnd::OnLBtnDown: byte-identical
- fn_16914 UIWindow::UIWindow: byte-identical
- fn_12099 UIWindow::DrawTitleBarAt: byte-identical
- fn_07560 NAsyncWorkPtr::NAsyncWorkPtr: byte-identical
- fn_10163 UIRuneSetinfoList::AddLine: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-11 12:05:23 +00:00
ragnarok-clanker
c68d9942bf Confirm fn_17142 (UIWindowMgr::UnregisterNamedWindow)
Batch #16960 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_17142 UIWindowMgr::UnregisterNamedWindow: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-11 11:49:45 +00:00
ragnarok-clanker
e4c5a4db7b Decompile 4 functions in Source/UI/Window/UIWindowMgr.cpp
Batch #16764 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_17121 UIWindowMgr::SelectWhisperName: logic confirmed by peer review
- fn_17122 UIWindowMgr::AddWhisperName: logic confirmed by peer review
- fn_17123 UIWindowMgr::ShowWhisperFrom: logic confirmed by peer review
- fn_17253 UIWindowMgr::SendNotice: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 11:29:53 +00:00
ragnarok-clanker
c36e5b3fd6 Decompile 2 functions in Source/UI/Window/UIControl.cpp, Source/UI/Text/UIStaticTextControl.h, ...
Batch #16725 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17140 UIWindowMgr::RemoveSnapRectangle: logic confirmed by peer review
- fn_17233 UIWindowMgr::Shutdown: logic confirmed by peer review (already on main)

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 11:29:01 +00:00
ragnarok-clanker
440e355638 Decompile 2 functions in Source/UI/Window/WindowMgrState.cpp
Batch #16921 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17149 UIWindowMgr::DropAt: logic confirmed by peer review
- fn_17151 UIWindowMgr::RunEmailAddress: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 11:23:03 +00:00
ragnarok-clanker
ce46f3fe5d Decompile fn_17249 (UIWindowMgr::LoadReplayWindows)
Batch #16920 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17249 UIWindowMgr::LoadReplayWindows: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 11:22:27 +00:00
ragnarok-clanker
b9dd4b9683 Decompile fn_16914 (UIWindow::UIWindow)
Batch #16896 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_16914 UIWindow::UIWindow: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 10:59:10 +00:00
ragnarok-clanker
3622fb42e3 Decompile fn_15305 (CUIExchangeUI::BindItem)
Batch #16871 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_15305 CUIExchangeUI::BindItem: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-11 10:31:08 +00:00
ragnarok-clanker
00d04deb32 Decompile 13 functions in Source/UI/Window/UIControl.cpp
Batch #16843 by eAthena: 12 byte-identical, 1 confirmed by peer review.

- fn_14506 CUIResizer::OnMouseMove: logic confirmed by peer review
- fn_14566 CUITextButton::UpdateText: byte-identical
- fn_14597 CUIHScrollBar::Paint: byte-identical
- fn_14598 CUIHThumb::Paint: byte-identical
- fn_14604 CUIHScrollBar::UpdateThumb: byte-identical
- fn_14649 CUIImageButton::Paint: byte-identical
- fn_14671 CUIStaticText::UpdateText: byte-identical
- fn_14689 CUITabButton::Paint: byte-identical
- fn_14705 CUIVScrollBar::PositionFromOffset: byte-identical
- fn_14707 CUIVScrollBar::Paint: byte-identical
- fn_14708 CUIVThumb::Paint: byte-identical
- fn_14717 CUIVScrollBar::UpdateThumb: byte-identical
- fn_14489 CUIImageTextButton::Paint: byte-identical

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 09:45:27 +00:00
ragnarok-clanker
7f29c2dc3c Decompile fn_03589 (UINavigationroadiconWnd::Paint)
Batch #16779 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_03589 UINavigationroadiconWnd::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-11 08:54:44 +00:00
ragnarok-clanker
531b9bd16b Decompile 2 functions in Source/UI/Window/WindowMgrState.cpp
Batch #16777 by eAthena: 2 byte-identical, 0 confirmed by peer review.

- fn_17173 UIWindowMgr::RestoreHiddenWindows: byte-identical
- fn_17275 UIWindowMgr::ConfirmActiveDialog: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-11 08:48:06 +00:00
ragnarok-clanker
9987352c0f Confirm fn_12079 (UIFrameWnd::AddNumberedButton)
Batch #16752 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_12079 UIFrameWnd::AddNumberedButton: logic confirmed by peer review (already on main)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 08:08:10 +00:00