Commit graph

12 commits

Author SHA1 Message Date
ragnarok-clanker
7ea84b3b37 Confirm 5 functions in Source/Contents/Actors/ActorPickNode.cpp, Source/Contents/Emblems/EmblemDataUploadAsyncWork.cpp, ...
Batch #17208 by eAthena: 4 byte-identical, 1 confirmed by peer review.

- fn_03631 UINavigationV4Wnd::LoadRoute: byte-identical (already on main)
- fn_10693 UIEditCtrl3::~UIEditCtrl3: byte-identical (already on main)
- fn_10715 UIEditCtrl3::`scalar deleting destructor': byte-identical (already on main)
- fn_16930 UIWindow::CreateItemTagButton: logic confirmed by peer review (already on main)
- fn_21631 CGameMode::ReceivePlayerNameUpdate: byte-identical (already on main)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-11 14:52:37 +00:00
ragnarok-clanker
d074dedcd7 Maintenance: Centralize EncryptedName: delete 44 per-unit copies (incl. GameModeEncryptedName) and 4 EncryptedSource copies; units in
Batch #16852 by ragnarok-clanker: no function's compiled code changes; checked with 44 compiled unit(s), including every includer of Source/Utility/Cipher/LocalEncryptedName.h.
2026-11-11 10:05:15 +00:00
ragnarok-clanker
1bd6fae74a Decompile fn_03954 (CCURLMgr::FromUtf8)
Batch #16496 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_03954 CCURLMgr::FromUtf8: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 20:22:33 +00:00
ragnarok-clanker
5ad8e0c58c Maintenance: Resubmission of 16340 over main 047268c0 (conflict in UICashEmotionPack::GetPriceText resolved keeping main's new body).
Batch #16351 by ragnarok-clanker: no function's compiled code changes; checked with 784 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Browser/BrowserCommandTarget.h, Source/Client/Browser/BrowserDocumentUI.h, Source/Client/Browser/BrowserInPlace.h, Source/Client/Browser/WebBrowser.h, Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/Client/Input/Mouse.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StovePCSDK.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GndRiser.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/MousePointer.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClanInfo.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/ArrowEffect.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/DummyEffectLauncher.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/EffectTypes.h, Source/Contents/Effects/ElectricEffect.h, Source/Contents/Effects/EmitterEffect.h, Source/Contents/Effects/FortuneKissEffect.h, Source/Contents/Effects/MagicFloorEffect.h, Source/Contents/Effects/MandraAttackEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RichManKim.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StarEffect.h, Source/Contents/Effects/WhirlwindEffect.h, Source/Contents/EnchantMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/GuildInfo.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemInfo.h, Source/Contents/Items/RuneSystem.h, Source/Contents/MapSkyMgr.h, Source/Contents/Models/ModelActor.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/NavigationManager.h, Source/Contents/Party/PartyBookingMgr.h, Source/Contents/PetEvolutionMgr.h, Source/Contents/RenewQuestMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/Schedule/Schedule.h, Source/Contents/Schedule/ShutDownSchedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/Store/MCStoreInfoBackupAsyncWork.h, Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/WorldView/WorldViewData.h, Source/Network/Connection/Connection.h, Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/DirectDrawEnumeration.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/RendererDX7.h, Source/Render/Text/EmbedFont.h, Source/Render/Text/TextContext.h, Source/Render/Textures/Texture.h, Source/Resource/BinkRuntime.h, Source/Resource/GifResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelMesh.h, Source/Resource/ResourceMgr.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Security/NProtectGameGuardMgr.h, Source/Security/ReassemblyPacketMgr.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Dialogs/UILoadingWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/TableBox.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Lists/UIVScrollBar.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIRequestJoinPartyWnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/TextMarkup.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewer.h, Source/UI/Text/UITransBalloonText.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowId.h, Source/Utility/Async/NAsyncWork.h, Source/Utility/Async/NRecycleObjectPoolMgr.h, Source/Utility/JsonCppLoader.h, Source/Utility/Lexicon/LexiconSerializer.h, Source/Utility/NFileLog.h, Source/Utility/Threading/NThread.h.
2026-11-10 17:38:25 +00:00
ragnarok-clanker
027464186b Decompile fn_03982 (CEmblemDataUploadAsyncWork::Complete)
Batch #15197 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03982 CEmblemDataUploadAsyncWork::Complete: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 20:56:27 +00:00
ragnarok-clanker
1d1a0b4863 Decompile 2 functions in Source/Contents/Emblems/EmblemDataUploadAsyncWork.cpp
Batch #15296 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_03978 CEmblemDataUploadAsyncWork::CEmblemDataUploadAsyncWork: logic confirmed by peer review
- fn_03980 CEmblemDataUploadAsyncWork::Bind: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 20:36:26 +00:00
ragnarok-clanker
e79bbfcda9 Confirm 14 functions in Source/Utility/Async/NRecycleObject.h, Source/Contents/Async/AsyncWorkRecycleObjectPoolMgr.cpp, ...
Batch #14814 by kyoshi: 0 byte-identical, 14 confirmed by peer review.

- fn_02567 NRecycleObjectPool<CAccountLinkedUserDataLoadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02568 NRecycleObjectPool<CLoadPartyInfoAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02569 NRecycleObjectPool<CChangePartyMasterAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02570 NRecycleObjectPool<CStopRecruitingAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02571 NRecycleObjectPool<CRegisterPartyAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02572 NRecycleObjectPool<CLoadMyPartyAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02573 NRecycleObjectPool<CLoadPartyListAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02574 NRecycleObjectPool<CMCStoreInfoBackupSaveAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02575 NRecycleObjectPool<CMCStoreInfoBackupLoadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02576 NRecycleObjectPool<CEmblemDataDownloadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02577 NRecycleObjectPool<CEmblemDataUploadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02578 NRecycleObjectPool<CCharacterLinkedUserDataSaveAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02579 NRecycleObjectPool<CCharacterLinkedUserDataLoadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02580 NRecycleObjectPool<CAccountLinkedUserDataSaveAsyncWork>::Release: logic confirmed by peer review (already on main)

Peer-reviewed-by: secret, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 18:59:06 +00:00
ragnarok-clanker
b2ef8994d3 Decompile 3 functions in Source/Contents/Emblems/EmblemDataUploadAsyncWork.cpp
Batch #10607 by cremane: 0 byte-identical, 3 confirmed by peer review.

- fn_03978 CEmblemDataUploadAsyncWork::CEmblemDataUploadAsyncWork: logic confirmed by peer review
- fn_03980 CEmblemDataUploadAsyncWork::Bind: logic confirmed by peer review
- fn_03983 CEmblemDataUploadAsyncWork::Execute: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Lumen, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 17:27:24 +00:00
ragnarok-clanker
645ac9c6ec Decompile 9 functions in Source/Contents/Async/AsyncWorkMgr.cpp, Source/Contents/Async/AsyncWorkMgr.h, ...
Batch #10030 by ragnarok-clanker: 0 byte-identical, 9 confirmed by peer review.

- fn_13127 UIGuildInfoManageWnd::SendMsg: logic confirmed by peer review
- fn_02505 CAsyncWorkMgr::UploadEmblem: logic confirmed by peer review
- fn_03973 CEmblemDataMgr::Upload: logic confirmed by peer review
- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
- fn_03978 CEmblemDataUploadAsyncWork::CEmblemDataUploadAsyncWork: logic confirmed by peer review
- fn_03980 CEmblemDataUploadAsyncWork::Bind: logic confirmed by peer review
- fn_03982 CEmblemDataUploadAsyncWork::Complete: logic confirmed by peer review
- fn_13059 UIGuildInfoManageWnd::Slot15: logic confirmed by peer review (already on main)
- fn_13137 UIGuildWnd::StripNamelessTag: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-11-02 14:36:35 +00:00
ragnarok-clanker
7a679497ea 📚 docs(RagEffectState): corrected field offset comments 2026-10-28 18:12:16 +01:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
Renamed from Source/Contents/EmblemDataUploadAsyncWork.cpp (Browse further)