Batch #10607 by cremane: 0 byte-identical, 3 confirmed by peer review.
- fn_03978 CEmblemDataUploadAsyncWork::CEmblemDataUploadAsyncWork: logic confirmed by peer review
- fn_03980 CEmblemDataUploadAsyncWork::Bind: logic confirmed by peer review
- fn_03983 CEmblemDataUploadAsyncWork::Execute: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Lumen, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10791 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_05178 CGuildMgr::EmblemFilename: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10789 by kyoshi: 1 byte-identical, 0 confirmed by peer review.
- fn_18783 EffectLists::Find: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10566 by cremane: 0 byte-identical, 3 confirmed by peer review.
- fn_03704 CRegisterPartyAsyncWork::CRegisterPartyAsyncWork: logic confirmed by peer review
- fn_03706 CRegisterPartyAsyncWork::Bind: logic confirmed by peer review
- fn_03709 CRegisterPartyAsyncWork::Execute: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10516 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_24366 sub_E59030: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10548 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_04287 CReputeMgr::InfoInserter::operator(): logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10770 by dori: 0 byte-identical, 2 confirmed by peer review.
- fn_19562 CNavigationManager::AddState: logic confirmed by peer review (already on main)
- fn_19568 CNavigationManager::WriteTarget: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10645 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_19620 CNavigationManager::UpdateSearchResults: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10753 by kyoshi: 0 byte-identical, 2 confirmed by peer review.
- fn_23342 CSession::RemoveItem1750: logic confirmed by peer review
- fn_23348 CSession::RemoveItem1720: logic confirmed by peer review
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10744 by kyoshi: 2 byte-identical, 0 confirmed by peer review.
- fn_21024 CGameActor::ClearUnknown037C: byte-identical
- fn_21126 CRenderObject::DrawTintedQuad: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10743 by kyoshi: 1 byte-identical, 0 confirmed by peer review.
- fn_19434 CNaviInfo::HasName: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10526 by Toshiro: 0 byte-identical, 2 confirmed by peer review.
- fn_19801 CEffectPrim::PrimAuraGlow: logic confirmed by peer review
- fn_19812 CEffectPrim::PrimGrowFollow: logic confirmed by peer review
Peer-reviewed-by: Lumen, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10723 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_06574 FindItemCardName: logic confirmed by peer review (already on main)
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10721 by cremane: 2 byte-identical, 0 confirmed by peer review.
- fn_23853 CSession::IsBabyJob: byte-identical
- fn_23873 CSession::IsMercenaryJob: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10718 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_03683 CChangePartyMasterAsyncWork::Execute: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10625 by cremane: 0 byte-identical, 3 confirmed by peer review.
- fn_03916 CCharacterLinkedUserDataLoadAsyncWork::CCharacterLinkedUserDataLoadAsyncWork: logic confirmed by peer review
- fn_03918 CCharacterLinkedUserDataLoadAsyncWork::Bind: logic confirmed by peer review
- fn_03921 CCharacterLinkedUserDataLoadAsyncWork::Execute: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10629 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_03934 CCharacterLinkedUserDataMgr::Reset: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10637 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_23887 CSession::IsPlayerJobId: logic confirmed by peer review (already on main)
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10617 by kyoshi: 0 byte-identical, 3 confirmed by peer review.
- fn_18376 LookupMessage: logic confirmed by peer review (already on main)
- fn_18374 ImportMessageTable: logic confirmed by peer review (already on main)
- fn_18377 GetMessageString: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10695 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_17487 C3dActor::MarkOccluded: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10686 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_19983 CEffectPrim::RenderFanWedge: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10682 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_03968 CEmblemDataDownloadAsyncWork::Execute: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10597 by cremane: 0 byte-identical, 6 confirmed by peer review.
- fn_04241 CMCStoreInfoBackupLoadAsyncWork::CMCStoreInfoBackupLoadAsyncWork: logic confirmed by peer review
- fn_04243 CMCStoreInfoBackupLoadAsyncWork::Bind: logic confirmed by peer review
- fn_04246 CMCStoreInfoBackupLoadAsyncWork::Execute: logic confirmed by peer review
- fn_04247 CMCStoreInfoBackupSaveAsyncWork::CMCStoreInfoBackupSaveAsyncWork: logic confirmed by peer review
- fn_04249 CMCStoreInfoBackupSaveAsyncWork::Bind: logic confirmed by peer review
- fn_04252 CMCStoreInfoBackupSaveAsyncWork::Execute: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10517 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_21038 CRenderObject::ScaleByFadePulse: logic confirmed by peer review
Peer-reviewed-by: Toshiro, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10670 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.
- fn_01695 ServerTimeManager::Reset: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #10668 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_22608 CPc::Slot33: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, kyoshi, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10660 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_17604 GroundGeometry::DrawTerrainOverlay: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10659 by dori: 0 byte-identical, 2 confirmed by peer review.
- fn_17589 GroundGeometry::DrawGridDecal: logic confirmed by peer review
- fn_17587 GroundGeometry::DrawGrid: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10536 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_03697 CLoadPartyInfoAsyncWork::Execute: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10626 by cremane: 0 byte-identical, 3 confirmed by peer review.
- fn_03944 CCharacterLinkedUserDataSaveAsyncWork::CCharacterLinkedUserDataSaveAsyncWork: logic confirmed by peer review
- fn_03946 CCharacterLinkedUserDataSaveAsyncWork::Bind: logic confirmed by peer review
- fn_03949 CCharacterLinkedUserDataSaveAsyncWork::Execute: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Lumen, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10646 by dori: 0 byte-identical, 2 confirmed by peer review.
- fn_17593 GroundGeometry::DrawSide: logic confirmed by peer review
- fn_17590 GroundGeometry::Draw: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10636 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.
- fn_03042 CGameActor::Slot62: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #10631 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.
- fn_19191 CSphereWindEffect::Slot03: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #10615 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_04357 CWorldViewWorld::MapAt: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, kyoshi, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10619 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_04378 CWorldViewMgr::SelectField: logic confirmed by peer review (already on main)
Peer-reviewed-by: ragnarok-clanker, kyoshi, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10586 by dori: 1 byte-identical, 0 confirmed by peer review.
- fn_04354 CWorldViewWorld::FindField: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #10582 by dori: 1 byte-identical, 0 confirmed by peer review.
- fn_04379 CWorldViewMgr::Draw: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #10453 by Toshiro: 0 byte-identical, 1 confirmed by peer review.
- fn_17207 UIWindowMgr::sub_A978D0: logic confirmed by peer review
Peer-reviewed-by: secret, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10444 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_21595 CGameMode::sub_D08910: logic confirmed by peer review
Peer-reviewed-by: secret, willerthal, KWDev, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10450 by KWDev: 0 byte-identical, 1 confirmed by peer review.
- fn_45492 CSkillAction_WH_CRESCIVE_BOLT::Slot15: logic confirmed by peer review
Peer-reviewed-by: vinnyamancio, Toshiro, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10429 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_22666 CPlayer::OnProcess: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Yommy, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10430 by ragnarok-clanker: no function's compiled code changes; checked with 530 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/RenderObject.h, Source/Contents/ClientState.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Messenger/MessengerMember.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/UIBartermarketWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindowMgr.h.
Batch #10414 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10400 by ragnarok-clanker: no function's compiled code changes; checked with 13 compiled unit(s), including every includer of Source/UI/Window/UINavigationWnd.h.
Batch #10396 by ragnarok-clanker: no function's compiled code changes; checked with 190 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h.
Merged directly by the admin, bypassing peer review, because part of the
original function was overwritten by the client's protector and can never
match. Task 16009 is marked done on purpose; do not resubmit it.
- Jump table 0xAD29E4: modes 0/1 go to 0xAD1E58, now "jmp 0x027AB0FE" into
an empty protector stub. Bytes 0xAD1E58..0xAD237D are garbage.
- The rest of case 0/1 survives from 0xAD237E (g_serviceFlag07 = 29,
strstr(g_launchServerName, "QmSakray"), key/address pair, StringFormat
into g_serviceAddress, then the admin/monster-job tail); ported as is.
- Live WinDbg run (servertype=primary): 0xAD1C90 is never called; the
protector loader in .data6 (sub_3DE8027) replaces it at runtime.
- Based on attempt 57915 (batch 10359), with g_session.unknown_58FA replaced
by g_launchServerName (same address, 0x1737F32). Key/string decryption
verified against the binary. td check --includers: no errors.
Batch #10394 by ragnarok-clanker: no function's compiled code changes; checked with 8 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10392 by ragnarok-clanker: no function's compiled code changes; checked with 8 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10391 by ragnarok-clanker: no function's compiled code changes; checked with 8 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
