clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
610 commits 1 branch 0 tags 7.8 MiB
Commit graph

40 commits

Author SHA1 Message Date
ragnarok-clanker
b7fce8bdd9 Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h 
Batch #1992 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_19966 EffectParticle::FollowMasterAndAdvance: byte-identical
- fn_19952 EffectParticle::FollowMasterAndTickSlots: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 00:59:59 +00:00
ragnarok-clanker
97cf23ebda Decompile 4 functions in Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/RenderObjectState.cpp, ... 
Batch #1949 by ragnarok-clanker: 1 byte-identical, 3 confirmed by peer review.

- fn_21086 RenderObjectState::Reset: logic confirmed by peer review
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_20088 UpdatePartyEffect: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 00:03:44 +00:00
ragnarok-clanker
a591f8908d Decompile 6 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ... 
Batch #1876 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_19844 EffectParticle::PrimThrowItem: logic confirmed by peer review (annotation added to existing code)
- fn_19822 EffectParticle::PrimPeong: logic confirmed by peer review (annotation added to existing code)
- fn_19810 EffectParticle::PrimGI3: logic confirmed by peer review (annotation added to existing code)
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review (already on main)
- fn_04106 ItemInfo::GetItemId: logic confirmed by peer review (annotation added to existing code)
- fn_12589 ShortcutDrop::Drop: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-28 23:10:29 +00:00
ragnarok-clanker
81e812ea39 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ... 
Batch #1869 by ragnarok-clanker: 3 byte-identical, 0 confirmed by peer review.

- fn_19971 EffectParticle::PrimWaterFall: byte-identical
- fn_21090 CGameActor::ProcessBodyState: byte-identical
- fn_12629 UIShortCutWnd::Slot03: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
 2026-10-28 23:05:45 +00:00
ragnarok-clanker
2e808aaa74 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ... 
Batch #1853 by ragnarok-clanker: 1 byte-identical, 2 confirmed by peer review.

- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:53:38 +00:00
ragnarok-clanker
6f1a245675 Decompile 7 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ... 
Batch #1846 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_19830 EffectParticle::PrimSMA: logic confirmed by peer review (annotation added to existing code)
- fn_19790 EffectParticle::PrimBottom2: logic confirmed by peer review (already on main)
- fn_19791 EffectParticle::PrimBottom: logic confirmed by peer review (already on main)
- fn_02021 CreateTrigonometricTable: logic confirmed by peer review (already on main)
- fn_02023 ClientCosine: logic confirmed by peer review (already on main)
- fn_02025 ClientSine: logic confirmed by peer review (already on main)
- fn_19818 EffectParticle::PrimLineLink: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 22:52:17 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ... 
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:49:51 +00:00
ragnarok-clanker
716701c6ab Decompile fn_18985 (CEffect::RetireIfInactive) 
Batch #1827 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_18985 CEffect::RetireIfInactive: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:43:36 +00:00
ragnarok-clanker
16fade7361 Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ... 
Batch #1792 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_19796 EffectParticle::PrimChemical3: logic confirmed by peer review
- fn_19824 EffectParticle::PrimPoison: logic confirmed by peer review
- fn_19813 EffectParticle::PrimGuard: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 22:39:29 +00:00
ragnarok-clanker
6d568f53db Decompile 6 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/EffectLists.h, ... 
Batch #1818 by Yommy: 0 byte-identical, 6 confirmed by peer review.

- fn_18772 EffectLists::RetireActor: logic confirmed by peer review
- fn_18777 EffectLists::Retire: logic confirmed by peer review
- fn_18778 EffectLists::Retire: logic confirmed by peer review
- fn_18779 EffectLists::Retire: logic confirmed by peer review
- fn_18780 EffectLists::Clear: logic confirmed by peer review
- fn_18781 EffectLists::Release: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:37:37 +00:00
ragnarok-clanker
805cf67f82 Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ... 
Batch #1793 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_19800 EffectParticle::PrimEffectTexture2: logic confirmed by peer review
- fn_19802 EffectParticle::PrimEffectTexture_Ani: logic confirmed by peer review
- fn_19805 EffectParticle::PrimFirstAid: logic confirmed by peer review
- fn_19816 EffectParticle::PrimIntimidate: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:21:46 +00:00
ragnarok-clanker
73e944dded Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h 
Batch #1789 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19795 EffectParticle::PrimChemical2: logic confirmed by peer review
- fn_19797 EffectParticle::PrimChemical: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 22:19:15 +00:00
ragnarok-clanker
43198220b9 Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h 
Batch #1770 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19792 EffectParticle::PrimBottomOut: logic confirmed by peer review
- fn_19793 EffectParticle::PrimBubbleDrop: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:12:29 +00:00
ragnarok-clanker
25dd065dbd Decompile 8 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrimitiveState.cpp, ... 
Batch #1765 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.

- fn_19791 EffectParticle::PrimBottom: logic confirmed by peer review
- fn_19765 EffectPrimitiveState::GetColorOverride: logic confirmed by peer review
- fn_19779 EffectParticle::UpdateHit6: logic confirmed by peer review
- fn_19785 MoveEffectPrimitive: logic confirmed by peer review
- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_19866 RenderEffectPrimitive15: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:09:53 +00:00
ragnarok-clanker
fbb9a30daa Decompile fn_19790 (EffectParticle::PrimBottom2) 
Batch #1732 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19790 EffectParticle::PrimBottom2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:47:19 +00:00
ragnarok-clanker
0f7843e7c6 Decompile 2 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/EffectLists.h 
Batch #1724 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18781 EffectLists::Release: logic confirmed by peer review
- fn_18782 DestroyEffectMgr: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:43:07 +00:00
ragnarok-clanker
916347b79a Decompile fn_18182 (ResourceMgr::Exists) 
Batch #1614 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_18182 ResourceMgr::Exists: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/ResourcePresence.cpp
 2026-10-28 19:50:12 +00:00
ragnarok-clanker
d9a92a8e3b Decompile fn_19780 (EffectParticle::UpdateCoin) 
Batch #1626 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19780 EffectParticle::UpdateCoin: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:46:05 +00:00
ragnarok-clanker
9e88189238 Decompile fn_19766 (CalculateVectorAngle) 
Batch #1612 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19766 CalculateVectorAngle: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:44:33 +00:00
ragnarok-clanker
6ffc82d2d0 Decompile fn_24251 (CEffectMaker::CEffectMaker) 
Batch #1563 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_24251 CEffectMaker::CEffectMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/Effects/EffectMaker.cpp
 2026-10-28 19:10:23 +00:00
ragnarok-clanker
7a9ea8ab29 Decompile fn_17691 (WorldScene::Clear) 
Batch #1549 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17691 WorldScene::Clear: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-28 18:50:15 +00:00
ragnarok-clanker
07e0e8c45c 📚 docs(RagEffectState): corrected field offset comments 2026-10-28 17:59:04 +01:00
ragnarok-clanker
50d48d14dc 🔥 refactor(effects): removed unused header includes 2026-10-28 17:54:10 +01:00
ragnarok-clanker
6c9430e9a1 🔥 refactor(effects): removed unused header includes 2026-10-28 17:41:29 +01:00
ragnarok-clanker
e4be41defa Maintenance: Replace numeric case labels in SelectRagEffectResource with RagEffectID EF_* enumerators from EffectTypes.h; each value 
Batch #1485 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s).
 2026-10-28 16:29:31 +00:00
ragnarok-clanker
16d2e4d0b8 Decompile 22 functions in Source/Contents/EffectResourceSwitcher.cpp, Source/Contents/Effects/Effect.h 
Batch #1446 by Yommy: 22 byte-identical, 0 confirmed by peer review.

- fn_03083 CEffect::Slot10: byte-identical
- fn_03084 CEffect::Slot08: byte-identical
- fn_03090 CEffect::Slot28: byte-identical
- fn_03092 CEffect::Slot01: byte-identical
- fn_03094 CEffect::Slot12: byte-identical
- fn_03095 CEffect::Slot07: byte-identical
- fn_03098 CEffect::Slot04: byte-identical
- fn_03099 CEffect::Slot00: byte-identical
- fn_03100 CEffect::Slot23: byte-identical
- fn_03101 CEffect::Slot24: byte-identical
- fn_03102 CEffect::Slot26: byte-identical
- fn_03103 CEffect::Slot27: byte-identical
- fn_03104 CEffect::Slot21: byte-identical
- fn_03105 CEffect::Slot32: byte-identical
- fn_03106 CEffect::Slot15: byte-identical
- fn_03107 CEffect::Slot14: byte-identical
- fn_03108 CEffect::Slot17: byte-identical
- fn_03109 CEffect::Slot18: byte-identical
- fn_03110 CEffect::Slot19: byte-identical
- fn_03111 CEffect::Slot22: byte-identical
- fn_03112 CEffect::Slot13: byte-identical
- fn_03114 CEffect::Slot20: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/EffectResourceSwitcher.cpp
 2026-10-28 12:58:12 +00:00
ragnarok-clanker
819b017c80 Decompile fn_19783 (EffectParticle::UpdateWarp) 
Batch #1424 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19783 EffectParticle::UpdateWarp: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 12:44:52 +00:00
ragnarok-clanker
e79c5afc99 Decompile 8 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrimitiveState.h, ... 
Batch #1425 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.

- fn_19772 EffectParticle::UpdateFireWall: logic confirmed by peer review
- fn_19775 EffectParticle::UpdateStoneCurse: logic confirmed by peer review
- fn_19776 EffectParticle::UpdateBeginSpell: logic confirmed by peer review
- fn_19779 EffectParticle::UpdateHit6: logic confirmed by peer review
- fn_19781 EffectParticle::UpdateDetoxication: logic confirmed by peer review
- fn_19782 EffectParticle::UpdateExit: logic confirmed by peer review
- fn_19764 EffectParticle::AdvanceFrame: logic confirmed by peer review
- fn_19931 EffectParticle::UpdateRecords: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 12:43:08 +00:00
ragnarok-clanker
4342eec591 Decompile fn_19762 (EffectPrimitiveSlot::EffectPrimitiveSlot) 
Batch #1273 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 02:04:38 +00:00
ragnarok-clanker
c6cc9dc69e Decompile 6 functions in Source/Contents/Effects/EffectPrimitiveState.cpp, Source/Contents/Effects/EffectPrimitiveState.h, ... 
Batch #1199 by eAthena: 0 byte-identical, 6 confirmed by peer review.

- fn_19765 EffectPrimitiveState::GetColorOverride: logic confirmed by peer review
- fn_19773 ShrinkEffectPrimitiveSlots: logic confirmed by peer review
- fn_19774 PulseEffectPrimitiveSlots: logic confirmed by peer review
- fn_19777 SpinEffectPrimitive: logic confirmed by peer review
- fn_19778 RollEffectPrimitive: logic confirmed by peer review
- fn_19784 AdvanceEffectPrimitive: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 21:09:20 +00:00
ragnarok-clanker
02df811b36 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Contents headers (part 1: Actors, Effects, Ground, Hotke 
Batch #1066 by ragnarok-clanker: no function's compiled code changes; checked with 70 compiled unit(s), including every includer of Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Effects/AttachedEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectParticle.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Emblems/GuildEmblemReqBundle.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/Ground/GroundWaterState.h, Source/Contents/Ground/TerrainHeight.h, Source/Contents/Hotkeys/EmotionHotkeys.h, Source/Contents/Hotkeys/HotkeyInfo.h, Source/Contents/Hotkeys/UserHotkeyMgr.h, Source/Contents/InstantVar.h.
 2026-10-27 13:57:41 +00:00
ragnarok-clanker
3dbd276311 📚 docs(inlining): marked inlined functions across modules 2026-10-27 10:21:57 +01:00
ragnarok-clanker
9bacaba47a Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-27 09:47:29 +01:00
ragnarok-clanker
e690233c8d 🛠️ refactor(effects): added EF_UNK enum entries and replaced raw numeric effect IDs 2026-10-27 09:46:33 +01:00
ragnarok-clanker
5aafb686cc 🛠️ refactor(strings): wrote CP949 Korean literals as UTF-8 Hangul with /source-charset:utf-8 /execution-charset:.949 2026-10-27 09:42:20 +01:00
ragnarok-clanker
f0bf88d57e 🔥 refactor(PartyEffect): removed unused <new> include 2026-10-27 09:30:32 +01:00
ragnarok-clanker
db00a48497 🛠️ refactor(effects): replaced magic number 2343 with EF_UNK_2343 enum constant 2026-10-27 09:26:08 +01:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance 
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
 2026-10-26 23:41:07 +01:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections 
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
 2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems 
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
 2026-10-25 07:42:41 +00:00