Commit graph

59 commits

Author SHA1 Message Date
ragnarok-clanker
5ad8e0c58c Maintenance: Resubmission of 16340 over main 047268c0 (conflict in UICashEmotionPack::GetPriceText resolved keeping main's new body).
Batch #16351 by ragnarok-clanker: no function's compiled code changes; checked with 784 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Browser/BrowserCommandTarget.h, Source/Client/Browser/BrowserDocumentUI.h, Source/Client/Browser/BrowserInPlace.h, Source/Client/Browser/WebBrowser.h, Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/Client/Input/Mouse.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StovePCSDK.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GndRiser.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/MousePointer.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClanInfo.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/ArrowEffect.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/DummyEffectLauncher.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/EffectTypes.h, Source/Contents/Effects/ElectricEffect.h, Source/Contents/Effects/EmitterEffect.h, Source/Contents/Effects/FortuneKissEffect.h, Source/Contents/Effects/MagicFloorEffect.h, Source/Contents/Effects/MandraAttackEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RichManKim.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StarEffect.h, Source/Contents/Effects/WhirlwindEffect.h, Source/Contents/EnchantMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/GuildInfo.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemInfo.h, Source/Contents/Items/RuneSystem.h, Source/Contents/MapSkyMgr.h, Source/Contents/Models/ModelActor.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/NavigationManager.h, Source/Contents/Party/PartyBookingMgr.h, Source/Contents/PetEvolutionMgr.h, Source/Contents/RenewQuestMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/Schedule/Schedule.h, Source/Contents/Schedule/ShutDownSchedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/Store/MCStoreInfoBackupAsyncWork.h, Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/WorldView/WorldViewData.h, Source/Network/Connection/Connection.h, Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/DirectDrawEnumeration.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/RendererDX7.h, Source/Render/Text/EmbedFont.h, Source/Render/Text/TextContext.h, Source/Render/Textures/Texture.h, Source/Resource/BinkRuntime.h, Source/Resource/GifResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelMesh.h, Source/Resource/ResourceMgr.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Security/NProtectGameGuardMgr.h, Source/Security/ReassemblyPacketMgr.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Dialogs/UILoadingWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/TableBox.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Lists/UIVScrollBar.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIRequestJoinPartyWnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/TextMarkup.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewer.h, Source/UI/Text/UITransBalloonText.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowId.h, Source/Utility/Async/NAsyncWork.h, Source/Utility/Async/NRecycleObjectPoolMgr.h, Source/Utility/JsonCppLoader.h, Source/Utility/Lexicon/LexiconSerializer.h, Source/Utility/NFileLog.h, Source/Utility/Threading/NThread.h.
2026-11-10 17:38:25 +00:00
ragnarok-clanker
71a8ea69f2 Decompile fn_09164 (NamedBinkMovie::AddPosition)
Batch #16313 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_09164 NamedBinkMovie::AddPosition: logic confirmed by peer review

Peer-reviewed-by: youko, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 16:41:30 +00:00
ragnarok-clanker
52cde0eeb2 Decompile 5 functions in Source/Contents/Models/ModelActor.cpp
Batch #16210 by Yommy: 3 byte-identical, 2 confirmed by peer review.

- fn_17470 C3dActor::~C3dActor: byte-identical
- fn_17520 C3dActorV2::Prepare: byte-identical
- fn_17505 C3dActorV2::Animate: byte-identical
- fn_17496 C3dActorV1::Draw: logic confirmed by peer review
- fn_17497 C3dActorV2::Draw: logic confirmed by peer review

Peer-reviewed-by: youko, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 15:43:57 +00:00
ragnarok-clanker
42e2b60018 Decompile fn_01724 (ModelRotationTrack::Sample)
Batch #16140 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_01724 ModelRotationTrack::Sample: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 14:46:25 +00:00
ragnarok-clanker
7438832554 Decompile 2 functions in Source/Contents/Models/ModelNode.cpp
Batch #15893 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 14:12:31 +00:00
ragnarok-clanker
43d83cc2bf Decompile fn_17702 (OrientedBounds::Intersects)
Batch #15873 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17702 OrientedBounds::Intersects: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 13:42:28 +00:00
ragnarok-clanker
2e85f8316e Decompile fn_17471 (C3dNode::~C3dNode)
Batch #15894 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_17471 C3dNode::~C3dNode: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 11:23:06 +00:00
ragnarok-clanker
2b473feb24 Maintenance: Move the extern template declaration of std::_Traits_compare<char_traits<char>> from 18 units into Source/Utility/StdStr
Batch #15807 by ragnarok-clanker: no function's compiled code changes; checked with 18 compiled unit(s), including every includer of Source/Utility/StdStringCompare.h.
2026-11-10 10:18:14 +00:00
ragnarok-clanker
ea9fcc479c Decompile fn_01723 (LegacyRotationTrack::Sample)
Batch #15614 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_01723 LegacyRotationTrack::Sample: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 09:30:04 +00:00
ragnarok-clanker
a233b0b9a8 Decompile fn_17515 (C3dNode::SampleGroundColors)
Batch #15455 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_17515 C3dNode::SampleGroundColors: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 01:10:33 +00:00
ragnarok-clanker
94afe49718 Decompile fn_17491 (C3dNode::Find)
Batch #15456 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_17491 C3dNode::Find: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 01:04:46 +00:00
ragnarok-clanker
a098f98357 Decompile fn_02019 (Intersects)
Batch #15435 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_02019 Intersects: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 00:24:16 +00:00
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
adbe1db7e1 Decompile 3 functions in Source/Resource/Models/ModelResourceV2.cpp, Source/Resource/Models/ModelResource.h, ...
Batch #14636 by secret: 0 byte-identical, 3 confirmed by peer review.

- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review

Peer-reviewed-by: Tanke, Toshiro, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 17:22:36 +00:00
ragnarok-clanker
d3bef90ccd Decompile fn_17461 (C3dActor::C3dActor)
Batch #14106 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_17461 C3dActor::C3dActor: logic confirmed by peer review

Peer-reviewed-by: secret, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 08:36:26 +00:00
ragnarok-clanker
f49f3f33cb Decompile 2 functions in Source/Contents/Models/ModelRendering.cpp
Batch #13735 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17499 C3dNodeV1::Draw: logic confirmed by peer review
- fn_17500 C3dNodeV2::Draw: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 08:26:53 +00:00
ragnarok-clanker
be2cf07140 Decompile 4 functions in Source/Contents/Models/ModelAnimation.cpp, Source/Contents/Models/ModelAnimation.h, ...
Batch #14054 by Yommy: 4 byte-identical, 0 confirmed by peer review.

- fn_01725 LegacyScaleTrack::Sample: byte-identical
- fn_17465 C3dNodeV1::C3dNodeV1: byte-identical (already on main)
- fn_17466 C3dNodeV2::C3dNodeV2: byte-identical (already on main)
- fn_17507 C3dNodeV1::Animate: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-07 04:50:11 +00:00
ragnarok-clanker
100bfd3cf7 Decompile fn_17500 (C3dNodeV2::Draw)
Batch #13160 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_17500 C3dNodeV2::Draw: logic confirmed by peer review

Peer-reviewed-by: Tanke, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 15:10:15 +00:00
ragnarok-clanker
06e8a89955 Decompile fn_17494 (C3dActorV2::Update)
Batch #13366 by SapitoSucio: 1 byte-identical, 0 confirmed by peer review.

- fn_17494 C3dActorV2::Update: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 14:32:26 +00:00
ragnarok-clanker
4400332945 Decompile fn_01732 (ModelTextureChannelMap::Read)
Batch #13242 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_01732 ModelTextureChannelMap::Read: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 12:14:22 +00:00
ragnarok-clanker
daacec6d2f Decompile 10 functions in Source/Render/DX9/RendererDX9Operations.cpp, Source/Utility/Text/StringUtil.cpp, ...
Batch #13116 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_02239 CRendererDX9::SetLighting: byte-identical
- fn_02757 CountCharacters: byte-identical
- fn_03898 UIChangeMaterialWnd_List::ShiftSelectedIndex: byte-identical
- fn_04317 UIReputeWnd::SetPage: byte-identical
- fn_09718 CSnapMgr::MoveConnected: byte-identical
- fn_09918 UIRefining_Notice::Slot19: byte-identical
- fn_10838 UIBitmapTab::Slot25: byte-identical
- fn_17501 C3dActor::SetSpeed: byte-identical
- fn_18836 CParticle::SetQuad: byte-identical
- fn_19338 ReplayFileList::Select: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 05:24:06 +00:00
ragnarok-clanker
bfc6e8acc9 Decompile 2 functions in Source/Contents/Models/ModelActor.cpp, Source/Contents/Models/ModelActor.h
Batch #12236 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_17496 C3dActorV1::Draw: logic confirmed by peer review
- fn_17497 C3dActorV2::Draw: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, KWDev, aDw, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 03:24:43 +00:00
ragnarok-clanker
31acecb03b Confirm fn_17487 (C3dActor::MarkOccluded)
Batch #12805 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_17487 C3dActor::MarkOccluded: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-06 00:57:09 +00:00
ragnarok-clanker
e5d4b3b94c Decompile fn_17510 (C3dActor::CopyVolumes)
Batch #12528 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_17510 C3dActor::CopyVolumes: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:54:18 +00:00
ragnarok-clanker
3f9b790c6e Decompile fn_17493 (C3dActorV1::Update)
Batch #12405 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_17493 C3dActorV1::Update: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 16:01:26 +00:00
ragnarok-clanker
dd95a31022 Decompile 3 functions in Source/Contents/Models/ModelAnimation.cpp, Source/Contents/Models/ModelAnimation.h, ...
Batch #12238 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_01721 SampleLegacyPosition: logic confirmed by peer review
- fn_01722 SampleModelPosition: logic confirmed by peer review
- fn_01723 SampleLegacyRotation: logic confirmed by peer review

Peer-reviewed-by: KWDev, Toshiro, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:29:45 +00:00
ragnarok-clanker
f0cd1e9d13 Decompile 2 functions in Source/Contents/Models/ModelActorBounds.cpp
Batch #12165 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_17512 C3dActorV1::UpdateBounds: logic confirmed by peer review
- fn_17513 C3dActorV2::UpdateBounds: logic confirmed by peer review

Peer-reviewed-by: Tanke, cremane, raiken
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:00:08 +00:00
ragnarok-clanker
a20ef24120 Decompile 2 functions in Source/Contents/Models/ModelRendering.cpp, Source/Contents/Models/ModelRendering.h
Batch #12104 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_17499 C3dNodeV1::Draw: logic confirmed by peer review
- fn_17500 C3dNodeV2::Draw: logic confirmed by peer review

Peer-reviewed-by: KWDev, SapitoSucio, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 10:39:56 +00:00
ragnarok-clanker
116928a879 Decompile fn_17509 (C3dNode::OverrideColors)
Batch #11964 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_17509 C3dNode::OverrideColors: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 05:47:54 +00:00
ragnarok-clanker
9c0e63c95d Decompile fn_17494 (C3dActorV2::Update)
Batch #11713 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_17494 C3dActorV2::Update: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 04:29:31 +00:00
ragnarok-clanker
7533983e8a Decompile 2 functions in Source/Contents/Models/ModelNode.cpp
Batch #11688 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_17507 C3dNodeV1::Animate: logic confirmed by peer review
- fn_17508 C3dNodeV2::Animate: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 04:23:20 +00:00
ragnarok-clanker
fc53db8f39 Confirm fn_01724 (SampleModelRotation)
Batch #11644 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.

- fn_01724 SampleModelRotation: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 04:03:01 +00:00
ragnarok-clanker
4d023e3b1a Confirm 2 functions in Source/Contents/Models/ModelNode.cpp, Source/Contents/Models/ModelNode.h
Batch #11627 by StrawberrysherbetIX: 0 byte-identical, 2 confirmed by peer review.

- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review (already on main)
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:58:08 +00:00
ragnarok-clanker
99698b5fd7 Confirm 2 functions in Source/Contents/Models/ModelActorBounds.cpp
Batch #11481 by kyoshi: 0 byte-identical, 2 confirmed by peer review.

- fn_17512 C3dActorV1::UpdateBounds: logic confirmed by peer review (already on main)
- fn_17513 C3dActorV2::UpdateBounds: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:09:25 +00:00
ragnarok-clanker
344f57c8a8 Decompile 3 functions in Source/Contents/Models/ModelTextureAnimation.cpp
Batch #11500 by cremane: 0 byte-identical, 3 confirmed by peer review.

- fn_01728 ModelKeyList1::Read: logic confirmed by peer review
- fn_01729 ModelKeyList2::Read: logic confirmed by peer review
- fn_01731 ModelKeyList4::Read: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:52:58 +00:00
ragnarok-clanker
037bd46842 Decompile 2 functions in Source/Contents/Models/ModelLighting.cpp
Batch #11286 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_17491 C3dNode::Find: logic confirmed by peer review
- fn_17521 C3dNode::Prepare: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:34:51 +00:00
ragnarok-clanker
7cc4fdd58e Decompile 2 functions in Source/Contents/Models/ModelActorBounds.cpp, Source/Resource/Models/ModelResource.h
Batch #10504 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17512 C3dActorV1::UpdateBounds: logic confirmed by peer review
- fn_17513 C3dActorV2::UpdateBounds: logic confirmed by peer review

Peer-reviewed-by: Yommy, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:57:59 +00:00
ragnarok-clanker
55ac289a3b Decompile fn_17500 (C3dNodeV2::Draw)
Batch #10564 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_17500 C3dNodeV2::Draw: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:43:25 +00:00
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
bce396c837 Confirm fn_17487 (C3dActor::MarkOccluded)
Batch #10695 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17487 C3dActor::MarkOccluded: logic confirmed by peer review (already on main)

Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 16:50:15 +00:00
ragnarok-clanker
750f35b3dd Maintenance: [forced, user-approved] Family W5 (resubmission of 10276 without the STATIC lines; replaces agent 2's 10270, returned by
Batch #10277 by ragnarok-clanker: forced by an admin (17 lower score(s), 63 changed function(s)); checked with 414 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelNode.h, Source/Contents/Models/ModelRendering.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldOcclusion.h, Source/Contents/World/WorldTerrainPicking.h, Source/Render/Projection/RendererViewport.h, Source/Render/Projection/RenderProjection.h.
Deletes: Source/Render/Projection/RenderProjection.h
2026-11-03 15:49:14 +00:00
ragnarok-clanker
26277f915c Maintenance: [forced, user-approved] Family W3: remove invented ModelLightingContext and WorldModelLoading. Evidence: C3dActor::Prepa
Batch #10256 by ragnarok-clanker: forced by an admin (0 lower score(s), 8 changed function(s)); checked with 113 compiled unit(s), including every includer of Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelNode.h, Source/Contents/Models/ModelRendering.h, Source/Contents/World/World.h, Source/Contents/World/WorldModelLoading.h.
2026-11-03 12:59:38 +00:00
ragnarok-clanker
402041a79d Decompile fn_17480 (C3dActorV2::Assign)
Batch #8474 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_17480 C3dActorV2::Assign: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 18:10:38 +00:00
ragnarok-clanker
dc2f3a8f88 Align method names with DHXJ (call-graph matches): CEffectPrim::Prim3DParticle/Prim3DParticleNoMaster/Prim3DParticleOrbit, matrix::AppendScale/AppendXRotation/AppendZRotation/AppendTranslate/MakeYRotation/MakeZRotation, CRenderObject::CalcDist (2 overloads). Pure rename, codegen unchanged (504/504 functions identical with includers). 2026-10-29 13:12:37 +01:00
ragnarok-clanker
e9b98b8c69 Rename AffineMatrix -> matrix (DHXJ); clashes with variables named matrix use the elaborated form 'struct matrix'. Pure rename, codegen unchanged (383/383 functions identical with includers). 2026-10-29 12:33:14 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
5b61d1ac08 Decompile fn_17498 (C3dNode::Draw)
Batch #1635 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17498 C3dNode::Draw: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:46:47 +00:00
ragnarok-clanker
0e94db9d83 Decompile fn_01730 (ModelKeyList3::Read)
Batch #1597 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_01730 ModelKeyList3::Read: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
2026-10-28 19:42:35 +00:00
ragnarok-clanker
e53f03279f Decompile 4 functions in Source/Contents/Models/ModelTextureAnimation.cpp
Batch #1256 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_01728 ModelKeyList1::Read: logic confirmed by peer review
- fn_01729 ModelKeyList2::Read: logic confirmed by peer review
- fn_01731 ModelKeyList4::Read: logic confirmed by peer review
- fn_01732 ModelTextureChannelMap::Read: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 23:35:26 +00:00
ragnarok-clanker
fe5a446879 Decompile 2 functions in Source/Contents/Models/ModelActor.cpp, Source/Contents/Models/ModelActor.h
Batch #1134 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17495 C3dActor::Draw: logic confirmed by peer review
- fn_17518 C3dActor::Prepare: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 21:05:38 +00:00