Commit graph

25 commits

Author SHA1 Message Date
ragnarok-clanker
8ef4b126f4 Maintenance: Replace raw address calls in CUIGroupSkin::Slot15: 0x00A1E250 (fn_15382, unported, thiscall retn 0Ch) -> declared CUICom
Batch #8902 by ragnarok-clanker: forced by an admin (0 lower score(s), 1 changed function(s)); checked with 4 compiled unit(s), including every includer of Source/UI/GameSettings/GameSettingsUI.h.
2026-10-31 23:00:50 +00:00
ragnarok-clanker
1013488988 Decompile fn_15405 (GameSettingsUI::CUIListPage::Slot15)
Batch #8670 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_15405 GameSettingsUI::CUIListPage::Slot15: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 20:13:04 +00:00
ragnarok-clanker
9b05c56439 Decompile 7 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #8452 by dori: 0 byte-identical, 7 confirmed by peer review.

- fn_15421 CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderAdapter>::AddNewItem: logic confirmed by peer review
- fn_15422 CUIListBoxEx<GameSettingsUI::CUIComboItem,DisplayMode>::AddNewItem: logic confirmed by peer review
- fn_15423 CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderBackend>::AddNewItem: logic confirmed by peer review
- fn_15424 CUIListBoxEx<GameSettingsUI::CUIComboItem,std::basic_string<char,std::char_traits<char>,std::allocator<char> > >::AddNewItem: logic confirmed by peer review
- fn_15425 CUIListBoxEx<GameSettingsUI::CUIOptionItem,TALKTYPE>::AddNewItem: logic confirmed by peer review
- fn_15887 GameSettingsUI::CUIComboItem::CUIComboItem: logic confirmed by peer review
- fn_15903 GameSettingsUI::CUIOptionItem::CUIOptionItem: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, sherollyner, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 17:52:19 +00:00
ragnarok-clanker
9e9bdff93f Decompile fn_15406 (GameSettingsUI::CUIOptionItem::Slot15)
Batch #8369 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_15406 GameSettingsUI::CUIOptionItem::Slot15: logic confirmed by peer review

Peer-reviewed-by: Yommy, System4z, SapitoSucio, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 17:21:28 +00:00
ragnarok-clanker
ccde547b82 Decompile 2 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #8344 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_15978 GameSettingsUI::CUIGraphicsPage::ApplySettings: logic confirmed by peer review
- fn_15986 CUIGameSettingsUI::Slot16: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, vinnyamancio, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 16:50:15 +00:00
ragnarok-clanker
8552c60086 Decompile fn_23604 (CSession::LoadOptionInfo)
Batch #8272 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23604 CSession::LoadOptionInfo: logic confirmed by peer review

Peer-reviewed-by: Yommy, System4z, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 16:00:20 +00:00
ragnarok-clanker
598fad89ee Decompile 10 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h, ...
Batch #8153 by secret: 1 byte-identical, 9 confirmed by peer review.

- fn_15940 CUIGameSettingsUI::ResetToDefaults: logic confirmed by peer review
- fn_15941 GameSettingsUI::CUIOptionItem::RunFunction: logic confirmed by peer review
- fn_15950 GameSettingsUI::CUIOptionItem::OnCheck: logic confirmed by peer review
- fn_15957 GameSettingsUI::CUIGroupSkin::OnSelect: logic confirmed by peer review
- fn_15969 GameSettingsUI::CUIListPage::BindOption: logic confirmed by peer review
- fn_16014 GameSettingsUI::CUIListPage::LoadOptions: logic confirmed by peer review
- fn_16030 GameSettingsUI::CUIListPage::RefreshHotkeyLabels: logic confirmed by peer review
- fn_16046 CUIGameSettingsUI::sub_A43BA0: byte-identical
- fn_16047 GameSettingsUI::CUIListPage::RefreshOptions: logic confirmed by peer review
- fn_16048 CUIGameSettingsUI::sub_A43C70: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 14:44:45 +00:00
ragnarok-clanker
4fda79de97 Decompile 3 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h, ...
Batch #8056 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_15393 GameSettingsUI::CUIGroupEmblem::Slot15: logic confirmed by peer review
- fn_15394 GameSettingsUI::CUIGroupFullscreen::Slot15: logic confirmed by peer review
- fn_15397 GameSettingsUI::CUIGroupLogInOut::Slot15: logic confirmed by peer review

Peer-reviewed-by: eAthena, secret, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 13:50:53 +00:00
ragnarok-clanker
de5903c9c9 Decompile fn_15347 (CUIRadioButton::CUIRadioButton)
Batch #7873 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_15347 CUIRadioButton::CUIRadioButton: logic confirmed by peer review

Peer-reviewed-by: eAthena, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 12:13:50 +00:00
ragnarok-clanker
d0fe4c26e7 Decompile fn_15976 (GameSettingsUI::CUIGroupSound::Apply)
Batch #7344 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_15976 GameSettingsUI::CUIGroupSound::Apply: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:20:55 +00:00
ragnarok-clanker
89bf9fa406 Decompile fn_15995 (GameSettingsUI::CUIGroupSound::Slot16)
Batch #7177 by superintelligence: 0 byte-identical, 1 confirmed by peer review.

- fn_15995 GameSettingsUI::CUIGroupSound::Slot16: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 04:39:28 +00:00
ragnarok-clanker
74ea8fb938 Decompile 5 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #7155 by superintelligence: 0 byte-identical, 5 confirmed by peer review.

- fn_15988 GameSettingsUI::CUIGroupFullscreen::Slot16: logic confirmed by peer review
- fn_15990 GameSettingsUI::CUIGroupGraphicsAPI::Slot16: logic confirmed by peer review
- fn_15993 GameSettingsUI::CUIGroupRodexSpam::Slot16: logic confirmed by peer review
- fn_15998 GameSettingsUI::CUIGroupTrilinear::Slot16: logic confirmed by peer review
- fn_15992 GameSettingsUI::CUIGroupProcessPriority::Slot16: logic confirmed by peer review

Peer-reviewed-by: eAthena, pedrao, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 04:30:49 +00:00
ragnarok-clanker
1a0baa6468 Decompile fn_15400 (GameSettingsUI::CUIGroupSkin::Slot15)
Batch #7088 by Landruca: 0 byte-identical, 1 confirmed by peer review.

- fn_15400 GameSettingsUI::CUIGroupSkin::Slot15: logic confirmed by peer review

Peer-reviewed-by: Lumen, KWDev, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 04:07:22 +00:00
ragnarok-clanker
f5ee9dc0d9 Decompile 2 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h, ...
Batch #6956 by alisonrag: 2 byte-identical, 0 confirmed by peer review.

- fn_17278 UIWindowMgr::sub_AAB090: byte-identical
- fn_17279 UIWindowMgr::sub_AAB0B0: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-31 02:49:19 +00:00
ragnarok-clanker
f1c816107c Decompile 7 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #6652 by superintelligence: 5 byte-identical, 2 confirmed by peer review.

- fn_15374 CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderAdapter>::ClearItems: byte-identical
- fn_15375 CUIListBoxEx<GameSettingsUI::CUIComboItem,DisplayMode>::ClearItems: byte-identical
- fn_15376 CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderBackend>::ClearItems: byte-identical
- fn_15377 CUIListBoxEx<GameSettingsUI::CUIComboItem,std::basic_string<char,std::char_traits<char>,std::allocator<char> > >::ClearItems: byte-identical
- fn_15378 CUIListBoxEx<GameSettingsUI::CUIOptionItem,TALKTYPE>::ClearItems: byte-identical
- fn_16031 CUIGameSettingsUI::sub_A43590: logic confirmed by peer review
- fn_16044 GameSettingsUI::CUIListPage::SetOptionChecked: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:32:18 +00:00
ragnarok-clanker
5fdce3cf20 Decompile fn_17216 (ToggleGameSettingsTab4)
Batch #6642 by vinnyamancio: 0 byte-identical, 1 confirmed by peer review.

- fn_17216 ToggleGameSettingsTab4: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, superintelligence, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:29:23 +00:00
ragnarok-clanker
95e500757a Decompile 6 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #6484 by superintelligence: 0 byte-identical, 6 confirmed by peer review.

- fn_15952 SetComboItemAdapterText: logic confirmed by peer review
- fn_15954 SetComboItemModeText: logic confirmed by peer review
- fn_15956 SetComboItemBackendText: logic confirmed by peer review
- fn_15958 SetComboItemSkinText: logic confirmed by peer review
- fn_15996 GameSettingsUI::CUIGroupSpriteDetailLevel::Slot16: logic confirmed by peer review
- fn_15997 GameSettingsUI::CUIGroupTextureDetailLevel::Slot16: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 23:29:41 +00:00
ragnarok-clanker
fe08d33744 Decompile 3 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #5626 by SapitoSucio: 0 byte-identical, 3 confirmed by peer review.

- fn_16006 GameSettingsUI::CUIGroupProcessPriority::OnSelect: logic confirmed by peer review
- fn_16037 GameSettingsUI::CUIGroupProcessPriority::Refresh: logic confirmed by peer review
- fn_16038 GameSettingsUI::CUIGroupRodexSpam::Refresh: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 14:00:23 +00:00
ragnarok-clanker
d5f9ab8376 Decompile 8 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #5239 by SapitoSucio: 0 byte-identical, 8 confirmed by peer review.

- fn_16004 sub_A41E50: logic confirmed by peer review
- fn_16008 sub_A41FA0: logic confirmed by peer review
- fn_16013 CUIGameSettingsUI::sub_A421E0: logic confirmed by peer review
- fn_16022 sub_A43000: logic confirmed by peer review
- fn_16023 sub_A43040: logic confirmed by peer review
- fn_16029 CUIGameSettingsUI::sub_A433D0: logic confirmed by peer review
- fn_16042 GameSettingsUI::CUIGroupTextureDetailLevel::Refresh: logic confirmed by peer review
- fn_16043 GameSettingsUI::CUIGroupTrilinear::Refresh: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:54:50 +00:00
ragnarok-clanker
aaa3b0f007 Decompile 2 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #5212 by SapitoSucio: 0 byte-identical, 2 confirmed by peer review.

- fn_15973 sub_A404D0: logic confirmed by peer review
- fn_16019 GameSettingsUI::CUIGroupGraphicsAPI::Apply: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:32:12 +00:00
ragnarok-clanker
66cfab1e30 Decompile 10 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h, ...
Batch #4915 by youko: 8 byte-identical, 2 confirmed by peer review.

- fn_15939 CUIGameSettingsUI::sub_A3F0F0: byte-identical
- fn_15955 GameSettingsUI::CUIGroupGraphicsAPI::OnSelect: logic confirmed by peer review
- fn_15967 CUIGameSettingsUI::IsTab4Selected: logic confirmed by peer review
- fn_16024 CUIGameSettingsUI::sub_A43380: byte-identical
- fn_16025 CUIGameSettingsUI::sub_A43390: byte-identical
- fn_16026 CUIGameSettingsUI::sub_A433A0: byte-identical
- fn_16027 CUIGameSettingsUI::sub_A433B0: byte-identical
- fn_16028 CUIGameSettingsUI::sub_A433C0: byte-identical
- fn_16034 GameSettingsUI::CUIGroupGraphics::Refresh: byte-identical
- fn_16035 GameSettingsUI::CUIGroupGraphicsAPI::Refresh: byte-identical

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 05:56:44 +00:00
ragnarok-clanker
a645583bea Decompile 9 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h, ...
Batch #4814 by youko: 9 byte-identical, 0 confirmed by peer review.

- fn_15962 CUIComboBox<GameSettingsUI::CUIComboItem,RenderAdapter>::Selected: byte-identical
- fn_15963 CUIComboBox<GameSettingsUI::CUIComboItem,DisplayMode>::Selected: byte-identical
- fn_15964 CUIComboBox<GameSettingsUI::CUIComboItem,RenderBackend>::Selected: byte-identical
- fn_15965 CUIComboBox<GameSettingsUI::CUIComboItem,std::basic_string<char,std::char_traits<char>,std::allocator<char> > >::Selected: byte-identical
- fn_15968 GameSettingsUI::CUIListPage::Slot54: byte-identical
- fn_16009 CUIComboBox<GameSettingsUI::CUIComboItem,RenderAdapter>::UpdateListHeight: byte-identical
- fn_16010 CUIComboBox<GameSettingsUI::CUIComboItem,DisplayMode>::UpdateListHeight: byte-identical
- fn_16011 CUIComboBox<GameSettingsUI::CUIComboItem,RenderBackend>::UpdateListHeight: byte-identical
- fn_16012 CUIComboBox<GameSettingsUI::CUIComboItem,std::basic_string<char,std::char_traits<char>,std::allocator<char> > >::UpdateListHeight: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-30 05:06:23 +00:00
ragnarok-clanker
5d806a2df9 Decompile 5 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h, ...
Batch #4076 by youko: 5 byte-identical, 0 confirmed by peer review.

- fn_15411 CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderAdapter>::Paint: byte-identical
- fn_15412 CUIListBoxEx<GameSettingsUI::CUIComboItem,DisplayMode>::Paint: byte-identical
- fn_15413 CUIListBoxEx<GameSettingsUI::CUIComboItem,RenderBackend>::Paint: byte-identical
- fn_15414 CUIListBoxEx<GameSettingsUI::CUIComboItem,std::basic_string<char,std::char_traits<char>,std::allocator<char> > >::Paint: byte-identical
- fn_15415 CUIListBoxEx<GameSettingsUI::CUIOptionItem,TALKTYPE>::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-30 00:41:49 +00:00
ragnarok-clanker
d28f098f75 Decompile 5 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #3568 by eAthena: 3 byte-identical, 2 confirmed by peer review.

- fn_15999 GameSettingsUI::CUIListPage::Slot16: byte-identical
- fn_16000 GameSettingsUI::CUIOptionItem::Slot16: byte-identical
- fn_16001 GameSettingsUI::CUIPage::Slot16: logic confirmed by peer review
- fn_16002 CUIGameSettingsUI::Slot25: logic confirmed by peer review
- fn_16045 GameSettingsUI::CUIPage::Refresh: byte-identical

Peer-reviewed-by: Yommy, alisonrag, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:48:18 +00:00
ragnarok-clanker
00318f46b4 Decompile 7 functions in Source/UI/GameSettings/GameSettingsUI.cpp, Source/UI/GameSettings/GameSettingsUI.h
Batch #3131 by eAthena: 7 byte-identical, 0 confirmed by peer review.

- fn_15970 GameSettingsUI::CUIGroup::Apply: byte-identical
- fn_15977 GameSettingsUI::CUIPage::Apply: byte-identical
- fn_15979 GameSettingsUI::CUIGroupSound::Paint: byte-identical
- fn_15980 GameSettingsUI::CUIGroupSpriteDetailLevel::Paint: byte-identical
- fn_15981 GameSettingsUI::CUIGroupTextureDetailLevel::Paint: byte-identical
- fn_15983 GameSettingsUI::CUIOptionItem::Paint: byte-identical
- fn_15985 GameSettingsUI::CUIComboItem::Slot16: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/UI/GameSettings/GameSettingsUI.cpp
2026-10-29 20:34:21 +00:00