clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
512 commits 1 branch 0 tags 11 MiB
Commit graph

512 commits

This branch
This branch
All branches
Author SHA1 Message Date
ragnarok-clanker
64ad35e4c0 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-28 23:14:53 +01:00
ragnarok-clanker
f07e52ffeb 🔥 refactor(effects): removed unused header includes 2026-10-28 23:14:51 +01:00
ragnarok-clanker
41b839b378 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-28 23:14:46 +01:00
ragnarok-clanker
40dade2c0b Decompile 4 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h 
Batch #1783 by Yommy: 4 byte-identical, 0 confirmed by peer review.

- fn_19451 CNavi_Link::ClearLinkedLinks: byte-identical
- fn_19452 CNavi_Link::ClearLinks: byte-identical
- fn_19453 CNavi_Object::ClearLinks: byte-identical
- fn_19490 CNavi_Link::GetLinkedName: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 22:14:12 +00:00
ragnarok-clanker
4c22f54ad0 🔥 refactor(effects): removed unused header includes 2026-10-28 23:13:11 +01:00
ragnarok-clanker
5a44997d9c Decompile 22 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1769 by Yommy: 0 byte-identical, 22 confirmed by peer review.

- fn_08327 CEfstAction_ChangeSize::Slot01: logic confirmed by peer review
- fn_08328 CEfstAction_ChangeSize::Slot02: logic confirmed by peer review
- fn_08331 CEfstAction_GenderChange::Slot02: logic confirmed by peer review
- fn_08334 CEfstAction_ShowEffect::Slot02: logic confirmed by peer review
- fn_08335 CSkillAction_RA_UNLIMIT::Slot08: logic confirmed by peer review
- fn_08339 CEfstAction_UNLIMIT::Slot02: logic confirmed by peer review
- fn_08346 CEfstAction_SHADOW_WEAPON::Slot03: logic confirmed by peer review
- fn_08347 CEfstAction_SHADOW_WEAPON::Slot04: logic confirmed by peer review
- fn_08359 CEfstAction_DANCING_KNIFE::Slot02: logic confirmed by peer review
- fn_08366 CEfstAction_SHADOW_EXCEED::Slot01: logic confirmed by peer review
- fn_08367 CEfstAction_SHADOW_EXCEED::Slot02: logic confirmed by peer review
- fn_08368 CEfstAction_SHADOW_EXCEED::Slot03: logic confirmed by peer review
- fn_08369 CEfstAction_SHADOW_EXCEED::Slot04: logic confirmed by peer review
- fn_08404 CSkillActionMgr::ActionSlot01: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_08406 CSkillActionMgr::EfstSlot03: logic confirmed by peer review
- fn_08407 CSkillActionMgr::EfstSlot04: logic confirmed by peer review
- fn_08408 CSkillActionMgr::ActionSlot14: logic confirmed by peer review
- fn_08409 CSkillActionMgr::ActionSlot02: logic confirmed by peer review
- fn_08410 CSkillActionMgr::ActionSlot03: logic confirmed by peer review
- fn_08411 CSkillActionMgr::ActionSlot04: logic confirmed by peer review
- fn_08412 CSkillActionMgr::HasEfstAction: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:12:43 +00:00
ragnarok-clanker
43198220b9 Decompile 2 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h 
Batch #1770 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19792 EffectParticle::PrimBottomOut: logic confirmed by peer review
- fn_19793 EffectParticle::PrimBubbleDrop: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:12:29 +00:00
ragnarok-clanker
be749d87c8 Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1771 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_08371 CSkillAction_ABC_CHASING_BREAK::Slot07: byte-identical
- fn_08375 CSkillAction_ABC_CHASING_SHOT::Slot07: byte-identical
- fn_08385 CSkillAction_ABC_ABYSS_FLAME_ATK::Slot03: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 22:12:16 +00:00
ragnarok-clanker
996f026515 Decompile 8 functions in Source/Contents/CashEmotionMgr.cpp, Source/Contents/CashEmotionMgr.h, ... 
Batch #1766 by Yommy: 0 byte-identical, 8 confirmed by peer review.

- fn_02972 CCashEmotionMgr::SetOwnedPack: logic confirmed by peer review
- fn_09428 UICashEmotionMiniWnd::Select: logic confirmed by peer review
- fn_09429 UICashEmotionMiniWnd::Previous: logic confirmed by peer review
- fn_09431 UICashEmotionMiniWnd::Slot15: logic confirmed by peer review
- fn_09432 UICashEmotionMiniWnd::Paint: logic confirmed by peer review
- fn_09433 UICashEmotionMiniWnd::Next: logic confirmed by peer review
- fn_09434 UICashEmotionMiniWnd::SetIndex: logic confirmed by peer review
- fn_09435 UICashEmotionMiniWnd::SendMsg: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:10:56 +00:00
ragnarok-clanker
013f1a4dd5 Decompile 2 functions in Source/UI/Shortcuts/ShortcutCooldowns.cpp, Source/UI/Window/UIRebirthWnd.h, ... 
Batch #1768 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_12673 UIRebirthWnd::Paint: logic confirmed by peer review
- fn_12676 UISeekPartyMBWnd::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:10:51 +00:00
ragnarok-clanker
e6834bc146 Decompile fn_09430 (UICashEmotionMiniWnd::Refresh) 
Batch #1767 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_09430 UICashEmotionMiniWnd::Refresh: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:10:32 +00:00
ragnarok-clanker
25dd065dbd Decompile 8 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrimitiveState.cpp, ... 
Batch #1765 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.

- fn_19791 EffectParticle::PrimBottom: logic confirmed by peer review
- fn_19765 EffectPrimitiveState::GetColorOverride: logic confirmed by peer review
- fn_19779 EffectParticle::UpdateHit6: logic confirmed by peer review
- fn_19785 MoveEffectPrimitive: logic confirmed by peer review
- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_19866 RenderEffectPrimitive15: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:09:53 +00:00
ragnarok-clanker
b2cd2e3091 Decompile 4 functions in Source/UI/Lists/UIScrollBar.cpp, Source/UI/Lists/UIChatHisBox.h, ... 
Batch #1755 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_11279 UIListBoxEx::FindLine: logic confirmed by peer review
- fn_11280 UIImgMenu::ItemAt: logic confirmed by peer review
- fn_11284 UITabControl::TabAt: logic confirmed by peer review
- fn_11285 UIChatHisBox::HistoryText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:09:42 +00:00
ragnarok-clanker
d4d8129b0d Decompile 2 functions in Source/Contents/NavigationRoute.cpp, Source/Contents/NavigationManager.h 
Batch #1752 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19603 CNavigationManager::MapCellToView: logic confirmed by peer review
- fn_19608 CNavigationManager::RouteText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:09:32 +00:00
ragnarok-clanker
cf696df195 Decompile fn_12765 (UINewChatWnd::Show) 
Batch #1753 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_12765 UINewChatWnd::Show: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:09:24 +00:00
ragnarok-clanker
715e4e7cde Decompile fn_11283 (UITabControl::TabCount) 
Batch #1756 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_11283 UITabControl::TabCount: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 22:02:36 +00:00
ragnarok-clanker
d0614a545c Decompile 10 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h 
Batch #1751 by Yommy: 0 byte-identical, 10 confirmed by peer review.

- fn_19558 NaviRouteLine::~NaviRouteLine: logic confirmed by peer review
- fn_19562 CNavigationManager::AddState: logic confirmed by peer review
- fn_19563 CNavigationManager::ParseFlags: logic confirmed by peer review
- fn_19564 CNavigationManager::ParseCell: logic confirmed by peer review
- fn_19568 CNavigationManager::WriteTarget: logic confirmed by peer review
- fn_19569 CNavigationManager::WriteObject: logic confirmed by peer review
- fn_19571 CNavigationManager::ClearSavedTarget: logic confirmed by peer review
- fn_19576 CNavigationManager::ClearStates: logic confirmed by peer review
- fn_19579 CNavigationManager::FindNodePath: logic confirmed by peer review
- fn_19580 CNavigationManager::SelectNodePath: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:02:26 +00:00
ragnarok-clanker
e38b027ea1 Decompile 2 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h 
Batch #1754 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_19572 CNavigationManager::ClearCurrentObject: byte-identical
- fn_19577 CNavigationManager::ClearNodes: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 22:01:45 +00:00
ragnarok-clanker
df85eb5f7b Decompile 5 functions in Source/Contents/NavigationRoute.cpp, Source/Contents/NavigationManager.h 
Batch #1748 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_19377 CNaviData::FindLink: logic confirmed by peer review
- fn_19381 CNaviData::ClearAll: logic confirmed by peer review
- fn_19432 CNavi_Object::HasId: logic confirmed by peer review
- fn_19433 CNavi_Object::IsNamed: logic confirmed by peer review
- fn_19600 CNavigationManager::BuildRoute: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:00:12 +00:00
ragnarok-clanker
2e681e5fca Decompile 3 functions in Source/UI/Shortcuts/UIShortCutWnd.cpp, Source/UI/Chat/UISubChatMiniWnd.h, ... 
Batch #1747 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_12630 UIMemorialDunWnd::Move: logic confirmed by peer review
- fn_12762 UISubChatMiniWnd::SendMsg: logic confirmed by peer review
- fn_12763 UIWindowCallBtnWnd::SendMsg: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:00:04 +00:00
ragnarok-clanker
4092a8c832 Decompile fn_19379 (NaviCell::GetY) 
Batch #1750 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_19379 NaviCell::GetY: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 21:59:30 +00:00
ragnarok-clanker
05897157f1 Decompile 6 functions in Source/UI/Window/UIControl.cpp, Source/UI/Lists/UIListBoxTemplate.h, ... 
Batch #1741 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_14037 CUIListBox<AdventureGuide::CUISubTab>::Resize: logic confirmed by peer review
- fn_14038 CUIListBox<AdventureGuide::CUITab>::Resize: logic confirmed by peer review
- fn_14043 CUIListBoxEx<AdventureGuide::CUIItemInfo,AdventureGuide::CItemData>::OnScroll: logic confirmed by peer review
- fn_14044 CUIListBoxEx<AdventureGuide::CUIMonsterInfo,AdventureGuide::CMonsterData>::OnScroll: logic confirmed by peer review
- fn_14045 CUIListBoxEx<AdventureGuide::CUIQuestInfo,AdventureGuide::CQuestInfo>::OnScroll: logic confirmed by peer review
- fn_14046 CUIListBoxEx<AdventureGuide::CUITabInfo,Guide_Intro::Contents>::OnScroll: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:57:49 +00:00
ragnarok-clanker
a5a9051638 Decompile fn_19465 (CNaviInfo::FindMatchingLink) 
Batch #1735 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19465 CNaviInfo::FindMatchingLink: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:57:46 +00:00
ragnarok-clanker
ecdb364faa Decompile 2 functions in Source/UI/Buttons/UITextButton.cpp, Source/UI/Buttons/UIBmpRadioBtn.h, ... 
Batch #1737 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_11447 UIBarGraph4::Slot28: logic confirmed by peer review
- fn_11452 UIINT64BarGraph::Slot28: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:57:43 +00:00
ragnarok-clanker
ff9ce39334 Decompile fn_04157 (UILapineBox_IngredientListWnd::Paint) 
Batch #1736 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_04157 UILapineBox_IngredientListWnd::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 21:47:47 +00:00
ragnarok-clanker
fbb9a30daa Decompile fn_19790 (EffectParticle::PrimBottom2) 
Batch #1732 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19790 EffectParticle::PrimBottom2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:47:19 +00:00
ragnarok-clanker
fa4384640e Decompile fn_04158 (UILapineScrollBar::Paint) 
Batch #1730 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_04158 UILapineScrollBar::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:46:47 +00:00
ragnarok-clanker
3be87414c2 Decompile 3 functions in Source/Contents/NavigationRequest.cpp, Source/Contents/NavigationManager.h 
Batch #1728 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_19464 CNaviInfo::FindLink: logic confirmed by peer review
- fn_19478 CNaviInfo::FindNpc: logic confirmed by peer review
- fn_19479 CNaviInfo::FindNpcAt: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:46:17 +00:00
ragnarok-clanker
37d909cfee Decompile 3 functions in Source/Contents/NavigationRequest.cpp, Source/Contents/NavigationManager.h 
Batch #1729 by ragnarok-clanker: 3 byte-identical, 0 confirmed by peer review.

- fn_19462 CNaviInfo::GetCellY: byte-identical
- fn_19463 CNaviInfo::GetIndex: byte-identical
- fn_19480 CNaviInfo::Npcs: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 21:45:53 +00:00
ragnarok-clanker
9c23c9c1e0 Decompile 4 functions in Source/UI/UILapineUpgradeBoxWnd.cpp, Source/UI/UILapineUpgradeBoxWnd.h 
Batch #1727 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_04205 UILapineUpgradeBoxWnd::Slot25: logic confirmed by peer review
- fn_04206 UILapineUpgradeBox_IngredientInfoWnd::Slot25: logic confirmed by peer review
- fn_04211 UILapineUpgradeBoxWnd::Slot32: logic confirmed by peer review
- fn_04212 UILapineUpgradeBox_IngredientInfoWnd::Slot32: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:43:08 +00:00
ragnarok-clanker
0f7843e7c6 Decompile 2 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/EffectLists.h 
Batch #1724 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18781 EffectLists::Release: logic confirmed by peer review
- fn_18782 DestroyEffectMgr: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 21:43:07 +00:00
ragnarok-clanker
731d1b60ce Decompile 4 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/ModelResource.h, ... 
Batch #1726 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_08004 C3dGrannyModelRes::PlayAnimation: logic confirmed by peer review
- fn_08005 GrannyAnimationLibrary::Load: logic confirmed by peer review
- fn_08007 AnimatedModelNode::Shade: logic confirmed by peer review
- fn_08008 C3dGrannyModelRes::ProjectBounds: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 21:43:00 +00:00
ragnarok-clanker
eba26963c9 Add SkillId enum and name SkillInfo skill helpers 
SkillId.h: the full SKID table (1929 entries) from skillinfoz/skillid.lua. SkillInfo.cpp: every numeric skill ID replaced by its SkillId name; Sub773A00/Sub773CB0/Sub773CD0/Sub7745B0/CSkillActionMgr::Sub77B4A0 renamed IsOptionalSelfTargetSkill/HidesUseFailureMessage/IsSupportSkill/ShowsCastEffect/CSkillActionMgr::IsSupportAction from their call sites; CSkillInfo::operator= copies scalars by assignment instead of memcpy. Compiled code unchanged (all includers checked).
 2026-10-28 22:19:15 +01:00
ragnarok-clanker
34541f64a8 Decompile 6 functions in Source/Contents/HeadResources.cpp, Source/Client/Session.h, ... 
Batch #1721 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_19751 EquipmentResourceMgr::GetHeadName: logic confirmed by peer review
- fn_23373 CSession::GetHeadActName: logic confirmed by peer review
- fn_23374 CSession::GetPlayerHeadActName: logic confirmed by peer review
- fn_23375 CSession::GetHeadPalName: logic confirmed by peer review
- fn_23376 CSession::GetPlayerHeadPalName: logic confirmed by peer review
- fn_23377 CSession::GetHeadSprName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/HeadResources.cpp
 2026-10-28 21:11:05 +00:00
ragnarok-clanker
e310f19bcb Inline MessageNames.inc into MessageTable.cpp 
Move the message-name table from Source/Contents/MessageNames.inc into the messageNames definition in MessageTable.cpp, with its STATIC 0x0115AA88 / GLOBAL gl_13433 provenance, and delete the .inc. No other change: compiled code of every MessageTable function is unchanged (checked against main).
 2026-10-28 21:58:50 +01:00
ragnarok-clanker
3616ad5aa8 Decompile 2 functions in Source/Contents/Messenger/MessengerMember.cpp 
Batch #1717 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_07682 UIFriendOptionWnd::Paint: logic confirmed by peer review
- fn_07687 UIJobIconButton::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:55:32 +00:00
ragnarok-clanker
0085ade247 Decompile fn_02162 (RenderVertexPool::~RenderVertexPool) 
Batch #1715 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02162 RenderVertexPool::~RenderVertexPool: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:52:20 +00:00
ragnarok-clanker
320e545705 Decompile fn_06044 (EquipmentProperties::CEquipmentPropertiesMgr::~CEquipmentPropertiesMgr) 
Batch #1709 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06044 EquipmentProperties::CEquipmentPropertiesMgr::~CEquipmentPropertiesMgr: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:47:48 +00:00
ragnarok-clanker
018dee6278 Decompile 15 functions in Source/Client/Session.h, Source/Client/Replay.cpp, ... 
Batch #1712 by ragnarok-clanker: 0 byte-identical, 15 confirmed by peer review.

- fn_06570 ItemInfo::AssignBasic: logic confirmed by peer review
- fn_06607 SearchItemIds: logic confirmed by peer review
- fn_06608 MatchItemName: logic confirmed by peer review
- fn_06582 FindMetalProcessItems: logic confirmed by peer review
- fn_06590 ItemInfo::Serialize: logic confirmed by peer review
- fn_06544 FindItemCardName: logic confirmed by peer review
- fn_23291 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23297 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23584 CSession::HasRequiredItems: logic confirmed by peer review
- fn_23588 CSession::IsSlotItemIdentity: logic confirmed by peer review
- fn_23589 CSession::HasInventoryItem: logic confirmed by peer review
- fn_23591 CSession::HasItemId: logic confirmed by peer review
- fn_23592 CSession::HasItemCount: logic confirmed by peer review
- fn_23582 IsScreenShakeActive: logic confirmed by peer review
- fn_23908 CSession::SetPlayerNameKey: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:47:17 +00:00
ragnarok-clanker
2845c3431d Decompile 7 functions in Source/Contents/MessageTable.cpp, Source/Contents/MessageTable.h, ... 
Batch #1710 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_18371 DecodeMessageRot: logic confirmed by peer review
- fn_18372 InsertMessageRow: logic confirmed by peer review
- fn_18374 ImportMessageTable: logic confirmed by peer review
- fn_03416 CCommonObject::ReadCsvRow: logic confirmed by peer review
- fn_03418 CCommonObject::LoadCsv: logic confirmed by peer review
- fn_03420 CCommonObject::OpenCsv: logic confirmed by peer review
- fn_18373 ?TransformFields@?A0x79e5ab67@@YA?AV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@ABV23@@Z: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:46:36 +00:00
ragnarok-clanker
8125ad1ce1 Decompile fn_06623 (BuildReplayTaggedRecord) 
Batch #1714 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06623 BuildReplayTaggedRecord: logic confirmed by peer review (annotation added to existing code)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 20:43:04 +00:00
ragnarok-clanker
ff83912b6b Decompile 9 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Session.h, ... 
Batch #1711 by ragnarok-clanker: 0 byte-identical, 9 confirmed by peer review.

- fn_23304 SessionMessengerContext::UpdateRandomStats: logic confirmed by peer review
- fn_05603 EquipmentPropertyStore::EquipmentPropertyStore: logic confirmed by peer review
- fn_05771 EquipmentPropertyStore::Clear: logic confirmed by peer review
- fn_05740 EquipmentPropertyStore::~EquipmentPropertyStore: logic confirmed by peer review
- fn_05807 EquipmentPropertyGroup::~EquipmentPropertyGroup: logic confirmed by peer review
- fn_06013 EquipmentProperties::CEquipmentPropertiesMgr::CEquipmentPropertiesMgr: logic confirmed by peer review
- fn_06170 EquipmentProperties::CEquipmentPropertiesMgr::Clear: logic confirmed by peer review
- fn_17276 UIWindowMgr::NotifyItemWindows: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 20:41:46 +00:00
ragnarok-clanker
21ea249664 Decompile 2 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h 
Batch #1707 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_08322 Sub773CD0: logic confirmed by peer review
- fn_08413 CSkillActionMgr::Sub77B4A0: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:39:14 +00:00
ragnarok-clanker
e9fdd5f24b Decompile fn_09430 (UICashEmotionMiniWnd::Refresh) 
Batch #1705 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_09430 UICashEmotionMiniWnd::Refresh: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:38:35 +00:00
ragnarok-clanker
b677bdbc59 Decompile 3 functions in Source/Client/Session.cpp, Source/Client/Session.h, ... 
Batch #1704 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_24179 CSession::IsDoramJob: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review
- fn_19754 EquipmentResourceMgr::GetBodyRacePrefix: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 20:33:49 +00:00
ragnarok-clanker
b23d368372 Maintenance: Resubmit of batch 1702, which reported merged at 0bc2089 but that commit does not contain Replay.cpp changes. Source hyg 
Batch #1703 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s).
 2026-10-28 20:28:07 +00:00
ragnarok-clanker
fb4bfc02d5 Decompile fn_09128 (CTipBoxMgr::Sub7ACF50) 
Batch #1701 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_09128 CTipBoxMgr::Sub7ACF50: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:26:35 +00:00
ragnarok-clanker
0bc20896db Decompile 4 functions in Source/Contents/SpriteFrameSynchronization.cpp, Source/Contents/NpcLocationRadius.cpp, ... 
Batch #1694 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_23819 CSession::GetSyncedFrame: logic confirmed by peer review
- fn_23467 CSession::GetNpcLocationRadius: logic confirmed by peer review
- fn_23823 CSession::GetRidingJob: logic confirmed by peer review
- fn_24152 CSession::GetSpriteJob: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SpriteFrameSynchronization.cpp, Source/Contents/NpcLocationRadius.cpp, Source/Contents/SpriteJob.cpp
 2026-10-28 20:24:26 +00:00
ragnarok-clanker
7a88edb84c Decompile fn_23848 (CSession::LoadXmlTables) 
Batch #1684 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23848 CSession::LoadXmlTables: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientXmlTables.cpp
 2026-10-28 20:23:55 +00:00
ragnarok-clanker
429f04c98d Decompile fn_17019 (UIWindow::DrawRightOutlinedText) 
Batch #1679 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17019 UIWindow::DrawRightOutlinedText: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-28 20:23:25 +00:00