Commit graph

603 commits

Author SHA1 Message Date
ragnarok-clanker
b1daa66a79 Decompile 2 functions in Source/Client/Mode/GameModeNotices.cpp, Source/Client/Mode/GameModePackets.cpp
Batch #16568 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_21836 CGameMode::ReceiveSpriteChange2: logic confirmed by peer review
- fn_22061 CGameMode::ReceiveRouletteOpen: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 22:20:56 +00:00
ragnarok-clanker
425c40bd1c Decompile 2 functions in Source/Client/Mode/GameMode.cpp
Batch #16407 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_21329 CGameMode::ProcessGroundClick: logic confirmed by peer review
- fn_21335 CGameMode::ProcessActorPick: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 21:58:37 +00:00
ragnarok-clanker
7fa9b684cb Decompile 2 functions in Source/Client/Mode/LoginMode.cpp
Batch #16429 by eAthena: 1 byte-identical, 1 confirmed by peer review.

- fn_22271 GetMacAddress: logic confirmed by peer review
- fn_22278 CLoginMode::ReceiveCharacterPage: byte-identical

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 19:18:09 +00:00
ragnarok-clanker
fa0e51e34d Decompile fn_21815 (CGameMode::ReceiveSearchStoreItemsOld)
Batch #16157 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_21815 CGameMode::ReceiveSearchStoreItemsOld: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, bgamez23
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 18:55:31 +00:00
ragnarok-clanker
4a2aea4a0c Decompile fn_21717 (CGameMode::ReceiveInventoryEquipList)
Batch #16390 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_21717 CGameMode::ReceiveInventoryEquipList: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 18:43:04 +00:00
ragnarok-clanker
cb1aab3d6b Decompile fn_21780 (CGameMode::ReceiveParChange)
Batch #16377 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21780 CGameMode::ReceiveParChange: logic confirmed by peer review

Peer-reviewed-by: youko, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 17:58:16 +00:00
ragnarok-clanker
5ad8e0c58c Maintenance: Resubmission of 16340 over main 047268c0 (conflict in UICashEmotionPack::GetPriceText resolved keeping main's new body).
Batch #16351 by ragnarok-clanker: no function's compiled code changes; checked with 784 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Browser/BrowserCommandTarget.h, Source/Client/Browser/BrowserDocumentUI.h, Source/Client/Browser/BrowserInPlace.h, Source/Client/Browser/WebBrowser.h, Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/Client/Input/Mouse.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StovePCSDK.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GndRiser.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/MousePointer.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClanInfo.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/ArrowEffect.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/DummyEffectLauncher.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/EffectTypes.h, Source/Contents/Effects/ElectricEffect.h, Source/Contents/Effects/EmitterEffect.h, Source/Contents/Effects/FortuneKissEffect.h, Source/Contents/Effects/MagicFloorEffect.h, Source/Contents/Effects/MandraAttackEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RichManKim.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StarEffect.h, Source/Contents/Effects/WhirlwindEffect.h, Source/Contents/EnchantMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/GuildInfo.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemInfo.h, Source/Contents/Items/RuneSystem.h, Source/Contents/MapSkyMgr.h, Source/Contents/Models/ModelActor.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/NavigationManager.h, Source/Contents/Party/PartyBookingMgr.h, Source/Contents/PetEvolutionMgr.h, Source/Contents/RenewQuestMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/Schedule/Schedule.h, Source/Contents/Schedule/ShutDownSchedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/Store/MCStoreInfoBackupAsyncWork.h, Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/WorldView/WorldViewData.h, Source/Network/Connection/Connection.h, Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/DirectDrawEnumeration.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/RendererDX7.h, Source/Render/Text/EmbedFont.h, Source/Render/Text/TextContext.h, Source/Render/Textures/Texture.h, Source/Resource/BinkRuntime.h, Source/Resource/GifResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelMesh.h, Source/Resource/ResourceMgr.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Security/NProtectGameGuardMgr.h, Source/Security/ReassemblyPacketMgr.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Dialogs/UILoadingWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/TableBox.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Lists/UIVScrollBar.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIRequestJoinPartyWnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/TextMarkup.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewer.h, Source/UI/Text/UITransBalloonText.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowId.h, Source/Utility/Async/NAsyncWork.h, Source/Utility/Async/NRecycleObjectPoolMgr.h, Source/Utility/JsonCppLoader.h, Source/Utility/Lexicon/LexiconSerializer.h, Source/Utility/NFileLog.h, Source/Utility/Threading/NThread.h.
2026-11-10 17:38:25 +00:00
ragnarok-clanker
cfd20187fa Decompile fn_21255 (CGameMode::DrawMiniMap)
Batch #16298 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21255 CGameMode::DrawMiniMap: logic confirmed by peer review

Peer-reviewed-by: youko, bgamez23
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 16:50:12 +00:00
ragnarok-clanker
b2e98785dc Decompile fn_21974 (CGameMode::ReceiveRandomOptionSimulation)
Batch #16289 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_21974 CGameMode::ReceiveRandomOptionSimulation: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 16:05:50 +00:00
ragnarok-clanker
c3258abb9f Decompile 2 functions in Source/Client/Mode/GameModeNotices.cpp
Batch #16280 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_21843 CGameMode::ReceiveStorageEquipList: logic confirmed by peer review
- fn_21844 CGameMode::ReceiveStorageEquipList2: logic confirmed by peer review

Peer-reviewed-by: Yommy, kyoshi, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 15:56:53 +00:00
ragnarok-clanker
9b2bc57045 Decompile fn_21256 (CGameMode::DrawMiniMapTriangle)
Batch #16169 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_21256 CGameMode::DrawMiniMapTriangle: logic confirmed by peer review

Peer-reviewed-by: Yommy, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 15:48:30 +00:00
ragnarok-clanker
fcac5f5804 Decompile fn_21430 (ModeDragState::BeginSkill)
Batch #16199 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_21430 ModeDragState::BeginSkill: logic confirmed by peer review

Peer-reviewed-by: Yommy, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 15:45:57 +00:00
ragnarok-clanker
b3c4e2dda6 Decompile 2 functions in Source/Client/Mode/GameMode.cpp
Batch #16165 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_21248 CGameMode::UpdatePetFriendlyWindow: logic confirmed by peer review
- fn_21425 CGameMode::StopReplayRecording: logic confirmed by peer review

Peer-reviewed-by: Yommy, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 15:36:22 +00:00
ragnarok-clanker
2d37f14264 Decompile fn_22309 (CLoginMode::PollNetworkStatus)
Batch #15870 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_22309 CLoginMode::PollNetworkStatus: logic confirmed by peer review

Peer-reviewed-by: eAthena, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 14:33:54 +00:00
ragnarok-clanker
4b151714ff Decompile fn_17834 (CMode::ShowTooltip)
Batch #15998 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_17834 CMode::ShowTooltip: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 14:30:06 +00:00
ragnarok-clanker
e0757bb8fb Decompile fn_22016 (CGameMode::ReceiveClanChat)
Batch #16050 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_22016 CGameMode::ReceiveClanChat: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 14:20:05 +00:00
ragnarok-clanker
338b77fcbc Decompile 3 functions in Source/Client/Mode/GameModeHandlers.cpp
Batch #16052 by Yommy: 2 byte-identical, 1 confirmed by peer review.

- fn_21813 CGameMode::ReceiveStatusNotice: byte-identical
- fn_22026 CGameMode::ReceiveRuneRewardSteps: byte-identical
- fn_22033 CGameMode::ReceiveGameOptionResult: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 13:21:54 +00:00
ragnarok-clanker
1ee1c71464 Decompile fn_21842 (CGameMode::StopActorMove)
Batch #15829 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21842 CGameMode::StopActorMove: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 13:21:29 +00:00
ragnarok-clanker
09bed0c784 Decompile fn_21289 (CGameMode::RefreshActorJobEffects)
Batch #15992 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_21289 CGameMode::RefreshActorJobEffects: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 12:37:58 +00:00
ragnarok-clanker
7b9150b58a Decompile fn_09855 (UIMacroReporterWnd::SendMacroUserInfoPacket)
Batch #15951 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_09855 UIMacroReporterWnd::SendMacroUserInfoPacket: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 12:04:19 +00:00
ragnarok-clanker
e3993b5986 Decompile fn_21964 (NoticeSkillUse)
Batch #15944 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21964 NoticeSkillUse: logic confirmed by peer review

Peer-reviewed-by: Yommy, aDw, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 12:00:37 +00:00
ragnarok-clanker
4e319e3a02 Decompile fn_09151 (AutomaticSkills::CancelOption)
Batch #15929 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_09151 AutomaticSkills::CancelOption: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 11:54:39 +00:00
ragnarok-clanker
66bc6111db Decompile 2 functions in Source/Client/Mode/LoginMode.cpp
Batch #15882 by SapitoSucio: 2 byte-identical, 0 confirmed by peer review.

- fn_22294 nullsub_486: byte-identical
- fn_22296 nullsub_487: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 11:13:12 +00:00
ragnarok-clanker
2c56be15cb Decompile fn_22315 (CLoginMode::ReceiveLoginErrorDetail)
Batch #15860 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_22315 CLoginMode::ReceiveLoginErrorDetail: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 10:58:15 +00:00
ragnarok-clanker
2b473feb24 Maintenance: Move the extern template declaration of std::_Traits_compare<char_traits<char>> from 18 units into Source/Utility/StdStr
Batch #15807 by ragnarok-clanker: no function's compiled code changes; checked with 18 compiled unit(s), including every includer of Source/Utility/StdStringCompare.h.
2026-11-10 10:18:14 +00:00
ragnarok-clanker
caaa2cdd95 Decompile fn_22312 (CLoginMode::ReceiveNotifyBan)
Batch #15586 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_22312 CLoginMode::ReceiveNotifyBan: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 09:33:47 +00:00
ragnarok-clanker
ab78f8add5 Decompile 2 functions in Source/Client/Mode/GameModeNotices.cpp
Batch #15382 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_22082 CGameMode::ReceiveOngoingQuestList: logic confirmed by peer review
- fn_22083 CGameMode::ReceiveOngoingQuestList2: logic confirmed by peer review

Peer-reviewed-by: eAthena, gordaoprogramas, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 22:23:36 +00:00
ragnarok-clanker
9b20f77fbc Decompile 8 functions in Source/Client/Mode/GameMode.cpp
Batch #15360 by Yommy: 0 byte-identical, 8 confirmed by peer review.

- fn_21346 CGameMode::SaveActiveSkillEffects: logic confirmed by peer review (already on main)
- fn_21347 CGameMode::SaveNameCardState: logic confirmed by peer review
- fn_21348 CGameMode::SaveQuestState: logic confirmed by peer review (already on main)
- fn_21349 CGameMode::SaveGroundItems: logic confirmed by peer review (already on main)
- fn_21350 CGameMode::SaveActorStates: logic confirmed by peer review
- fn_21351 CGameMode::WriteReplaySkillState: logic confirmed by peer review (already on main)
- fn_21354 CGameMode::ReadReplayGroundItems: logic confirmed by peer review
- fn_21356 CGameMode::ReadReplayGroundSkills: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 22:03:51 +00:00
ragnarok-clanker
16e0485e93 Decompile 11 functions in Source/Client/Mode/LoginMode.cpp
Batch #15359 by Yommy: 0 byte-identical, 11 confirmed by peer review.

- fn_22264 CLoginMode::ReceiveAcceptLogin: logic confirmed by peer review
- fn_22277 CLoginMode::ReceiveCharacterResult: logic confirmed by peer review
- fn_22286 CLoginMode::SubD90C90: logic confirmed by peer review
- fn_22287 CLoginMode::SubD911C0: logic confirmed by peer review
- fn_22289 CLoginMode::ShowLoginError: logic confirmed by peer review
- fn_22293 CLoginMode::ShowNotice: logic confirmed by peer review
- fn_22301 CLoginMode::OnUpdateEx: logic confirmed by peer review
- fn_22302 CLoginMode::SubD97780: logic confirmed by peer review
- fn_22313 CLoginMode::SendMsg: logic confirmed by peer review
- fn_22315 CLoginMode::ReceiveLoginErrorDetail: logic confirmed by peer review
- fn_22316 CLoginMode::ReceiveLoginError: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, alisonrag, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 22:02:41 +00:00
ragnarok-clanker
6c307a4339 Decompile 19 functions in Source/Client/Mode/GameModePackets.cpp
Batch #15155 by Yommy: 0 byte-identical, 19 confirmed by peer review.

- fn_21658 CGameMode::ReceiveColorBroadcast: logic confirmed by peer review
- fn_21704 CGameMode::ReceiveFeedResult: logic confirmed by peer review
- fn_21708 CGameMode::ReceivePartyMemberList: logic confirmed by peer review
- fn_21709 CGameMode::ReceiveGuildInfo: logic confirmed by peer review
- fn_21751 CGameMode::ReceiveActorChat: logic confirmed by peer review
- fn_21752 CGameMode::ReceivePartyChat: logic confirmed by peer review
- fn_21763 CGameMode::ReceiveBroadcast: logic confirmed by peer review
- fn_21771 CGameMode::ReceiveActorDisappear: logic confirmed by peer review
- fn_21776 CGameMode::ReceiveMapMove: logic confirmed by peer review
- fn_21777 CGameMode::ReceiveZoneServerChange: logic confirmed by peer review
- fn_21865 CGameMode::ReceiveAddRelatedGuild: logic confirmed by peer review
- fn_21870 CGameMode::ReceiveGuildChat: logic confirmed by peer review
- fn_21873 CGameMode::ReceiveGuildInfo4: logic confirmed by peer review
- fn_21874 CGameMode::ReceiveGuildNotice: logic confirmed by peer review
- fn_21883 CGameMode::ReceiveGuildRelationList: logic confirmed by peer review
- fn_21960 CGameMode::SetPartyMemberList: logic confirmed by peer review
- fn_21968 CGameMode::UpdatePartyMemberInfo: logic confirmed by peer review
- fn_21970 CGameMode::ReceiveActorStatusValue: logic confirmed by peer review
- fn_22187 CGameMode::ReceiveActorMessage7: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 21:57:44 +00:00
ragnarok-clanker
9de843cbac Decompile fn_21584 (CGameMode::ReceiveWhisperResult)
Batch #15326 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21584 CGameMode::ReceiveWhisperResult: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 21:05:30 +00:00
ragnarok-clanker
59cfddcb5b Decompile fn_21656 (CGameMode::ReceiveActorBroadcastText)
Batch #15323 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21656 CGameMode::ReceiveActorBroadcastText: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 21:04:44 +00:00
ragnarok-clanker
95fe4670e6 Decompile fn_21588 (CGameMode::ReceiveChangeZoneServerWithHost)
Batch #15320 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21588 CGameMode::ReceiveChangeZoneServerWithHost: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 21:04:14 +00:00
ragnarok-clanker
39cc85f608 Decompile fn_21654 (CGameMode::ReceiveBroadcastText)
Batch #15315 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21654 CGameMode::ReceiveBroadcastText: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, kyoshi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 20:57:28 +00:00
ragnarok-clanker
724cd926e1 Decompile fn_21258 (CGameMode::DrawMiniMapCoordinates)
Batch #15253 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21258 CGameMode::DrawMiniMapCoordinates: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 20:53:00 +00:00
ragnarok-clanker
31665f58ed Confirm fn_06507 (CPrivateAirplaneMgr::IsEndableMap)
Batch #15244 by kyoshi: 0 byte-identical, 1 confirmed by peer review.

- fn_06507 CPrivateAirplaneMgr::IsEndableMap: logic confirmed by peer review (already on main)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 18:39:25 +00:00
ragnarok-clanker
bfca70e15b Decompile 3 functions in Source/Client/Mode/GameModeHandlers.cpp, Source/Client/Mode/GameModeNotices.cpp, ...
Batch #15203 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_10041 RodexMailEntryLess::operator(): byte-identical
- fn_10043 UIRodexInboxWnd::RequestMailAction: byte-identical
- fn_10044 UIRodexInboxWnd::RequestAllMailActions: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-09 13:03:47 +00:00
ragnarok-clanker
9cbb5257ed Maintenance: Resubmission of 15183 over main 662db5ca. PacketId: switch to the official packet names (names.txt, 1689 entries). 194 e
Batch #15189 by ragnarok-clanker: no function's compiled code changes; checked with 58 compiled unit(s), including every includer of Source/Network/Packets/PacketId.h, Source/Network/Packets/ShortcutPacket.h.
2026-11-09 12:56:29 +00:00
ragnarok-clanker
cd30e144a2 Decompile 7 functions in Source/Client/Mode/GameModePackets.cpp
Batch #15163 by Yommy: 7 byte-identical, 0 confirmed by peer review.

- fn_21660 CGameMode::ReceiveColoredNotice: byte-identical
- fn_21871 CGameMode::ReceiveGuildInfo2: byte-identical
- fn_21872 CGameMode::ReceiveGuildInfo3: byte-identical
- fn_21888 CGameMode::ReceiveGuildPositionNames: byte-identical
- fn_21956 CGameMode::OpenPackageSimulatorFile: byte-identical
- fn_21957 CGameMode::OpenSimulatorFile: byte-identical
- fn_21958 CGameMode::OpenRandomOptionSimulatorFile: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-09 12:36:25 +00:00
ragnarok-clanker
c932ad6499 Maintenance: Resubmission of 15134 without the 12 struct/type renames (their new names changed mangled symbols in 17 functions). Rena
Batch #15141 by ragnarok-clanker: no function's compiled code changes; checked with 537 compiled unit(s), including every includer of Source/Client/Input/LanguageTC.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/EnchantMgr.h, Source/Contents/GuildInfo.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TableMng.h, Source/Contents/World/SkyBox.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl.
2026-11-09 12:21:09 +00:00
ragnarok-clanker
9ffc1cb9f9 Decompile fn_22282 (CLoginMode::ReceiveDeleteCancel)
Batch #15100 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_22282 CLoginMode::ReceiveDeleteCancel: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-09 09:54:57 +00:00
ragnarok-clanker
bd947f545e Decompile 10 functions in Source/Client/Mode/GameModeNotices.cpp, Source/Client/Session.cpp, ...
Batch #14954 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_21601 ReceiveShortcutPage: byte-identical
- fn_22072 CGameMode::ReceiveRouletteInfo: byte-identical
- fn_23361 CSession::FindUnknown0708: byte-identical
- fn_23362 CSession::FindUnknown0700: byte-identical
- fn_21014 CRenderObject::DrawPulseOutline: byte-identical
- fn_07839 C3dAttr::HeightBounds: byte-identical
- fn_23342 CSession::RemoveItem1750: byte-identical
- fn_10077 RouletteMgr::Update: byte-identical
- fn_09079 CSimpleStringMgr::GetString: byte-identical
- fn_17703 WorldSpatialTree::RefreshBounds: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-08 23:56:15 +00:00
ragnarok-clanker
fdbebbba25 Maintenance: Second pass on unknown_XXXX members: 140 more renamed (61 files), named from the original binary (accesses at this+offse
Batch #14947 by ragnarok-clanker: no function's compiled code changes; checked with 596 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/EquipWindowLook.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GraffiSkill.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/Camera/Camera.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/Items/ItemInfo.h, Source/Render/SpriteQuad.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelMesh.h, Source/Resource/World/WorldResource.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Items/UISpellListWnd.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/MiniPartyGrid.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UIWindowMgr.h.
2026-11-08 18:16:10 +00:00
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
521b52384c Maintenance: Replace LookupMessage(<integer>) with the existing MSGSTRINGID constant of the same value (3596 sites, 162 files; each v
Batch #14938 by ragnarok-clanker: no function's compiled code changes; checked with 162 compiled unit(s).
2026-11-08 14:19:01 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 13:56:42 +00:00
ragnarok-clanker
858265cc69 Maintenance: Second pass: name remaining numeric switch case labels (identifier-only; no code change). ~3,500 more labels across 150
Batch #14936 by ragnarok-clanker: no function's compiled code changes; checked with 158 compiled unit(s), including every includer of Source/Client/Mode/GameModeEnums.h, Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Contents/Actors/PetEnums.h, Source/Contents/Combat/CombatTypes.h, Source/Contents/Configuration/ServiceEnums.h, Source/Contents/Effects/EffectPrimId.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemId.h, Source/Contents/Items/ItemType.h, Source/Network/Packets/ModeResultEnums.h, Source/Network/Packets/NoticeEnums.h, Source/Network/Packets/PacketId.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 12:37:46 +00:00
ragnarok-clanker
854a0e32fb Maintenance: Name numeric switch case labels with enum constants (identifier-only; no code change). 13,500+ case labels across 70 uni
Batch #14886 by ragnarok-clanker: no function's compiled code changes; checked with 225 compiled unit(s), including every includer of Source/Contents/Combat/CombatTypes.h, Source/Contents/Effects/EffectMessageId.h, Source/Contents/Items/InventoryType.h, Source/Contents/Items/ItemId.h, Source/Contents/Jobs/JobId.h, Source/Contents/MessageTable.h, Source/Contents/Skills/SkillId.h, Source/Contents/Skills/SkillUnitId.h, Source/Network/Packets/ModeResultEnums.h, Source/Network/Packets/NoticeEnums.h, Source/Network/Packets/PacketId.h, Source/UI/GameSettings/TalkType.h, Source/UI/Window/WindowId.h.
2026-11-07 23:58:37 +00:00
ragnarok-clanker
503e865c10 Maintenance: Name the CSkillActionMgr dispatchers after the CSkillAction/CEfstAction/CSkillObjectAction virtual each one forwards to
Batch #14885 by ragnarok-clanker: no function's compiled code changes; checked with 305 compiled unit(s), including every includer of Source/Contents/Skills/SkillInfo.h.
2026-11-07 23:14:25 +00:00
ragnarok-clanker
953a3946d1 Maintenance: Remove 3 more aliased globals inside g_session (0x01732638) and use the real fields. g_whisperRecord gl_25102 (0x01737B8
Batch #14883 by ragnarok-clanker: no function's compiled code changes; checked with 204 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/UI/GameSettings/GameSettingsUI.h.
2026-11-07 22:49:54 +00:00