Commit graph

163 commits

Author SHA1 Message Date
ragnarok-clanker
bed005bc9d Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Network headers (ConnectionBuffer, CURLMgr, PacketLength
Batch #1058 by ragnarok-clanker: no function's compiled code changes; checked with 28 compiled unit(s), including every includer of Source/Network/Connection/ConnectionBuffer.h, Source/Network/Http/CURLMgr.h, Source/Network/Packets/PacketLengths.h.
2026-10-27 13:41:30 +00:00
ragnarok-clanker
1d0e5dc05e Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Utility headers (Async, Math, Threading)
Batch #1057 by ragnarok-clanker: no function's compiled code changes; checked with 75 compiled unit(s), including every includer of Source/Utility/Async/AsyncDiagnostic.h, Source/Utility/Async/NAsyncWorkQueue.h, Source/Utility/Async/NMessageQueue.h, Source/Utility/Async/NRecycleObjectPoolMgr.h, Source/Utility/Math/AffineMatrix.h, Source/Utility/Threading/CSyncObject.h, Source/Utility/Threading/NSyncObject.h.
2026-10-27 13:40:06 +00:00
ragnarok-clanker
4a3f02a4d1 Maintenance: Add mandatory field offset markers /* XXXX */ and x86 assertions to Archive headers (PakEntry, PakRegistry, PakCipher)
Batch #1056 by ragnarok-clanker: no function's compiled code changes; checked with 5 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Archive/PakCipher.h, Source/Archive/PakRegistry.h.
2026-10-27 13:37:30 +00:00
ragnarok-clanker
ce2ee31947 Maintenance: Add mandatory field offset markers /* XXXX */ and offset assertions to CameraFrame (0x80..0xC8)
Batch #1055 by ragnarok-clanker: no function's compiled code changes; checked with 2 compiled unit(s), including every includer of Source/Contents/Camera/CameraFrame.h.
2026-10-27 13:36:07 +00:00
ragnarok-clanker
4e5f7335ff Decompile fn_17124 (UIWindowMgr::RegisterNamedWindow)
Batch #1049 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17124 UIWindowMgr::RegisterNamedWindow: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 12:14:55 +00:00
ragnarok-clanker
fbdc231444 Decompile 5 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1048 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_17219 UIWindowMgr::Schedule: logic confirmed by peer review
- fn_17235 UIWindowMgr::DismissTransient: logic confirmed by peer review
- fn_17237 UIWindowMgr::Destroy: logic confirmed by peer review
- fn_17833 ModeTooltip::Clear: logic confirmed by peer review
- fn_17843 ModeTooltip::Expire: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-27 12:07:15 +00:00
ragnarok-clanker
2a43504543 Decompile 9 functions in Source/Client/ReplayControl.cpp, Source/Client/Replay.h, ...
Batch #1043 by ragnarok-clanker: 0 byte-identical, 9 confirmed by peer review.

- fn_19316 Replay::AnimationScale: logic confirmed by peer review
- fn_19343 Replay::SetState: logic confirmed by peer review
- fn_21118 CRenderObject::SetAnimation: logic confirmed by peer review
- fn_21119 CRenderObject::SetColor: logic confirmed by peer review
- fn_21130 CRenderObject::SetSequenceDeadline: logic confirmed by peer review
- fn_21131 CRenderObject::SetSequenceInterval: logic confirmed by peer review
- fn_21132 CRenderObject::SetAnimationSequence: logic confirmed by peer review
- fn_21133 CRenderObject::SetFrameSequence: logic confirmed by peer review
- fn_21140 CRenderObject::SetAnimationSpeed: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/ReplayControl.cpp
2026-10-27 11:01:59 +00:00
ragnarok-clanker
823aeda193 Decompile 2 functions in Source/Resource/Sprites/ActionResource.cpp, Source/Resource/Sprites/ActionResource.h
Batch #1042 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_07787 CActRes::Frame: logic confirmed by peer review
- fn_07788 CActRes::FrameCount: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 11:01:42 +00:00
ragnarok-clanker
efee869d24 Decompile fn_17849 (ModeBaseEvents::Send)
Batch #1039 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17849 ModeBaseEvents::Send: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/ModeBaseEvents.cpp
2026-10-27 11:01:39 +00:00
ragnarok-clanker
44f60ba6ca Decompile 6 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1038 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_07649 CMiniPartyWndAreaMgr::CMiniPartyWndAreaMgr: logic confirmed by peer review
- fn_17099 UIWindowMgr::~UIWindowMgr: logic confirmed by peer review
- fn_17233 UIWindowMgr::Shutdown: logic confirmed by peer review
- fn_09716 CSnapMgr::MoveEdge: logic confirmed by peer review
- fn_06318 ServiceOptions::Get: logic confirmed by peer review (already on main)
- fn_06325 ServiceOptions::Set: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-27 11:01:30 +00:00
ragnarok-clanker
c60cbe211b Decompile 2 functions in Source/Client/ModeFadeOut.cpp, Source/Client/ModeFadeOut.h, ...
Batch #1037 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_17148 DrawBitmapResource: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/ModeFadeOut.cpp, Source/Render/BitmapDrawing.cpp
2026-10-27 10:19:58 +00:00
ragnarok-clanker
f3ceb09e9d Merge commit '6c40a36577' 2026-10-27 10:06:35 +00:00
ragnarok-clanker
d22c6b96a6 Decompile 5 functions in Source/Resource/Bitmap/BitmapImage.cpp, Source/Resource/Bitmap/BitmapImage.h, ...
Batch #1026 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_07866 BitmapImage::CreateAuxiliary: logic confirmed by peer review
- fn_07867 BitmapImage::Pixel: logic confirmed by peer review
- fn_07874 BitmapImage::ClearAuxiliary: logic confirmed by peer review
- fn_09684 SkinPaletteColor: logic confirmed by peer review
- fn_09685 SkinPaletteChannels: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Resource/SkinPalette.cpp
2026-10-27 10:04:56 +00:00
ragnarok-clanker
2035aa96de Decompile 2 functions in Source/Render/AlphaRectangle.cpp, Source/Client/ModeFade.cpp, ...
Batch #1027 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_01952 DrawAlphaRectangle: logic confirmed by peer review
- fn_17842 ModeFade::Draw: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Render/AlphaRectangle.cpp, Source/Client/ModeFade.cpp
2026-10-27 10:04:54 +00:00
ragnarok-clanker
51e57d4b27 Decompile 2 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1031 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17086 UIWindowMgr::UIWindowMgr: logic confirmed by peer review
- fn_17209 UIWindowMgr::ResetWindows: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 10:04:52 +00:00
ragnarok-clanker
e21c7e6235 Decompile 2 functions in Source/Contents/Actors/MercenaryAI.cpp, Source/Contents/Actors/MercenaryAI.h
Batch #1021 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_22327 CMercenaryAI::CMercenaryAI: logic confirmed by peer review
- fn_22328 CMercenaryAI::~CMercenaryAI: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 10:04:43 +00:00
ragnarok-clanker
7d9b244fb1 Decompile 3 functions in Source/Contents/Sound/SoundMaker.cpp, Source/Contents/Sound/SoundMaker.h
Batch #1017 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review
- fn_22406 CSoundMaker::Update: logic confirmed by peer review
- fn_22428 CSoundMaker::SendObjectMessage: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 10:04:43 +00:00
ragnarok-clanker
770ead30fc Decompile 6 functions in Source/Contents/MovementRoute.cpp, Source/Contents/MovementRouteInterpolation.h
Batch #1016 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_17861 MovementRouteInterpolation::MovementRouteInterpolation: logic confirmed by peer review
- fn_17867 BuildMovementRoute: logic confirmed by peer review
- fn_17869 MovementRouteInterpolation::Point: logic confirmed by peer review
- fn_17870 MovementRouteInterpolation::EndTick: logic confirmed by peer review
- fn_17871 MovementRouteInterpolation::EndMetadata: logic confirmed by peer review
- fn_17874 MovementRouteInterpolation::NextPoint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/MovementRoute.cpp
2026-10-27 10:04:33 +00:00
ragnarok-clanker
befcc681c5 Register recovered Replay source in existing UI build target 2026-10-27 10:04:22 +00:00
ragnarok-clanker
6d6e55e3f2 Decompile 2 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1030 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17179 UIWindowMgr::InitializeWindowPolicy: logic confirmed by peer review
- fn_17227 UIWindowMgr::LookupWindow: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 10:04:20 +00:00
ragnarok-clanker
6188ab372a Decompile fn_04414 (EncodeBase64)
Batch #1029 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_04414 EncodeBase64: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 10:04:17 +00:00
ragnarok-clanker
c989c4837c Decompile 6 functions in Source/Client/Replay.cpp, Source/Client/Replay.h
Batch #998 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_06623 BuildReplayTaggedRecord: logic confirmed by peer review
- fn_19300 Replay::Replay: logic confirmed by peer review
- fn_19326 Replay::WriteSection: logic confirmed by peer review
- fn_19327 Replay::WriteHeader: logic confirmed by peer review
- fn_19328 Replay::BuildMetadata: logic confirmed by peer review
- fn_19354 Replay::Instance: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 10:04:02 +00:00
ragnarok-clanker
07d2f8441c 📝 docs(headers): added inlined comments to method definitions 2026-10-27 10:46:28 +01:00
ragnarok-clanker
e331e03f4c 📝 docs(headers): annotated inlined methods 2026-10-27 10:43:00 +01:00
ragnarok-clanker
ff15df90ad 📝 docs(annotations): marked inlined functions across modules 2026-10-27 10:42:13 +01:00
ragnarok-clanker
d73c3c1296 Decompile 5 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1025 by ragnarok-clanker: 5 byte-identical, 0 confirmed by peer review.

- fn_17831 CWorld::ActiveGameMode: byte-identical
- fn_19302 ReplaySection::ReplaySection: byte-identical (already on main)
- fn_19306 ReplaySection::~ReplaySection: byte-identical (already on main)
- fn_17835 CMode::Slot7: byte-identical
- fn_17838 CMode::Slot5: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 09:38:13 +00:00
ragnarok-clanker
7afc1a3a5b Decompile fn_22331 (CMercenaryAI::Shutdown)
Batch #1022 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_22331 CMercenaryAI::Shutdown: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Actors/MercenaryAI.cpp
2026-10-27 09:33:55 +00:00
ragnarok-clanker
01aeb424f6 Maintenance: Real scalar owner for gl24542 signed-byte g_language at16D3B07 and gl24529 int g_serviceType16D3B10. PE section .data Vi
Batch #1019 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s), including every includer of Source/Contents/Configuration/ServiceConfiguration.h.
Adds to the build: Source/Contents/Configuration/ServiceConfiguration.cpp
2026-10-27 09:31:50 +00:00
ragnarok-clanker
a996ad893b Decompile fn_22417 (CSoundMaker::Draw)
Batch #1018 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_22417 CSoundMaker::Draw: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Sound/SoundMaker.cpp
2026-10-27 09:30:10 +00:00
ragnarok-clanker
3dbd276311 📚 docs(inlining): marked inlined functions across modules 2026-10-27 10:21:57 +01:00
ragnarok-clanker
add868efe7 ♻️ refactor(source): removed unused includes and add INLINE comments 2026-10-27 10:09:10 +01:00
ragnarok-clanker
0d7e98ce6d Confirm 2 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1011 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_19302 ReplaySection::ReplaySection: byte-identical (already on main)
- fn_19306 ReplaySection::~ReplaySection: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/UI/Window/UIWindowMgr.cpp
2026-10-27 09:02:57 +00:00
ragnarok-clanker
fba5ab8527 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-27 10:02:57 +01:00
ragnarok-clanker
98e3d7fa17 🎨 style(shortcuts): annotated inlined helper functions and updated stdio include 2026-10-27 10:02:55 +01:00
ragnarok-clanker
779dd40d2e 🛠️ refactor(source): annotated inlined functions and removed unused include 2026-10-27 10:01:19 +01:00
ragnarok-clanker
38defb749a 🛠️ fix(FontCache): attached STATIC 0x01311ED0 to the fallback font table 2026-10-27 10:00:45 +01:00
ragnarok-clanker
fafcae34db Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-27 09:59:05 +01:00
ragnarok-clanker
ee401857a1 📝 docs(annotations): annotated inlined functions across modules 2026-10-27 09:59:03 +01:00
ragnarok-clanker
279b86f980 Merge branch 'main' of http://forgejo:3000/clank/rodecomp 2026-10-27 08:58:12 +00:00
ragnarok-clanker
a107b3f0de 🛠️ refactor(TraditionalKeyInput): renamed Zhuyin Big5 key table to zhuyinBig5 2026-10-27 09:57:24 +01:00
ragnarok-clanker
e66baf48bd 📝 docs(UserHotkeyScript): added inlined comments for Lua wrapper functions 2026-10-27 09:57:19 +01:00
ragnarok-clanker
c5aea5fa76 📝 docs(models,render): added inlined comments to functions 2026-10-27 09:57:08 +01:00
ragnarok-clanker
b779b21820 Merge branch 'main' of https://clank.rodecomp.online/git/clank/rodecomp 2026-10-27 09:54:26 +01:00
ragnarok-clanker
9886d0e91c 📝 docs(ScalarConversion): added inlined comment to TruncateToInt 2026-10-27 09:54:24 +01:00
ragnarok-clanker
2751e3ff3d 📝 docs(CameraState): documented struct field offsets and added CameraShake size assertion 2026-10-27 09:54:11 +01:00
ragnarok-clanker
dc5c68be89 🛠️ refactor(TraditionalKeyInput): replaced OEM key escapes with VK_OEM_* constants 2026-10-27 09:53:10 +01:00
ragnarok-clanker
c2b4547ea0 Decompile 2 functions in Source/Resource/ResourceAliases.cpp, Source/Resource/ResourceAliases.h, ...
Batch #1004 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18179 ResourceAliases::ResolveMapName: logic confirmed by peer review
- fn_18187 ResourceAliases::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 08:52:33 +00:00
ragnarok-clanker
67dd9978df Decompile 2 functions in Source/Client/Replay.cpp, Source/Client/Replay.h
Batch #1003 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_19302 ReplaySection::ReplaySection: byte-identical
- fn_19306 ReplaySection::~ReplaySection: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Client/Replay.cpp
2026-10-27 08:51:56 +00:00
ragnarok-clanker
b574abe09d Decompile 4 functions in Source/Resource/PaletteResource.cpp, Source/Resource/PaletteResource.h, ...
Batch #989 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_08039 CPaletteRes::Create: logic confirmed by peer review
- fn_08040 CPaletteRes::Load: logic confirmed by peer review
- fn_02597 CFile::Open: logic confirmed by peer review
- fn_01124 CFile::~CFile: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-27 08:51:32 +00:00
ragnarok-clanker
4d9d775cc8 Decompile 3 functions in Source/Contents/World/WorldSpatialTree.cpp, Source/Contents/World/WorldSpatialTree.h, ...
Batch #995 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_17651 WorldScene::WorldScene: logic confirmed by peer review
- fn_17654 WorldScene::~WorldScene: logic confirmed by peer review
- fn_17704 WorldSpatialTree::RefreshModelBounds: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 08:51:12 +00:00